Re: [edk2-devel] GitHub PR Code Review process now active

["Michael D Kinney" <michael.d.kinney@intel.com>]

CI jobs are dispatched to both GitHub Actions and Azure Pipelines.

For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running.

This must imply that edk2 repo allows this.  Do you happen to know where
this is configurable or a link to GitHub docs for configuration?

Mike

> -----Original Message-----
> From: Neal Gompa <ngompa13@gmail.com>
> Sent: Monday, June 3, 2024 9:13 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
> <michael.d.kinney=intel.com@groups.io> wrote:
> >
> > Hello,
> >
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> Process
> >
> >   Big thanks to Michael Kubacki for writing up all the
> >   changes based on the RFC proposal and community discussions.
> >
> >   We will learn by using, so if you see anything missing or
> >   incorrect or clarifications needed, please send feedback
> >   here so the Wiki pages can be updated quickly for everyone.
> >
> > * The edk2 repo settings have been updated to require
> >   a GitHub PR code review approval before merging and
> >   all conversations must be resolved before merging.
> >
> > * A PR has been opened that removes the requirement for
> >   Cc: tags in the commit messages and is the first PR
> >   that will use the new process. This PR needs to be
> >   reviewed and merged to support the revised commit
> >   message format.
> >
> >   https://github.com/tianocore/edk2/pull/5688
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> Format
> >
> > * Please use "Draft" PRs to run CI without any reviews.
> >   Once ready for reviews, convert from "Draft" to
> >   "Ready for Review".
> >
> 
> Generally GitHub doesn't allow CI to run on PRs created as draft pull
> requests. Was this changed for edk2?
> 
> 
> --
> 真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119430): https://edk2.groups.io/g/devel/message/119430
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-