From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2262A941B8A for ; Sat, 9 Mar 2024 20:17:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eMWe9o4tPY1RGdFY3AAh3egSIhAmvwwvhEu88iqdlVI=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710015453; v=1; b=kbw7ZIRvJ0vpFrrRvP9wK107F3xsKkFJdAHLOUfh7YPV0/1e2l4GbfzdYEILj86/1Z3RuKfa v0SOUXGwiQD3by5JJXJWlrB7GK+0YInk7eJyjq5VYvXNXDrIXj89Oz9xkzw/rdtbvzIqrHa3XxM l+TDJqPpF0cGItLlS9xr1qSH2m7/R2IRllVQu/xZT+HWsHF31V3yXbBVwNH/QfaP43t8tYcatX1 MgqfjHdyrADzdp+yBg9GHxnpOZdoCDiTadNb4Ew0CIB7lkMtbrJYtbKnGS0/BzJ8XZnLQwnoo/S fn7/T+LyTGNcBuDll9TRKTa1Nzhl6JcP1hcn0JI6HoyLw== X-Received: by 127.0.0.2 with SMTP id JzjXYY7687511x0kfxn64G7A; Sat, 09 Mar 2024 12:17:33 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web10.20209.1710015452848526873 for ; Sat, 09 Mar 2024 12:17:33 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,11008"; a="7672575" X-IronPort-AV: E=Sophos;i="6.07,113,1708416000"; d="scan'208";a="7672575" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2024 12:17:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,113,1708416000"; d="scan'208";a="10871188" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Mar 2024 12:17:32 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 9 Mar 2024 12:17:31 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sat, 9 Mar 2024 12:17:31 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 9 Mar 2024 12:17:31 -0800 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH0PR11MB5926.namprd11.prod.outlook.com (2603:10b6:510:14d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.10; Sat, 9 Mar 2024 20:17:28 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7386.011; Sat, 9 Mar 2024 20:17:27 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Pethaiyan, Madhan" CC: Liming Gao , "Liu, Zhiguang" , "Li, Yi1" , GuoX Xu , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details Thread-Topic: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details Thread-Index: AQHacX3Pail4Pw+/G0mweK5JEze9mrEv2qDg Date: Sat, 09 Mar 2024 12:17:33 -0800 Message-ID: References: <20240308172556.2473-1-madhan.pethaiyan@intel.com> In-Reply-To: <20240308172556.2473-1-madhan.pethaiyan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH0PR11MB5926:EE_ x-ms-office365-filtering-correlation-id: 22b2605a-8bd1-46dc-e5c6-08dc4075f105 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ez/5c9TZtauzbS259XuLSNR3gPGusDjB8RlRyOmcIO6HPcTZIdsIPeOM5umEce/ODhi7LCNsZA8sffyY9C7mvtPzMLxBiWki6agOcVV/m1Y5iGzFSpQGgvCOfVYSUW3mQesLBXyOxwWvNtNhKbPxhmigaQsgTnHE+IkpXJwlsR++P/UGs/t5Bnntm9k+QQt2Q+prOZ+0bN+VjPmej7g4yPnUT2qTy3Xz57DX5BBP/+emDTdx0obJHslYiZSxrt3MhmkRLaNkp8/auz4/B8DrCsGKM6SJwhEoTaLSmtyq5jYQGlptS9exWZWbkLt+6U31JBBfphtFvvL6m/VzBCvyHo/HKpoaVpKY33I4WdgoexN0FbMWF7gAR2H9PqW5M+Dbyieolmzl5fVjzvGOB2U9gABkynS7x2E7NTcOVA/QaNxBlSCAFecXeWdE9QpRbOiTdR3QRmRWmzIDG7cA08QSOACu8ltYel88VEwIs89oOa77FLds98TLzj6HNV8BEc+C1prY8NsjrD8P4wkJSvWtxtd13/VrvXW6mXmn9ZPuXpJG+xEsuwpH6qejuFIohuOvlWZTRcSEQLXT0uUJCHJevG3/PhGN2J2pcJCqrgR/GjWqFcenUb9vj9mi5bo8Zpl3sg2JrauGomEyo5UNE+rE4Iv8wuUFmAkq3p1XaW023v3EjwmEyaYw9/QB3qVblark x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e9ARDwxVWSBZcsEySBNc79PtOCEZTIP3rcqjckUoyJNH3SDwHFO4Pnn6tiFE?= =?us-ascii?Q?Mk2dKI70v/b/2WfStm6ubeD5LnMSk3oLLfFM+k6IZ1WTqahI2zb7LdRe2mFs?= =?us-ascii?Q?zncAbLAg1tGDwOp7KMMtMViHl7Moj9uAOsFx70GpIAn18kpeVNBoGhV96HE6?= =?us-ascii?Q?voLtyIoRPDZ6rwCjIObrXqdJOznxrLvZyTX+N5cXy4W4jcDimMfxTEq3hVBV?= =?us-ascii?Q?InoCQWORbRcM2A7nGHicVp9Q8SnF0tuOOvTLLs65oOBZe4XnwK0Bq+EHmd2/?= =?us-ascii?Q?Yso5p8FKAcNv2Z6jYAZJHKs4wr+LXb7G70SQX9eM9969NouBVNhf2rWyqK89?= =?us-ascii?Q?Qv67qg4cSvPnXzsEey3d7v0sLSy72FAIBtEDtcg9jH1ZEz3qt5hVSQ+LawDk?= =?us-ascii?Q?PoWM87S8RIeqN+/eSZuXT8VZm8JKyx7nocgJt/3HmedYdDZEvuHTyudda6Y3?= =?us-ascii?Q?LvTuuQ7qQmKPPvxjxyBiVjO7pAAoFGk5PjawgMJTXqUEAm+q4OwJ9O6ermUz?= =?us-ascii?Q?0VAbihojSHDFE0qalnpRDMuQYKV6oCSLnVGuh6o0hHST/HmcDttV7TvvEurY?= =?us-ascii?Q?pQXttWeMrkV4thKHyB2iQVo3iSIOZJvHsQ7Ltpz9LTS06RrvgPJxDQfHqdR7?= =?us-ascii?Q?nczJdZIHyJ1Sj28DwCBJMeDCN5REI1tW1U7k3d9YcEz/LzUaeZXxWEHDqs4W?= =?us-ascii?Q?49H0F5lAFLdEujvhkZ01ktEGBqWHnOoSEp1ZCg5BzjrMhepNkGk1btGxrxR7?= =?us-ascii?Q?L6R1geHdoyyn09B7etDBHjojMnyfIC7PBHeiFxgmA0/sBahrK787kG2admSL?= =?us-ascii?Q?689VJUd9WQNg/ifV7DPlsAdRO6/AORWSinW/+H1GAfkANsrP/RI0kcYu/got?= =?us-ascii?Q?UfuQlNT85HeitpwqM8ozz3/9U62Ey1C9FlVMz5VE7V3s9lsaSrRIY3JOMt+B?= =?us-ascii?Q?Xd9EKhWQAjbx5Am633xzHywe+U+f2pc3J7zs7A8jXQ9INkwksnlwNTEjExnw?= =?us-ascii?Q?UBTBDTH+ufdwE7lOt28BNOufuCLBzLfQf3kMmlBSpUAFSfNPnD+nrHmVEqXI?= =?us-ascii?Q?FTwByst4vD0MnuERhaVs/u68r/lFyxaw5caX70NeW9l5NwZtr2RiQrFbGAa5?= =?us-ascii?Q?HLgKcB4HB+SLOY92++D2yIoD6E3ER963jkOm4wlbvbakGTUzaS67OzzGKICs?= =?us-ascii?Q?Dob1cEy181gX/tmNNi0/GvA1AMCREPkZ1pyzFUrRZ/kNAq6V8wFCrXNFhrbg?= =?us-ascii?Q?B0+cQGj1n+lRyRw12V4tMbG9xQ6bATO2eGV9ib10AHyBZmIA4rYdd1WypgWP?= =?us-ascii?Q?pqvLZ0FzCz15SUIG6g9S3+V48kb0HMeRyuap2Sg/8AKgQc+zELFHEGFWPldD?= =?us-ascii?Q?4977i18ma7ucCIdKuKbvnS3KJXKJEPP0uFu4GENdqFCKbAU25ZMsBqBnOlBN?= =?us-ascii?Q?nhoE2a3vN5JN4cB6f5XM1Jh/oGlJ9sVCDvwQLF5tCFxzyKeegCnAJ0eoi+vT?= =?us-ascii?Q?2yVeb0XhB7ONpF4t+awcyJ3WI+VYxbr3KnCk0YC6LzauGzGKl6aFB4xpsZTq?= =?us-ascii?Q?ICThATkfrGhmr5wL/lnM+m+p6Cb7EVnDONprgZo0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22b2605a-8bd1-46dc-e5c6-08dc4075f105 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2024 20:17:27.8562 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6W1nHcJnwpWdSdu0rc0MpzgH63olvQ9kentuqjXPaY9wbZDcchmYAtOzxjtPo1Fr/bXSsNA2E+tdIyI8LSqvX4R1I7LPtIMeXsQipp3U3p4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5926 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: x6mGH9aB1GEcoRrqI72l5Y1Gx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=kbw7ZIRv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Madhan, I created a PR with all 3 related patches to run through EDK II CI. https://github.com/tianocore/edk2/pull/5453 There are CI failures. Please resolve and send updated patches. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Pethaiyan Madhan > Sent: Friday, March 8, 2024 3:17 PM > To: devel@edk2.groups.io > Cc: Pethaiyan, Madhan ; Kinney, Michael D > ; Liming Gao ; > Liu, Zhiguang ; Li, Yi1 ; > GuoX Xu > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo > description details >=20 > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): > Add the following sentence at the end of the Image parameter > description. "May be NULL with a zero ImageSize in order to determine > the size of the buffer needed". >=20 > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > ImageSize is not too small and Image is NULL." >=20 > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > Add the following sentence at the end of the ImageInfo parameter > description."May be NULL with a zero ImageInfoSize in order to > determine the size of the buffer needed". >=20 > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > ImageInfoSize is not too small and Image is NULL." and add new > descriptions for "EFI_INVALID_PARAMETER" return code. >=20 > REF: UEFI spec v2.10 23.1.2 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4660 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Yi Li > Cc: GuoX Xu > Signed-off-by: Pethaiyan Madhan > --- > MdePkg/Include/Protocol/FirmwareManagement.h | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h > b/MdePkg/Include/Protocol/FirmwareManagement.h > index e535bb697d..90b7d83c8f 100644 > --- a/MdePkg/Include/Protocol/FirmwareManagement.h > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h > @@ -294,6 +294,8 @@ EFI_STATUS > to contain the image(s) > information if the buffer was too small. > @param[in, out] ImageInfo A pointer to the buffer in which > firmware places the current image(s) > information. The information is > an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs. > + May be NULL with a zero > ImageInfoSize in order to determine the size of the > + buffer needed. > @param[out] DescriptorVersion A pointer to the location in > which firmware returns the version number > associated with the > EFI_FIRMWARE_IMAGE_DESCRIPTOR. > @param[out] DescriptorCount A pointer to the location in > which firmware returns the number of > @@ -314,7 +316,12 @@ EFI_STATUS > @retval EFI_SUCCESS The device was successfully > updated with the new image. > @retval EFI_BUFFER_TOO_SMALL The ImageInfo buffer was too > small. The current buffer size > needed to hold the image(s) > information is returned in ImageInfoSize. > - @retval EFI_INVALID_PARAMETER ImageInfoSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is not too small > and ImageInfo is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorCount is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersionName is NULL. > @retval EFI_DEVICE_ERROR Valid information could not be > returned. Possible corrupted image. >=20 > **/ > @@ -341,6 +348,9 @@ EFI_STATUS > @param[in] ImageIndex A unique number identifying the > firmware image(s) within the device. > The number is between 1 and > DescriptorCount. > @param[out] Image Points to the buffer where the > current image is copied to. > + May be NULL with a zero ImageSize in > order to determine the size of the > + buffer needed. > + > @param[in, out] ImageSize On entry, points to the size of the > buffer pointed to by Image, in bytes. > On return, points to the length of > the image, in bytes. >=20 > @@ -348,7 +358,7 @@ EFI_STATUS > @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize is > too small to hold the > image. The current buffer size needed > to hold the image is returned > in ImageSize. > - @retval EFI_INVALID_PARAMETER The Image was NULL. > + @retval EFI_INVALID_PARAMETER The ImageSize is not too small and > Image is NULL. > @retval EFI_NOT_FOUND The current image is not copied to > the buffer. > @retval EFI_UNSUPPORTED The operation is not supported. > @retval EFI_SECURITY_VIOLATION The operation could not be performed > due to an authentication failure. > -- > 2.38.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116563): https://edk2.groups.io/g/devel/message/116563 Mute This Topic: https://groups.io/mt/104819885/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-