public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Hou, Wenxing" <wenxing.hou@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Li, Yi1" <yi1.li@intel.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in CI
Date: Wed, 11 Oct 2023 18:23:35 +0000	[thread overview]
Message-ID: <CO1PR11MB4929E8170805FCCD18838139D2CCA@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230928153416.537-10-wenxing.hou@intel.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wenxing Hou
> Sent: Thursday, September 28, 2023 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu,
> Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in
> CI
> 
> Change CI for new Mbedtls submodule.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
> ---
>  .pytool/CISettings.py                  |  2 ++
>  CryptoPkg/CryptoPkg.ci.yaml            | 12 +++++++++++-
>  CryptoPkg/CryptoPkg.dec                |  3 ++-
>  CryptoPkg/CryptoPkg.dsc                |  8 ++++++++
>  CryptoPkg/Private/Library/MbedTlsLib.h | 12 ++++++++++++
>  5 files changed, 35 insertions(+), 2 deletions(-)
>  create mode 100644 CryptoPkg/Private/Library/MbedTlsLib.h
> 
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index 6fb7342f81..c5803a877c 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -199,6 +199,8 @@ class Settings(CiBuildSettingsManager,
> UpdateSettingsManager, SetupSettingsManag
>              "MdePkg/Library/BaseFdtLib/libfdt", False))
> 
>          rs.append(RequiredSubmodule(
> 
>              "MdePkg/Library/MipiSysTLib/mipisyst", False))
> 
> +        rs.append(RequiredSubmodule(
> 
> +            "CryptoPkg/Library/MbedTlsLib/mbedtls", False))
> 
>          return rs
> 
> 
> 
>      def GetName(self):
> 
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index 59ba56d41e..967612230d 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -38,10 +38,20 @@
>              # This has OpenSSL interfaces that aren't UEFI spec compliant
> 
>              "Library/BaseCryptLib/Hash/CryptParallelHash.h",
> 
>              "Library/Include/fcntl.h",
> 
> +            # This has Mbedtls interfaces that aren't UEFI spec compliant
> 
> +            "Library/Include/stdint.h",
> 
> +            "Library/Include/stubs-32.h",
> 
>              # These directories contain auto-generated OpenSSL content
> 
>              "Library/OpensslLib",
> 
>              "Library/IntrinsicLib",
> 
> -            "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
> 
> +            "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c",
> 
> +            # mbedtls
> 
> +            "Library/MbedTlsLib/mbedtls",
> 
> +            # This has mbedtls interfaces that aren't UEFI spec compliant
> 
> +            "Library/MbedTlsLib/EcSm2Null.c",
> 
> +            "Library/MbedTlsLib/CrtWrapper.c",
> 
> +            "Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h",
> 
> +            "Library/BaseCryptLibMbedTls/SysCall"
> 
>          ]
> 
>      },
> 
>      "CompilerPlugin": {
> 
> diff --git a/CryptoPkg/CryptoPkg.dec b/CryptoPkg/CryptoPkg.dec
> index a5fa81a338..e613b6b1ae 100644
> --- a/CryptoPkg/CryptoPkg.dec
> +++ b/CryptoPkg/CryptoPkg.dec
> @@ -28,9 +28,9 @@
>    Library/OpensslLib/OpensslGen/include
> 
>    Library/OpensslLib/OpensslGen/providers/common/include
> 
>    Library/MbedTlsLib/Include
> 
> -  Library/MbedTlsLib/mbedtls
> 
>    Library/MbedTlsLib/mbedtls/include
> 
>    Library/MbedTlsLib/mbedtls/include/mbedtls
> 
> +  Library/MbedTlsLib/mbedtls/library
> 
> 
> 
>  [LibraryClasses]
> 
>    ##  @libraryclass  Provides basic library functions for cryptographic
> primitives.
> 
> @@ -49,6 +49,7 @@
>    ##  @libraryclass  Provides library functions from the openssl project.
> 
>    #
> 
>    OpensslLib|Private/Library/OpensslLib.h
> 
> +  MbedTlsLib|Private/Library/MbedTlsLib.h
> 
> 
> 
>    ##  @libraryclass  Provides compiler intrinsic functions required to
> link openssl project.
> 
>    #
> 
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index a55dcb9668..6a0104a3bb 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -364,6 +364,14 @@
>    CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> 
>    CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> 
>    CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> 
> +  CryptoPkg/Library/BaseCryptLibMbedTls/BaseCryptLib.inf
> 
> +  CryptoPkg/Library/BaseCryptLibMbedTls/SecCryptLib.inf
> 
> +  CryptoPkg/Library/BaseCryptLibMbedTls/PeiCryptLib.inf
> 
> +  CryptoPkg/Library/BaseCryptLibMbedTls/SmmCryptLib.inf
> 
> +  CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf
> 
> +  CryptoPkg/Library/BaseCryptLibMbedTls/TestBaseCryptLib.inf
> 
> +  CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf
> 
> +  CryptoPkg/Library/MbedTlsLib/MbedTlsLibFull.inf
> 
>    CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> 
>    CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> 
>    CryptoPkg/Library/TlsLib/TlsLib.inf
> 
> diff --git a/CryptoPkg/Private/Library/MbedTlsLib.h
> b/CryptoPkg/Private/Library/MbedTlsLib.h
> new file mode 100644
> index 0000000000..30517a76d3
> --- /dev/null
> +++ b/CryptoPkg/Private/Library/MbedTlsLib.h
> @@ -0,0 +1,12 @@
> +/** @file
> 
> +  MbedTlsLib class with APIs from the mbedtls project
> 
> +
> 
> +  Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +
> 
> +**/
> 
> +
> 
> +#ifndef MBEDTLS_LIB_H_
> 
> +#define MBEDTLS_LIB_H_
> 
> +
> 
> +#endif
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#109161): https://edk2.groups.io/g/devel/message/109161
> Mute This Topic: https://groups.io/mt/101639984/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109533): https://edk2.groups.io/g/devel/message/109533
Mute This Topic: https://groups.io/mt/101639984/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-10-11 18:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28 15:34 [edk2-devel] [PATCH v3 00/11] Add HMAC/HKDF/RSA/HASH/AES features based on Mbedtls Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 01/11] CryptoPkg: Add mbedtls submodule for EDKII Wenxing Hou
2023-10-11 18:21   ` Michael D Kinney
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 02/11] CryptoPkg: Add mbedtls_config and MbedTlsLib.inf Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 03/11] CryptoPkg: Add HMAC functions based on Mbedtls Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 04/11] CryptoPkg: Add HKDF " Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 05/11] CryptoPkg: Add RSA " Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 06/11] CryptoPkg: Add all .inf files for BaseCryptLibMbedTls Wenxing Hou
2023-12-12  3:52   ` Alexey Kardashevskiy via groups.io
     [not found]   ` <179FF92851F08A90.471@groups.io>
2023-12-12  4:03     ` Alexey Kardashevskiy via groups.io
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 07/11] CryptoPkg: Add Null functions for building pass Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 08/11] CryptoPkg: Add MD5/SHA1/SHA2 functions based on Mbedtls Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in CI Wenxing Hou
2023-10-11 18:23   ` Michael D Kinney [this message]
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 10/11] CryptoPkg: Add basic Readme for BaseCryptLibMbedTls Wenxing Hou
2023-09-28 15:34 ` [edk2-devel] [PATCH v3 11/11] CryptoPkg: Add CryptAes functions based on Mbedtls Add CryptAes APIS Wenxing Hou
2023-10-07 12:38 ` [edk2-devel] [PATCH v3 00/11] Add HMAC/HKDF/RSA/HASH/AES features based on Mbedtls Li, Yi
     [not found] ` <178919F6750E1B48.1188@groups.io>
2023-10-07 13:39   ` [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in CI Wenxing Hou
2023-10-10  1:49     ` Wenxing Hou
2023-10-11  8:04       ` Li, Yi
     [not found] ` <178BD38EB7306FC4.5378@groups.io>
2023-10-12  5:50   ` [edk2-devel] [PATCH v3 00/11] Add HMAC/HKDF/RSA/HASH/AES features based on Mbedtls Li, Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929E8170805FCCD18838139D2CCA@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox