public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Lin, Benny" <benny.lin@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v3 3/3] .pytool: Support FDT library.
Date: Wed, 19 Apr 2023 15:58:58 +0000	[thread overview]
Message-ID: <CO1PR11MB4929EA09C6BD02BC8937CDFAD2629@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230417053505.670-4-benny.lin@intel.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Lin, Benny <benny.lin@intel.com>
> Sent: Sunday, April 16, 2023 10:35 PM
> To: devel@edk2.groups.io
> Cc: Lin, Benny <benny.lin@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [PATCH v3 3/3] .pytool: Support FDT library.
> 
> From: Benny Lin <benny.lin@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
> Add FDT support in EDK2 by submodule 3rd party libfdt
> (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
> 
> Add RequiredSubmodule object for CI setting.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Benny Lin <benny.lin@intel.com>
> ---
>  .pytool/CISettings.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index e3f44add58..2fb99f2a17 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -195,6 +195,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
>              "RedfishPkg/Library/JsonLib/jansson", False))
> 
>          rs.append(RequiredSubmodule(
> 
>              "UnitTestFrameworkPkg/Library/SubhookLib/subhook", False))
> 
> +        rs.append(RequiredSubmodule(
> 
> +            "MdePkg/Library/BaseFdtLib/libfdt", False))
> 
>          return rs
> 
> 
> 
>      def GetName(self):
> 
> --
> 2.39.1.windows.1


      reply	other threads:[~2023-04-19 15:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  5:35 [PATCH v3 0/3] Support FDT library Benny Lin
2023-04-17  5:35 ` [PATCH v3 1/3] Tianocore: " Benny Lin
2023-04-19 15:58   ` Michael D Kinney
2023-04-17  5:35 ` [PATCH v3 2/3] MdePkg: " Benny Lin
2023-04-19 15:54   ` Michael D Kinney
2023-04-19 17:11     ` Benny Lin
2023-04-19 21:04       ` Michael D Kinney
2023-04-20  4:25         ` Benny Lin
2023-04-20 16:44           ` Michael D Kinney
2023-04-21  2:33             ` [edk2-devel] " Chiu, Chasel
2023-04-24 17:28             ` Leif Lindholm
2023-04-24 17:41               ` Michael D Kinney
2023-04-26  5:21                 ` Chiu, Chasel
     [not found]                 ` <17596494A9010E70.30288@groups.io>
2023-05-01 16:31                   ` Chiu, Chasel
2023-05-02 11:41                     ` Leif Lindholm
2023-05-03  2:34                       ` Chiu, Chasel
2023-05-03  5:39                         ` Michael D Kinney
2023-05-03 18:31                           ` Chiu, Chasel
2023-04-17  5:35 ` [PATCH v3 3/3] .pytool: " Benny Lin
2023-04-19 15:58   ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929EA09C6BD02BC8937CDFAD2629@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox