From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"joeyvagedes@microsoft.com" <joeyvagedes@microsoft.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make error
Date: Mon, 6 Nov 2023 21:54:05 +0000 [thread overview]
Message-ID: <CO1PR11MB4929EB19EBC3E85461C83B7BD2AAA@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231106200845.9040-1-joeyvagedes@microsoft.com>
What is the random data at the end of your path emails???
Thanks,
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Joey
> Vagedes via groups.io
> Sent: Monday, November 6, 2023 12:09 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make
> error
>
> When make or nmake fails to build the basetools, Edk2ToolsBuild.py
> currently prints a generic error message "Failed to build." and
> raises an exception. This has two issues: The first is that it raises
> an exception, which leads people to believe it is a python issue, and
> not a build issue. The second is that users don't necessarily know to
> check the build log if this error occurs.
>
> This has been reported many times through many different avenues:
>
> https://github.com/tianocore/edk2/discussions/4611
> https://stackoverflow.com/questions/77421168/edkii-base-tools-fails-
> to-build
> https://github.com/tianocore/edk2-pytool-extensions/issues/180
> https://github.com/tianocore/edk2-pytool-extensions/issues/207
>
> This patch series changes the exception to a error log so that the
> invocable
> completes and returns a non-zero exit code and also logs a more
> descriptive
> error that informs the user to review the build log, and where to find
> it.
>
> Joey Vagedes (1):
> BaseTools: Edk2ToolsBuild.py: Clarify make error
>
> BaseTools/Source/C/Common/BinderFuncs.c | 2 +-
> BaseTools/Edk2ToolsBuild.py | 8 ++++++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> --
> 2.34.1
>
> \x06®‹©²*
> Šy,b‹«yÇ¢½æ¥–g¬±¨\x1e²Ç§¶Ú-†+ ®‹©V'°ý\x17©—#§–)Þ×];çˆm¶›?ýçdÚ
> 躛"£ø?uëÞ—
> ùž²Æ {ýuÓ¾x2ë^N\x18¬NŠbr^[m¦Ïÿ‚º.¦È¨þk\x7f×M¸ÛÎüïýzã~=èj躓°êÝz÷¥úŒ'z·“h+¢ê
> lŠ…'²æìr¸›z^[m¦ÏÿyÙ6‚º.¦È¨þ\x0fÝz÷¥þéì¹¹¢r\x16ž•Ù"žw²Š{^•Ê&
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110761): https://edk2.groups.io/g/devel/message/110761
Mute This Topic: https://groups.io/mt/102428787/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-06 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 20:08 [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make error Joey Vagedes via groups.io
2023-11-06 20:08 ` [edk2-devel] [PATCH v1 1/1] BaseTools: " Joey Vagedes via groups.io
2023-11-06 21:54 ` Michael D Kinney [this message]
2023-11-06 22:47 ` [edk2-devel] [PATCH v1 0/1] " Joey Vagedes via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929EB19EBC3E85461C83B7BD2AAA@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox