public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Michael Kubacki <mikuback@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib
Date: Fri, 4 Nov 2022 16:32:14 +0000	[thread overview]
Message-ID: <CO1PR11MB4929EBFB487608FBBE50D09ED23B9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <22885.1667573092402501637@groups.io>

Hi Michael,

Here is a first pass at a feature matrix.  Can you think of other features to add?

### Framework and GoogleTest Feature Comparison

| Feature                   | Framework | GoogleTest |
|:--------------------------|:---------:|:----------:|
| Host based unit tests     |    YES    |    YES     |
| Target based unit tests   |    YES    |     NO     |
| Unit test source language |     C     |    C++     |
| Register Test Suite       |    YES    |    Auto    |
| Register Test Case        |    YES    |    Auto    |
| Setup/Teardown Hooks      |    YES    |    YES     |
| Value-Parameterized Tests |    NO     |    YES     |
| Typed Tests               |    NO     |    YES     |
| Type-Parameterized Tests  |    NO     |    YES     |
| Mocking Support           |   Cmocka  |     NO     |
| JUNIT XML Reports         |    YES    |    YES     |
| Execute subset of tests   |    NO     |    YES     |
| VS Code Extensions        |    NO     |    YES     |

Thanks,

Mike



From: Michael Kubacki <mikuback@linux.microsoft.com> 
Sent: Friday, November 4, 2022 7:45 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib

Reviewed-by: Michael Kubacki <mailto:michael.kubacki@microsoft.com>

There's a typo in UnitTestFrameworkPkg/ReadMe.md. You'll find it by searching for "ued".

The ReadMe.md updates are very helpful. Something else to consider would be a brief feature matrix at the top for the "framework" vs GoogleTest. I think it would be a little easier to parse which to choose than picking apart the key differences in the text. 

  reply	other threads:[~2022-11-04 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04  3:30 [Patch 0/7] Add GoogleTest to UnitTestFrameworkPkg Michael D Kinney
2022-11-04  3:30 ` [Patch 1/7] MdePkg/Include: Update Base.h to improve C++ compatibility Michael D Kinney
2022-11-04  3:30 ` [Patch 2/7] MdePkg/Include/Library: Undefine _ASSERT() if already defined Michael D Kinney
2022-11-04  3:30 ` [Patch 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib Michael D Kinney
2022-11-04 14:44   ` [edk2-devel] " Michael Kubacki
2022-11-04 16:32     ` Michael D Kinney [this message]
2022-11-04  3:30 ` [Patch 4/7] UnitTestFrameworkPkg/Library/CmockaLib: Enable symbol files Michael D Kinney
2022-11-04 14:45   ` [edk2-devel] " Michael Kubacki
2022-11-04  3:30 ` [Patch 5/7] .pytool: Add googletest submodule to CISettings.py Michael D Kinney
2022-11-04 14:46   ` [edk2-devel] " Michael Kubacki
2022-11-04  3:30 ` [Patch 6/7] BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml output Michael D Kinney
2022-11-04 13:30   ` Bob Feng
2022-11-04  3:30 ` [Patch 7/7] MdePkg/Test: Add port of BaseSafeIntLib unit tests to GoogleTest Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929EBFB487608FBBE50D09ED23B9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox