Re: [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs

["Michael D Kinney" <michael.d.kinney@intel.com>]

Pushed as ff31f8f683..75899d2a8f

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, August 23, 2021 6:58 PM
> To: Pedro Falcato <pedro.falcato@gmail.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: RE: [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs
> 
> Hi Pedro,
> 
> Found one VS compat issue with signed/unsigned comparison in last patch.
> 
> It was a very simple fix for force an unsigned compare.
> 
> Change:
>     if (Len < EXT4_MIN_DIR_ENTRY_LEN + Entry.name_len) {
> 
> To:
>     if (Len < (UINTN)(EXT4_MIN_DIR_ENTRY_LEN + Entry.name_len)) {
> 
> 
> With this one change:  Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> I will do push with this change
> 
> Mike
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Monday, August 23, 2021 6:42 PM
> > To: Pedro Falcato <pedro.falcato@gmail.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Subject: RE: [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs
> >
> > Series
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Pedro Falcato <pedro.falcato@gmail.com>
> > > Sent: Saturday, August 21, 2021 7:47 AM
> > > To: devel@edk2.groups.io
> > > Cc: Pedro Falcato <pedro.falcato@gmail.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Subject: [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs
> > >
> > > This patch-series addresses bugs found when testing the filesystem with
> > > more complex usage of the file protocol, particularly through the shell
> > > itself.
> > >
> > > This is version 2 of the patch series and addresses feedback received
> > > from the community. This version also adds two new patches to further
> > > improve Ext4Dxe and make it more resilient and ready to be used.
> > >
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >
> > > Pedro Falcato (5):
> > >   Ext4Pkg: Fix incorrect usage of Ext4InitExtentsMap.
> > >   Ext4Pkg: Hide "." and ".." entries from Read() callers.
> > >   Ext4Pkg: Add a directory entry tree.
> > >   Ext4Pkg: Add handling of EFI_FILE_SYSTEM_VOLUME_LABEL GetInfo().
> > >   Ext4Pkg: Sanity check more EXT4_DIR_ENTRY values.
> > >
> > >  Features/Ext4Pkg/Ext4Dxe/Directory.c  | 343 ++++++++++++++++++++------
> > >  Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h   |   3 +
> > >  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    |   1 -
> > >  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    |  88 ++++++-
> > >  Features/Ext4Pkg/Ext4Dxe/File.c       | 202 +++++++++++----
> > >  Features/Ext4Pkg/Ext4Dxe/Inode.c      |   3 +-
> > >  Features/Ext4Pkg/Ext4Dxe/Partition.c  |   7 +
> > >  Features/Ext4Pkg/Ext4Dxe/Superblock.c |  23 +-
> > >  8 files changed, 534 insertions(+), 136 deletions(-)
> > >
> > > --
> > > 2.33.0