From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"spbrogan@outlook.com" <spbrogan@outlook.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support
Date: Sun, 3 Apr 2022 17:32:34 +0000 [thread overview]
Message-ID: <CO1PR11MB4929F0C5560BC79725A8DB41D2E29@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4584.1648835119520240314@groups.io>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
Hi Sean,
Perhaps in the future this can be converted to an option python parameter with a default value of None?
Mike
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
Sent: Friday, April 1, 2022 10:45 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support
In regard to the "nofile.txt"
That parameter is used for reporting which file specified the ignore list. This was a feature of the gitignore parser that was integrated but that "report" is never used. Thus, in the additional api I added where I enabled the ignore content in a parameter rather than file, I "shimmed" it using nofile.txt as an indicator that this came from parameter.
Hope that helps explain why.
Thanks
Sean
[-- Attachment #2: Type: text/html, Size: 40009 bytes --]
next prev parent reply other threads:[~2022-04-03 17:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 1:58 [PATCH v1 0/4] UncrustifyCheck Ignore Support Michael Kubacki
2022-03-22 1:58 ` [PATCH v1 1/4] .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths Michael Kubacki
2022-03-22 16:07 ` [edk2-devel] " Michael D Kinney
2022-03-22 16:12 ` Michael D Kinney
2022-04-01 16:22 ` Michael Kubacki
2022-03-22 1:58 ` [PATCH v1 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support Michael Kubacki
2022-03-22 16:14 ` Michael D Kinney
2022-04-01 16:07 ` [edk2-devel] " Michael Kubacki
2022-04-01 16:50 ` Michael D Kinney
2022-04-01 17:45 ` Sean
2022-04-03 17:32 ` Michael D Kinney [this message]
2022-03-22 1:58 ` [PATCH v1 3/4] OvmfPkg: Revert Uncrustify formatting in VbeShim.h files Michael Kubacki
2022-03-22 6:34 ` Laszlo Ersek
2022-03-22 8:45 ` [edk2-devel] " Gerd Hoffmann
2022-03-22 1:58 ` [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify Michael Kubacki
2022-03-22 6:35 ` Laszlo Ersek
2022-03-22 8:46 ` [edk2-devel] " Gerd Hoffmann
2022-03-22 16:14 ` [PATCH v1 0/4] UncrustifyCheck Ignore Support Michael D Kinney
2022-04-01 16:04 ` [edk2-devel] " Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929F0C5560BC79725A8DB41D2E29@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox