public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Oliver Smith-Denny <osde@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg
Date: Thu, 1 Aug 2024 22:49:48 +0000	[thread overview]
Message-ID: <CO1PR11MB4929F3677DB572EF0D57F539D2B22@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <d2e8443b-2ab0-450a-935f-c3d97a5034c1@linux.microsoft.com>

In order to make this a compatible change, look into
updating MdeLibs.dsc.inc too so the lib mappings 
to the new locations are invisible to DSC files that
include MdeLibs.dsc.inc.

Mike

> -----Original Message-----
> From: Oliver Smith-Denny <osde@linux.microsoft.com>
> Sent: Thursday, August 1, 2024 3:39 PM
> To: devel@edk2.groups.io; Ard Biesheuvel <ardb@kernel.org>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg
> 
> CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler
> intrinsics and floating point functions required by OpenSSL,
> respectively. CompilerIntrinsicsLib is used almost in every DSC that
> builds ARM/AARCH64 and ArmSoftFloatLib is used by every DSC that builds
> logic from OpenSSL. Together these make almost every DSC have a
> dependency on ArmPkg, which is odd and for a handful, MdeModulePkg,
> EmbeddedPkg, and ShellPkg, namely, it is a circular dependency.
> 
> There have been previous mailing list suggestions to move
> CompilerIntrinsicsLib to MdePkg (possibly combining with other arch
> intrinsics). I am not sure the end status of those conversations. By
> moving these two libraries to MdePkg package, we accomplish a few
> things:
> 
>    - Removing the circular dependency from MdeModulePkg and ShellPkg
>      (EmbeddedPkg has other ArmPkg dependencies)
> 
>    - Aligning MdePkg as the base package where baseline build and spec
>      dependencies are found with other industry standard behavior
> 
>    - Detangling ArmPkg and making ARM/AARCH64 more of a first class
>      citizen in edk2 instead of bolted onto the side
> 
> There is no functional change here and the amount of work is light, but
> I think it moves edk2 in the direction it wants to go, so I'm happy to
> put up a PR for this, but I wanted to get feedback before I did so. This
> aligns with similar efforts, such as moving more ARM/AARCH64 chipset
> definitions to MdePkg from ArmPkg [1][2][3]. This also aligns to the
> overall goal of deleting ArmPkg:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4121
> 
> Thanks,
> Oliver
> 
> [1]
> https://github.com/tianocore/edk2/commit/f2b9d5417dccf763bcbb68cd0effed0e25
> 890aab
> [2]
> https://github.com/tianocore/edk2/commit/cf323e2839ce260fde43487baae205527d
> ee1b2f
> [3]
> https://github.com/tianocore/edk2/commit/c68fb69dfefa7a76ebad33674a49632c4f
> 8c6926


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120198): https://edk2.groups.io/g/devel/message/120198
Mute This Topic: https://groups.io/mt/107675828/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-08-01 22:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 22:39 [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg Oliver Smith-Denny
2024-08-01 22:49 ` Michael D Kinney [this message]
2024-08-01 22:51   ` Oliver Smith-Denny
2024-08-02  8:46 ` Ard Biesheuvel
2024-08-02 15:41   ` Michael D Kinney
2024-08-05 16:18   ` Oliver Smith-Denny
2024-08-05 10:13 ` Leif Lindholm
2024-08-05 16:20   ` Oliver Smith-Denny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929F3677DB572EF0D57F539D2B22@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox