From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@nuviainc.com" <rebecca@nuviainc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build
Date: Wed, 18 Aug 2021 19:00:03 +0000 [thread overview]
Message-ID: <CO1PR11MB4929F47A74F8E8BF8083554BD2FF9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <378d8020-eea0-2f49-3879-8768120392d7@nuviainc.com>
Good idea.
I was going to enter a BZ too.
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Wednesday, August 18, 2021 11:32 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build
>
> Maybe add a comment saying why it's disabled, in case fixing it takes
> some time?
>
>
> --
> Rebecca Cran
>
>
> On 8/17/21 11:42 PM, Michael D Kinney wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
> >
> > SocketDxe generates build failures with VS2017 and VS2019 due to
> > use of weak references and /WHOLEARCHIVE. Disable SocketDxe until
> > weak references can be removed.
> >
> > Cc: Rebecca Cran <rebecca@nuviainc.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> > StdLib/StdLib.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc
> > index d0a0c8a..4c72b4f 100644
> > --- a/StdLib/StdLib.inc
> > +++ b/StdLib/StdLib.inc
> > @@ -99,7 +99,7 @@
> > ##########
> > # Socket Layer
> > ##########
> > - StdLib/SocketDxe/SocketDxe.inf
> > +# StdLib/SocketDxe/SocketDxe.inf
> >
> >
> > ##############################################################################
>
>
>
>
next prev parent reply other threads:[~2021-08-18 19:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 5:41 [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
2021-08-18 5:41 ` [edk2-libc Patch 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
2021-08-18 5:41 ` [edk2-libc Patch 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc Michael D Kinney
2021-08-18 5:42 ` [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build Michael D Kinney
2021-08-18 18:31 ` Rebecca Cran
2021-08-18 19:00 ` Michael D Kinney [this message]
2021-08-18 5:42 ` [edk2-libc Patch 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function Michael D Kinney
2021-08-18 5:42 ` [edk2-libc Patch 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF Michael D Kinney
2021-08-18 5:42 ` [edk2-libc Patch 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS Michael D Kinney
2021-08-18 5:42 ` [edk2-libc Patch 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc Michael D Kinney
2021-08-18 5:42 ` [edk2-libc Patch 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define Michael D Kinney
2021-08-18 5:42 ` [edk2-libc Patch 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes Michael D Kinney
2021-08-18 18:37 ` [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019 Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929F47A74F8E8BF8083554BD2FF9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox