public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney via groups.io" <michael.d.kinney=intel.com@groups.io>
To: Michael Kubacki <mikuback@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"osde@linux.microsoft.com" <osde@linux.microsoft.com>,
	"leif.lindholm@oss.qualcomm.com" <leif.lindholm@oss.qualcomm.com>
Cc: Oliver Smith-Denny <osde@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure
Date: Wed, 18 Dec 2024 23:03:20 +0000	[thread overview]
Message-ID: <CO1PR11MB4929F4F1640C35BEFF8A3A59D2052@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB492979358025AE36A0674A37D2052@CO1PR11MB4929.namprd11.prod.outlook.com>

CMOS comment is incorrect. I was thinking OVMF.

For EmulatorPkg, a resource that is global to the user mode app
is needed to store the address.  

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, December 18, 2024 1:47 PM
> To: Michael Kubacki <mikuback@linux.microsoft.com>;
> devel@edk2.groups.io; osde@linux.microsoft.com;
> leif.lindholm@oss.qualcomm.com
> Cc: Oliver Smith-Denny <osde@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure
> 
> Yes.  We have had issues with Windows and Linux with the virtual address
> ranges used.
> 
> It is a fragile aspect of EmulatorPkg.
> 
> The challenge is that value needs to be FixedAtBuild because modules
> need the
> value before dynamic PCD services are available.
> 
> We could consider alternate storage for this value and allow Windows and
> Linux
> init code to allocate this special buffer anywhere and store the address
> in
> a global location in HW (such as CMOS).
> 
> Mike
> 
> > -----Original Message-----
> > From: Michael Kubacki <mikuback@linux.microsoft.com>
> > Sent: Wednesday, December 18, 2024 1:27 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>; osde@linux.microsoft.com;
> > leif.lindholm@oss.qualcomm.com
> > Cc: Oliver Smith-Denny <osde@microsoft.com>
> > Subject: Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure
> >
> > It looks like there was a similar issue in the past that led to a
> tweak
> > to the PCD value -
> >
> https://github.com/tianocore/edk2/commit/868254ace3a0729c9ed6eb1a8646f64
> > c77ee84f9.
> >
> > Mike, do you recall that rationale / debug details for that change?
> I'm
> > also making some pipeline changes for the new names. Understanding
> this
> > is tangential to a change dropping IA32 VS EmulatorPkg in the pipeline
> > but that could be considered as well and I could add that if desired.
> >
> > Thanks,
> > Michael
> >
> > On 12/18/2024 3:44 PM, Michael Kubacki wrote:
> > > Hi Mike,
> > >
> > > I've also had trouble reproducing it consistently locally but I was
> > able
> > > to with at least one build. With that build, simply rerunning the
> same
> > > WinHost.exe binary would sometimes work and fail.
> > >
> > > Thanks,
> > > Michael
> > >
> > > On 12/18/2024 3:33 PM, Michael D Kinney via groups.io wrote:
> > >> I also just did a rerun on a job that failed, and the rerun passed.
> > >>
> > >>      https://github.com/tianocore/edk2/pull/6542
> > >>
> > >> Either there was an OS change/patch since the failed run or the
> > >> failure is non deterministic.
> > >>
> > >> Mike
> > >>
> > >>> -----Original Message-----
> > >>> From: Kinney, Michael D <michael.d.kinney@intel.com>
> > >>> Sent: Wednesday, December 18, 2024 12:31 PM
> > >>> To: devel@edk2.groups.io; mikuback@linux.microsoft.com;
> > >>> osde@linux.microsoft.com; leif.lindholm@oss.qualcomm.com
> > >>> Cc: Oliver Smith-Denny <osde@microsoft.com>; Kinney, Michael D
> > >>> <michael.d.kinney@intel.com>
> > >>> Subject: RE: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg
> > failure
> > >>>
> > >>> Here are some more details.  Looks like the upgrade to VS2022 also
> > >>> change the runner image which included an OS version change as
> well.
> > >>>
> > >>> Passing Azure Pipelines CI Agent details:
> > >>>      Image: windows-2019
> > >>>      Version: 20241125.1.0
> > >>>      Included Software: https://github.com/actions/runner-
> > >>> images/blob/win19/20241125.1/images/windows/Windows2019-Readme.md
> > >>>          OS Version: 10.0.17763 Build 6532
> > >>>          Image Version: 20241125.1.0
> > >>>      Image Release: https://github.com/actions/runner-
> > >>> images/releases/tag/win19%2F20241125.1
> > >>>
> > >>> Failing Azure Pipelines CI Agent details:
> > >>>      Runner Image
> > >>>      Image: windows-2022
> > >>>      Version: 20241215.1.0
> > >>>      Included Software: https://github.com/actions/runner-
> > >>> images/blob/win22/20241215.1/images/windows/Windows2022-Readme.md
> > >>>          OS Version: 10.0.20348 Build 2966
> > >>>          Image Version: 20241215.1.0
> > >>>      Image Release: https://github.com/actions/runner-
> > >>> images/releases/tag/win22%2F20241215.1
> > >>>
> > >>>> -----Original Message-----
> > >>>> From: Kinney, Michael D <michael.d.kinney@intel.com>
> > >>>> Sent: Wednesday, December 18, 2024 9:54 AM
> > >>>> To: devel@edk2.groups.io; mikuback@linux.microsoft.com;
> > >>>> osde@linux.microsoft.com; leif.lindholm@oss.qualcomm.com
> > >>>> Cc: Oliver Smith-Denny <osde@microsoft.com>; Kinney, Michael D
> > >>>> <michael.d.kinney@intel.com>
> > >>>> Subject: RE: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg
> > failure
> > >>>>
> > >>>> I can not reproduce locally either.
> > >>>>
> > >>>> I installed VS2022 build tools.
> > >>>>
> > >>>> The error message is related to the ability to allocate a
> specific
> > >>> range
> > >>>> of virtual memory.
> > >>>>
> > >>>> If that fails on CI agent, but not local envs, it could be
> related
> > to
> > >>>> the
> > >>>> CI agent windows image being used.
> > >>>>
> > >>>> Mike
> > >>>>
> > >>>>
> > >>>>> -----Original Message-----
> > >>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > >>> Michael
> > >>>>> Kubacki via groups.io
> > >>>>> Sent: Wednesday, December 18, 2024 8:48 AM
> > >>>>> To: devel@edk2.groups.io; osde@linux.microsoft.com;
> > >>>>> leif.lindholm@oss.qualcomm.com; Kinney, Michael D
> > >>>>> <michael.d.kinney@intel.com>
> > >>>>> Cc: Oliver Smith-Denny <osde@microsoft.com>
> > >>>>> Subject: Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg
> > >>> failure
> > >>>>>
> > >>>>> I'll update the pipeline names later today.
> > >>>>>
> > >>>>> Thanks,
> > >>>>> Michael
> > >>>>>
> > >>>>> On 12/18/2024 10:42 AM, Oliver Smith-Denny via groups.io wrote:
> > >>>>>> Hi Leif,
> > >>>>>>
> > >>>>>> On 12/18/2024 3:13 AM, Leif Lindholm via groups.io wrote:
> > >>>>>>> PR CI jobs are currently failing on Ia32 EmulatorPkg RELEASE
> > >>>> (passes
> > >>>>>>> on DEBUG) with
> > >>>>>>> ---
> > >>>>>>> ERROR : Could not allocate PeiServicesTablePage @ 13000000
> > >>>>>>> ---
> > >>>>>>> during the "run to shell" test.
> > >>>>>>>
> > >>>>>>> I note that the build step for
> > >>>>>>> PlatformCI_EmulatorPkg_Windows_VS2019_PR now uses VS2022,
> > >>>>>>> presumably as of https://github.com/tianocore/edk2/pull/6501
> > >>>>>>>
> > >>>>>>> Can someone with access to a VS environment help investigate?
> > >>>>>>
> > >>>>>> I tried to repro this locally yesterday, but unfortunately was
> > not
> > >>>>>> getting one. I will try again today.
> > >>>>>>
> > >>>>>>> We should probably also get the CI job names updated to
> reflect
> > >>> the
> > >>>>>>> toolchain version they're using.
> > >>>>>>
> > >>>>>> Yes, I asked Mike Kinney to update the pipelines (I
> unfortunately
> > >>> do
> > >>>>>> not have permission to do so, it has to be done by an admin,
> Mike
> > >>>>> Kinney
> > >>>>>> or Michael Kubacki I believe will do it. The plan is to also
> > >>> change
> > >>>>> the
> > >>>>>> name of the GCC5 pipeline (Gerd requested this) and instead
> have
> > >>>> more
> > >>>>>> generically named pipelines so when they are updated in the
> > future
> > >>>> we
> > >>>>>> don't have this name mismatch.
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>> Oliver
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>
> > >>
> > >>
> > >> 
> > >>
> > >>
> > >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120920): https://edk2.groups.io/g/devel/message/120920
Mute This Topic: https://groups.io/mt/110178683/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-12-18 23:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 11:13 [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure Leif Lindholm via groups.io
2024-12-18 15:42 ` Oliver Smith-Denny via groups.io
2024-12-18 16:48   ` Michael Kubacki via groups.io
2024-12-18 17:54     ` Michael D Kinney via groups.io
2024-12-18 20:30       ` Michael D Kinney via groups.io
2024-12-18 20:33         ` Michael D Kinney via groups.io
2024-12-18 20:44           ` Michael Kubacki via groups.io
2024-12-18 21:26             ` Michael Kubacki via groups.io
2024-12-18 21:47               ` Michael D Kinney via groups.io
2024-12-18 23:03                 ` Michael D Kinney via groups.io [this message]
     [not found] <1812411E4A564231.26783@groups.io>
2024-12-18 14:34 ` Leif Lindholm via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929F4F1640C35BEFF8A3A59D2052@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox