From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1C718D80442 for ; Thu, 10 Aug 2023 19:25:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6APYgL671K23VAP//hE9mQSFVMZtzwKuTGMiuSEdYIE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691695531; v=1; b=PZjGxh4xmsrNQF5cZ4djAz/pSVJ0f+F0ZrKPk3SfseZ4r0JLDhtaZYHKpapmC+lVuB0pxcSe lcct2VkqY+aG2DQryEjBbot2ZVnJztS8uNIeF6uM2umFLEfiSzt0GPc3SE6Z5tLzMwOmx++DYZb RRl+YACNsSYxR5LJtJVqSv9c= X-Received: by 127.0.0.2 with SMTP id zyyuYY7687511xPeQ3SW0Wqm; Thu, 10 Aug 2023 12:25:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.26775.1691695530946038847 for ; Thu, 10 Aug 2023 12:25:31 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="375216362" X-IronPort-AV: E=Sophos;i="6.01,163,1684825200"; d="scan'208";a="375216362" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 12:25:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="732398132" X-IronPort-AV: E=Sophos;i="6.01,163,1684825200"; d="scan'208";a="732398132" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 10 Aug 2023 12:25:28 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 12:25:29 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 12:25:29 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 10 Aug 2023 12:25:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JNBJ4OY9NGZi6u/MOPCEKRHPBnG7qkxZXGvCjzjjG+l/sqTp90M4e5aCfTts9CCWaLCI6Uf2g0sJj9xop7IQ7fGkldgI41GRzASMBmvrY249aQkVLJZz09OLQFHF4fUDUVVo6Amkj33noq900GXpA6S8IBeAqbeSBioFPIvLDSuTZDEpd3Pz3z8NJQUU72Ksq5B/fUfGvG0gz6PS98TCRppI+nXdPsiBp0gYA/oDR19l0pVYSn7oYcQuEZqg2eWrzj35pS6QDbXubEvDAhyYMXQjkTy9O1kZPpWMSYJEIvwENXk4243X/1EuP4XBZK4U5nN6fo9Cx+pxq3m8Fi6jCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VXrzwZQAJvh5RK5lSdfyqd+83TBQ9sWQ4df5GlPBL4g=; b=T22RfEGjXj/k2A7qVkl/DTCt0AwuE9KlF3I3pft1OpdkgD/LA+P8eYUdLxixvy96lcRI2TYhpnQ2as1lhgNRzSIxJGBoBqjc3zX4pMlz39v+1B91llAkPgxoXc6M80ED//R24dILauNfKwivy5Iqdkr+3pMvW3R9HqWKhGWfRe8ux4l55hi3dA5KSV3rRFmLZAYq/CneVkLRlPhO4PcVJHuNciU3G35DwR8tM8Rg+Anq26OTvH9n8pqRL6tJcCjaS+wwlyuFhEaEq01hXbJ1LXlmn9s384emnV8KL+txLD5rhf0wo7TPGw6eY/4V08MN9u3TH62WRxyEbyibdjGhZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by DM6PR11MB4628.namprd11.prod.outlook.com (2603:10b6:5:28f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 19:25:27 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::379b:adac:f23b:e038]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::379b:adac:f23b:e038%6]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 19:25:27 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "vnowkakeane@linux.microsoft.com" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files Thread-Topic: [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files Thread-Index: AQHZy75wMd7RI6DgBEyJeYh4Xfq0uK/j6UAA Date: Thu, 10 Aug 2023 19:25:27 +0000 Message-ID: References: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> <20230809213226.1387-7-vnowkakeane@linux.microsoft.com> In-Reply-To: <20230809213226.1387-7-vnowkakeane@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|DM6PR11MB4628:EE_ x-ms-office365-filtering-correlation-id: 4c8bc35d-62ed-4bb0-22ba-08db99d78dac x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ZIL97g/SI5TzXwmZO/ON1c9ajfE9mFF8Oekm7+MysAMfEfF/E55C429fgj85bnYyqVibWAr+gfd+CKzIuZPN5qjbJpKKIQfjo+H8y4PUe+HXoPwb8bjH+vxdirieuCo7nMT6Fu5AWbXx6m0328MoNje/6oEbzbSGjowuJvqja1x0yMl41I+a1m40s5G4zJle4AqSpUB1KyMqbnmLUMsojp5w8saOzDazMpdGsJ033YsYoXR0ZP4rXc6w70eoTQrSITOhkA4FAjUSKuRTu0dp88Kueya32VCCkfpvPPfFdEgiZfgp3hH9Ui9CgBcrX8wf8uqcpB0Tka9BWeGBOt4njJUWGyk45Zrj9ZbWKjltBd5/39GEGhk7s7MxBA+ZyKpVDdaGVnunrQ5/P9IIDjAmi2XH2i76ZGUtuxlS4n23BUApOnkB477vUNMq38OCaAkI+dNY4ALYb8vNQId13OjE/Vqv5HXfDzGXUDtqF8y3Yc2Al2f4nz6rrbbTndOmoJOfINvRSlWRdm6tKfMbsYiHlvlouAn1NvCfGSUMxPem+D2MK7HTDoqM023y5FCoEyG9dfwGDjGQaEx20lEnECxCImrzN4uMW0LBkVMOE6ug//Y5UsjW4UbyjUlZfBghuENB8OGo+PKaQrHRBqsf6CuVEQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XEU5kvllhl8QT6IQHGzt5JJ4WoGEp+GbvkoKkmkd8X8+V6DodNYmS0Y7xfQm?= =?us-ascii?Q?sSgLB3CVmBZXubGJtg0RsOBmVxpnVEIArqV3mbEn9E75ckWAEKb9Y1JSPfvq?= =?us-ascii?Q?ADUn6WcKKfm6Xy02Nb1TYDc0XYlbB2SSmjtQgqm4T4sLNtt8imZ+a/7nVpEI?= =?us-ascii?Q?hwUovacJXnqamX0z2EzMyKPNmRxboJ/g07VJejMCJA051IQqkwl/KtF/50EY?= =?us-ascii?Q?N56Mgw7ieKUzrgq5LtzXXlBgIF4xfqOvgL6DvLrV5S/Qc+CRg+g6F6dkPaic?= =?us-ascii?Q?hGgE9Mnh5nA7nvJEOauIVVYsp53i9dQc6CmG7wOqZEjSjade+427tXNEeHZJ?= =?us-ascii?Q?WWNjWWq8TsP1EaKafc/7++i7lpNmtxzymn8iAIa5soUS6RIEI8Gk82AoKmK5?= =?us-ascii?Q?E5B56BV6+Z9qu/QOvWq4ck6SWwqdY47cWWiYNek3IT6dPRjciHW0mUvuIAqd?= =?us-ascii?Q?w/y0R7rNq1DhEcXOOI6dlElow7y3A3C8CpWyiR+7hfeweoSYhGufhapSHyzZ?= =?us-ascii?Q?YV5rqTVhhkZ8KmiaRlF3+Ma5f+ArvYwmzsimAq8Cbx8YaTCvPc2txLlOF1pY?= =?us-ascii?Q?7M2kdG0LbFYXiIhmZ16eJ+7w+nPitVjuOdAyvLQhs3nbe0XPNnY6UWDH6pHf?= =?us-ascii?Q?AiZ5+MqSS0Bq70ARmMcYNFRM1Vys3wUnIk4uWG0kFULn0zWdjsMCUuye2aDv?= =?us-ascii?Q?r0OSPuAwt/iqGdg10nG7xqJmWvzHDd3o2FmfC57XuNP82hOpm7GaqBdCpz3t?= =?us-ascii?Q?EBmaAcQ5/V4IMQ2lhAA4Sw49x0/RkH9sVTz7cdIiHBBS9qlLZyJi88ujzUWN?= =?us-ascii?Q?IE6LcvycXck/6peJhdhZ+xddv4j8P3ciQTX4QRd1Zl7uG0x0c8BNAAaHhxLt?= =?us-ascii?Q?9qegL2Tpbot4lpnuqXiy+62NFa7sx2icxu6Q20ZSzS3IEVIm/pzWJJ8mW3Tq?= =?us-ascii?Q?Z45k32s5toC2NxmEIS8uDRX5oLmvT8ZNmq86BPoIYrzbOz4N8hLkJJbpDXCh?= =?us-ascii?Q?Om2bJJw0lBq7CIeajLCkD59FW8sq42AbDElAOWOcZTz5X5/WZ4ZftCcdmaQW?= =?us-ascii?Q?8oHEE7czf9y0eznbf6IiUb5rH66uNfsP1wSiJ78vKWizS/8DY3hU2z9oHm+k?= =?us-ascii?Q?KVhFuxR7YgBUOVz//shX8v/MIWHtpBbOMWFzgPmwddeQG+aQ6ELVaBFFl3F/?= =?us-ascii?Q?PnuZP+7gVTltSJ+Evryj3Ck9N58oGBO8zIMRmWWTr7zkvqFAQZ2xN7cNePHO?= =?us-ascii?Q?D1qK9RUySE77F4gNWicFFYDeno704wMAnTsXX2Sz5kWh3hrCaG5GLIOQQUQO?= =?us-ascii?Q?SwdXVyCV4/tBsfHfbpMPFShKe+uqErkb+rUxHorzQcIWQM9X4kumsgq3ssBD?= =?us-ascii?Q?HN2WHWYqY553CjKGNRnFxYTaQ2enhvroZkupN1WT4DPAOVFfPWXk7d7/SdR6?= =?us-ascii?Q?VXz34d7inb2QpvtK4FM/45G2mrpgL1i6f5raZxO+sLWixHzXaT07GqRINgqV?= =?us-ascii?Q?yCQ95JusiQvHDGMr0ytLDbcDFyrmDwrW0+e5SB4xdQZQd5vz4nG9VstNjXl1?= =?us-ascii?Q?8v6Y3PwyzSnDimPpqibmUfFp3H1NfdsrPNiWx+s2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c8bc35d-62ed-4bb0-22ba-08db99d78dac X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2023 19:25:27.6481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QiVKourrRinHoWiufwqNLqNiSE30K9+gkLjqDcCn0BSBCX7x0c3ee3Y+FwFzkUP1k7rpwBYvvFWeyYQmROaf6Ngv365cEumUoUSr9lTg4gA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4628 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gBMJlLmo1aW9fTWEtS8O78Odx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PZjGxh4x; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Michael D Kinney > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of VivianNK > Sent: Wednesday, August 9, 2023 2:32 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 6/7] UnitTestFrameworkPkg: Apply > uncrustify formatting to relevant files >=20 > Apply uncrustify formatting to GoogleTest cpp and header files. >=20 > CC: Michael D Kinney > CC: Michael Kubacki > CC: Sean Brogan > Signed-off-by: Vivian Nowka-Keane > --- > UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > | 2 +- >=20 > UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogle > Test.cpp | 76 ++++++++++++-------- > 2 files changed, 47 insertions(+), 31 deletions(-) >=20 > diff --git a/UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > b/UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > index c0a3d8e66011..c723b5c23050 100644 > --- a/UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > +++ b/UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > @@ -14,7 +14,7 @@ > #include >=20 >=20 >=20 > extern "C" { >=20 > -#include >=20 > + #include >=20 > } >=20 >=20 >=20 >=20 > ///////////////////////////////////////////////////////////////////////// > ///// >=20 > diff --git > a/UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoog > leTest.cpp > b/UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoog > leTest.cpp > index c83e58596a82..94cbf2cf0b3c 100644 > --- > a/UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoog > leTest.cpp > +++ > b/UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoog > leTest.cpp > @@ -18,7 +18,7 @@ extern "C" { > Sample unit test that verifies the expected result of an unsigned > integer >=20 > addition operation. >=20 > **/ >=20 > -TEST(SimpleMathTests, OnePlusOneShouldEqualTwo) { >=20 > +TEST (SimpleMathTests, OnePlusOneShouldEqualTwo) { >=20 > UINTN A; >=20 > UINTN B; >=20 > UINTN C; >=20 > @@ -34,11 +34,11 @@ TEST(SimpleMathTests, OnePlusOneShouldEqualTwo) { > Sample unit test that verifies that a global BOOLEAN is updatable. >=20 > **/ >=20 > class GlobalBooleanVarTests : public ::testing::Test { >=20 > - public: >=20 > - BOOLEAN SampleGlobalTestBoolean =3D FALSE; >=20 > +public: >=20 > + BOOLEAN SampleGlobalTestBoolean =3D FALSE; >=20 > }; >=20 >=20 >=20 > -TEST_F(GlobalBooleanVarTests, GlobalBooleanShouldBeChangeable) { >=20 > +TEST_F (GlobalBooleanVarTests, GlobalBooleanShouldBeChangeable) { >=20 > SampleGlobalTestBoolean =3D TRUE; >=20 > ASSERT_TRUE (SampleGlobalTestBoolean); >=20 >=20 >=20 > @@ -51,37 +51,46 @@ TEST_F(GlobalBooleanVarTests, > GlobalBooleanShouldBeChangeable) { > pointer is updatable. >=20 > **/ >=20 > class GlobalVarTests : public ::testing::Test { >=20 > - public: >=20 > - VOID *SampleGlobalTestPointer =3D NULL; >=20 > +public: >=20 > + VOID *SampleGlobalTestPointer =3D NULL; >=20 >=20 >=20 > - protected: >=20 > - void SetUp() override { >=20 > +protected: >=20 > + void >=20 > + SetUp ( >=20 > + ) override >=20 > + { >=20 > ASSERT_EQ ((UINTN)SampleGlobalTestPointer, (UINTN)NULL); >=20 > } >=20 > - void TearDown() { >=20 > + >=20 > + void >=20 > + TearDown ( >=20 > + ) >=20 > + { >=20 > SampleGlobalTestPointer =3D NULL; >=20 > } >=20 > }; >=20 >=20 >=20 > -TEST_F(GlobalVarTests, GlobalPointerShouldBeChangeable) { >=20 > +TEST_F (GlobalVarTests, GlobalPointerShouldBeChangeable) { >=20 > SampleGlobalTestPointer =3D (VOID *)-1; >=20 > ASSERT_EQ ((UINTN)SampleGlobalTestPointer, (UINTN)((VOID *)-1)); >=20 > } >=20 >=20 >=20 > - >=20 > /** >=20 > Set PcdDebugPropertyMask for each MacroTestsAssertsEnabledDisabled > test >=20 > **/ >=20 > class MacroTestsAssertsEnabledDisabled : public > testing::TestWithParam { >=20 > - void SetUp() { >=20 > - PatchPcdSet8 (PcdDebugPropertyMask, GetParam()); >=20 > + void >=20 > + SetUp ( >=20 > + ) >=20 > + { >=20 > + PatchPcdSet8 (PcdDebugPropertyMask, GetParam ()); >=20 > } >=20 > }; >=20 >=20 >=20 > /** >=20 > Sample unit test using the ASSERT_TRUE() macro. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertTrue) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertTrue) { >=20 > UINT64 Result; >=20 >=20 >=20 > // >=20 > @@ -99,7 +108,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertTrue) { > /** >=20 > Sample unit test using the ASSERT_FALSE() macro. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertFalse) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertFalse) { >=20 > UINT64 Result; >=20 >=20 >=20 > // >=20 > @@ -117,7 +126,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertFalse) { > /** >=20 > Sample unit test using the ASSERT_EQ() macro. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertEqual) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertEqual) { >=20 > UINT64 Result; >=20 >=20 >=20 > // >=20 > @@ -135,7 +144,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertEqual) { > /** >=20 > Sample unit test using the ASSERT_STREQ() macro. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertMemEqual) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertMemEqual) { >=20 > CHAR8 *String1; >=20 > CHAR8 *String2; >=20 >=20 >=20 > @@ -150,7 +159,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertMemEqual) { > /** >=20 > Sample unit test using the ASSERT_NE() macro. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertNotEqual) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertNotEqual) { >=20 > UINT64 Result; >=20 >=20 >=20 > // >=20 > @@ -169,7 +178,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertNotEqual) { > Sample unit test using the ASSERT_TRUE() and ASSERT(FALSE) >=20 > and EFI_EFFOR() macros to check status >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertNotEfiError) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertNotEfiError) { >=20 > // >=20 > // This test passes because the status is not an EFI error. >=20 > // >=20 > @@ -184,7 +193,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertNotEfiError) { > /** >=20 > Sample unit test using the ASSERT_EQ() macro to compare EFI_STATUS > values. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertStatusEqual) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertStatusEqual) { >=20 > // >=20 > // This test passes because the status value are always equal. >=20 > // >=20 > @@ -194,7 +203,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertStatusEqual) { > /** >=20 > Sample unit test using ASSERT_NE() macro to make sure a pointer is not > NULL. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroAssertNotNull) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroAssertNotNull) { >=20 > UINT64 Result; >=20 >=20 >=20 > // >=20 > @@ -206,7 +215,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroAssertNotNull) { > /** >=20 > Sample unit test using that should not generate any ASSERTs() >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroExpectNoAssertFailure) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroExpectNoAssertFailure) { >=20 > // >=20 > // This test passes because it never triggers an ASSERT(). >=20 > // >=20 > @@ -222,7 +231,7 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroExpectNoAssertFailure) { > /** >=20 > Sample unit test using the ASSERT_DEATH() macro to test expected > ASSERT()s. >=20 > **/ >=20 > -TEST_P(MacroTestsAssertsEnabledDisabled, MacroExpectAssertFailure) { >=20 > +TEST_P (MacroTestsAssertsEnabledDisabled, MacroExpectAssertFailure) { >=20 > // >=20 > // Skip tests that verify an ASSERT() is triggered if ASSERT()s are > disabled. >=20 > // >=20 > @@ -243,21 +252,28 @@ TEST_P(MacroTestsAssertsEnabledDisabled, > MacroExpectAssertFailure) { > ASSERT_DEATH (DecimalToBcd8 (101), ""); >=20 > } >=20 >=20 >=20 > -INSTANTIATE_TEST_SUITE_P(ValidInput, >=20 > - MacroTestsAssertsEnabledDisabled, >=20 > - ::testing::Values(PcdGet8 > (PcdDebugPropertyMask) | BIT0, PcdGet8 (PcdDebugPropertyMask) & > (~BIT0))); >=20 > +INSTANTIATE_TEST_SUITE_P ( >=20 > + ValidInput, >=20 > + MacroTestsAssertsEnabledDisabled, >=20 > + ::testing::Values (PcdGet8 (PcdDebugPropertyMask) | BIT0, PcdGet8 > (PcdDebugPropertyMask) & (~BIT0)) >=20 > + ); >=20 >=20 >=20 > /** >=20 > Sample unit test using the SCOPED_TRACE() macro for trace messages. >=20 > **/ >=20 > -TEST(MacroTestsMessages, MacroTraceMessage) { >=20 > +TEST (MacroTestsMessages, MacroTraceMessage) { >=20 > // >=20 > // Example of logging. >=20 > // >=20 > SCOPED_TRACE ("SCOPED_TRACE message\n"); >=20 > } >=20 >=20 >=20 > -int main(int argc, char* argv[]) { >=20 > - testing::InitGoogleTest(&argc, argv); >=20 > - return RUN_ALL_TESTS(); >=20 > +int >=20 > +main ( >=20 > + int argc, >=20 > + char *argv[] >=20 > + ) >=20 > +{ >=20 > + testing::InitGoogleTest (&argc, argv); >=20 > + return RUN_ALL_TESTS (); >=20 > } >=20 > -- > 2.41.0.windows.3 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#107671): > https://edk2.groups.io/g/devel/message/107671 > Mute This Topic: https://groups.io/mt/100655294/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107700): https://edk2.groups.io/g/devel/message/107700 Mute This Topic: https://groups.io/mt/100655294/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-