From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AB03C7803D2 for ; Fri, 18 Aug 2023 15:30:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NB+Udb9enwJ22cF9/nl/bsmN8MvPzv9zW4Jh2KEFSUw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692372606; v=1; b=Pbskl81S5pUcmbSsAMMQQLsq2abLP0fu/Yf/ZUvWKiyWLX9fyTsae3PZ8bK4Kj6mwUb6KowN MFnXd4wUk/2D/uRO0EbRQ9Nut93iO/Rx8kTvv9YuddZknbTrrVU3tH+HEDhl4R3PrWld/vpFcdO IXhrLTH/thscblWzBjn4h4Rk= X-Received: by 127.0.0.2 with SMTP id snjVYY7687511xAHdgXMdEuK; Fri, 18 Aug 2023 08:30:06 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.14143.1692372605252702245 for ; Fri, 18 Aug 2023 08:30:05 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="372026798" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="372026798" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2023 08:30:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10806"; a="805200648" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="805200648" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 18 Aug 2023 08:30:04 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 18 Aug 2023 08:30:03 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 18 Aug 2023 08:30:03 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 18 Aug 2023 08:30:03 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 18 Aug 2023 08:30:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LpHVhI//E4r6QAM1A+FmJUh3yxoDecS+7zX4bXE3vifwPyd9zDaexD7USVj1d2RnExbJnOFvheVLc8rdZvzpWdbT4fDuxiy6GLvTYajlNdLSMh1mE/7b/Sze63VITLVYJnK8SwXjTNnLQY9RZJImGABmjtd2eTt9TxCg6ciksBAgIJUMtL4Pj/aFOoiltAWfqGRms3L94BbBdQ+4vahu9hn/p6ZU2b6vpRpmIKlv1G/MVeBV7IwW48WZ8KGjlo0NHMvoJkNS5XQnkNXCYFRooItC1gQBChWgV/A0Ahl5SNbMhvmqBJGwFZpexPFfcIB3HM+adPMUO3VoMj3S2qWZGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=apvVbapRsV/SM4Fxncb6a++5VUT4C+vkh7kzE+35EY8=; b=SIAyyhQuIHRif/TZNYttZ1z7yG4HQzDguR2dVVRucw8JD1Wc4fEqUzkbczAPz3TTpRO91VzRyPvHm95ctK3zef5/wkc/r6vqldj5dFipQJS4gA2frmMSvkxxpSBpj+xheK8USkLlXQ6Ra/Qaxtj9jeR32iKmRSAuYB6tlTxYoqjai0uSUD9EfHX7eiSPYh8FLVf1cd3Wncj6TDrCtSfF1SAprn3N+xyOT85FAjVvw5tDNvh7Svjv4fv0MzG4vpUZsQ75ztOHCMuTvhYSo+K0FMRYRwh8MxJLORV+jbJ14dTAjU2Qvdosz4INoH1WzEJ+YaBFXu6RumSQ8cDOUu+s2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA1PR11MB5924.namprd11.prod.outlook.com (2603:10b6:806:23b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.31; Fri, 18 Aug 2023 15:29:59 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6699.020; Fri, 18 Aug 2023 15:29:59 +0000 From: "Michael D Kinney" To: Chris Li OS , "devel@edk2.groups.io" , "Nong, Foster" , "Gao, Liming" CC: "Yao, Jiewen" , "Ni, Ray" , "Open Source Submission" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into IndustryStandard Thread-Topic: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into IndustryStandard Thread-Index: AQHZ0bZvgiVE5OZUtUmSBC3yYgxbYq/wLjyA Date: Fri, 18 Aug 2023 15:29:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=True;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2023-08-18T09:28:50.366Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA1PR11MB5924:EE_ x-ms-office365-filtering-correlation-id: 33d018d5-a173-4dda-19eb-08db9ffffbe9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Q+MgR+1dmhH4P2F5xNZvdQ0ylsumUN2HqegNK6l3jVRI7jFNBKi3uyGa28UlbUokh2YbWclLUpOoOwKM/Bxd8u0Kwk0mCxGnljLQnVIXS9WGHCI1SjcoevSYPhjh7qXhK1kZYAcSPYq6hlNk4prGpDO3KbxoLl3dsTVm+bZc04hyTzq3tupc2Lye87MBxvpqKTrXyyma+plF6hH9ExerUK2/RwapcPGvQbggkwS2+HNEgCkTxw44QNyhV/ZJcsba1iLHL/8O4BpRDzJcKhDskn0DCSSFV6gJE2jxZty8d9Xbak3pQ2YzJf/0bMQSlbrCY/zR0sb3SmG5uvzQf/60kN4nhuX3s3rqbs4VggmcosH+0IKloaLJKFCBZeUgv2AAVR6otCX44YZHxDcjMBy/JqMCr8c/2RA2Xc5uWS453IEmwkOmZUuHs+StJBGQVdr0CShZpU8T4VKlPR9Nwfqk50M7MMXcyjw+fI566LpRSqwJmslYeCMVzJIyETHxKBcU8uP58jA62AjYh+A0mrizGrhG64XS2MsvgHpPPloBFmU41HJv+BBN4Z9aFDeNd8Dd4bl1TAq7AmcW7zxOdtJqvL+W6xDepBwj9Um/IzkRVQU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gPQ2gkmqCBvUpPd7os/eZ929EUwylpPvFBmgzu81R3PaZqJ7hAGynpFDoPnx?= =?us-ascii?Q?ANIZcRiG+Z9tJRkh1zHOCftDdZZQl7FQCYBvwfH+H+3wj4BPdISexYiSzZSo?= =?us-ascii?Q?5KbrO3VcfFEQvGK/kAfA71ZR7ErCXJPD1WBRyZ3qHO8L7CEZJNPM7O/2Pd0n?= =?us-ascii?Q?9eJlPZJDKnOj2hwSGA31/VDZi2rEdtaOK1rDOHxOPuiJLtg9bHIbNn1oAwMJ?= =?us-ascii?Q?q4DIY4eJYPnloMtyhKWowCScnOrcW5Tq7JEFTQF1AWHQSwvQ97gmzFJBk0dE?= =?us-ascii?Q?ZTHhYgerLZMCbOoeaPDWhKAMeTojfEaxXbefdzGZYe2QAhmwFRzK4G+r2mx2?= =?us-ascii?Q?IkMhRnbzXXmcDTVXuWpIPOmT5wcZMLQ4vUbmDkRSj4AxZGVQbPB5ztwgey55?= =?us-ascii?Q?Ii4VZvYNIeVxZZ5veLV1v0zVzxWalcrCBN2lvPwQkwoS6W6WdQtSCmzUDZ+O?= =?us-ascii?Q?HstnawnpRGVlWpqddgmPMB+uLl+5XnHxrCWV/lBVhkpEZXIsXWV7HVfucLhi?= =?us-ascii?Q?GPOQqUF7A4ZL2yrEZjX9DXeTK785R4MBo3P8We601pVoGOcUvv1UTilNi2m4?= =?us-ascii?Q?6XF+mvCSOeoZ3pSmM3Mvt0KAC4gTlrDCEdTcyKJDif0Cb89/+WXDQAP7ttZC?= =?us-ascii?Q?KRcNfWTxt5GyqiP7BjUCWxBBKPTv5gYIkkgRlfHIiyerB8RArQ4CXwY0zvY9?= =?us-ascii?Q?1DOZPs4rT4Im/0kK7KGPlCKtcduN9f6ZF6/SsU/ISkh7/594S0leMgG9hcxA?= =?us-ascii?Q?45oNJjLwcUcY2veldW6P+gPbcafRqcSu40laPxFhjgGi6W/Ubb/EknVwySrv?= =?us-ascii?Q?g+geBt+8v2opV2PmgugFkhgqGyQIp0Ki1al246WxVBi1wujsya3pugxhAy/7?= =?us-ascii?Q?H0q2uJFVoDC0tVvpld+FAE1fSPXP053XkVNbTeSJjFGtorSlDAJw9cPsYwp4?= =?us-ascii?Q?SkrCowM0ng+DhuNSKr/zyGWMkSsI40Yh0oE55BHambikkx9bJho9fbI0XStq?= =?us-ascii?Q?8ng6fBC0sLOo1jahjVSBVPjmpDnq9s9rgya/XXvAJXbTznxR9f1d9nODHpxw?= =?us-ascii?Q?fgIObUZGSP4u4qvFmyZpPceUAUDubXcflGp2TI761ZzKpL92YaWMi3PMj9Ud?= =?us-ascii?Q?jWSvcQ1w5lKTyzgRaHPp2psMjF9CjpG44FXHsXc/E6gVzTnyJBnQG0aoFMxN?= =?us-ascii?Q?QjA3rm5KUEJI2KjsOQxalJ61VjXGywDhfU6awE8rdHrzNLQdmtTkLOYx4QRp?= =?us-ascii?Q?rCCpcA9hmfFp127Me6ME8QXPL/P517xqQ2QaTOFOZ0mtsaQXzN10bBrupxy9?= =?us-ascii?Q?PhxMVzSGgUhAHPsfezuvgnhNK8puT+jaZVAeOE4c+xNxIfzxCx6zV4Kct7w/?= =?us-ascii?Q?M7qvuZLpSuIGgpNRR7Rl/M7c4inMRpBg2GAyxJOmROlbiPEeb4+qhpP976An?= =?us-ascii?Q?Ku+2voVGD+U7D0yE3UHx5XDNat9YEXLZvYevn4ojiebXA7P+wthgkylZC9qH?= =?us-ascii?Q?sQckPFmBDWIL7aYktZvfqz4AFJYjN5YXx/ovcMKqjqgrYtp1SN+2FjDc1gpA?= =?us-ascii?Q?A2gE4ylP3VlCDzUAhsbOj9X1qU9AJW4/LZJnrd4y?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33d018d5-a173-4dda-19eb-08db9ffffbe9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2023 15:29:59.4308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l7wqlTgvXlkuHJj9b6+4bpsetFs7eQCXWDJFDoP1tcv/VMvCrqVbbjCs8xqKVzQQIerey0KQlx2iRKq6tbm5ZICl+4J/oQa+07/optmsP8E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5924 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ccnFikfWVvEtPRAuhauCZAZUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Pbskl81S; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Is RegisterBlock a flexible array member? If so, then [] is the compatible syntax. Mike > -----Original Message----- > From: Chris Li OS > Sent: Friday, August 18, 2023 2:29 AM > To: devel@edk2.groups.io; Nong, Foster ; Gao, > Liming > Cc: Yao, Jiewen ; Ni, Ray ; > Kinney, Michael D ; Open Source Submission > > Subject: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into > IndustryStandard >=20 > Absorbed Foster's input with minor delta. > @Nong, Foster @Liming and all kindly help review/vote again. >=20 > One change compared with Intel's proposal is the below line, we prefer > [1] style to be safer to work across all compilers. > Let us know if you folks have different suggestions here. >=20 >=20 > - CXL_DVSEC_REGISTER_LOCATOR_REGISTER_BLOCK > RegisterBlock[0]; // offset 0x0C > + CXL_DVSEC_REGISTER_LOCATOR_REGISTER_BLOCK > RegisterBlock[1]; // offset 0x0C >=20 >=20 > Thanks all! >=20 > ----- > 1) Add CXL 2.0 header file to comply with CXL 2.0 specification > 2) CXL 2.0 header will embed Cxl11.h > 3) Updated Cxl.h to point to 2.0 header file >=20 > Signed-off-by: Chris Li > --- > MdePkg/Include/IndustryStandard/Cxl.h | 2 +- > MdePkg/Include/IndustryStandard/Cxl20.h | 465 ++++++++++++++++++++++++ > 2 files changed, 466 insertions(+), 1 deletion(-) > create mode 100644 MdePkg/Include/IndustryStandard/Cxl20.h >=20 > diff --git a/MdePkg/Include/IndustryStandard/Cxl.h > b/MdePkg/Include/IndustryStandard/Cxl.h > index 06c1230e3e..9ad3242e25 100644 > --- a/MdePkg/Include/IndustryStandard/Cxl.h > +++ b/MdePkg/Include/IndustryStandard/Cxl.h > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #ifndef _CXL_MAIN_H_ > #define _CXL_MAIN_H_ >=20 > -#include > +#include > // > // CXL assigned new Vendor ID > // > diff --git a/MdePkg/Include/IndustryStandard/Cxl20.h > b/MdePkg/Include/IndustryStandard/Cxl20.h > new file mode 100644 > index 0000000000..a5fe22b4a2 > --- /dev/null > +++ b/MdePkg/Include/IndustryStandard/Cxl20.h > @@ -0,0 +1,465 @@ > +/** @file > + CXL 2.0 Register definitions > + > + This file contains the register definitions based on the Compute > Express Link > + (CXL) Specification Revision 2.0. > + > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > +#ifndef CXL20_H_ > +#define CXL20_H_ > + > +#include > + > +// > +// CXL DVSEC IDs > +// Compute Express Link Specification Revision 2.0 - Chapter 8.1.1 > +// > +#define CXL_DVSEC_ID_PCIE_DVSEC_FOR_CXL_DEVICE 0x0 > +#define CXL_DVSEC_ID_NON_CXL_FUNCTION_MAP 0x2 > +#define CXL_DVSEC_ID_CXL20_EXTENSIONS_DVSEC_FOR_PORTS 0x3 > +#define CXL_DVSEC_ID_GPF_DVSEC_FOR_CXL_PORTS 0x4 > +#define CXL_DVSEC_ID_GPF_DVSEC_FOR_CXL_DEVICES 0x5 > +#define CXL_DVSEC_ID_PCIE_DVSEC_FOR_FLEX_BUS_PORT 0x7 > +#define CXL_DVSEC_ID_REGISTER_LOCATOR 0x8 > +#define CXL_DVSEC_ID_MLD 0x9 > +#define CXL_DVSEC_ID_PCIE_DVSEC_FOR_TEST_CAPABILITY 0xA > + > +// > +// Register Block ID > +// Compute Express Link Specification Revision 2.0 - Chapter 8.1.9.1 > +// > +#define CXL_REGISTER_BLOCK_ID_EMPTY 0x0 > +#define CXL_REGISTER_BLOCK_ID_COMPONENT 0x1 > +#define CXL_REGISTER_BLOCK_ID_BAR_VIRTUALIZATION_ACL 0x2 > +#define CXL_REGISTER_BLOCK_ID_DEVICE 0x3 > + > +// > +// CXL component register layout > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.4 > +// > +//|------------------------------------| > +//|--------- Range & Type -------------| > +//|------------------------------------| IO Base - 0KB > +//| (0KB - 4KB)IO Regs | > +//|------------------------------------| Cache and Mem Base - 4KB > +//| {4KB - 8KB)Cache & Mem Regs | > +//|------------------------------------| Implementation Spec Regs Base - > 8KB > +//| (8KB - 56KB)Implement Spec Regs| > +//|------------------------------------| ARB/Mux Regs Base - 56KB > +//| (56KB - 57KB)ARBMUX Regs | > +//|------------------------------------| Reserved Base - 57KB > +//| (57KB - 63KB)Reserved | > +//|------------------------------------| End 64KB > +// > +// Component Register Block Register Ranges Offset > +// > +#define CXL_COMPONENT_REGISTER_RANGE_OFFSET_IO 0x0 > +#define CXL_COMPONENT_REGISTER_RANGE_OFFSET_CACHE_MEM 0x1000 > +#define CXL_COMPONENT_REGISTER_RANGE_OFFSET_ARB_MUX 0xE000 > + > + > +// > +// CXL Cache Memory Capability IDs > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.5 > +// > +#define CXL_CACHE_MEM_CAPABILITY_ID_CXL 0x1 > +#define CXL_CACHE_MEM_CAPABILITY_ID_RAS 0x2 > +#define CXL_CACHE_MEM_CAPABILITY_ID_SECURITY 0x3 > +#define CXL_CACHE_MEM_CAPABILITY_ID_LINK 0x4 > +#define CXL_CACHE_MEM_CAPABILITY_ID_HDM_DECODER 0x5 > +#define CXL_CACHE_MEM_CAPABILITY_ID_EXTENDED_SECURITY 0x6 > +#define CXL_CACHE_MEM_CAPABILITY_ID_IDE 0x7 > +#define CXL_CACHE_MEM_CAPABILITY_ID_SNOOP_FILTER 0x8 > +#define CXL_CACHE_MEM_CAPABILITY_ID_MASK 0xFFFF > + > +// > +// Generic CXL Device Capability IDs 0x0000 ~ 0x3FFF > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.8.2.1 > +// > +#define CXL_DEVICE_CAPABILITY_ID_CAPABILITIES_ARRAY_REGISTER 0x0000 > +#define CXL_DEVICE_CAPABILITY_ID_DEVICE_STATUS 0x0001 > +#define CXL_DEVICE_CAPABILITY_ID_PRIMARY_MAILBOX 0x0002 > +#define CXL_DEVICE_CAPABILITY_ID_SECONDARY_MAILBOX 0x0003 > + > +// > +// Specific CXL Device Capability IDs 0x4000 ~ 0x7FFF > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.8.2.1 > and 8.2.8.5 > + > +// > +#define CXL_DEVICE_CAPABILITY_ID_MEMORY_DEVICE_STATUS 0x4000 > +#define CXL_DEVICE_CAPABILITY_ID_MASK 0xFFFF > + > +// > +// Memory Device Status > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.8.5.1.1 > +// > +#define CXL_MEM_DEVICE_MEDIA_STATUS_NOT_READY 0x0 > +#define CXL_MEM_DEVICE_MEDIA_STATUS_READY 0x1 > +#define CXL_MEM_DEVICE_MEDIA_STATUS_ERROR 0x2 > +#define CXL_MEM_DEVICE_MEDIA_STATUS_DISABLED 0x3 > + > +// > +// Ensure proper structure formats > +// > +#pragma pack(1) > + > +// > +// PCIe DVSEC for CXL Device > +// Compute Express Link Specification Revision 2.0 - Chapter 8.1.3 > +// > +typedef union { > + struct { > + UINT16 CacheCapable : 1; // bit 0 > + UINT16 IoCapable : 1; // bit 1 > + UINT16 MemCapable : 1; // bit 2 > + UINT16 MemHwInitMode : 1; // bit 3 > + UINT16 HdmCount : 2; // bit 4..5 > + UINT16 CacheWriteBackAndInvalidateCapable : 1; // bit 6 > + UINT16 CxlResetCapable : 1; // bit 7 > + UINT16 CxlResetTimeout : 3; // bit 8..10 > + UINT16 CxlResetMemClrCapable : 1; // bit 11 > + UINT16 Reserved : 1; // bit 12 > + UINT16 MultipleLogicalDevice : 1; // bit 13 > + UINT16 ViralCapable : 1; // bit 14 > + UINT16 PmInitCompletionReportingCapable : 1; // bit 15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_CAPABILITY; > + > +typedef union { > + struct { > + UINT16 CacheEnable : 1; // bit 0 > + UINT16 IoEnable : 1; // bit 1 > + UINT16 MemEnable : 1; // bit 2 > + UINT16 CacheSfCoverage : 5; // bit 3..7 > + UINT16 CacheSfGranularity : 3; // bit 8..10 > + UINT16 CacheCleanEviction : 1; // bit 11 > + UINT16 Reserved1 : 2; // bit 12..13 > + UINT16 ViralEnable : 1; // bit 14 > + UINT16 Reserved2 : 1; // bit 15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_CONTROL; > + > +typedef union { > + struct { > + UINT16 Reserved1 : 14; // bit 0..13 > + UINT16 ViralStatus : 1; // bit 14 > + UINT16 Reserved2 : 1; // bit 15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_STATUS; > + > +typedef union { > + struct { > + UINT16 DisableCaching : 1; // bit 0 > + UINT16 InitiateCacheWriteBackAndInvalidate : 1; // bit 1 > + UINT16 InitiateCxlReset : 1; // bit 2 > + UINT16 CxlResetMemClrEnable : 1; // bit 3 > + UINT16 Reserved : 12; // bit 4..15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_CONTROL2; > + > +typedef union { > + struct { > + UINT16 CacheInvalid : 1; // bit 0 > + UINT16 CxlResetComplete : 1; // bit 1 > + UINT16 Reserved : 13; // bit > 2..14 > + UINT16 PowerManagementInitialzationComplete : 1; // bit > 15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_STATUS2; > + > +typedef union { > + struct { > + UINT16 ConfigLock : 1; // bit 0 > + UINT16 Reserved : 15; // bit 1..15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_LOCK; > + > +typedef union { > + struct { > + UINT16 CacheSizeUnit : 4; // bit 0..3 > + UINT16 Reserved : 4; // bit 4..7 > + UINT16 CacheSize : 8; // bit 8..15 > + } Bits; > + UINT16 Uint16; > +} CXL_DVSEC_CXL_DEVICE_CAPABILITY2; > + > +typedef union { > + struct { > + UINT32 MemorySizeHigh : 32; // bit 0..31 > + } Bits; > + UINT32 Uint32; > +} CXL_DVSEC_CXL_DEVICE_RANGE_SIZE_HIGH; > + > +typedef union { > + struct { > + UINT32 MemoryInfoValid : 1; // bit 0 > + UINT32 MemoryActive : 1; // bit 1 > + UINT32 MediaType : 3; // bit 2..4 > + UINT32 MemoryClass : 3; // bit 5..7 > + UINT32 DesiredInterleave : 5; // bit 8..12 > + UINT32 MemoryActiveTimeout : 3; // bit 13..15 > + UINT32 Reserved : 12; // bit 16..27 > + UINT32 MemorySizeLow : 4; // bit 28..31 > + } Bits; > + UINT32 Uint32; > +} CXL_DVSEC_CXL_DEVICE_RANGE_SIZE_LOW; > + > +typedef union { > + struct { > + UINT32 MemoryBaseHigh : 32; // bit 0..31 > + } Bits; > + UINT32 Uint32; > +} CXL_DVSEC_CXL_DEVICE_RANGE_BASE_HIGH; > + > +typedef union { > + struct { > + UINT32 Reserved : 28; // bit 0..27 > + UINT32 MemoryBaseLow : 4; // bit 28..31 > + } Bits; > + UINT32 Uint32; > +} CXL_DVSEC_CXL_DEVICE_RANGE_BASE_LOW; > + > + > +typedef struct { > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header; > // offset 0x00 > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1 DvsecHeader1; > // offset 0x04 > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2 DvsecHeader2; > // offset 0x08 > + CXL_DVSEC_CXL_DEVICE_CAPABILITY DeviceCapability; > // offset 0x0A > + CXL_DVSEC_CXL_DEVICE_CONTROL DeviceControl; > // offset 0x0C > + CXL_DVSEC_CXL_DEVICE_STATUS DeviceStatus; > // offset 0x0E > + CXL_DVSEC_CXL_DEVICE_CONTROL2 DeviceControl2; > // offset 0x10 > + CXL_DVSEC_CXL_DEVICE_STATUS2 DeviceStatus2; > // offset 0x12 > + CXL_DVSEC_CXL_DEVICE_LOCK DeviceLock; > // offset 0x14 > + CXL_DVSEC_CXL_DEVICE_CAPABILITY2 DeviceCapability2; > // offset 0x16 > + CXL_DVSEC_CXL_DEVICE_RANGE_SIZE_HIGH > DeviceRange1SizeHigh; // offset 0x18 > + CXL_DVSEC_CXL_DEVICE_RANGE_SIZE_LOW > DeviceRange1SizeLow; // offset 0x1C > + CXL_DVSEC_CXL_DEVICE_RANGE_BASE_HIGH > DeviceRange1BaseHigh; // offset 0x20 > + CXL_DVSEC_CXL_DEVICE_RANGE_BASE_LOW > DeviceRange1BaseLow; // offset 0x24 > + CXL_DVSEC_CXL_DEVICE_RANGE_SIZE_HIGH > DeviceRange2SizeHigh; // offset 0x28 > + CXL_DVSEC_CXL_DEVICE_RANGE_SIZE_LOW > DeviceRange2SizeLow; // offset 0x2C > + CXL_DVSEC_CXL_DEVICE_RANGE_BASE_HIGH > DeviceRange2BaseHigh; // offset 0x30 > + CXL_DVSEC_CXL_DEVICE_RANGE_BASE_LOW > DeviceRange2BaseLow; // offset 0x34 > +} CXL_DVSEC_CXL_DEVICE; > + > +#define CXL_DVSEC_CXL_DEVICE_REVISION_1 0x1 > + > +// > +// Register Locator DVSEC > +// Compute Express Link Specification Revision 2.0 - Chapter 8.1.9 > +// > + > +typedef union { > + struct { > + UINT32 RegisterBir : 3; // bit 0..2 > + UINT32 Reserved : 5; // bit 3..7 > + UINT32 RegisterBlockIdentifier : 8; // bit 8..15 > + UINT32 RegisterBlockOffsetLow : 16; // bit 16..31 > + } Bits; > + UINT32 Uint32; > +} CXL_DVSEC_REGISTER_LOCATOR_REGISTER_OFFSET_LOW; > + > +typedef union { > + struct { > + UINT32 RegisterBlockOffsetHigh : 32; // bit 0..31 > + } Bits; > + UINT32 Uint32; > +} CXL_DVSEC_REGISTER_LOCATOR_REGISTER_OFFSET_HIGH; > + > +typedef struct { > + CXL_DVSEC_REGISTER_LOCATOR_REGISTER_OFFSET_LOW OffsetLow; > + CXL_DVSEC_REGISTER_LOCATOR_REGISTER_OFFSET_HIGH OffsetHigh; > +} CXL_DVSEC_REGISTER_LOCATOR_REGISTER_BLOCK; > + > +typedef struct { > + PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER Header; > // offset 0x00 > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_1 DvsecHeader1; > // offset 0x04 > + PCI_EXPRESS_DESIGNATED_VENDOR_SPECIFIC_HEADER_2 DvsecHeader2; > // offset 0x08 > + UINT16 Reserved; > // offset 0x0A > + CXL_DVSEC_REGISTER_LOCATOR_REGISTER_BLOCK > RegisterBlock[1]; // offset 0x0C > + > +} CXL_DVSEC_REGISTER_LOCATOR; > + > +#define CXL_DVSEC_REGISTER_LOCATOR_REVISION_0 0x0 > + > +// > +// CXL HDM Decoder Capability Header Register > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.5.5 > +// > +typedef union { > + struct { > + UINT32 CxlCapabilityId : 16; // bit 0..15 > + UINT32 CxlCapabilityVersion : 4; // bit 16..19 > + UINT32 CxlHdmDecoderCapabilityPointer : 12; // bit 20..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_CAPABILITY_HEADER_REGISTER; > + > +// > +// CXL HDM Decoder Capability Register > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.5.12 > +// > +typedef union { > + struct { > + UINT32 DecoderCount : 4; // bit 0..3 > + UINT32 TargetCount : 4; // bit 4..7 > + UINT32 InterleaveCapableA11to8 : 1; // bit 8 > + UINT32 InterleaveCapableA14to12 : 1; // bit 9 > + UINT32 PoisonOnDecodeErrorCapability : 1; // bit 10 > + UINT32 Reserved : 21; // bit 11..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_CAPABILITY_REGISTER; > + > +typedef union { > + struct { > + UINT32 PoisonOnDecodeErrorEnable : 1; // bit 0 > + UINT32 HdmDecoderEnable : 1; // bit 1 > + UINT32 Reserved : 30; // bit 2..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_GLOBAL_CONTROL_REGISTER; > + > +typedef union { > + struct { > + UINT32 Reserved : 28; // bit 0..27 > + UINT32 MemoryBaseLow : 4; // bit 28..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_BASE_LOW_REGISTER; > + > +typedef union { > + struct { > + UINT32 MemoryBaseHigh : 32; // bit 0..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_BASE_HIGH_REGISTER; > + > +typedef union { > + struct { > + UINT32 Reserved : 28; // bit 0..27 > + UINT32 MemorySizeLow : 4; // bit 28..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_SIZE_LOW_REGISTER; > + > +typedef union { > + struct { > + UINT32 MemorySizeHigh : 32; // bit 0..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_SIZE_HIGH_REGISTER; > + > +typedef union { > + struct { > + UINT32 InterleaveGranularity : 4; // bit 0..3 > + UINT32 InterleaveWays : 4; // bit 4..7 > + UINT32 LockOnCommit : 1; // bit 8 > + UINT32 Commit : 1; // bit 9 > + UINT32 Committed : 1; // bit 10 > + UINT32 ErrorNotCommitted : 1; // bit 11 > + UINT32 TargetDeviceType : 1; // bit 12 > + UINT32 Reserved : 19; // bit 13..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_CONTROL_REGISTER; > + > +typedef union { > + struct { > + UINT32 TargetPortIdentiferWay0 : 8; // bit 0..7 > + UINT32 TargetPortIdentiferWay1 : 8; // bit 8..15 > + UINT32 TargetPortIdentiferWay2 : 8; // bit 16..23 > + UINT32 TargetPortIdentiferWay3 : 8; // bit 24..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_TARGET_LIST_LOW_REGISTER; > + > +typedef union { > + struct { > + UINT32 Reserved : 28; // bit 0..27 > + UINT32 DpaSkipLow : 4; // bit 28..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_DPA_SKIP_LOW_REGISTER; > + > +typedef union { > + struct { > + UINT32 TargetPortIdentiferWay4 : 8; // bit 0..7 > + UINT32 TargetPortIdentiferWay5 : 8; // bit 8..15 > + UINT32 TargetPortIdentiferWay6 : 8; // bit 16..23 > + UINT32 TargetPortIdentiferWay7 : 8; // bit 24..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_TARGET_LIST_HIGH_REGISTER; > + > +typedef union { > + struct { > + UINT32 DpaSkipHigh : 32; // bit 0..31 > + } Bits; > + UINT32 Uint32; > +} CXL_HDM_DECODER_DPA_SKIP_HIGH_REGISTER; > + > +typedef union { > + CXL_HDM_DECODER_TARGET_LIST_LOW_REGISTER TargetListLow; > + CXL_HDM_DECODER_DPA_SKIP_LOW_REGISTER DpaSkipLow; > +} CXL_HDM_DECODER_TARGET_LIST_OR_DPA_SKIP_LOW; > + > +typedef union { > + CXL_HDM_DECODER_TARGET_LIST_HIGH_REGISTER TargetListHigh; > + CXL_HDM_DECODER_DPA_SKIP_HIGH_REGISTER DpaSkipHigh; > +} CXL_HDM_DECODER_TARGET_LIST_OR_DPA_SKIP_HIGH; > + > +typedef struct { > + CXL_HDM_DECODER_BASE_LOW_REGISTER DecoderBaseLow; > // 0x10 > + CXL_HDM_DECODER_BASE_HIGH_REGISTER DecoderBaseHigh; > // 0x14 > + CXL_HDM_DECODER_SIZE_LOW_REGISTER DecoderSizeLow; > // 0x18 > + CXL_HDM_DECODER_SIZE_HIGH_REGISTER DecoderSizeHigh; > // 0x1c > + CXL_HDM_DECODER_CONTROL_REGISTER DecoderControl; > // 0x20 > + CXL_HDM_DECODER_TARGET_LIST_OR_DPA_SKIP_LOW > DecoderTargetListDpaSkipLow; // 0x24 > + CXL_HDM_DECODER_TARGET_LIST_OR_DPA_SKIP_HIGH > DecoderTargetListDpaSkipHigh; // 0x28 > + UINT32 Reserved; > // 0x2C > +} CXL_HDM_DECODER; > + > +// > +// CXL Device Capabilities Array Register > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.8.1 > +// > + > +typedef union { > + struct { > + UINT64 CxlDeviceCapabilityId : 16; // bit 0..15 > + UINT64 CxlDeviceCapabilityVersion : 8; // bit 16..23 > + UINT64 Reserved1 : 8; // bit 24..31 > + UINT64 CxlDeviceCapabilitiesCount : 16; // bit 32..47 > + UINT64 Reserved2 : 16; // bit 48..63 > + } Bits; > + UINT64 Uint64; > +} CXL_DEVICE_CAPABILITIES_ARRAY_REGISTER; > + > +// > +// CXL Memory Status Register > +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.8.5 > +// > +typedef union { > + struct { > + UINT64 DeviceFatal : 1; // bit 0 > + UINT64 FwHalt : 1; // bit 1 > + UINT64 MediaStatus : 2; // bit 2..3 > + UINT64 MailboxInterfacesReady : 1; // bit 4 > + UINT64 ResetNeeded : 3; // bit 5..7 > + UINT64 Reserved : 56; // bit 8..63 > + } Bits; > + UINT64 Uint64; > +} CXL_MEMORY_DEVICE_STATUS_REGISTER; > + > +#pragma pack() > + > +#endif > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107852): https://edk2.groups.io/g/devel/message/107852 Mute This Topic: https://groups.io/mt/100817312/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-