public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"rebecca@bsdio.com" <rebecca@bsdio.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	"pedro.falcato@gmail.com" <pedro.falcato@gmail.com>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	Oliver Smith-Denny <osd@smith-denny.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	Andrew Fish <afish@apple.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Date: Tue, 4 Apr 2023 17:45:48 +0000	[thread overview]
Message-ID: <CO1PR11MB4929FA9ED967BCDECBE8017FD2939@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <61cc40d6-c2b2-5c56-aa3d-f06a4ee11cd3@bsdio.com>

Changing the toolchain tag name from GCC5 to GCC will break 
EDK II CI and likely 100's of downstream developer/CI scripts.

Can we keep GCC5 and add GCC that is identical to GCC5?

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Tuesday, April 4, 2023 10:01 AM
> To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.groups.io; pedro.falcato@gmail.com
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Oliver Smith-Denny <osd@smith-denny.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Feng, Bob C <bob.c.feng@intel.com>; Andrew Fish <afish@apple.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete
> CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
> 
> 
> On 4/4/23 10:32 AM, Leif Lindholm wrote:
> > On Tue, Apr 04, 2023 at 16:57:18 +0100, Pedro Falcato wrote:
> >> On Tue, Apr 4, 2023 at 4:49 PM Rebecca Cran <rebecca@bsdio.com> wrote:
> >>> Okay. I'll rework the patch series to only delete GCC48 and keep GCC49
> >>> and GCC5.
> >> Please rename them? There's no point in keeping their current names
> >> anyway. I guarantee you that most people are not really able to guess
> >> GCC49 to be the "non-LTO" flavor.
> >>
> >> And IMO Ard has already proved the value in non-LTO builds anyway, so
> >> yeah. GCC and GCCNOLTO please.
> > Agreed. I don't think there are any outstanding items that need
> > resolving.
> >
> > I'd be very happy to stop hearing "you need GCC 5 in order to build
> > edk2" misunderstandings.
> 
> Thanks! As a new co-maintainer I was trying to be diplomatic, but I
> really don't see any reason to keep the existing names.
> 
> I'll send out a v3 patch series with all the fixes I and others have
> identified.
> 
> 
> --
> Rebecca Cran
> 
> 
> 
> 
> 


  reply	other threads:[~2023-04-04 17:45 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 17:30 [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC Rebecca Cran
2023-03-28 17:30 ` [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call Rebecca Cran
2023-03-28 22:40   ` Yao, Jiewen
2023-03-28 22:45     ` Michael D Kinney
2023-03-28 17:31 ` [PATCH v2 02/13] CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler flags Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 03/13] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 Rebecca Cran
2023-03-29  3:46   ` [edk2-devel] " Guo, Gua
     [not found]   ` <1750C725F99FA0C2.29160@groups.io>
2023-03-29  9:24     ` Guo, Gua
2023-03-28 17:31 ` [PATCH v2 04/13] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 05/13] BaseTools: Remove VS2008-VS2013 remnants Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 06/13] MdePkg: " Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 07/13] edksetup.bat: " Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 08/13] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 09/13] BaseTools: Remove EBC (EFI Byte Code) compiler definitions Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 10/13] OvmfPkg: Use Xcode5 version of CpuExceptionHandlerLib for CLANGDWARF Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 11/13] Delete GCC48 and GCC49 toolchains and rename GCC5 to GCC Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 12/13] BaseTools: Remove unused CYGWIN_ defines from tools_def.txt.template Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 13/13] Bump tools_def.txt VERSION to 3.0 Rebecca Cran
2023-03-28 17:57 ` [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC Ard Biesheuvel
2023-03-28 18:01   ` Rebecca Cran
2023-03-28 18:12     ` [edk2-devel] " Ard Biesheuvel
2023-03-29 10:21       ` Rebecca Cran
2023-03-29 10:30         ` Ard Biesheuvel
2023-03-29  1:19 ` 回复: " gaoliming
2023-03-29  7:39   ` Ard Biesheuvel
2023-03-29 10:20     ` Rebecca Cran
2023-03-29 11:28     ` Leif Lindholm
2023-03-29 11:53       ` Ard Biesheuvel
2023-04-02 15:41   ` 回复: " Rebecca Cran
2023-04-02 16:36     ` Ard Biesheuvel
2023-04-02 16:42       ` Michael D Kinney
2023-04-02 18:38     ` Pedro Falcato
2023-04-02 21:50       ` Rebecca Cran
2023-04-03 11:30         ` Gerd Hoffmann
2023-04-03 11:33           ` Rebecca Cran
2023-04-03 11:39             ` Gerd Hoffmann
2023-04-03 11:55               ` Ard Biesheuvel
2023-04-03 12:15                 ` Leif Lindholm
2023-04-03 12:26                   ` Rebecca Cran
2023-04-03 13:44                     ` Pedro Falcato
2023-04-03 13:54                       ` Rebecca Cran
2023-04-03 14:08                     ` Gerd Hoffmann
2023-04-03 14:27                       ` Rebecca Cran
2023-04-03 19:42                         ` Michael D Kinney
2023-04-03 19:54                           ` Rebecca Cran
2023-04-03 20:23                             ` Michael D Kinney
2023-04-03 13:04                   ` Ard Biesheuvel
2023-04-03 13:27                     ` Michael D Kinney
2023-04-03 13:43                       ` Ard Biesheuvel
2023-04-04  1:31         ` 回复: " gaoliming
2023-04-04 15:49           ` Rebecca Cran
2023-04-04 15:57             ` Pedro Falcato
2023-04-04 16:32               ` Leif Lindholm
2023-04-04 17:00                 ` Rebecca Cran
2023-04-04 17:45                   ` Michael D Kinney [this message]
2023-04-04 17:48                     ` Rebecca Cran
2023-04-04 17:52                       ` Michael D Kinney
2023-04-04 17:57                         ` Pedro Falcato
2023-04-04 18:03                           ` Rebecca Cran
2023-04-04 18:26                             ` Ard Biesheuvel
2023-04-04 18:29                             ` Michael D Kinney
2023-04-04 18:36                               ` Rebecca Cran
2023-04-05 10:21                                 ` Ard Biesheuvel
2023-04-06  0:57                                   ` 回复: " gaoliming
2023-04-06  2:49                                     ` Rebecca Cran
2023-04-06  7:32                                       ` Ard Biesheuvel
2023-04-06  9:19                               ` Marcin Juszkiewicz
2023-03-29 12:20 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929FA9ED967BCDECBE8017FD2939@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox