Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, March 6, 2024 1:09 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Joey Vagedes
> <joey.vagedes@gmail.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Sean Brogan <sean.brogan@microsoft.com>; Chen,
> Christine <yuwei.chen@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt:
> require edk2-basetools version 0.1.51
> 
> Can I please get a quick R-b for this patch -- it's urgent because of
> <https://edk2.groups.io/g/devel/message/116453>.
> 
> Thank you,
> Laszlo
> 
> On 3/5/24 12:38, Laszlo Ersek wrote:
> > The edk2-basetools commit that corresponds to edk2 commit
> bac9c74080cf
> > ("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
> > modules", 2024-02-29) is 5b7161de22ee ("BaseTools/AutoGen: declare
> > ProcessLibraryConstructorList() for SEC modules", 2024-03-04); it is
> part
> > of tag v0.1.51.
> >
> > Subsequent patches in this series put that feature to use. Require
> release
> > 0.1.51 of edk2-basetools in "pip-requirements.txt", so that the next
> > patches work with in-tree and out-of-tree (e.g., CI) BaseTools.
> >
> > Furthermore, require version 0.20.0 of edk2-pytool-library. This is a
> > dependency of edk2-basetools v0.1.50 (commit 08e5bbe755d2, "Add
> > pyproject.toml and fix setup.py deprecation warnings", 2024-02-13)
> and
> > v0.1.51 too (commit f3e15d654479, "Add pyproject.toml and fix
> setup.py
> > deprecation warnings", 2024-02-16).
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Joey Vagedes <joey.vagedes@gmail.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >  pip-requirements.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/pip-requirements.txt b/pip-requirements.txt
> > index 6420078822b5..2f4cd33cc620 100644
> > --- a/pip-requirements.txt
> > +++ b/pip-requirements.txt
> > @@ -12,9 +12,9 @@
> >  # https://www.python.org/dev/peps/pep-0440/#version-specifiers
> >  ##
> >
> > -edk2-pytool-library==0.19.9
> > +edk2-pytool-library==0.20.0
> >  edk2-pytool-extensions==0.26.4
> > -edk2-basetools==0.1.48
> > +edk2-basetools==0.1.51
> >  antlr4-python3-runtime==4.7.1
> >  lcov-cobertura==2.0.2
> >  regex==2023.12.25
> >
> >
> >
> > 
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116461): https://edk2.groups.io/g/devel/message/116461
Mute This Topic: https://groups.io/mt/104742519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-