* [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO [not found] <cover.1703568086.git.suqiangx.ren@intel.com> @ 2023-12-26 5:22 ` Ren, Suqiang [not found] ` <17A44A35342BC710.18684@groups.io> 1 sibling, 0 replies; 5+ messages in thread From: Ren, Suqiang @ 2023-12-26 5:22 UTC (permalink / raw) To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu Add the description of FileName to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 13.5.16 Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> --- MdePkg/Include/Guid/FileInfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/FileInfo.h b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8 100644 --- a/MdePkg/Include/Guid/FileInfo.h +++ b/MdePkg/Include/Guid/FileInfo.h @@ -46,7 +46,7 @@ typedef struct { /// UINT64 Attribute; /// - /// The Null-terminated name of the file. + /// The Null-terminated name of the file. For a root directory, the name is an empty string. /// CHAR16 FileName[1]; } EFI_FILE_INFO; -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112906): https://edk2.groups.io/g/devel/message/112906 Mute This Topic: https://groups.io/mt/103366883/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <17A44A35342BC710.18684@groups.io>]
* Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO [not found] ` <17A44A35342BC710.18684@groups.io> @ 2024-01-11 9:03 ` Ren, Suqiang 2024-01-19 9:28 ` Ren, Suqiang 2024-01-23 1:09 ` Michael D Kinney 0 siblings, 2 replies; 5+ messages in thread From: Ren, Suqiang @ 2024-01-11 9:03 UTC (permalink / raw) To: devel@edk2.groups.io; +Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang Hi All, Any comments about this patch? Thanks Ren, Suqiang -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, Suqiang Sent: Tuesday, December 26, 2023 1:22 PM To: devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> Subject: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO Add the description of FileName to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 13.5.16 Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> --- MdePkg/Include/Guid/FileInfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/FileInfo.h b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8 100644 --- a/MdePkg/Include/Guid/FileInfo.h +++ b/MdePkg/Include/Guid/FileInfo.h @@ -46,7 +46,7 @@ typedef struct { /// UINT64 Attribute; /// - /// The Null-terminated name of the file. + /// The Null-terminated name of the file. For a root directory, the name is an empty string. /// CHAR16 FileName[1]; } EFI_FILE_INFO; -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113602): https://edk2.groups.io/g/devel/message/113602 Mute This Topic: https://groups.io/mt/103366883/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO 2024-01-11 9:03 ` Ren, Suqiang @ 2024-01-19 9:28 ` Ren, Suqiang 2024-01-23 1:09 ` Michael D Kinney 1 sibling, 0 replies; 5+ messages in thread From: Ren, Suqiang @ 2024-01-19 9:28 UTC (permalink / raw) To: devel@edk2.groups.io; +Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang Hi All, Any comments about this patch? Thanks Ren, Suqiang -----Original Message----- From: Ren, SuqiangX Sent: Thursday, January 11, 2024 5:04 PM To: devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <Zhiguang.Liu@intel.com> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO Hi All, Any comments about this patch? Thanks Ren, Suqiang -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, Suqiang Sent: Tuesday, December 26, 2023 1:22 PM To: devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> Subject: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO Add the description of FileName to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 13.5.16 Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> --- MdePkg/Include/Guid/FileInfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/FileInfo.h b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8 100644 --- a/MdePkg/Include/Guid/FileInfo.h +++ b/MdePkg/Include/Guid/FileInfo.h @@ -46,7 +46,7 @@ typedef struct { /// UINT64 Attribute; /// - /// The Null-terminated name of the file. + /// The Null-terminated name of the file. For a root directory, the name is an empty string. /// CHAR16 FileName[1]; } EFI_FILE_INFO; -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114031): https://edk2.groups.io/g/devel/message/114031 Mute This Topic: https://groups.io/mt/103366883/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO 2024-01-11 9:03 ` Ren, Suqiang 2024-01-19 9:28 ` Ren, Suqiang @ 2024-01-23 1:09 ` Michael D Kinney 2024-01-23 7:12 ` Ren, Suqiang 1 sibling, 1 reply; 5+ messages in thread From: Michael D Kinney @ 2024-01-23 1:09 UTC (permalink / raw) To: Ren, SuqiangX, devel@edk2.groups.io Cc: Gao, Liming, Liu, Zhiguang, Kinney, Michael D Hi Suqiang, The comment line added look like is exceeds 80 columns. Please reformat. Also, there are implementations of this service in the edk2 repo. Please update those with this same function header update. Thanks, Mike > -----Original Message----- > From: Ren, SuqiangX <suqiangx.ren@intel.com> > Sent: Thursday, January 11, 2024 1:04 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> > Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition > of FileName on EFI_FILE_INFO > > Hi All, > > Any comments about this patch? > > Thanks > Ren, Suqiang > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, > Suqiang > Sent: Tuesday, December 26, 2023 1:22 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> > Subject: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of > FileName on EFI_FILE_INFO > > Add the description of FileName to align with UEFI spec 2.10. > > REF: UEFI spec 2.10 Table 13.5.16 > > Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > --- > MdePkg/Include/Guid/FileInfo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Guid/FileInfo.h > b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8 100644 > --- a/MdePkg/Include/Guid/FileInfo.h > +++ b/MdePkg/Include/Guid/FileInfo.h > @@ -46,7 +46,7 @@ typedef struct { > /// > UINT64 Attribute; > /// > - /// The Null-terminated name of the file. > + /// The Null-terminated name of the file. For a root directory, the > name is an empty string. > /// > CHAR16 FileName[1]; > } EFI_FILE_INFO; > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114159): https://edk2.groups.io/g/devel/message/114159 Mute This Topic: https://groups.io/mt/103366883/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO 2024-01-23 1:09 ` Michael D Kinney @ 2024-01-23 7:12 ` Ren, Suqiang 0 siblings, 0 replies; 5+ messages in thread From: Ren, Suqiang @ 2024-01-23 7:12 UTC (permalink / raw) To: Kinney, Michael D, devel@edk2.groups.io; +Cc: Gao, Liming, Liu, Zhiguang Hi Mike, Thanks for reviewing. Patch updated here: https://edk2.groups.io/g/devel/message/114182. From my check this change need not update with the same function header. Can you help to review again? Thanks Ren, Suqiang -----Original Message----- From: Kinney, Michael D <michael.d.kinney@intel.com> Sent: Tuesday, January 23, 2024 9:10 AM To: Ren, SuqiangX <suqiangx.ren@intel.com>; devel@edk2.groups.io Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO Hi Suqiang, The comment line added look like is exceeds 80 columns. Please reformat. Also, there are implementations of this service in the edk2 repo. Please update those with this same function header update. Thanks, Mike > -----Original Message----- > From: Ren, SuqiangX <suqiangx.ren@intel.com> > Sent: Thursday, January 11, 2024 1:04 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> > Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition > of FileName on EFI_FILE_INFO > > Hi All, > > Any comments about this patch? > > Thanks > Ren, Suqiang > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, > Suqiang > Sent: Tuesday, December 26, 2023 1:22 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com> > Subject: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of > FileName on EFI_FILE_INFO > > Add the description of FileName to align with UEFI spec 2.10. > > REF: UEFI spec 2.10 Table 13.5.16 > > Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > --- > MdePkg/Include/Guid/FileInfo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Guid/FileInfo.h > b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8 > 100644 > --- a/MdePkg/Include/Guid/FileInfo.h > +++ b/MdePkg/Include/Guid/FileInfo.h > @@ -46,7 +46,7 @@ typedef struct { > /// > UINT64 Attribute; > /// > - /// The Null-terminated name of the file. > + /// The Null-terminated name of the file. For a root directory, the > name is an empty string. > /// > CHAR16 FileName[1]; > } EFI_FILE_INFO; > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114183): https://edk2.groups.io/g/devel/message/114183 Mute This Topic: https://groups.io/mt/103366883/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-23 7:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1703568086.git.suqiangx.ren@intel.com>
2023-12-26 5:22 ` [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO Ren, Suqiang
[not found] ` <17A44A35342BC710.18684@groups.io>
2024-01-11 9:03 ` Ren, Suqiang
2024-01-19 9:28 ` Ren, Suqiang
2024-01-23 1:09 ` Michael D Kinney
2024-01-23 7:12 ` Ren, Suqiang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox