public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch] pip-requirements.txt: Update basetools version to 0.1.24
Date: Wed, 29 Jun 2022 15:54:23 +0000	[thread overview]
Message-ID: <CO1PR11MB4929FFE0007D1B9409C6586BD2BB9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <186d84ef-a718-2761-4cc4-0f9a1949c3a2@linux.microsoft.com>

Hi Bob,

Can you please add a summary of the BaseTools bugs/features addressed
in the upgrade from 0.1.17 to 0.1.24 to the commit message.

With that update: 

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Wednesday, June 29, 2022 8:23 AM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Subject: Re: [edk2-devel] [Patch] pip-requirements.txt: Update basetools version to 0.1.24
> 
> Acked-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> On 6/29/2022 3:55 AM, Bob Feng wrote:
> > Synced the basetools patch from edk2 repo to
> > edk2-basetools repo.
> >
> > edk2 sha-1: 59141288716f8917968d4bb96367b7d08fe5ab8a
> >
> > Update the basetools pip module version
> > to the latest 0.1.24.
> >
> > Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> > ---
> >   pip-requirements.txt | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pip-requirements.txt b/pip-requirements.txt
> > index 6585df201d..29424b08bd 100644
> > --- a/pip-requirements.txt
> > +++ b/pip-requirements.txt
> > @@ -12,7 +12,7 @@
> >   # https://www.python.org/dev/peps/pep-0440/#version-specifiers
> >
> >   ##
> >
> >
> >
> >   edk2-pytool-library==0.11.2
> >
> >   edk2-pytool-extensions~=0.16.0
> >
> > -edk2-basetools==0.1.17
> >
> > +edk2-basetools==0.1.24
> >
> >   antlr4-python3-runtime==4.7.1
> >
> 
> 
> 
> 


      reply	other threads:[~2022-06-29 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29  7:55 [Patch] pip-requirements.txt: Update basetools version to 0.1.24 Bob Feng
2022-06-29 15:23 ` [edk2-devel] " Michael Kubacki
2022-06-29 15:54   ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929FFE0007D1B9409C6586BD2BB9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox