From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kingsumos@gmail.com" <kingsumos@gmail.com>,
"Dong, Guo" <guo.dong@intel.com>
Cc: "Liu, Zhiguang" <zhiguang.liu@intel.com>, "Tan, Dun" <dun.tan@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV
Date: Tue, 24 Aug 2021 11:44:53 +0000 [thread overview]
Message-ID: <CO1PR11MB4930095DDACD07DE54663CA88CC59@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAGfcU4Rcy9y2P_ON6-CGUN1on_S2j2F+NC6TeYd5wc1u4fotjw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3399 bytes --]
It seems like the coreboot cannot support FV that contains GUID in its header.
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of King Sumo
Sent: Tuesday, August 24, 2021 1:02 AM
To: devel@edk2.groups.io; Dong, Guo <guo.dong@intel.com>
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV
Hi All,
This patch broke the coreboot payload loading. Tested with:
build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT
Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:
"Not a usable UEFI firmware volume"
Trying to boot coreboot results in an exception and the following error message:
"Payload not loaded"
Probably it broke the interface.
commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>
Date: Wed Jul 14 14:24:45 2021 +0800
UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>
Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>>
Kind regards,
Sumo
On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote:
Signed-off-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>>
> -----Original Message-----
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>
> ---
> UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
> [FV.PLDFV]
>
> +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
> BlockSize = $(FD_BLOCK_SIZE)
>
> FvAlignment = 16
>
> ERASE_POLARITY = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
> [FV.DXEFV]
>
> +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23
>
> BlockSize = $(FD_BLOCK_SIZE)
>
> FvForceRebase = FALSE
>
> FvAlignment = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner@edk2.groups.io<mailto:devel%2Bowner@edk2.groups.io>
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com<mailto:guo.dong@intel.com>]
> -=-=-=-=-=-=
>
[-- Attachment #2: Type: text/html, Size: 8250 bytes --]
next prev parent reply other threads:[~2021-08-24 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 6:24 [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Zhiguang Liu
2021-07-14 7:35 ` [edk2-devel] " Ni, Ray
2021-07-14 16:08 ` Guo Dong
2021-08-23 17:01 ` King Sumo
2021-08-24 11:44 ` Ni, Ray [this message]
2021-08-24 16:55 ` King Sumo
2021-08-24 18:53 ` Guo Dong
2021-08-25 0:28 ` Ni, Ray
2021-09-01 6:56 ` duntan
[not found] <16919434E257EB22.1732@groups.io>
2021-07-14 6:48 ` Zhiguang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930095DDACD07DE54663CA88CC59@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox