From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot
Date: Wed, 10 Mar 2021 09:55:59 +0000 [thread overview]
Message-ID: <CO1PR11MB49301000A0784AC4E766825B8C919@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210310082014.700-1-zhiguang.liu@intel.com>
1. DataSIze should be set to sizeof (BOOLEAN) before calling GetVariable()
> + Status = gRT->GetVariable (
> + L"IsFirstBoot",
2. Can you please define a macro in this C file for IsFirstBoot string?
e.g.: #define IS_FIRST_BOOT_VAR_NAME L"IsFirstBoot"
> + if (IsFirstBoot == TRUE) {
3. Please remove "== TRUE". Just use "If (IsFirstBoot)".
> + L"IsFirstBoot",
4. Please use the macro defined as above.
>
> + &gEfiCallerIdGuid,
>
> + EFI_VARIABLE_NON_VOLATILE |
> EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS,
5. Please remove "EFI_VARIABLE_RUNTIME_ACCESS".
> + 1,
6. Please use sizeof (BOOLEAN) instead of "1".
next prev parent reply other threads:[~2021-03-10 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 8:20 [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot Zhiguang Liu
2021-03-10 9:55 ` Ni, Ray [this message]
2021-03-15 1:36 ` 回复: " gaoliming
2021-03-16 1:56 ` [edk2-devel] " Zhiguang Liu
2021-03-17 3:00 ` 回复: " gaoliming
2021-03-17 4:04 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49301000A0784AC4E766825B8C919@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox