From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.6798.1615370205330031180 for ; Wed, 10 Mar 2021 01:56:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=naUdtbOC; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) IronPort-SDR: N8ZVsL0KHV/Hx6X4+6X3IcQZPwnKgvJMmk0E9cceznMfLiDbOaXkwukx1FNJzCSu4t8aQuY3Xx +rYyEfWCrkhw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="188469993" X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="188469993" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 01:56:08 -0800 IronPort-SDR: g7dTQYLKwhQ/kpvRS5Thua6VZ5XcoTDEwUwxe8ZlEXQysxTv2OA2ugi9J1GzIBLoXi+PqHSGga 1EH/CwYCzj8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,237,1610438400"; d="scan'208";a="431151175" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2021 01:56:08 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 10 Mar 2021 01:56:07 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 10 Mar 2021 01:56:07 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 10 Mar 2021 01:56:07 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 10 Mar 2021 01:56:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8Zn6ZSYEs0Oq4nr5i+tmY/SJniGs+Q2pJ7bAZQa7sEyqOXhSJZfNcl2AIreHNcpPk7ChUIah609RrvOE73xUgMnOe8fHcpM2U+J2j3kq2ytJvkGfUKTFoX9CUX4GjDI8evScv5DadbVW3F/+BDcTlL6DorncnFOZCHXoHo8KNV8D/FPZbSWNkmJCFzX/HgjAA0Jwj2tm+H/wQc0MXJ6ZA3l3dK66IIEpY5WGah6KlOFmZRi8Ox/HJHY3aQZ8GW4C7306NyupyPm6HML2FzGjpwX90PojwVpbWOEEAft9vB4i11aXh+zK6aDtmGnZgshiYuPtxXwSKjqvi1Wc95YWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BJXTXMgZfoQTisWnrE+dF0tjh2c36zeNgHII+lr4PEQ=; b=UnZvM0f7+INfUH3q0wkbKn8y3ybPfzNmzBavMJivXyhgENIDhKOByBF1/HCvYQXHdXl+t34iXG2fF9ni52uj00wScXzb+iJEpst/DAuPpLDh6tzaE4UtS/Xqlff+K/vnIF02E4z+vbN9sTfttv3jWXfdmrGL54Tlu9ZgWVR9+5o6N6rimYYts9+V8VeF6FBPAL9i2ui95t+j+G5hzBAWVK/iLy3SnSLniYDeu17/U5PDvioTTB4ifT+pRaRIC6QqrBe0HdcI6qH/gXCantZB8RT3OoZ8lZvHhzTVIDdhrkjIGv1+xH7TcvZnPe+u3XSfn1MvLoYTFqFVsK6IUHidmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BJXTXMgZfoQTisWnrE+dF0tjh2c36zeNgHII+lr4PEQ=; b=naUdtbOCPJrHkLs01ZYwlisYKLOs/Uphe74pw6y3URzyy6n3PMDIo+bn7I1/O5j+s+B7FefnsrIfnNtyS5vrOcC8KbrvLuDQOykBX7/C4MB8R3VGlR/wjwYyz/GUfwodvsgQ/WRM9EAVjx72N8YcQqFf2Jr0iQgkNrtcZDchDbk= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB4834.namprd11.prod.outlook.com (2603:10b6:303:90::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.30; Wed, 10 Mar 2021 09:56:00 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%7]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 09:56:00 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Dong, Eric" , Liming Gao , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Gao, Zhichao" Subject: Re: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot Thread-Topic: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot Thread-Index: AQHXFYY+M3lbwab2mUuMaZrzQbD9D6p8+pVg Date: Wed, 10 Mar 2021 09:55:59 +0000 Message-ID: References: <20210310082014.700-1-zhiguang.liu@intel.com> In-Reply-To: <20210310082014.700-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f9b28c3-3d02-42ec-a4ed-08d8e3aab56c x-ms-traffictypediagnostic: CO1PR11MB4834: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z/7X8089hmBHQ9diPWx1NILv+kWta7fZyFbLAmNQ9i7YnZ1djhdIRxtt/6zQIJZSOoz3tV16/ifALF4g1IyhfXHl3byDCUUIKsZavRXgpL+KrSVZ5SlONOHAK3ht82OBjM3smhsyFHbRPzR3VeY25q+mStfRLyFGu4bwlpBZNGH0PZ9WPFXT1F5tW/D0oPO8/v9ZY5+j/hyaJOCt5c0OhaQHDaR/leXqhBD4sEaxH2cLpnqyGU29gRGHstuzgpeAPVj6zklsGqEGajf09AN6gLnunW+MJK8bgr9QXlGN+LUXCUmnQTmxGCLmjNAO4QXu6fIys7yCpMpx3HEsDUBWf8U2waxHaJMRQJcSZN8JFyjk8Y3A4F4Nlj2LxtAGhWvR2BVKPfJrrYowfoPjfEeL9BzPtEq0RfhVBmNkp9nxG4Fryr8LhmIFvU6evz7RE9SycSR2XXXlEl7zQ0WPVui9rHhclRtA/ZjY5UJswZfJrPm2SdUVVfwA+jsTvBHVS3553C+gqPxarUX7lChVOA22Eg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(396003)(366004)(39860400002)(376002)(66446008)(5660300002)(66946007)(66556008)(64756008)(66476007)(55016002)(107886003)(8676002)(86362001)(8936002)(6506007)(52536014)(83380400001)(316002)(2906002)(186003)(478600001)(71200400001)(7696005)(4744005)(4326008)(76116006)(9686003)(33656002)(54906003)(110136005)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?MBIwZ8QuUDobxfY4f29VLfae1nsvG6f+X9NwKG6g0ez3VD0VUSoEdCGS8Sji?= =?us-ascii?Q?dnlsq+xmOKJvAKuxQtDIbtTAwIXdPD76nJUI33gnKWZJaIXTkjogvKF1dK/o?= =?us-ascii?Q?Xrqkjf9lHc83WhVaimHLVCiflqgnCuYeqSTpu2hniW7RXU3SetCrairUvQgg?= =?us-ascii?Q?tc/OXywImOAbA2cxppeQO4D39uXC+/pL8orVKVjKRMWPdMI/LlYnHz+FZ//k?= =?us-ascii?Q?usYIn7mbWMCcIIOTmZqU8BQSyUnszkSkD7GZXyQpdCHL+MhweBguWlVVhas1?= =?us-ascii?Q?ZVorYR4BkgJYsbt3Ov2EbIhv8OVjJfYmYkp/SAmfN4kaahimxQZdOoaEWlMH?= =?us-ascii?Q?fx7FAFLQ3AHxLTQC7YD1+pJwQ6MbJrsqAgiXf+kfO2IJQIwRs+IIH9+Ic2Ub?= =?us-ascii?Q?vb2kHsbKdeFP8vDuPmBV8KcBgx358oOEvBkiXSXoJ/EL+MQMstZJTLHH8bXT?= =?us-ascii?Q?UxyBqnqBfrgxhUMCtI9rF/RBUl0/mc5ioXaKrSfK61FB/CiYyC/ZVRxEzdZe?= =?us-ascii?Q?rbCnXVrOIwqhoG4S7/7/OcVliz9SAnZbJt40/gzfT2tEa++RPDOgcuaJm4Ln?= =?us-ascii?Q?GwQnewfNLlsTIcNxk263m69qJ0sZE5WxQQXxF9/Ne8eLEmT164modZ0lC1fn?= =?us-ascii?Q?RH6sxjMwCueB4D0AsWcxMMOwZjz5E3W4jD4Tw+nQcs4fjPhkrOFb8vtlOlKt?= =?us-ascii?Q?FlWNAQVrdUDTtdSJXjEQrZsJtdRxCbB+O9Y2E6fE7DRKjpE5DP+9GdGFaMzX?= =?us-ascii?Q?kxpDhIkwYHm0lpPvjVF+2Q5khxX/zTQpO4B03U7nvG9NaptUusnB3s8H2mAG?= =?us-ascii?Q?bZDK7RYvA5axFXPBniyEBE7ulK7CVuBJzRsyHs3r3z7pJYIdwkfgiSDC0P3y?= =?us-ascii?Q?xuKbZGhXPrDjtWrYsbWcRqPbvjOQaamk6n0KAHMIuYCxVpqH89qZfrwssONf?= =?us-ascii?Q?JNdD3LU1ZJ13XrE403IxSaiHVQ61ZO1sxoFMUnIU+WfEHanVOE5H6CPmxyK1?= =?us-ascii?Q?np41kL2huVdIdVyA0qs5QSptyHaod1L4Zh4gpi96BAy9Q3n4cHaEV6VQIsp7?= =?us-ascii?Q?QAFVIY8qGApGaLL58iNUOLymIceQB9byfEucl9KkA/92N5eoMjL98cBpEq3t?= =?us-ascii?Q?lhD0BBu4zS5p1sVPNuI5MbbpjX9wzWALQKpjgzMXWeQRPjJb7rbza4hAociY?= =?us-ascii?Q?TmbGvQYkqn0knpA/sZ5brSXeF4uKYetRPmocTag96m9FTvjrV4rm+s3zUfRe?= =?us-ascii?Q?3ZRTX1PaRXDu5xME/41QuepPACYwJLjoFhA9dEU6t78cE08FT0HoEZol9Bli?= =?us-ascii?Q?hRE0jJeJt1JpwjnXHc/xayph?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f9b28c3-3d02-42ec-a4ed-08d8e3aab56c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2021 09:55:59.8854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8zn5to2sC49bI0CQ5GeuEqICntsRPGM1Qo+jMBIQsyXCzLuUfYQ9B87TJqzKyoVnFwoJVoWDCK2BVPxjjtYMDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4834 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable 1. DataSIze should be set to sizeof (BOOLEAN) before calling GetVariable() > + Status =3D gRT->GetVariable ( > + L"IsFirstBoot", 2. Can you please define a macro in this C file for IsFirstBoot string? e.g.: #define IS_FIRST_BOOT_VAR_NAME L"IsFirstBoot" > + if (IsFirstBoot =3D=3D TRUE) { 3. Please remove "=3D=3D TRUE". Just use "If (IsFirstBoot)". > + L"IsFirstBoot", 4. Please use the macro defined as above. >=20 > + &gEfiCallerIdGuid, >=20 > + EFI_VARIABLE_NON_VOLATILE | > EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS, 5. Please remove "EFI_VARIABLE_RUNTIME_ACCESS". > + 1, 6. Please use sizeof (BOOLEAN) instead of "1".