From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.7685.1622601706104158712 for ; Tue, 01 Jun 2021 19:41:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VY1wx2zy; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) IronPort-SDR: rYEgIoSFS2yCazVcQyg5YZbJT7TbLoS6fsipvz3lsFkpHV0GS+s+qQGngDTIxCpdmziycwFJIY mOEZeAXl42rw== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="203681690" X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="203681690" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 19:41:45 -0700 IronPort-SDR: eMwOn2rgG6ZeSQrpRLM6YS9pU6tqCnAIoWuLoJ/CYSShbpYTKswTCB2f9oleOqBOjVUDX1gyRV 2TFqoWdc7C5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="549964585" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2021 19:41:44 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 19:41:44 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 19:41:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 1 Jun 2021 19:41:44 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 1 Jun 2021 19:41:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTyEnl/e3wwH2tItplZ8xf3vMRldR8QdpCarqhIG9Hw6VPLb3rxSYYb0eGblX80wXYJFnUl3vekjHqsJcPeXXKsdU5BJzI2fVgkWJQ+MQ2LFxWtsp1zB9LYHbmbDkD78bckeiOxIM4H5l+ZfLZCXxI6byX69QO1xPF7sffjjBrmSoIqLGoeIsi20IK6eFtmkooJv8EfA6I9rwyUJsDs6Yl518DiXKhi9WLt+QwtEF4qd1OH4P/KZlHwfw+dRAwEPf4nq5T3hMW2ESDRiJJdYQthd5P3+7Z5k4JnuQCg5/zUHOSW8wf/TxN5qj+32RJTKtedfxkzEJuK1CeN11vVACQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i/ByVPUCbSW5mCPIkyC7V3slKhsLZkupUOiTffkMMQE=; b=kMS5poNrlqY6wF/Bya1zHEiS23N5hXNX0HFOY3pLxJEmSywiwhi7Fniq9evwivLBkFKKw5vFFivVYlh+iPA77QGogzV8L0eQ3czsKz5dt8ekuBOqVOkNCPVu2LLya114S+eATd7PVgh6K95RpIBmTpIPAtoZsAm+jFWQ7rM6Yb/RWyENuZyB2KXnjojehC9c02tcRjMNCuTem8H9BkNdzBss689XtXiWEfOsSM3YJuhpAsN6fovcspFUzNwkryYBv0WY5Aw8zQ0istMqfl+QqlTyzV2qzri/IA5sInT39IxO5A8fHUAWenZm4QD0rj72pAc6f3wiStFAOslqymg4fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i/ByVPUCbSW5mCPIkyC7V3slKhsLZkupUOiTffkMMQE=; b=VY1wx2zyKgy0rSianvigRoU2x+8Yrrhbj1+9DrL8J4kfSqPy+2DwTGSM/4BtE4hkm5RCaubMMS/oR/NLsIQk2tG/DziGA0D2WpuOrOHbULIcScMBYNyXWza97iF6Joo04sk6vcYzSGKOlhyrmYiuoD5m5cqd3iDajpiBLoYSqMQ= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5156.namprd11.prod.outlook.com (2603:10b6:303:95::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.22; Wed, 2 Jun 2021 02:41:37 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7%5]) with mapi id 15.20.4173.030; Wed, 2 Jun 2021 02:41:37 +0000 From: "Ni, Ray" To: "Li, Daoxiang" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v3 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor location info Thread-Topic: [PATCH v3 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor location info Thread-Index: AQHXV1aGGn6PDqlobU6Lu6QsU57xqqsAAgUg Date: Wed, 2 Jun 2021 02:41:37 +0000 Message-ID: References: <20210602022503.1447-1-daoxiang.li@intel.com> In-Reply-To: <20210602022503.1447-1-daoxiang.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fed43967-ad48-4e1a-f73b-08d9256ff1e4 x-ms-traffictypediagnostic: CO1PR11MB5156: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6U1RdGVQ8I4GIZqTW018lH1Ft/SW/NejJKoOMTWQp2z0vRjImVyLXeHMRAf50C141Abxx2/mXoHqRNE3Ch3/42yFFNU8kFG0Cp8eUvJpcmkX+SfcZQjS1vALMLiM6+URxHxwECCCLQywDADJ19vrjecjX+C852dPE3QZjDX1BSwWBOL/sHr5CM1TEUESM7X1I4FDNBxqHgdpgwKTNs4DGFWCpAb7WqcsJxR9tks818ugmTkn2AD9nTycfEt8v2GZ4wbLfpCXC2JNO0Yuzt3UfX/pIlOXqjzOlrFJsaRlYHMNWqOcZAhWU2vy9WpI8a51YhsDCHqGVJBRqD6lm4rGCgdcoxWalMbWSRaa/R3WsdIxRuDef+WCo2QgVYRUQIYwfqnHm/mRWCmlAj4GEM2vmoLjEb4ab9HGEGAIudmv2v8Nf99qfAtnH8CoHSccYKqY01LmFtEZ3ylHaRZ13UmkYIARW2H/8F81H58SLAOmmA5PD90/QPJyU1ReVQrXlJvCa/8N3ORtBZSNxxa3DlbF+234xJMDPKfwOyshc4WYNRXwTNGZxkWoDpf9vpCxAEWmYjQ3mzdD7O8YGLHUIzWUv1d95iNy8zBm8Dms3BRdIq3x3uKRLwInkYMyBAm2qn21S1u+lVuixmMJgwB+nxGZJESIaLL/24Z5buS6MWe4LCq3o8ulLApA0jcSvdeKvKqtkyz9fMbYT1NM09tb7LIQBw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(366004)(376002)(346002)(6506007)(53546011)(54906003)(316002)(66946007)(107886003)(966005)(110136005)(76116006)(5660300002)(55016002)(33656002)(15650500001)(66476007)(478600001)(66446008)(64756008)(19627235002)(66556008)(4326008)(8936002)(122000001)(38100700002)(7696005)(2906002)(9686003)(186003)(26005)(52536014)(8676002)(86362001)(71200400001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?vLqxSfUKLzwgz1oI6OxeG5sqeSSL0cb/HGUViuUWP3VIL8xr3zlsnk1h4ZPB?= =?us-ascii?Q?rg4vm2H59thGEhR/KdMK5LSGy7M4qJ/IPS8Hl+eM5M0VzixmbRpM372qWAqG?= =?us-ascii?Q?SGj8qowZmGnwrucnu20SBmot9WhkHUIIUIu3xbUxs8/4I2yWNwECG4bWEEka?= =?us-ascii?Q?nUBOZFieR3Pki+65+ASU/tVcKcDT9Qi9strUZUcwwTNSEzjsn+iUyvVZzZQ4?= =?us-ascii?Q?2FmFvqF9M3hxUT+lC5n+ZK1Zv8RyEFJ7yzOSbOd0MFQk8uarkMxMc5diPSlr?= =?us-ascii?Q?J6IUHfKIurFVOXKRgU/bW6yxgVtgoa9u5nEkpc1dp4CFSMjyP7aBSsqmONUZ?= =?us-ascii?Q?FkXfvBr09hAFGi/vehKx/b4aC0Uqu/MsJ4WVfQzpFO4+DEmww88H3tpzjIzJ?= =?us-ascii?Q?ah09soaT11KkF6Q4WW5z5JyzlOSUCuhsSdvEIzWCA+MPr5BxmX4n5LQ3M8LD?= =?us-ascii?Q?tmQzi82WAg0XHZbYof93iK2EVDbP3bBrbzXHcn8T8FP8qH9r8+ciEOeyD4YO?= =?us-ascii?Q?P1i4ediNY4lRfec4ngIef9tQvPoG6v+YLaGrl9WIPcBQnx90HgDIZtv7SXX7?= =?us-ascii?Q?lgcQ6xAu1JAo0s01JJgTin3xi/0QWCHFO+CCWVyyw5UKTtjSYTTZemLBP7yp?= =?us-ascii?Q?1iLqhGRX40srNYBld5FknUAoBYMR8ompcD4cy8X2Ta74yElyjphoalOU962a?= =?us-ascii?Q?wCJ689tYNhkfSWAHDtVeyLBUFPg/c0QCJkym7pHlozoQTjOOWTrYL6mMLMLS?= =?us-ascii?Q?cxQUp0fzqrwNzbwz0nXj3k/F02t4qdwYAjXgFNSlXY1tGadsjqYCn47lN51r?= =?us-ascii?Q?HC6Xn+7A02PgbZr6eJycZwuW2L8pfht3trRj9KIFE11C1weCkEgPOuBXQtNI?= =?us-ascii?Q?0LiWY9oB++dYio7HY1We8cpWS++gtgRu5J4fldEQWUt9NFRr8GJYFDG7U42K?= =?us-ascii?Q?7lR+0CuEQ38EO8sAdkIirPMkpWI8F/pl7qaWCDUhUrlHaziTUJVrHANRGUbP?= =?us-ascii?Q?oqlpNBfH1+8jCV7pVuORl/6SKFwsOCeh+VgO8+M5oBgwZ7v9nQT4VsLt/8S7?= =?us-ascii?Q?jer2bIA3Q0y/W9ch18JBQ/UtwxtcVubiuM5IRIKwPYCVVr1ynbhgRsXvvQRw?= =?us-ascii?Q?9sCLy3pukS7I6sy3HiLvqDMVIPdQL5+rZxyQF3qnRYVZRt3rEn/CzepuzcBh?= =?us-ascii?Q?RaWqU7ZIwHX5CRbf/qfG//dECsLn4jllHTipL16IMeC5n7mc4qpBhGc1yfLX?= =?us-ascii?Q?N5u8PTEe9hOSM8QgontRfXrAqB8Ceq9tBI0K0Znl1MiCN+idLOnUk1B0X1Us?= =?us-ascii?Q?pJjKr8SM9tnw5fs3D7W6NVS7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fed43967-ad48-4e1a-f73b-08d9256ff1e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2021 02:41:37.9139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /jOkW++YRkjv0Oeaws8xvDqiaRmDpFiwNOsCHsiENj6fdbhr39T3S8npm6AhaAqd4yiZv7iiJHAvjUZEk1U32g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5156 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable When reviewing V2, I only focused on whether the C code change is good. I am ok that this patch contains not just processor location check logic up= date, but also updates to comments that are not related to the location check. 2 minor comments: 1. Change the commit message title to "UefiCpuPkg/CpuCommonFeaturesLib: cor= rect the CPU location check" 2. Update the commit message body to mention the other changes you did to c= omments. > -----Original Message----- > From: Li, Daoxiang > Sent: Wednesday, June 2, 2021 10:25 AM > To: devel@edk2.groups.io > Cc: Li, Daoxiang ; Dong, Eric ; > Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul1 > Subject: [PATCH v3 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update > processor location info >=20 > From: Daoxiang Li >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3424 >=20 > Processor location information check needs to updated > When Core 0 is disabled >=20 > Signed-off-by: Daoxiang Li > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c | 4 ++-- > UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 4 ++-- > UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > index e6e5db75917c..6f9685733202 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > @@ -63,9 +63,9 @@ C1eInitialize ( > { >=20 > // >=20 > // The scope of C1EEnable bit in the MSR_NEHALEM_POWER_CTL is > Package, only program >=20 > - // MSR_FEATURE_CONFIG for thread 0 core 0 in each package. >=20 > + // MSR_NEHALEM_POWER_CTL once for each package. >=20 > // >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo- > >ProcessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D 0)= ) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 >=20 >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > index bb5d983d1f4b..a3a2861cee5b 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > @@ -152,10 +152,10 @@ McaInitialize ( >=20 >=20 > // >=20 > // The scope of MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS is package > for below processor type, only program >=20 > - // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS for thread 0 core 0 in > each package. >=20 > + // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS once for each package. >=20 > // >=20 > if (IS_NEHALEM_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo- > >DisplayModel)) { >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo- > >ProcessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D = 0)) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 > } >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > index 8450c7ea3eaf..3c4c1bc706ba 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > @@ -130,10 +130,10 @@ PpinInitialize ( > // Support function already check the processor which support PPIN > feature, so this function not need >=20 > // to check the processor again. >=20 > // >=20 > - // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only > program MSR_IVY_BRIDGE_PPIN_CTL for >=20 > - // thread 0 core 0 in each package. >=20 > + // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only > program MSR_IVY_BRIDGE_PPIN_CTL >=20 > + // once for each package. >=20 > // >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo- > >ProcessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D 0)= ) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 >=20 >=20 > -- > 2.28.0.windows.1