From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.1329.1626161333393277317 for ; Tue, 13 Jul 2021 00:28:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=X6bFqScD; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="197388956" X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="197388956" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 00:28:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="429952192" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 13 Jul 2021 00:28:50 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 00:28:49 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 13 Jul 2021 00:28:49 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 13 Jul 2021 00:28:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gn1r56i6GuFc05Qny6riyOBvcAAgroCfUOfVVi2VSgZ7ZbRUZ/yEND9B8vWytO0jCbcloqAZ/mGrdV3cWnMhF2LlplrzKPsT6HAlXw4eskwN6HcDsFvpbVDPBhwt2EPbe9r3ezEAqIbqsyBq+7xJbglj0br/fol2ogYNXopE9LFfGn/5obRvEAdZqLWeOYPqWdR3x9pG/zqKKOyjt/lzSuLP4l66I1dqge/jln5YtSZ+CUsME5l1gZYT/GZQzaZDjZbdlJ2tqSrwVmmJmKXRnmmZ3p3sYC5uEQAbmmYWLuyqLV4MH2Mc9YBo5wEU807Y1a8kZaFTdtQwwXFPTY1Wzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDk6kW+Za2WK0caKyzAf8pcdWbWqCRRDS2Rci4oRek8=; b=TnC0hI9pVJDG9v+L74O6yCojmCD4Zk8nM4BNeeg8Z12Gv4uUDr8ybVqxgH+PiqKaIheW3pT7A5BtNM6NOO8fodD78hsnPxfh/J+ca/VGA2ASOp8XAYsQ+KXrNDPVLGSM8PPkzr9FH2RRa4X4kAKH/UkXVQGJAZVlezNoKeMWkNOaPa8fZSBNyvLCQFl2NJleL2ZgMcIdjuCEYzYn2AmsRXVD9Hh4d06lUriMBBG7dZ01Oja1t8qhaF9ARIF6GhKqZelKsniLVCBXNBZxsq3NVi2y/vxaMBs8642h0UKw4konkljM07yS91MtjDocyyGgrSxEwECsoLksGM2yVuTafw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDk6kW+Za2WK0caKyzAf8pcdWbWqCRRDS2Rci4oRek8=; b=X6bFqScDrsVrM+tUWEmoqv5H7dZEmnS2GKXxO6EBUbX2IiCt9QJbOdf8ANYleoJcPiBs8QS/TyxtbEWALw4dRlO9oeDNVvx9ibFCg0qmtJgRhCE7sQNqrcHqn3zcvVwUx/bGyDh2rw0hed+9XYNuQoAcdeccUra6xlr34p2W+xg= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5091.namprd11.prod.outlook.com (2603:10b6:303:6c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Tue, 13 Jul 2021 07:28:46 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869%2]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 07:28:46 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData Thread-Topic: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData Thread-Index: AQHXd7eUTQZie4LE7Eu5TKhOPrKrGKtAgckw Date: Tue, 13 Jul 2021 07:28:46 +0000 Message-ID: References: <20210713071913.1060-1-dun.tan@intel.com> <20210713071913.1060-3-dun.tan@intel.com> In-Reply-To: <20210713071913.1060-3-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3cdda0b-f3cd-407f-260a-08d945cfd9e6 x-ms-traffictypediagnostic: CO1PR11MB5091: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +nhatBBxo+xT4RSHS/sC2oL8eBE2s23CwalUTPtFi34Mv/+K4DAD3g3rLQy4d4O+4TAUyvdkisv20Y+KKe9DjShJjNDk1Un0UBPLIHYL9C/DtK8AgSqoVWLD4xn+sMSVpIpXPNeQXSn4nyubdT9K4KQHd4yyg5Xgrm/HxQ/TrZhRGeOUjtyLCziqklrF+wHZf/SS4g1Eo6nRXkaLjhY0tDSmuXGuYUPf5IGFMNzm9Opnn/oDgwprEzcUOF0o7DMwmIVhQY/DAeiJyA266YC0+cOBrO+kkSnjWT+otx55GWrSYabiBFMoSl+sttF6C88Q6V2snWr3xiTKE07NJ90tlvz/OHZ6ukoMyBo5ZJxs5oVi9sqgueTFJZySJqYbVhfeLaZS08moXsNr7bHTxQgCmTslrhC54jQiirxfHyIqG1bPB8gAsdWCpHxwyPTjepWcdWwMtpgmtE1SmYhSFQJBjAXyDzWiG0ivFCouPDNfhtlpn9Eo18OYSDsxiRRlVivLZ3BIucpZA1XbBlgrG+iUWDShtjxYwf8jE3AzDjfh3zgx7FQnsXLjhQ7dpB4a+Blxv9RK6KuMxLvIjiuqtFD2vyKx70R2OUIRktbjn//N7Xy6TtQYfry8Rz8JpVMQwgMRZhP/LRP8qpzjmkEJcS40Uw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(346002)(366004)(39860400002)(4326008)(76116006)(8936002)(316002)(71200400001)(38100700002)(110136005)(8676002)(66476007)(66446008)(64756008)(66946007)(66556008)(52536014)(86362001)(122000001)(83380400001)(54906003)(6506007)(53546011)(33656002)(9686003)(478600001)(7696005)(107886003)(5660300002)(55016002)(26005)(186003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3/Bg+7uuVtz3xrZVYniha4M8F+FPOf7J/mhOHFSKpAkI/U4EmDmt7HCrY62t?= =?us-ascii?Q?pl9/ytTYaQBMrmE0gsmmf00xL7/gRGHOODr2HlJaqiz+iKfrOq9XK2x34IYt?= =?us-ascii?Q?rRKHHG7HzUijKgECDhgVIXA9pt3PV5nfQp0FBehKkNQls10JuYW8905qcokX?= =?us-ascii?Q?jvNCHt7RBUhZialcNGCyTOjownlixeWdO6oRmTru56VnD4pFKCUNOd+eDYKb?= =?us-ascii?Q?SPqO5zM4J0fEhJDLTrIVJZ4EWgz4l9mQb+RN4gB+kk9UYgZVWRVVT4E5YpY6?= =?us-ascii?Q?YCMYfYsPZJ6gYAddWrSUw26mnnkBAEjJQkngJOo0Z2bCIZadPSTrteqpG5S3?= =?us-ascii?Q?VcZgGS+Fd3LPUOoTwtkXM5mw6nOoqQZFtra3Rvj/8s1m4+8oLr+4i9HzGa8O?= =?us-ascii?Q?fonCKbD80ER6uCjrs8clXzv207muUA+Zenye2Crn3uxajb9JqVObqNMa9qm8?= =?us-ascii?Q?NZuR0Axt8LE7QRsYupqDAKGiB3Hcf+l1onjNHXBiJyyorju+lv4qcy7eRAoO?= =?us-ascii?Q?FXsGk3Um3lWr9e1XtAbc3PiUguUV9+oJL+RgiXBu8jrxvD+Wo3A9lAYEd8IT?= =?us-ascii?Q?WKSxs9UgQY1FqU7pM3llvkFwItShGy0yv2K1+xrJMlSL6syD0JSK36AfmNyF?= =?us-ascii?Q?bDw7uPmEUt4d6bX6Z31GIDNMU13kL7x1mzs8/ZdEqj5TwjdSzMjr4ZDV+EhR?= =?us-ascii?Q?Gn9iYSkxka9wWC24oGQLUK0vEkvQ5IzVcnaRERpvuVnSkFg0qZ0xcJ3qx4Af?= =?us-ascii?Q?oDbTrHszzbs1kThOmPuM4GwpjlEY9T6PrVhoJAeametjbfW7rb6h9btywAQx?= =?us-ascii?Q?ivZ+7tdCE3cdrrtQWCaANLfsB1jVTOmlTJL3qska1i+J9/2N1192K4f78cJW?= =?us-ascii?Q?kFuZPloaG86fcej4KG1F5IDcgZW/XaJHxjVLjerU81ZUsPzVybN6HIwTD4gq?= =?us-ascii?Q?q8DlEplhaq/rYFi7+6t0ihzNJblxI3YHociCqkq8YAOAgrMpjhw1rexiGtIk?= =?us-ascii?Q?lNq38h0Vrno9JXXCYDq83v4eQtAOQsCQe3/NpqJUQkfuuOCMQ8c5MjSjFkFn?= =?us-ascii?Q?DkwfdOndCa+KSeTPufy6R2M5At7zQbGr5fARSCbDO/7gdzMf43YB4VJ9bwXx?= =?us-ascii?Q?la9IIhyC8H1A+RgNhW0ouTnG1Ldpklbj7NhC/95sf9OIrskemkZNyfcbN/m4?= =?us-ascii?Q?xBXYh3Li7o4yNo/kSfbvJ5gQfu818HQnmsCSsZHphNhpymo9hIitBD7V+tA9?= =?us-ascii?Q?2yGshdcHtlC0qhtg1najGvhGLB5Lfh+Sw6NvVCjU40w6w2zU7Mp0naD1Q3pl?= =?us-ascii?Q?WdU1SKCoKpWcp2phu+tlTgLF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3cdda0b-f3cd-407f-260a-08d945cfd9e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 07:28:46.4149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BEs2JZcZuGgC431RbT/P/9dvpxXPxBoXWAlUoHhSKzYD6oAj/EXyxX+eU61OY8EvtPwwqJ1S/AbdBb7ZBRWdDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5091 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Tan, Dun =20 Sent: Tuesday, July 13, 2021 3:19 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice= ; You, Benjamin ; Tan, Dun <= dun.tan@intel.com> Subject: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPaylo= ad ExtraData V1: Assign the length and revision of UniversalPayload ExtraData V2: Force int to UINT16 V3: Create a local variable to hold the size of ExtraData Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan --- UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c b/UefiPay= loadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c index c619470dbb..141ce86b46 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c @@ -56,6 +56,7 @@ PeiLoadFileLoadPayload ( UINTN Size; UINT32 ExtraDataCount; UINTN Instance; + UINTN Length; =20 // // ELF is added to file as RAW section for EDKII bootloader. @@ -105,11 +106,14 @@ PeiLoadFileLoadPayload ( // // Report the additional PLD sections through HOB. // + Length =3D sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * size= of (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY); ExtraData =3D BuildGuidHob ( &gUniversalPayloadExtraDataGuid, - sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * si= zeof (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY) + Length ); ExtraData->Count =3D ExtraDataCount; + ExtraData->Header.Revision =3D UNIVERSAL_PAYLOAD_EXTRA_DATA_REVISION; + ExtraData->Header.Length =3D (UINT16) Length; if (ExtraDataCount !=3D 0) { for (ExtraDataIndex =3D 0, Index =3D 0; Index < Context.ShNum; Index++= ) { Status =3D GetElfSectionName (&Context, Index, &SectionName); --=20 2.31.1.windows.1