From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.7510.1622856612062898214 for ; Fri, 04 Jun 2021 18:30:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ss7n1cqa; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: yd9gmtvYtTUk0x9q3Pcs9rNaj/nw5VAf+zDozhBTWtdYYbFP6PLO2krMeQKsynKv2dw3sXVNhZ shTApsTYPQJg== X-IronPort-AV: E=McAfee;i="6200,9189,10005"; a="184080654" X-IronPort-AV: E=Sophos;i="5.83,249,1616482800"; d="scan'208";a="184080654" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 18:30:10 -0700 IronPort-SDR: fiA+zWcL91CIiumt6ALKerbJ9rDKLH4dmEZ2+aHgbMM4jr3Ax3zGlzLN3pPRjs3din7tCiZo7a NiqVe72Rj0nA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,249,1616482800"; d="scan'208";a="401128290" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 04 Jun 2021 18:30:09 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 18:30:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 4 Jun 2021 18:30:08 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 4 Jun 2021 18:30:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nK8di6Fr6UH3ltD1eEUrE2rnSI9+ByCqrpZAJDsjYoKWTUh0MbAki+cLQdcA9168h0FX1umqN6N5hEh/JKQRoqKKfQoAN/zDLLXOYwqYNESVv6yfk092bqDiVDCQft0yrOfGxIYrVyndLKL6VaqjHdaM6dIOvCoAViO9OMz9cOrtTT/VyyeV8K9Q+0YJ/Vvc2Ie1fl5JGDjOJWSavj0eT0gLOY4Fka0NomQkEy97cEgkRxm6grk7F9ea5xETlu/XuyXz+rA+UQylePUAoqFxc3/yDB8+1XYpNrFPCXntxIi0euCFHrSxHk5EHBi8r4p50Pmv7qexPEMhF6DUCNBuBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OnIOenopkYAYXFfwMditmnwbC+SENcJGwHl5hj6pvY=; b=ACruux5alRAtkrcqGYhMa4TcIOtGMDZqxMtPELu+PTZ0utk9G0Yoy8QkLAxciAkK66AtEPI5rPWr5Tb4IWKkfPQxiu4jrc+JyOwVAihLOyt7mvMsgstJ7iGnFC8Sh0FQJ1vAv8bxQ8JQrWnMO7PmJQyiPLtvVF7Lg8kltoiqYX7uCvkbdy606W6crHsRYU22GlJu8hsuCsov4/nBpTSU0UDfSmIOEwcVriCxJ7dzUtESn6zEpb60iwb2iCt+2tNTrJzvDfthXZ/aYHJOuDcVMbd14cytKLIQ9Lb34hbX5KqIDCCPbhkWEZ/F8hMyuwbY+ipklQTBAh6Dtj0Ibq85EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OnIOenopkYAYXFfwMditmnwbC+SENcJGwHl5hj6pvY=; b=ss7n1cqaebrzzrbZG5oDIJRlRKLXtgyvzifFaikxYs2rB7kj3Hr92zyGlJbmpb9LH3YDSGa2Vd6pl+SCE3fniykCSVhjEbEF9fZDs0ejH/ZUs3eta3QBvltYIqCXCUfm79LIDUyh169ZfGtCfSAA9Kn6uJ2Wdnz8b1brJHIK1R8= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1998.namprd11.prod.outlook.com (2603:10b6:300:1e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.22; Sat, 5 Jun 2021 01:30:07 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::a439:f8ae:4699:718f]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::a439:f8ae:4699:718f%6]) with mapi id 15.20.4195.024; Sat, 5 Jun 2021 01:30:07 +0000 From: "Ni, Ray" To: Leif Lindholm , "gaoliming@byosoft.com.cn" CC: "Feng, Bob C" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data Thread-Index: AQHXWajVljA5hGHNK0qF/a7vVQq7LqsEoNcg Date: Sat, 5 Jun 2021 01:30:07 +0000 Message-ID: References: <20210605011854.1938-1-gaoliming@byosoft.com.cn> In-Reply-To: <20210605011854.1938-1-gaoliming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5dd8653a-b6fc-4dac-dc7b-08d927c173eb x-ms-traffictypediagnostic: MWHPR11MB1998: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NA32RuIE4TRtmZ1I74gvLgO4ooAhU6fPvvmuVQZGJuMp+VeRYgv8m8QTz+XE9zCfS+gUW0lV20Fsn/0X1rqMiZh3VEN+kAX3xgocE9zem8oAaUzskPSFso7bYymxrfyjQYL6HIxKpbbI2Q+D4Yom+i705JgWK0tz9GKYBJaUP1x4o16T6JCWs+4MhVgEHLEaKGcIMNVwODZC+BCtro/lPX+0GmCh9tnLJwplTIgyGyYToi0L8O7klJOXsbN43O/Tvlpz/sziB9S8TIYkGlsQY0B2fkIJpoxDJJ7gHDzz8tSAiLlblKuMxhRWj3e0OgJEiQU1NuwUtVCvZIxFCCS2XtWIR7rA/NQ4sQdbhBQ4fk9v5nxZFiDuVx62bHG3UGnrxMCp2FA94AnFSdTZMCx3WruTti3K6JKggCQIOLqdVuZCc6n/75agEfsWS1BvGIsv2MmQ6EuUz3SbRPJKe05VBW6fS+4DGl1r6Iurz/vArLafm/rvlma1NyHx3tLxfXT4VU0EAi+EYgwNsr9mLInU0G0WePcWtPjeF8cG1SCpYpx2ymZd4+JE862BIHFrHBOs9IUI4bY0ElzB1ObJYF3gfhwXi9hY2GX3q5RaVOTGb+LsYqP1Ljj46w+cdD0s8SkmrsMu/9Oa7NoQN4hB0VyCbPDvmkOObxCS+8S1MMnbLydOq8iU6hb+TjJURAJMP+xBUMZ1tGV1KYOTmd1akYO0GYiWZbQwzU7unaHK3cjFl1dBxDA2/j4KOl7oiUkoMDeS x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(136003)(366004)(39860400002)(966005)(38100700002)(71200400001)(122000001)(83380400001)(8936002)(33656002)(53546011)(7696005)(54906003)(6506007)(478600001)(110136005)(26005)(19627235002)(316002)(186003)(55016002)(4326008)(8676002)(9686003)(86362001)(52536014)(66946007)(5660300002)(2906002)(66556008)(66446008)(76116006)(64756008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QCQ1r6/4k17c7417y7aKiPG1RQkpCJyxR8HJ60roZFjnkWGvReFdTlssEysW?= =?us-ascii?Q?KV0uPQgTSjmi13IwUziGJHYLh0DWrfVHjXHDB2Uw2Kn1Qyx1NBqvqmdFFQTw?= =?us-ascii?Q?c3LuSufJJjNNB9nMpVNHcH6APSu4uU9vbBASze2QG8mAOEd3YCl5N52hlHUf?= =?us-ascii?Q?13CJi9VRH9DFLR5M4EnIYeAl3oLTEas/zHsLwt6+oAzlJNUZAZHsfxKWUimf?= =?us-ascii?Q?5KE5oAIcSJB+1USiijiWPeSdou0ZDRMr8bV+gY04iHvNB+U3z31flXdNQ1nY?= =?us-ascii?Q?vjTPUPT2yajMKVxqNKRGeuTCJgxRkZVUqQSqqnivhc8Dg2Y9K9dzKchQAAJi?= =?us-ascii?Q?GvykHe22I/Yo2hDQQvINtRGXqVEQSuhcdK7j0xEWLbSimXc+S34ncMkVZzzA?= =?us-ascii?Q?b/w4WfsPIUeu1PPXnRDcO6qCPYnhkKXh4BrAPgUfawzd0uBYyk193GB5v8w+?= =?us-ascii?Q?MDlV2WdaG9SyiDKKZH41yZLRPbMXRoDCZXxZso9j+rQa6yr5keju8AMb0UJq?= =?us-ascii?Q?7PhtHyl6U0B4scYuEtP7eCnLVy2G5g1SdxTpK/Z8TkorSa2NzFaw/1DygWER?= =?us-ascii?Q?GNqU3mOsMSb/Qa1TIwizbzApubw/k66amG0Z9WbjLyjHfjzLqsDCKGyq/kAJ?= =?us-ascii?Q?L1TpRxgmgOh3tQD6L0NlnOQhsDK8lCurLRQl1Ot9op3kaOW1O3HPJwnFGyPg?= =?us-ascii?Q?oklDztGWy6g85mY3b+PEA4Km6dpgg9H+ORgbLpYB8lBNksRhl+sF1EhoqZwu?= =?us-ascii?Q?EZ6y1kVzV+THauDcADZOTtMfcmBkxSvS/6F1RFJ8whWMKft+0GaT6F9wMwNs?= =?us-ascii?Q?oykQ9yTGqYHWpkqUSaktwQZkBEycmckABTfUzqVWWtdoFU1297aZFdKvZ8o7?= =?us-ascii?Q?KB94xPrRhpuj7POi4igEAwI1nr7OaJdwFUGdt8/eawyN6JDAEzro7GaLE4J5?= =?us-ascii?Q?W3EslNzIuNqqpolowOPa2WOZpc7e8P2m+TCtd+QWWmgs1hBhTUj6OemGvXjl?= =?us-ascii?Q?sYk3NtabqtissOae2STfnAhdilQMafoyGhx+0FuDOZjIjlu0GifaX7C4TFUl?= =?us-ascii?Q?RyQDTIM2hoizBekBFulMbxGwg/1Vj2rGol5x4AFYqreOe9ndHteo4sLcRMiw?= =?us-ascii?Q?o8MNJcFqxNV4d9caU70WXxIZgnf7HUlnqMfKCz1aRTmogVsSgzJG8egSU3A1?= =?us-ascii?Q?soVk1A0PSiY4DjBgUMwNhm9GNWgEV3ld+uLxJEwyKhk+AFwXfn1qH56dLFhS?= =?us-ascii?Q?GdbqTMP972ZqQyctHQNGzXeiQ6l7oAWagd2iiIjJsB4Q6TecCfhPdNV7HW9P?= =?us-ascii?Q?U3+ckSyFFItEUv/oAJKHmeEI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd8653a-b6fc-4dac-dc7b-08d927c173eb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2021 01:30:07.5210 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AyJlysooDqxZ39WXE2acLMrLzi+kGGRjGoRxOEJJwJYT3KM+WjpUl5J3r530peK8Eu4g1zXD+xcfJ0MyJu4q7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1998 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cool! Thank you so much!! It answers my question that why CI cannot detect such failure because it's= using GCC5+. Leif, Can you verify that this can resolve your GCC49 issue? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Saturday, June 5, 2021 9:19 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Leif Lindholm ; Feng, > Bob C > Subject: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue = to > convert the image to ACPI data >=20 > With GCC49 tool chain, aslc file is compiled into elf image. > But, its text section has no CODE attribute. So, it can't be detected > by new GenFw tool.For this type file. its text section is not required. > Its data section will be converted to acpi table. >=20 > This fix is to remove assert check when the generated image is ACPI data= . >=20 > Signed-off-by: Liming Gao > Cc: Ray Ni > Cc: Leif Lindholm > Cc: Bob Feng > --- > This patch has been verified on GCC49 for AARCH64 platform. >=20 > BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +- > BaseTools/Source/C/GenFw/Elf64Convert.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c > b/BaseTools/Source/C/GenFw/Elf32Convert.c > index 7c8a065678ac..314f8233234d 100644 > --- a/BaseTools/Source/C/GenFw/Elf32Convert.c > +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c > @@ -435,7 +435,7 @@ ScanSections32 ( > } > } >=20 > - if (!FoundSection) { > + if (!FoundSection && mOutImageType !=3D FW_ACPI_IMAGE) { > Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' section.= "); > assert (FALSE); > } > diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c > b/BaseTools/Source/C/GenFw/Elf64Convert.c > index 8fe672e98448..8b09db7b690b 100644 > --- a/BaseTools/Source/C/GenFw/Elf64Convert.c > +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c > @@ -714,7 +714,7 @@ ScanSections64 ( > } > } >=20 > - if (!FoundSection) { > + if (!FoundSection && mOutImageType !=3D FW_ACPI_IMAGE) { > Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' section.= "); > assert (FALSE); > } > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20