From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.1430.1626162283315511098 for ; Tue, 13 Jul 2021 00:44:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=k+XRCM75; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="197302770" X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="197302770" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 00:44:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="649231416" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 13 Jul 2021 00:44:38 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 00:44:38 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 00:44:37 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 13 Jul 2021 00:44:37 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 13 Jul 2021 00:44:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQ5ilyqAdatwoyhhV/AhrFrgV354952YCZ8J9VxXdUVY0YRqbY+bB/v1f0O6TCFjPSzPxR7UfWZmM/8ljqu7hRsVV1p+ev+6/PvlWy4ASbo/SwGgibQ+Q1knllsvbT709wpyjKqsb4878kKSHWbUkx55NDpXfjfbyS47G7Wc27xF0BuYHtlb2o15dA2i0gsbMCe3BQXuNkX0DSD913eWJSdi+iW2DVCRXH8snB8rwmfepTwYTnJO0xDwsLWfu8Urf9Tya9qOoFUKp0mr/bfLsFFwmiytoD/1GmqhzKJ8p2v6NrTeIGkxfsItcvGnbZkSYxX8mFaDHxO4pYAhiopfRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDk6kW+Za2WK0caKyzAf8pcdWbWqCRRDS2Rci4oRek8=; b=NIjz/bpgIFCkapbQlm8gIQpZpV7tK/dSURkWO+fAShwVwdRP6etQsDGlY6ryx2YuK+ZzmboHIbRq+PakO8kRpXJDbp49j9IORpj0T4e1f8SXVdIzVfHoDF0YgaVZKNBqDfGcWV1FhvvwYV+mYf/BdK90v2TYR5p632wIeiXnejYcfBYW+svHktcKyuYJ8VZsv44bRae+bBpA/4YUDm6Yn5R/XuHTwRUYiufCYLy+N222GCE9MbOdSAGopdP3q0+IHzFWktOkuA6EpyCeb6z685H44TFO/CpC8FvchqnuYmaIzvceatMWZM+w5F5jqjKEf01A5rkuntXGg3Ig7X5d3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDk6kW+Za2WK0caKyzAf8pcdWbWqCRRDS2Rci4oRek8=; b=k+XRCM75f2lotX/JtoQ/RdsUx+Izjxl/LkoHebBYYefxfQipV34ljkLz/Uxsd7W86GE5mc0GIOXzFz0pZDWUVIK/Klb667mmT9aDDpiMO8MWlBlzkg4D9HVG/QU7CQdvO5JnRQW8PTs/c+7rVDhIzEm6apAYNSad/YDgtnEG6ZI= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1614.namprd11.prod.outlook.com (2603:10b6:301:11::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Tue, 13 Jul 2021 07:44:36 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869%2]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 07:44:36 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData Thread-Topic: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData Thread-Index: AQHXd7eUTQZie4LE7Eu5TKhOPrKrGKtAhkHw Date: Tue, 13 Jul 2021 07:44:36 +0000 Message-ID: References: <20210713071913.1060-1-dun.tan@intel.com> <20210713071913.1060-3-dun.tan@intel.com> In-Reply-To: <20210713071913.1060-3-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c2efcdb-3ae7-4632-1b03-08d945d20fee x-ms-traffictypediagnostic: MWHPR11MB1614: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PWMCOylkPE5WaaQu1iXnDGn5ReHxw1JAqsSq6XYdwMOHSQESTXonrZG3yLD30bGA7J3Sv9cHuYlIoHM3hQwxMd3G7UdgTnYQVBzeuVGCqYrH24DciUp7tyN0mS3DL7i9cGI1Dz7qS2rRdyFugmC3VLdJfE5AoW9PI+VgjQ2YDribCiRtePl/m3pEczcDAYWgp5iMDNeysro3SpKTaDH61P9yWbF73DeevNCHtqHky3wA0l10fI2bUNlWNt8fncXV/r+R6Rva61uJcTH7O+E1WFYpJp8MDK1x/3W3SF7WMm6DaYyQbhlQ+P13Ha5FuYgZMp5My7lYsj/aQgv/crK7KTqDrPjt881vvmrSgvFVa3fEtlvYunU4dpLYS6owdTfsBJVcTRQUm+csoUWI6hOi3o4YKnCRwsQzWerg5GBvRedjt/7PTukkclFd3ewNi9I2flOCNsaBjm65xI5Czk+EDOY3/PRkm7nWemaFA2Ny36j3i27KpXBiUHVtCs+lRCx6UnNlTNbZWAcCemIqCT8JXa16qwSVR7egpmXsL6pYsVT31vtm6F1frd+loKNOfAHtiqmSc67F1QpyG9LPeO5aLN51udFJWWWOh+KtDyKLcO5i8XqSizOyloBr7alyS9VjxNJ+2j5W4hq7csCbSPWRHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(366004)(396003)(346002)(8936002)(33656002)(38100700002)(4326008)(26005)(316002)(86362001)(186003)(8676002)(53546011)(6506007)(71200400001)(110136005)(107886003)(66476007)(66446008)(9686003)(66946007)(54906003)(64756008)(5660300002)(55016002)(478600001)(2906002)(52536014)(7696005)(122000001)(66556008)(76116006)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GvHffydcv77HFOWpZRsuwgaLOOIjuAj9256ViWxJWxTcsXOnJnxMP35Ohe8Q?= =?us-ascii?Q?N+vQ33BvWnggJptAGBLFDCKwtSvb/3gp5izZX9Uk2IvhUrIZGIdJ1P6B8TQ0?= =?us-ascii?Q?y60Ig3cQTDfzRKsOOBaHXtWPaSKzVh9tTqV2fFDWqb5krQz6Jyolv5K4+oM7?= =?us-ascii?Q?0EspTLpPkIOxoUIF3AX46mmUj5dKvSZ3YxWgHMCLCFU+qnAYXydcT4B1F4a7?= =?us-ascii?Q?eR7B35gmtcNCQ5uW/4FIl7uYdrraUyjm80xnDr+APiWxCSrGSFCKSu02DR5d?= =?us-ascii?Q?XwBs+fvoHbgl7qzx6TWZz/8eLFriFggN001n9a35ibYttYNeh5ubgacDsD1M?= =?us-ascii?Q?zZ1Hm47JJKWSX1nQSigxC36bm8RysVJHBnfN/q1WSLDvow+MZI01m0Tx4goD?= =?us-ascii?Q?oxeFDqTxiRoUcefEMJ+xePL+lZPCXaQih5mq/KQcLk4JPL03Z2sQWS2jSiMP?= =?us-ascii?Q?rnOQeIHIqY5Yvd0F4BGQf9bsNZWa41aYjCGdq6YgBFMN7SMeLUMaObb8uz+m?= =?us-ascii?Q?hX7DRMpG5kScITwsUUqOeuvElDWhx4jfywr9VfxHE5kBmOHTjvhSO6t6js8X?= =?us-ascii?Q?hKTTA1VKJkeLKm4hYOIWQ3BNvqTpsabEE8O3vYKkS5cRe+4l2uKPj5v1YvsS?= =?us-ascii?Q?HtIiwiUkrU8cCf9fQ92donZkn35Ln0acQGTXAwCNcTVGVn/HiKBNG7H21J03?= =?us-ascii?Q?OePcdGWPm5A+X3Bq+QvMgucMAoeuJ4B5ufpgW4ndvml7y5qV5AvOGpvzW69z?= =?us-ascii?Q?ZlPPwZpfdYT8kZbIy19cXQNAfUCm/Wg9Wqvt9KcaXp5SSkG7YCMlNAu3Arur?= =?us-ascii?Q?cDdyeNXLEf1rGgtbD06WSmQR/maSsNZGFr+uiJg14tD4VxKIpi62D8B13ixo?= =?us-ascii?Q?V04cvgKXFFvUJJDGW3551iu5AFgImsi1JSGtmxmlnxtj47Yejf7t0JjoyR3A?= =?us-ascii?Q?Y4Y5MfPNIjDCDyg9/Tl7VOtQd8k1TbyG2FTHTK18PBkBYVbPhdnjmhJ317cI?= =?us-ascii?Q?MXElObNYGT11VvPcWVaxg2ACcp/cWi70gnmdqAw2kaTIIO7swrcqjZuAja0B?= =?us-ascii?Q?RN7/knMo41KwDJ1X24Ni/as1OxFyAaBX0QZccuRQ6zBNLxZME2BHXeLd6T4l?= =?us-ascii?Q?S+bEocxhcFW9WeVpnb3R9lEROVXccxWHzCv8vpiIFTzEqlx+aINMKzxP6IcC?= =?us-ascii?Q?bzlf4gMzHGa93nlW/0nw89yMcmLHqv33B+a/bHKT35XL/V/JbdLKaVPorXlr?= =?us-ascii?Q?Kymmq+mZ5xPuW3ZFNJNNWPgaKX9z1QiE8teAhhjVxx/4ZERUJryKPB71K4co?= =?us-ascii?Q?aOxgl8iN1sSbGhNf2cyl83JB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c2efcdb-3ae7-4632-1b03-08d945d20fee X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 07:44:36.1192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /YY2dOG5dchOF2HkMgp6WJE13o/wkdYLnq8ATbZB4kZkfB+qiv347+f/MOCRVPJlBULHdV4EaM8oKItrrlCXFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1614 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Tan, Dun =20 Sent: Tuesday, July 13, 2021 3:19 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice= ; You, Benjamin ; Tan, Dun <= dun.tan@intel.com> Subject: [Patch V3 2/2] UefiPayloadPkg: Assign the length of UniversalPaylo= ad ExtraData V1: Assign the length and revision of UniversalPayload ExtraData V2: Force int to UINT16 V3: Create a local variable to hold the size of ExtraData Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan --- UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c b/UefiPay= loadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c index c619470dbb..141ce86b46 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c @@ -56,6 +56,7 @@ PeiLoadFileLoadPayload ( UINTN Size; UINT32 ExtraDataCount; UINTN Instance; + UINTN Length; =20 // // ELF is added to file as RAW section for EDKII bootloader. @@ -105,11 +106,14 @@ PeiLoadFileLoadPayload ( // // Report the additional PLD sections through HOB. // + Length =3D sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * size= of (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY); ExtraData =3D BuildGuidHob ( &gUniversalPayloadExtraDataGuid, - sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * si= zeof (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY) + Length ); ExtraData->Count =3D ExtraDataCount; + ExtraData->Header.Revision =3D UNIVERSAL_PAYLOAD_EXTRA_DATA_REVISION; + ExtraData->Header.Length =3D (UINT16) Length; if (ExtraDataCount !=3D 0) { for (ExtraDataIndex =3D 0, Index =3D 0; Index < Context.ShNum; Index++= ) { Status =3D GetElfSectionName (&Context, Index, &SectionName); --=20 2.31.1.windows.1