From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.2977.1628562614970633714 for ; Mon, 09 Aug 2021 19:30:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=A1pHPEWz; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="211715015" X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="211715015" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 19:30:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="671467778" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 09 Aug 2021 19:30:13 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 19:30:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 19:30:12 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 19:30:12 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 19:30:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CfVzyJZzQR9JmF5bGogsjbiooMnf9bwWt+WB0xPpU+q/T+o+cnz1GUBPubD6GazF37yLzPMcB3+2v5o6r4GlK5uC78+124g8jA4bFSlb+ryG9v4vtosfCylfWGfJeBB/4qLI9l8zpPkqyWzDr6WCQdK6qBHr8D4LRc1bRfkmI6HGT4AoeYL7N2l1DUiksrVN5vShZ6Dg/D8y+OEbCqaPgYGvsWndsI/NjpyRLF2IK3Tf1wEqYrnAkm4STCG5vGB9lkuAMtym1CMo8fC65ggVhVbS7Cuc9VfpNcEu7iSPfS9ccyyB019ntYbRoyU7gPRyAMgX74CDTB6npCjGvMKoTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ImnjZ1gyXBiXfErUJ14y79mhks8O6Cu8iYSyYhoDpI=; b=Cl/bR1nUPZg8K3IlW5iDf5C6MGttjLkpITvuzo8Dzktn/DuJ/Kt8J+9L9J4eNJigFWIPKMnMvOzbo8QnXSeBD0d5JQA7AlcICi/xq4pK0JHR8/LfYzKavGiabDKARCqW3fgmirB0zAVS6WNIgOydTuWbpJ82x7Z27BryCTRd2Tgfenps/dqEwKPCLwfZ/4GHEG7JdApQ4kvrAokWJ08cntzbuGxtFbDFPkE9R+HkeMFeItQO/u9/8UrcfHcKKnvp5wQHuzjgoV8CZp0NJiPPQ0BD/pZOtGwNwZt0rL6JYMZDCXCO9VHu/8xvTfHlFagdSKOxp1cN+GwC8yJ8VB7+gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ImnjZ1gyXBiXfErUJ14y79mhks8O6Cu8iYSyYhoDpI=; b=A1pHPEWzwP9SXF6Lc1LOOKEoAoyQc9pOVtorVlYg+HmBDqreGJaIe+8eb0tvxDo8+dzk3ufQQy9tAl9Lc3wmGDoRTR9umph30N+6ZQjjc6ATZ8E/CXxWf1WvfCtM+Lr/uZX9Riia6A368Xl+cXu5FpiOQBQa40g1jjqvpHkKj70= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1661.namprd11.prod.outlook.com (2603:10b6:301:b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Tue, 10 Aug 2021 02:30:11 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865%5]) with mapi id 15.20.4394.023; Tue, 10 Aug 2021 02:30:11 +0000 From: "Ni, Ray" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull Thread-Topic: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull Thread-Index: AQHXjSkjEfuxZmmn2EetFe+Om1P0XKtsBHPQ Date: Tue, 10 Aug 2021 02:30:11 +0000 Message-ID: References: <20210809141554.2568-1-mikuback@linux.microsoft.com> In-Reply-To: <20210809141554.2568-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c20457c8-599e-49f3-0b39-08d95ba6c75c x-ms-traffictypediagnostic: MWHPR11MB1661: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: esMdRrqXWEueuWDzGYft/Yt6QD/P1xkhzWELjAi1k1XlgarpClBAausuko88EydxDPbQczTfKaWohPlRq/Pwo+b8ulRg2VzFcYcu0XZlVMttWOwTYUJDgeCIypd52YhsanNesGbOeWI6ThlYVuscCJnu9w/79s7iisCGbOM1hxRaEx1toEZ/lFZSKW2bM0nOp3/WjrJscrlk5aYemqDuAdji68VilpU/fRRnLhWN7v76dwGoV1NeAMDqV61VyJtR8rgTRWl7viSIigKmWT6Rifv34nnaIGtIF7vSjTzLNABCJszPEklhAs87K76HBzm2PdluLT+FqdGTvexekJ9ukzK5udDLcPc08ELYG/8crQFRHymBkkU5HeNYsUodJMBm0wxvrjMG6x2jF/iUnJLsShwHAbU1CVwaDAqCAQCftbgPurMtQH1KJ6+Es6/GlpsZVwoJ+Uyx5suP8fiLbtycrUoXsvI1a/Xtogw01LyQdKcMbee90+QkfRtTo9RggedgJTzpvT+cgqc/kx889seGFslfljbjks/dJt0Wy2qJ8gRrPAfa+ecUY5Xpcm749JWpWcxv4D7AfZDgf4++rPM+OsSYxfjVs5aeSY7UE4h2O3ih9sSHC5Y0UPT1G4h1DylG99tgDIOhZm1Sa2/vCgtWR2319eRHygFHh6Pp1FkWUZligRLt8kW7pbErPdPRDC/hXpPxzCRK7Wn/ecquXo9daVqB7E8uQZaOuRgUDEY1lJLLFa5o6Nnx4UD+sVx3DKNen6Trr5nXyHpDE4ov0iBZKE/5f/oA0Bi3xdTz2Avmi1rEXsO1fg3KT045EdDDRObZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(26005)(76116006)(66446008)(64756008)(66556008)(66476007)(186003)(33656002)(38070700005)(5660300002)(66946007)(83380400001)(110136005)(107886003)(4326008)(7696005)(45080400002)(316002)(2906002)(9686003)(71200400001)(6506007)(55016002)(52536014)(53546011)(8676002)(86362001)(478600001)(38100700002)(8936002)(122000001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7wrqIRryS1jbys4R5kFeCQnFqFjJEh/95CP2oI3976e/kMKz87vS+mg70dKO?= =?us-ascii?Q?sQTizc/s6FgKpSTLzBxVmEP2FBTWW4CulGKAZzwe+gsR2xa/NuQ5xgemWMKm?= =?us-ascii?Q?1EcPzfcnC9Dd8x4wZiPBbopj3tOMse2CfSSAvGY6j0ZRirEhvtgJuFivarZb?= =?us-ascii?Q?qOqbfqEKWfQkfPN/uVK1+gwzf9O+3au25xGMTB8aO5z3ttBWFYU0k1N+dnJc?= =?us-ascii?Q?4oRqIPNp1dSKxm0Ls+KgjoCtqfi6s5t1mkeFrXJHhXg/gwIH+1t1Engb/BCY?= =?us-ascii?Q?8RaAY/T2IB8j3tRi7A/VyfpaIPbUYyHq/TX1hyciCDzYC6k5bVeVMgb/PUrE?= =?us-ascii?Q?wzu3hO/Di7w5cjp9mVS8flPsQqC1ux2lM+XnzYihi8xRB0nq79HTnC7grBvg?= =?us-ascii?Q?zw0bm+19XBSmzXYSuPvaPmhmtxEDVdx1lwmaUIJ0dqNouVMj543s5tdYTYUw?= =?us-ascii?Q?D8LA3WurokCUNZlly/qI75plBZoR2qO4Voslpwhg/1w9tLFavdlbxIeS9OkV?= =?us-ascii?Q?Exk6ha/UgZ4iJ9mNEwF+f7J33ots1j8i35z/SXfiUdOhMTifG2JeVCgHC0Ta?= =?us-ascii?Q?VwVhaasBqgzkG6bbp5+U1DyBpgcv0lP90iK21oHWmEKCpmFJ8Vu6fPQ+jXZE?= =?us-ascii?Q?tZEA3uJrcV1lvWcbENFivcBibrvjRmm39U8Aitfj3gymhoYDOOQfRnCm1dny?= =?us-ascii?Q?S2LLg+C52gA1RzCCU88tIgWhHz0rCKxEd9VcDuxreqbPyUJScOk1MO5bTq2a?= =?us-ascii?Q?11KCTm2HdN1BElan2SwOIIUy8dHknrLr6hOwGJvPDzEd90DVt9gy5uGLEBrx?= =?us-ascii?Q?boo/S2UzpfVjbeY0tyrQE+jUwPjfh0P4UPuJuYJnznMbUi07mDtQXG3amWLt?= =?us-ascii?Q?vrnDppt6X69I1hpf8pep1Fpnj3wDe4/p9rCW84HmuCWts3ZQjDG2or0BQMu1?= =?us-ascii?Q?XJohbIWhO9ep2jIzXKhHW0px5f1+EaW+ai4EC+3D+MQJF51a4TRnG1K4PjSA?= =?us-ascii?Q?LaPdcFCCilc2kN434MWwJ1623DNebC3/omAXpaXyGk4tVfUefQhZVpeuEh97?= =?us-ascii?Q?D4HU3/HG8BRg96RZgFjbjvuO9M3JcmV+ejPwUKPAYQO+JdFSNWjkUvkLIQe2?= =?us-ascii?Q?N/kt2ojS+G8+hj8hAWiDtTUEXl5zbbdBfw/FvKED7cNYV2HftSf5D2QYNl5m?= =?us-ascii?Q?xz6H/H6dfMZoeOCfW3RYZZzWT3/ep85bu2irLMnI4qaJS0Gsbc5n9Uo1ZA/6?= =?us-ascii?Q?/qizgXcg9o7vaxFSYfvbEOanrsnqvgGU5gfcMyDnytOoxxKvKJvbIR4qUdvi?= =?us-ascii?Q?wggq9d4IvVzL6a5WG+1uJS81?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c20457c8-599e-49f3-0b39-08d95ba6c75c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 02:30:11.5798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dubHOHC0adkABWc3kwTvXhebw6pN7b/rjzJ5xXigfrtQXEaAG0feNv/1uHLq1qgy+cLHUOeNSDplAg4SGjsLuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1661 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Michael, If your platform doesn't need SmmAccessPPI, you don't put the SmmAccess PEI= M in the FDF. Why do you need: 1. Put SmmAccess PEIM in FDF 2. Let SmmAccess PEIM link to a NULL dummy-do-nothing library I feel the additional abstraction is not necessary. Thanks, Ray > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Monday, August 9, 2021 10:16 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAcces= sLibNull >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3540 >=20 > Adds a NULL instance of SmmAccessLib. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLib= Null/BaseSmmAccessLibNull.c | 33 > ++++++++++++++++++++ > Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLib= Null/BaseSmmAccessLibNull.inf | 26 > +++++++++++++++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = | 1 + > 3 files changed, 60 insertions(+) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/Base= SmmAccessLibNull/BaseSmmAccessLibNull.c > b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLi= bNull/BaseSmmAccessLibNull.c > new file mode 100644 > index 000000000000..f5ad306b380b > --- /dev/null > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAcce= ssLibNull/BaseSmmAccessLibNull.c > @@ -0,0 +1,33 @@ > +/** @file > + A NULL library instance of SmmAccessLib. > + > + Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> + Copyright (c) Microsoft Corporation.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > + > +/** > + This function is to install an SMM Access PPI > + > + @retval EFI_SUCCESS - Ppi successfully started and installed= . > + @retval EFI_NOT_FOUND - Ppi can't be found. > + @retval EFI_OUT_OF_RESOURCES - Ppi does not have enough resources to = initialize the driver. > + @retval EFI_UNSUPPORTED - The PPI was not installed and installa= tion is unsupported in > + this instance of function implementati= on. > + > +**/ > +EFI_STATUS > +EFIAPI > +PeiInstallSmmAccessPpi ( > + VOID > + ) > +{ > + ASSERT (FALSE); > + return EFI_UNSUPPORTED; > +} > diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/Base= SmmAccessLibNull/BaseSmmAccessLibNull.inf > b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLi= bNull/BaseSmmAccessLibNull.inf > new file mode 100644 > index 000000000000..7fd3b0b89655 > --- /dev/null > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAcce= ssLibNull/BaseSmmAccessLibNull.inf > @@ -0,0 +1,26 @@ > +## @file > +# A NULL library instance of SmmAccessLib. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) Microsoft Corporation.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > +INF_VERSION =3D 0x00010017 > +BASE_NAME =3D BaseSmmAccessLibNull > +FILE_GUID =3D C1A14AB6-B757-4046-9B92-9DCE1A2154C6 > +VERSION_STRING =3D 1.0 > +MODULE_TYPE =3D BASE > +LIBRARY_CLASS =3D SmmAccessLib > + > +[Packages] > + MdePkg/MdePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > + > +[LibraryClasses] > + DebugLib > + > +[Sources] > + BaseSmmAccessLibNull.c > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc b/Silicon/= Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > index 1092371d848e..dd0928ec58f3 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > @@ -90,6 +90,7 @@ [Components] > IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.= inf > IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/Mi= crocodeFlashAccessLibNull.inf > IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.inf > + IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLibNull/BaseSmm= AccessLibNull.inf > IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/PeiFirmwareBootMediaLib.= inf > IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/DxeSmmFirmwareBootMediaL= ib.inf > IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf > -- > 2.28.0.windows.1