From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Lou, Yun" <yun.lou@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v7 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah).
Date: Tue, 19 Jan 2021 12:05:33 +0000 [thread overview]
Message-ID: <CO1PR11MB49301EC8C0FCD0ACE04D5B088CA30@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210117141541.3627-1-yun.lou@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
If this patch is not updated, please carry the original Reviewed-by tag.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jason Lou
> Sent: Sunday, January 17, 2021 10:16 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun <yun.lou@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [PATCH v7 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah).
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3105
>
> The UefiCpuPkg/CpuCacheInfoLib will reference new definition
> about CPUID_HYBRID_INFORMATION Leaf(1Ah).
>
> Signed-off-by: Jason Lou <yun.lou@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdePkg/Include/Register/Intel/Cpuid.h | 63 +++++++++++++++++++-
> 1 file changed, 62 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Register/Intel/Cpuid.h b/MdePkg/Include/Register/Intel/Cpuid.h
> index d4496079570d..dd1b64a1e50b 100644
> --- a/MdePkg/Include/Register/Intel/Cpuid.h
> +++ b/MdePkg/Include/Register/Intel/Cpuid.h
> @@ -1278,7 +1278,7 @@ typedef union {
> @retval EAX The maximum input value for ECX to retrieve sub-leaf information.
>
> @retval EBX Structured Extended Feature Flags described by the type
>
> CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_EBX.
>
> - @retval EBX Structured Extended Feature Flags described by the type
>
> + @retval ECX Structured Extended Feature Flags described by the type
>
> CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_ECX.
>
> @retval EDX Reserved.
>
>
>
> @@ -3597,6 +3597,67 @@ typedef union {
> ///
>
>
>
>
>
> +/**
>
> + CPUID Hybrid Information Enumeration Leaf
>
> +
>
> + @param EAX CPUID_HYBRID_INFORMATION (0x1A)
>
> + @param ECX CPUID_HYBRID_INFORMATION_SUB_LEAF (0x00).
>
> +
>
> + @retval EAX Enumerates the native model ID and core type described
>
> + by the type CPUID_NATIVE_MODEL_ID_AND_CORE_TYPE_EAX
>
> + @retval EBX Reserved.
>
> + @retval ECX Reserved.
>
> + @retval EDX Reserved.
>
> +
>
> + <b>Example usage</b>
>
> + @code
>
> + CPUID_NATIVE_MODEL_ID_AND_CORE_TYPE_EAX Eax;
>
> +
>
> + AsmCpuidEx (
>
> + CPUID_HYBRID_INFORMATION,
>
> + CPUID_HYBRID_INFORMATION_SUB_LEAF,
>
> + &Eax, NULL, NULL, NULL
>
> + );
>
> + @endcode
>
> +
>
> +**/
>
> +#define CPUID_HYBRID_INFORMATION 0x1A
>
> +
>
> +///
>
> +/// CPUID Hybrid Information Enumeration sub-leaf
>
> +///
>
> +#define CPUID_HYBRID_INFORMATION_SUB_LEAF 0x00
>
> +
>
> +/**
>
> + CPUID Hybrid Information EAX for CPUID leaf #CPUID_HYBRID_INFORMATION,
>
> + sub-leaf #CPUID_HYBRID_INFORMATION_SUB_LEAF.
>
> +**/
>
> +typedef union {
>
> + ///
>
> + /// Individual bit fields
>
> + ///
>
> + struct {
>
> + ///
>
> + /// [Bit 23:0] Native model ID of the core.
>
> + ///
>
> + /// The core-type and native mode ID can be used to uniquely identify
>
> + /// the microarchitecture of the core.This native model ID is not unique
>
> + /// across core types, and not related to the model ID reported in CPUID
>
> + /// leaf 01H, and does not identify the SOC.
>
> + ///
>
> + UINT32 NativeModelId:24;
>
> + ///
>
> + /// [Bit 31:24] Core type
>
> + ///
>
> + UINT32 CoreType:8;
>
> + } Bits;
>
> + ///
>
> + /// All bit fields as a 32-bit value
>
> + ///
>
> + UINT32 Uint32;
>
> +} CPUID_NATIVE_MODEL_ID_AND_CORE_TYPE_EAX;
>
> +
>
> +
>
> /**
>
> CPUID V2 Extended Topology Enumeration Leaf
>
>
>
> --
> 2.28.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#70467): https://edk2.groups.io/g/devel/message/70467
> Mute This Topic: https://groups.io/mt/79750873/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
>
next prev parent reply other threads:[~2021-01-19 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 14:15 [PATCH v7 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah) Jason Lou
2021-01-17 14:15 ` [PATCH v7 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib Jason Lou
2021-01-19 12:05 ` Ni, Ray
2021-01-19 12:05 ` Ni, Ray [this message]
2021-01-19 13:17 ` [edk2-devel] [PATCH v7 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah) Jason Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49301EC8C0FCD0ACE04D5B088CA30@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox