From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.4046.1621484674657460444 for ; Wed, 19 May 2021 21:24:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=aglaM2NC; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) IronPort-SDR: xX9Eh01LiMwxVd8QCbY1zCemeEHqqa6YpQslpw3rf0+FQqJyHW+1PXmxJ59jEbGQHpTGv5zxGE GCDBQjFdKHLg== X-IronPort-AV: E=McAfee;i="6200,9189,9989"; a="198048704" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="198048704" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 21:24:33 -0700 IronPort-SDR: skuDRmh4Ye2WWwk4FA1sQ18XySWr5lsJyxVj3LNpWVtxMPl+nHH4y3v0whPCYTYsaUL2uwP8SL BisuWA9ItrYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="627941725" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 19 May 2021 21:24:33 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 19 May 2021 21:24:32 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 19 May 2021 21:24:32 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 19 May 2021 21:24:32 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 19 May 2021 21:24:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNygKdW8E/KXDdDDDXQes8UMvgufF+20WkhSh3PMoNWb85SR3nHMorhF5+DyTv7SaUppy7wunHS2Sy4tH/IDdLuaclGqBAci2rpQhZaGiABTEoMWg9G65XxqBwtUZN96gH2ceyt9bpPw1TNU0VCg0RX60ks1fU9KhKYp6ocWbj2BLeFQk0StKEtUpbx6tSx7NESONPSn8Satyb7BVsJPUh5LkAVjPow8he1SgSne8oVa35vMkcI8qkq95WqEc8uhoqDEVzpRwjzJc3jhP9rdNsEEOLPwuOj3UHwKP+UJ7RdIGxnyGVIpUJ32vKLOXVG4lqykmFxVovKz96EjIEQkQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LmUTX2wIEpSmZTLHgFmxk5RYQ1cbOG5uqDbLcYRyIiQ=; b=K0UBy60ikft0snrgR+2ciRnCDenlXAszDPFoZaUvK0ORHosRncXHBNjZ6aioFsoFza069fZonsNKHhE+2OlFqp+VtSr3ZjZ3WCfnD/qErswOilVj5GfRwhJzTcPkXyglBrOZDfXScg56AT85O5xubRZP5/qz+XY+ORpjLjZc283MtRS/OfxZmPEdZoP8kIxf0VbPUg6v1lv8tXZEoqdzL9Shk41epez5DgeDtagRS0Kje/+tJKMYyPbHzIIJi39mqjwvmLxr0ekA0oXUIoSNc6is5bhn/a1I9geUnbabCugKpDq4m8jiYlTytz5CQtDg81qOKhu99EWElUMq9z+Guw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LmUTX2wIEpSmZTLHgFmxk5RYQ1cbOG5uqDbLcYRyIiQ=; b=aglaM2NCBZfHSIA/Nrmf+Lp6TjGUjR+9m6Y/xvxfsVHSGzLkhKAj+BR/8po1ce6IPlF8iO0Y+/d1LCYTXBUpdwSzlUozoHWnElsjX8EvIiA3DukNkdtR6b9ZD0XArJH5pnwuv6gkmesZLEEvl7dTYgHxQYNpOdn3l2NG/U/xhJI= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MW3PR11MB4652.namprd11.prod.outlook.com (2603:10b6:303:5a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Thu, 20 May 2021 04:24:31 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7%5]) with mapi id 15.20.4150.023; Thu, 20 May 2021 04:24:31 +0000 From: "Ni, Ray" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chuang, SofiaX" Subject: Re: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Cast UINT32 to UINT8 conversion in ReportCpuHobLib Thread-Topic: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Cast UINT32 to UINT8 conversion in ReportCpuHobLib Thread-Index: AQHXTGWwmswB/q8p7EKtCBZcD6k0larrxvJQ Date: Thu, 20 May 2021 04:24:30 +0000 Message-ID: References: <20210519041530.1368-1-mikuback@linux.microsoft.com> In-Reply-To: <20210519041530.1368-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53b06cec-4fb9-448a-21e3-08d91b4729fe x-ms-traffictypediagnostic: MW3PR11MB4652: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B/4gT6K3z1DWR09rAMwGoFDNSm8Dk3sz9ZTAwt6sqVFEDkZEwFQyGBRKVyBi+c8SnQnMVtz+JyaPveR4tOaHHZb4Oqw6w+LeNhukhWflglu+Gz0LxppihkL0t9muH4/sU0uwOSaNNO8d3OqOuXXXHPTW/8esUe0LwbewWu+QF0JYjQSUvjj26+yhNvcaSFn4bCSJuX4g5JrVhnMzJhlW3MwMjuljOPha3yLJjPTAHpeXzmx05zlE3houfYzryhYKkelsy2DXR24toHspeZny6es4ZbjAzpdBk/YcPGw4MyW+CTOhRliVg7UDyAyY+Y2HGV3CKAsn7ZqUsNftP6b/9dzQeIpHGsP9XR5tm9JTKIeA61dE0fE05VEUo9gXHx5J68QfqrT+mPEB9wR5MbB/dc0HmhSL6SJxsqlc3O62Csmw7bVp2B4h1yHzZDHySx5baX8kTLxKEcjvHrf6Zgv5WOnPPRSa8pSXmDCZCF3/SUepfNb4afj+ZU4+KaWZIhQmEAjBndPk4NrLm4v5IKX+/MEzhrHOzFTo9HVIlM8SPRoxdMZgmJlzmHsFLPVThXX5ETBPVk3IJrmIKc4tfWaWIQQELAWjVH1vvgHJnPXM0PqSL2e39BHrVw+nnbPuf/FqAOztfbQAvIaXZv/OpEsx/qTJMSj/IshF2/PmEIawiW8Bq/NB2wAX/pH7gDEVa47+ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(136003)(366004)(39860400002)(83380400001)(86362001)(38100700002)(122000001)(33656002)(26005)(8676002)(8936002)(71200400001)(76116006)(6506007)(4326008)(66446008)(66556008)(66476007)(186003)(64756008)(107886003)(53546011)(2906002)(5660300002)(54906003)(55016002)(9686003)(110136005)(7696005)(316002)(66946007)(52536014)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?N3yRyAxoJbq1NJNMklCCLn6LeyPuYrl/GmRlAgJQU/0+7z+RKiqtieyQsyjE?= =?us-ascii?Q?HtsqUqJN6AxtDX5TbkUAQyvHY39OAAeJ7Qyd6oGn6ZfZCYGVXPNl/JTibmxc?= =?us-ascii?Q?Z7vabWK77bHyQ/8H6O+cYWvQUE0xd6aa0WFe4lhUVzJydlWtJFNxn15BosPO?= =?us-ascii?Q?kfVWtIl/pxnXJSXhPdJW37m6i5SxLDNSNC5fZqFChft94OEBJRwU5gLkAob5?= =?us-ascii?Q?J5wvuUeHiy/97fHUnvS4CIIi8AU8PI0+BGQ0A8eIru07GceSyBxVk/vmkIXI?= =?us-ascii?Q?bMdK8GR1FPJ0yUst7lk4WFwB1uH/910LFXnkNQZoun8u1QUpDjsVX7aJZC3v?= =?us-ascii?Q?A5HjS+UG8AkNN2RM2Xkyu5GTBr+qeuWsPWQ6709t3Cy0eVyuaGnHNeNwIq5Z?= =?us-ascii?Q?u+GJi/5fmORZkiebbLnDCFLk6oJT+HzoHy1Ym6LZLvJ5YlsOKaV+KbUhA26U?= =?us-ascii?Q?Pf5HJa6QGQ/HB5YvBZdCwLWqXW5KWxOKZKM5yH2OpNkBsIugdxDDfklcgTov?= =?us-ascii?Q?Uu7Gwb42CdCd8vppGeCQ/yXLMejxKVAxv9GCw5rErc3Kx3p6kPHLqB6pM8CU?= =?us-ascii?Q?zhmeGtbo9GiAKFr5pomanI4rpvzWXHRl1YvOnhcnhDdicca4UWDtuKgVByul?= =?us-ascii?Q?roDFXRsuYRPzqZJ6ZoKTmSjEB8JJ9QSohxRPo0Uo5rhgwBQ5TGY8I+WFkbrJ?= =?us-ascii?Q?4BzbTZEWfXgdhQTZuFwcqe4WmukWa4I92Y+e3txvsE9rwtUT4ClsqZSP6tO+?= =?us-ascii?Q?DbGg0L+fehgU/+ZM7JWNLBvQP66IQvJFtOqPpQzgxPz2D6UYIi81vtKkFVmf?= =?us-ascii?Q?pDBYoblZe9rYtySE4BtgGr9e3igM4MDd/Uyn9TuCKsL6Ooa2yFJX94buGPGr?= =?us-ascii?Q?9Kvdl23PNdJy17f7foM8Jhpz3s4YGIAoFDRXLWlYcFMQn1vCMG3b9FnJtpM7?= =?us-ascii?Q?AKl5UIK2WFi+JSslj+vkOk15T3H/R16/QSgg/k38XsMzpV3Tesbb4+tnvdXT?= =?us-ascii?Q?8N8T4x1ZTPYuVypoh2RcZUHDqCGUlr0f0ZSMleaDnZQy3Rjm9xvsxwGApT4v?= =?us-ascii?Q?4A0SU3w8ZLNFPPjyZ8RLMtoymLuuf67QNn1tsjutDuywtzSOLlQm8FdAGAtI?= =?us-ascii?Q?JVUgfh2RoiCRJ0dv9AuH2pVDeS2uBayrkZQ+AU8Ay8oTn1AUHV1NQCYzcyD4?= =?us-ascii?Q?RgXtneZmP/8VfBzca9mlXPXmKH7z1CruaK7Ctvg1uc7IPQaVGgjcpInPjNUg?= =?us-ascii?Q?xKj/GEN3bvkk3fLGHeQA9OwBxgcVA4nAA+yI1nH7HrQM6zgkHmZ+SS8ewIid?= =?us-ascii?Q?wUARAPGjW/yiiFPC/q+RSo7G?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53b06cec-4fb9-448a-21e3-08d91b4729fe X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2021 04:24:30.9310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KDn5BbxOedX2Y0JiMJ+Jkt/CyygZinjp1jJJxNzpgmpQ8kTgof8mMV5pTyuK99RRHbpOr9JhFFxYdCVrHhXIIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4652 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Since it's a pure a build failure fix, I will merge it now. > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:16 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Chuang, SofiaX > Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Cast UINT32 to > UINT8 conversion in ReportCpuHobLib >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3404 >=20 > Commit d3c10d3 introduced a build error in ReportCpuHobLib.c: >=20 > IntelSiliconPkg\Library\ReportCpuHobLib\ReportCpuHobLib.c(30): > error C2220: warning treated as error - no 'object' file generated > IntelSiliconPkg\Library\ReportCpuHobLib\ReportCpuHobLib.c(30): > warning C4244: '=3D': conversion from 'UINT32' to 'UINT8', > possible loss of data >=20 > This commit explicitly cast the assignment to fix the build error. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: SofiaX Chuang > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c = | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > index 3f67b477d25a..56d63a35edcb 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > @@ -27,7 +27,7 @@ ReportCpuHob ( > AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, > NULL, NULL, NULL); > if (AddressSizeEax.Uint32 >=3D CPUID_VIR_PHY_ADDRESS_SIZE) { > AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, > NULL, NULL, NULL); > - PhysicalAddressBits =3D AddressSizeEax.Bits.PhysicalAddressBits; > + PhysicalAddressBits =3D (UINT8)AddressSizeEax.Bits.PhysicalAddressBi= ts; > } else { > PhysicalAddressBits =3D 36; > } > -- > 2.28.0.windows.1