Re: [PATCH v3 2/4] UefiPayloadPkg: Use legacy timer in Linuxboot payload

["Ni, Ray" <ray.ni@intel.com>]

can you explain more in commit message why HPET may fail?

> -----Original Message-----
> From: Cheng-Chieh Huang <chengchieh@google.com>
> Sent: Monday, August 23, 2021 2:33 PM
> To: devel@edk2.groups.io
> Cc: Cheng-Chieh Huang <chengchieh@google.com>; Dong, Guo <guo.dong@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; Trammell Hudson <hudson@trmm.net>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> <benjamin.you@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v3 2/4] UefiPayloadPkg: Use legacy timer in Linuxboot payload
> 
> HPET timer may fail to init after prior linux taking over.
> 
> Signed-off-by: Cheng-Chieh Huang <chengchieh@google.com>
> Reviewed-by: Guo Dong <guo.dong@intel.com>
> Cc: Cheng-Chieh Huang <chengchieh@google.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Trammell Hudson <hudson@trmm.net>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++++++
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 5 +++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 54576ba485b7..e56e6f4a5379 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -438,7 +438,13 @@ [Components.X64]
>        NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
>    }
> 
> +!if $(BOOTLOADER) == "LINUXBOOT"
> +  OvmfPkg/8254TimerDxe/8254Timer.inf
> +  OvmfPkg/8259InterruptControllerDxe/8259.inf
> +!else
>    PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
> +!endif
> +
>    MdeModulePkg/Universal/Metronome/Metronome.inf
>    MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>    MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 041fed842cd8..f57a8b4bf3d3 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -101,7 +101,12 @@ [FV.DXEFV]
>  INF UefiCpuPkg/CpuDxe/CpuDxe.inf
>  INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>  INF MdeModulePkg/Application/UiApp/UiApp.inf
> +!if $(BOOTLOADER) != "LINUXBOOT"
>  INF PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
> +!else
> +INF OvmfPkg/8254TimerDxe/8254Timer.inf
> +INF OvmfPkg/8259InterruptControllerDxe/8259.inf
> +!endif
>  INF MdeModulePkg/Universal/Metronome/Metronome.inf
>  INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>  INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
> --
> 2.33.0.rc2.250.ged5fa647cd-goog