Re: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Tuesday, March 23, 2021 11:25 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI
> 
> MdeModulePkg\Universal\Acpi\AcpiTableDxe\AcpiTableDxe.inf is capable to install
> ACPI table contained in HOB. All ACPI table shoulb be managed by that module.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c   | 13 ++-----------
>  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h   |  5 +----
>  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf |  5 ++---
>  3 files changed, 5 insertions(+), 18 deletions(-)
> 
> diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> index a746d0581e..dfff8ecf0e 100644
> --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c
> @@ -1,8 +1,8 @@
>  /** @file
> 
> -  This driver will report some MMIO/IO resources to dxe core, extract smbios and acpi
> 
> +  This driver will report some MMIO/IO resources to dxe core, extract smbios
> 
>    tables from bootloader.
> 
> 
> 
> -  Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +  Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>  **/
> 
> @@ -120,15 +120,6 @@ BlDxeEntryPoint (
>    ASSERT (GuidHob != NULL);
> 
>    SystemTableInfo = (SYSTEM_TABLE_INFO *)GET_GUID_HOB_DATA (GuidHob);
> 
> 
> 
> -  //
> 
> -  // Install Acpi Table
> 
> -  //
> 
> -  if (SystemTableInfo->AcpiTableBase != 0 && SystemTableInfo->AcpiTableSize != 0) {
> 
> -    DEBUG ((DEBUG_ERROR, "Install Acpi Table at 0x%lx, length 0x%x\n", SystemTableInfo->AcpiTableBase, SystemTableInfo-
> >AcpiTableSize));
> 
> -    Status = gBS->InstallConfigurationTable (&gEfiAcpiTableGuid, (VOID *)(UINTN)SystemTableInfo->AcpiTableBase);
> 
> -    ASSERT_EFI_ERROR (Status);
> 
> -  }
> 
> -
> 
>    //
> 
>    // Install Smbios Table
> 
>    //
> 
> diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> index 512105fafd..3332a30eae 100644
> --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    The header file of bootloader support DXE.
> 
> 
> 
> -Copyright (c) 2014, Intel Corporation. All rights reserved.<BR>
> 
> +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>  **/
> 
> @@ -19,12 +19,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include <Library/IoLib.h>
> 
>  #include <Library/HobLib.h>
> 
> 
> 
> -#include <Guid/Acpi.h>
> 
>  #include <Guid/SmBios.h>
> 
>  #include <Guid/SystemTableInfoGuid.h>
> 
>  #include <Guid/AcpiBoardInfoGuid.h>
> 
>  #include <Guid/GraphicsInfoHob.h>
> 
> 
> 
> -#include <IndustryStandard/Acpi.h>
> 
> -
> 
>  #endif
> 
> diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> index cebc811355..ad4e0a57a1 100644
> --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
> @@ -1,9 +1,9 @@
>  ## @file
> 
>  # Bootloader Support DXE Module
> 
>  #
> 
> -# Report some MMIO/IO resources to dxe core, extract smbios and acpi tables
> 
> +# Report some MMIO/IO resources to dxe core, extract smbios tables
> 
>  #
> 
> -#  Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -42,7 +42,6 @@
>    HobLib
> 
> 
> 
>  [Guids]
> 
> -  gEfiAcpiTableGuid
> 
>    gEfiSmbiosTableGuid
> 
>    gUefiSystemTableInfoGuid
> 
>    gUefiAcpiBoardInfoGuid
> 
> --
> 2.30.0.windows.2