From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.4151.1616471098236885386 for ; Mon, 22 Mar 2021 20:44:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=toCD1/FV; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) IronPort-SDR: b4TRpiCKJMPK/+ethXY/VdtQkrxmjmxOmQ5AvsfJSG/+Z8Sj/bwJhW66n/Yu5N5hdJd/sey5oe XTwWJRKN50Vw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="251751732" X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="251751732" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 20:44:51 -0700 IronPort-SDR: b0REC0S5JjFR41FcdvUJ2IOIGSnMou6KszP4mO9gSXMC7KTbLGF7WtNC+ZK0m1zpuj9SRzhmuG deR38WXfl63Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="441479694" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2021 20:44:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 20:44:50 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 20:44:50 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 22 Mar 2021 20:44:50 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 22 Mar 2021 20:44:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n2qY/IOYuhqU2OhghQ4ksZrPytjhlGJL7p64LDvXsC3qiL61rUYXG5lN7Cs9J8shz8fWWVbW4K8uZwjP6UCu/izvpGhGnOjTM/WxQAPLJ9sKzbd3IFS4s13YFfN/FLrogHPQXDNmCL3WuADrYqCKzgx683hj2sv45+cPgvnrBmDWe2wjCmD2k1ITio6pRgo2yT2R+7my9/wPIg8PYNozE2PQIWM3R7EjUMpx13LOCS+dqmDpeEnCXk54Q2cLWLo2faol7q1OI9MhraLjL+aeHrzxsfWlURHQrmGvyqJKiKcOS2YYS4VuDLy8dMv2PyscqbT+XgwN73rYCI1QgaIehQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MReLKDtqmu8eKLVJiHi3Xx6SXX//Ioecd2gs1zcgd24=; b=VpihM4kYgF+fhjPQxGOr3lH8CtQwq0a04dT9n0FLlQSHWbkf0gqPhA49L3xZJ5NNiu/zuxj/kcX5RkGm39dDPbEYdw7/PSg0LS63rMWyNFxyonDRj9t6a1l2dc8G92+SdEKPlp9gpU/BzekAZuGbWw00hphcc19S9LL3qInxj1DyclXTNYjxjfA9Yy88h0j43m9KDoofv9fU07n2pNBkUVAHQZn/g0Xa9OorpV0MFaXcDO+3lc7cpiAwRVI+ORFsPRPa+EMJO37JrrDBl0v/7kTzv9WzAyvnzW+NHUjeBY3mh5DUMd2ZHR8MW9WglNstWYOZoHgxO0tBlRI69txuzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MReLKDtqmu8eKLVJiHi3Xx6SXX//Ioecd2gs1zcgd24=; b=toCD1/FVnKtOukR6Q8pmpmSgrmDKd0nLU+hNrAyynd4qF/piLl1WgMkF3AyORCMEESBRnwNoF5cPDoSkcmiwFQbSw23w/NrFciYimuHi7YZjpG27Hz6t0jhoXYC6GkPvK8afgwGwxoHrdJYgugROYwHRBN1Pli2T6S7GF3kweYo= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB0029.namprd11.prod.outlook.com (2603:10b6:301:67::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.25; Tue, 23 Mar 2021 03:44:48 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%7]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 03:44:48 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Dong, Guo" , "You, Benjamin" Subject: Re: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI Thread-Topic: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI Thread-Index: AQHXH5QjFiH+67hF4EuZb4GKpNHkT6qQ7o6g Date: Tue, 23 Mar 2021 03:44:48 +0000 Message-ID: References: <20210323032438.950-1-zhiguang.liu@intel.com> <20210323032438.950-2-zhiguang.liu@intel.com> In-Reply-To: <20210323032438.950-2-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [124.77.195.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9959af5d-f02e-4d68-b08d-08d8edae01f7 x-ms-traffictypediagnostic: MWHPR11MB0029: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:288; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FYqMXN3R5VygEZCCeGcbjDGWoGUDLCj1eM6ZY0p+NUa9FSP1XJKcw+eozfXLWCzoWKjOHDv30sj5z0fYzxbp/OrQOnNAhMYgDhnD91TOwmN1oOk0B9Ex1ccIdGVmvgh5BY55FIjj6UOk//39DPz5YKyk9+9Rq8sqexGtSkNJwsSPqhNXP1/PTLr13OJKm2RYogAs8IbgNso4XiPa2+pohqqYQWOt8vYrRdOy/julrwFOUbNrVINyw06BsCTZwN6y/xWxbwEQGJ8f+k2vH+s6xCqvS46FUCLCmt9P9TPlYgZ6Dsc9rL5NFDBmS3kKuU9J40zSZAR5jcirzI32L0Zg54b2POpZd3mEYszJKVVAWpydzLVmg9HMZQsLbA1BWu5H2gQ7DmR2yu6uI5YRJwOdYfHoLs4F3upiGKfu3r17zT2e6YA1C78Xb5yFjT/r0AMhJI7Hr5FAc/8wcuhTc9FGKT4ap+Z6Lncx3S1al/sq4rFTeVyBl1xEr2E2VRlNHw4+Zi6MIqdFXJeZqaIlKvh6SvS7DZQ/i+OJkeERnbmcL5sW0jMrAL/hW4hq78fCtzk3wHb9S2Z6Owl9gmpZAUsHfWWtLe+xLB/8abZoqJ2e2+hzJOj4LtzsmV7HQAFVT6tdFLJQU47ycFzlHqJ+rtQg1kyTZ/QZhs1mpqqIyhjGVAc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(376002)(366004)(396003)(346002)(8936002)(76116006)(5660300002)(6506007)(83380400001)(53546011)(7696005)(52536014)(66946007)(4326008)(71200400001)(8676002)(107886003)(478600001)(2906002)(64756008)(33656002)(66446008)(54906003)(66556008)(86362001)(55016002)(66476007)(9686003)(26005)(186003)(316002)(110136005)(38100700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/GS2HFJap8jjllyyYWmpae58yqYrrWAKAcOSLNTYALviHXH0grYM6cVfK8GV?= =?us-ascii?Q?6wWd4uR3qo62/qHh42tW7VUoauvmNYXOlF10BN0XMYxMw+VyIuDRf9IMATyE?= =?us-ascii?Q?yaoh9N1Bvlr9SNDj4woNv0OjyMTb7LVWo6d73deqZAHrHMBpN1e5BWWo8PSb?= =?us-ascii?Q?G69ItKL1dV9VT1OlVjYHpGBatxRE9R4AH0Q0Oc88NM/5yjwZXujkd0+wqVgL?= =?us-ascii?Q?W6kq40ng16D0yaI8XS19YfbBMXs+CtpteQJF+5PVmiDETHnU4RxK76xkEXMW?= =?us-ascii?Q?zQa9v5sPcziybhMXvVxwv/pf8OXlci81QZsPA4PiTQfhuraVetdSVn1U1xgg?= =?us-ascii?Q?X0HFcjFyZ5IeLnmIkrycmGb783brCZTaNfLB9syATJnEQrtyRHeq+N0RfJ7a?= =?us-ascii?Q?fiPS/o8yBhBpAn3966WusupO9O5SfaIshWL4sGSQ2wdeQCL+xOB/1uPYQCP5?= =?us-ascii?Q?S4CIotvbH3JSbmGAtm09kJhdda2cL/P/aP9ku/FUffuGVomUtT+B7QXI91Uh?= =?us-ascii?Q?Po6c7BAZlw7E721HDbb5vr+2Q4ErDjzmOn6KwIoS9adJ4fkjm0HwYWfwb7sh?= =?us-ascii?Q?7k/yLGPZKvkkKtoLOneYmmRjkSTG8LMJTd53UxptrnwkC0Og1KzP6+kPJX9/?= =?us-ascii?Q?n24Gs74nIYkYxzn9HDEBdYNE/Bc+yflo7iDlxO+C4TrtyA2UC2ua+0BKcEai?= =?us-ascii?Q?u70awzK5xtMidwHTfhffGJVLE/HE60WoljdRIOGSCkqBIfaoNaogsdjG4kS/?= =?us-ascii?Q?QXf6g+DyZ5KyQn6hsyAZaKFPfNrCKANe1TVCbJbjtMhHoD4B+OSNIrM4U83K?= =?us-ascii?Q?Ye97YX0DvQoGcYyAFbeuCIZISqkANqFBFwO9KWeEzg8imABhXD141ex0XiMN?= =?us-ascii?Q?X412+FmtstcUqlijnxyhDA26AuLObtMRST+LCAJGsGXjlYCsI0qIxeq/mIDF?= =?us-ascii?Q?ZqAW/43TTZZdWryJSwj95hLAWosgq6mVYf1s/m8HAF+FYHbekzyt3Vj5CWOB?= =?us-ascii?Q?iRLe+N2FaEYSH9xwl1cyiAw3AZVAieTf7WZt5SOoQuUWZQmt5ii/gMpEWs8t?= =?us-ascii?Q?ZUIY8jsdOD0Kx1lqWCZ8kFh972wfi9b4RMMzYPJkex/jTixKzwCI21HtEsqC?= =?us-ascii?Q?1kMmBd1xSyhDvvU7HZs1eA0xZeq1MupjYFKszv0ZvcsaaaWuP5wUnfhkMHbw?= =?us-ascii?Q?ZNlOzQCRGyPlvTrrnyBHB1TJGRQml/GDUuqusMJeNZsjPrBQ4RyjNNKL/Yrj?= =?us-ascii?Q?wQAI1J+9HFgggJ4SpPxo4xhiB8BsxeJFwcDYq82yhjaGFlYUpRm4OrZcfGY6?= =?us-ascii?Q?/h5xpql1z/dJT3XIa31zcdqX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9959af5d-f02e-4d68-b08d-08d8edae01f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 03:44:48.4982 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W5w77kOJj2H4rRweMae48fshMJD0sydGe/ygha1wsOjWM0j4Sm6UfB3Zg1Uxh8sSuqIgeEajgdX6koIy4RjJJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0029 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, Zhiguang > Sent: Tuesday, March 23, 2021 11:25 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; Y= ou, Benjamin ; Ni, > Ray > Subject: [Patch V2 2/2] UefiPayloadPkg: Remove code that installs APCI >=20 > MdeModulePkg\Universal\Acpi\AcpiTableDxe\AcpiTableDxe.inf is capable to i= nstall > ACPI table contained in HOB. All ACPI table shoulb be managed by that mod= ule. >=20 > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | 13 ++----------- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h | 5 +---- > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf | 5 ++--- > 3 files changed, 5 insertions(+), 18 deletions(-) >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c b/UefiPayloadPkg/= BlSupportDxe/BlSupportDxe.c > index a746d0581e..dfff8ecf0e 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c > @@ -1,8 +1,8 @@ > /** @file >=20 > - This driver will report some MMIO/IO resources to dxe core, extract sm= bios and acpi >=20 > + This driver will report some MMIO/IO resources to dxe core, extract sm= bios >=20 > tables from bootloader. >=20 >=20 >=20 > - Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
>=20 > + Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -120,15 +120,6 @@ BlDxeEntryPoint ( > ASSERT (GuidHob !=3D NULL); >=20 > SystemTableInfo =3D (SYSTEM_TABLE_INFO *)GET_GUID_HOB_DATA (GuidHob); >=20 >=20 >=20 > - // >=20 > - // Install Acpi Table >=20 > - // >=20 > - if (SystemTableInfo->AcpiTableBase !=3D 0 && SystemTableInfo->AcpiTabl= eSize !=3D 0) { >=20 > - DEBUG ((DEBUG_ERROR, "Install Acpi Table at 0x%lx, length 0x%x\n", S= ystemTableInfo->AcpiTableBase, SystemTableInfo- > >AcpiTableSize)); >=20 > - Status =3D gBS->InstallConfigurationTable (&gEfiAcpiTableGuid, (VOID= *)(UINTN)SystemTableInfo->AcpiTableBase); >=20 > - ASSERT_EFI_ERROR (Status); >=20 > - } >=20 > - >=20 > // >=20 > // Install Smbios Table >=20 > // >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h b/UefiPayloadPkg/= BlSupportDxe/BlSupportDxe.h > index 512105fafd..3332a30eae 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h > @@ -1,7 +1,7 @@ > /** @file >=20 > The header file of bootloader support DXE. >=20 >=20 >=20 > -Copyright (c) 2014, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2021, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -19,12 +19,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 >=20 >=20 > -#include >=20 > #include >=20 > #include >=20 > #include >=20 > #include >=20 >=20 >=20 > -#include >=20 > - >=20 > #endif >=20 > diff --git a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf b/UefiPayloadPk= g/BlSupportDxe/BlSupportDxe.inf > index cebc811355..ad4e0a57a1 100644 > --- a/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > +++ b/UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > @@ -1,9 +1,9 @@ > ## @file >=20 > # Bootloader Support DXE Module >=20 > # >=20 > -# Report some MMIO/IO resources to dxe core, extract smbios and acpi tab= les >=20 > +# Report some MMIO/IO resources to dxe core, extract smbios tables >=20 > # >=20 > -# Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved. >=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -42,7 +42,6 @@ > HobLib >=20 >=20 >=20 > [Guids] >=20 > - gEfiAcpiTableGuid >=20 > gEfiSmbiosTableGuid >=20 > gUefiSystemTableInfoGuid >=20 > gUefiAcpiBoardInfoGuid >=20 > -- > 2.30.0.windows.2