From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Lou, Yun" <yun.lou@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah).
Date: Thu, 10 Dec 2020 00:53:20 +0000 [thread overview]
Message-ID: <CO1PR11MB49302F1D05C995F71443A7138CCB0@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201208045104.1234-1-yun.lou@intel.com>
> +#define CPUID_HYBRID_INFORMATION_SUB_LEAF 0x00
1. At first, I thought there is no need for a definition of xxx_SUB_LEAF. Later when
I checked the SDM, I found it says, "Hybrid Information Enumeration Leaf (EAX = 1AH, ECX = 0)".
It seems that maybe ECX=1 will be introduced in future.
But with this macro name, it's hard to choose the name for ECX=1.
So, I suggest changing the macro name to
+#define CPUID_HYBRID_INFORMATION_MAIN_LEAF 0x00
>
> + sub-leaf #CPUID_HYBRID_INFORMATION_SUB_LEAF.
2. Change to _xxx_MAIN_LEAF
>
> + UINT32 CoreType:8;
>
3. Please define macros for core types: Intel Atom, Intel Core.
+#define CPUID_CORE_TYPE_INTEL_ATOM 0x40
+#define CPUID_CORE_TYPE_INTEL_ATOM 0x20
prev parent reply other threads:[~2020-12-10 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 4:51 [PATCH v2 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah) Jason Lou
2020-12-08 4:51 ` [PATCH v2 2/2] UefiCpuPkg/CpuCacheInfoLib: Add new CpuCacheInfoLib Jason Lou
2020-12-08 5:26 ` 回复: [PATCH v2 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah) gaoliming
2020-12-10 0:53 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49302F1D05C995F71443A7138CCB0@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox