From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.6255.1607561604242552796 for ; Wed, 09 Dec 2020 16:53:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s2OYBgzZ; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: PHAW6nBPphxXoLjY154tZda8HdgcBptiMAjCum6Uz0pzTU8V3SqWJUnwVmC/MPb2zjUYBTxS8I wwqbkvnTzhkw== X-IronPort-AV: E=McAfee;i="6000,8403,9830"; a="153413747" X-IronPort-AV: E=Sophos;i="5.78,407,1599548400"; d="scan'208";a="153413747" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 16:53:22 -0800 IronPort-SDR: ZpK/+L/ixqoEYkLyYsdnTVE0g+9DCYGznSeHp7Ypv2PXQykrV1SAfeqObO+iHbQdckFj4k2DFy vO2Rt3tuNY/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,407,1599548400"; d="scan'208";a="484213186" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 09 Dec 2020 16:53:22 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 16:53:22 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 16:53:22 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 16:53:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A28jJJe3XmO53kVnUcPT7lYt5L7h61wYokDIOoQtZPoS+QBgDuHq9IfgDQOATD8tpXhnCpehLs0+/sBcaMP5FKbwjn2vFNePSbSCdQ/4/x39833fmNKRyLjhAvO2Fd0+Pu4WchQO7LaboFMo6+zjcWP3zD8R3F5TZnQSyOo1ObEAnEQ1nKapx3VR4wx4P79Usa2kT22Oof4+8Jj5PBmdV+V0fFxgNFGVGOB1nVusYxkVUU+njK8yMbHVWPYcmW7mJNOYcfxehCt6xSaU4dqX+V6AShxbg+bz6tiZYB0eXTlnpWUoDHWb87LHXHY/t7EI09LTjoFJlZ9lPQCAFvzttw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MtZ0WdAroT5PEkY2XsqdTZyst/PMGHcBHMmpcGI+b6U=; b=FuesTQu9yzNpN50DoOu8bdW+AFS3cCL9GETjmeHQZ5fvz9dHL9KsSfALMTL6XfaenxnXJKSIScro7oZ5ZQbXr+Cm5hWrYhDj/BqD4D8QosDgczP3otia2zyAItL2Ej1jUXeSmUm9wz24/s51Z3GrMqp2ACm+JabuzklQDjt3e/JdOSqLJ3ihswq4U2koj1+HTg4LsoPBfEglXuUeaRyaPvIkgYstoR1oweLLWSgsVbh/PPeJxQIeJ9VNE6/mZtWFQhA8u8V20suiu3LppGAz+yuPpULnqPLbzU3pYTubyncAHrB/ssswbY4TxpQ2C4eX5tYUEJJ24mNQICPGmpjNfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MtZ0WdAroT5PEkY2XsqdTZyst/PMGHcBHMmpcGI+b6U=; b=s2OYBgzZm0WQB9LdFP4Hl70ws4b+3G7t1b9Zv3SGfSnjaqt5GhKVp5647dctJTkv/c6FAN/BoN10024ICERbr1e6zKZeiZ/lsuK1DRhFN3+02LjJpebKICF39VX4s4o6ZgEAzPFRXCw8g+TyWwnwVOfokNw/f5P2Vx4wDELQQ6k= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB4884.namprd11.prod.outlook.com (2603:10b6:303:6c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Thu, 10 Dec 2020 00:53:21 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3654.012; Thu, 10 Dec 2020 00:53:21 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Lou, Yun" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v2 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah). Thread-Topic: [edk2-devel] [PATCH v2 1/2] MdePkg/Cpuid.h: Add CPUID_HYBRID_INFORMATION Leaf(1Ah). Thread-Index: AQHWzR3H+LWUhkGVWEio5dDdV3l176nvf6bg Date: Thu, 10 Dec 2020 00:53:20 +0000 Message-ID: References: <20201208045104.1234-1-yun.lou@intel.com> In-Reply-To: <20201208045104.1234-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1bb2e64b-ba23-4403-1c28-08d89ca5fd8b x-ms-traffictypediagnostic: CO1PR11MB4884: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XUjyZF7ARhytYt4Dl+0D0fyJkyn0MhoLoVTpJKb0GorKTIt5V45hFMbOi5zHjLgS66rWRe+NGluN8hIoxFpsinJFx4fmdEf0ErhhuSuu1Y19LANhOeyDrL2kB3pQ6UeHKV4K7i0F43ovIwCMpk03mw818qTsGJDXIFfewdZ3ZNIel0Nx9XAQ4pOymZTjZ73wcyzkD/QAM2K+l/4KpuygQf8sJBHhJYWSRx2vNB2HdtIKp5X91YuaXTdOPdXhuz2FmF1bnOgx57BBmHd2cz7RvCGCUvgFfmORFASmayMKsKEy2IguYoWclfo49Z6FWVLAcXK0FkF6qQKsJ6VC7uuyoTCJYNWlaq3CfS5hWn65R8+QCtPAvCt4g+quGAuLcMXL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(346002)(64756008)(66446008)(26005)(71200400001)(8676002)(66556008)(33656002)(55016002)(66946007)(8936002)(7696005)(86362001)(110136005)(9686003)(6636002)(4744005)(52536014)(508600001)(4326008)(54906003)(186003)(6506007)(5660300002)(107886003)(76116006)(66476007)(2906002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?207tttouorVudO4rlCBbYWzxY9mX/ie0s/7orVbHfJnGW7n5nZtSvoWPoxFE?= =?us-ascii?Q?riDVUB78XuR2zWZFugtpPBV5M01zQb+T8qvIrLtDHs4MjzyyI5moHwfXnVDj?= =?us-ascii?Q?9o6oG6qOwQVaYKUi6yDSvIzzjqQRSbn3UGIfK9JkzSiN+YLyzN+RgIGgq7LD?= =?us-ascii?Q?9etXH3SE6XJ0U4K1A4SEyevASdOMsJ/CfJIhHEmsRj24isDlE1P/EJqWHIRw?= =?us-ascii?Q?wt1F9Nn+o1cezxPCIaW4RoPgo54LJDFNRxbFBOVHsnh3CsCvuFO5U+q7KjMN?= =?us-ascii?Q?dw/FwYg2Tt7ebflgY8IFjG+zOFnJYaeWqHWRw17OK0RRHRYoDM9h2NyUQzcL?= =?us-ascii?Q?DOM0YfCrDqqRHQ+A+BOK47G++qnnXqmo9v4cTCCoSvndt8mIedqmzAcgp5J+?= =?us-ascii?Q?y/4mJCzs1cAQMC4LqQq3el7ld1sIt7khfqPBJFa0fC8vYJVx1CDH0aQa151m?= =?us-ascii?Q?L6ZNMrLixNqYNVRiiuibh6RBWeV5483e85Hu7b7mcMwABwgntE1jvFx1npvu?= =?us-ascii?Q?AQXrPbGLoiAkkCov85PpNGwStIDBVUvW6SQ6ofd9U6bvoZwDTvnBHNRs6YPY?= =?us-ascii?Q?LIaM+7B33iCMQ4zPGSCA3wgyl4+EC4Cz3hux7ZKmWo6DS+pbNVd5FtUZy+zM?= =?us-ascii?Q?vjle9basb0mUEOFXAy7I9ebRV7Bsa8Y3eNEcY4ZY8Y1a86gbbiA1bi7K4cgP?= =?us-ascii?Q?gAzuUFkl8ozJvp4+ZMH4bzdW+9nqEf7NuYQynS7xq0AlAtcKkJhX8MJe9WLu?= =?us-ascii?Q?8WI6M6IH8bRCa4SeJThmhRLr+OKBsPn4h8P+M7sizVnG3E6dpXEQ5WrmJeJ0?= =?us-ascii?Q?Q6rpFDtrJr/acFZ5ZXy97saQP8EbXnXPyFNZmPbP92mxfxfDpGk6u9PKEunl?= =?us-ascii?Q?f2pdp4XKV88V28vt6v0VZwNd5OeisXeJTsm+8wU2rOBjuaA3xy7dNDBzzvIt?= =?us-ascii?Q?uyiWsrcMYdOpe59itEHMSydrTyEfMYmI+Q21mjzF8NpKKhnkJMkk5ryGKfMz?= =?us-ascii?Q?Gs7D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb2e64b-ba23-4403-1c28-08d89ca5fd8b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2020 00:53:20.8721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NmVKiwSOFHDvHTxsJc6evjPPaqz0Q8qk1rXfUp4k1XNV3YKfB4sKK/y9rt6BHyJqk5ErYjV74O1sSakfunBQEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4884 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > +#define CPUID_HYBRID_INFORMATION_SUB_LEAF = 0x00 1. At first, I thought there is no need for a definition of xxx_SUB_LEAF. L= ater when I checked the SDM, I found it says, "Hybrid Information Enumeration Leaf (E= AX =3D 1AH, ECX =3D 0)". It seems that maybe ECX=3D1 will be introduced in future. But with this macro name, it's hard to choose the name for ECX=3D1. So, I suggest changing the macro name to=20 +#define CPUID_HYBRID_INFORMATION_MAIN_LEAF 0= x00 >=20 > + sub-leaf #CPUID_HYBRID_INFORMATION_SUB_LEAF. 2. Change to _xxx_MAIN_LEAF >=20 > + UINT32 CoreType:8; >=20 3. Please define macros for core types: Intel Atom, Intel Core. +#define CPUID_CORE_TYPE_INTEL_ATOM 0x40 +#define CPUID_CORE_TYPE_INTEL_ATOM 0x20