From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.5109.1631698569171751450 for ; Wed, 15 Sep 2021 02:36:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=T7UEutWq; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="221934984" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="221934984" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 02:36:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="508697318" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 15 Sep 2021 02:36:08 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 02:36:07 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 02:36:07 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 02:36:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XejTuDCh4iguBVxYtu5Gd8yxR/6Ts99DtG2RjFVz1OJ/XnHSfCDKKQew0MgkL0brprP/haTYrXp2mHDVVOKEs3BDBtF08bjQbviCZYuILEfDSDRYWd3iw4r5BE1Ha0DqWt594NbVRftltBbZeqXn5TjH0hMb69z3HV2Pk3Qwl6vzORTrDVq6zYi6kCqzelUBFB9deKD/86G0r9SFz6pxzcET5tUHK7g62JqAEazISWJi6km1yOtFzC7/hLxgFYKBBWGTSZrO/bzl26Q3BY/rNlsNbnnpVGPu8YjWUFVT0+hvaSpakKfkzJI1qm+BptVZEAQsSXixVwsfYydyS16lQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aPcjl9D3Kku8V2IPrnCL+Vc1wVW96hbZKeqlZSmhgBg=; b=UKOoeyl/n96uXZ70QG9462SfPyixRmvPevG4LNyB7A2NWRFfzgIjJa1GOP7BrslTreCRIuVcLP/Ip0cZ+YAJSCCQOAHOZoRJY5h64xSHXPeLFpcF8XeQmh2rvZC37fepPS7CcG2JlyHLGvuq5VZ5rELUZzmsgJX0ozfApV9I1werNRNbUAWMSRZH3blOwtpPHEbU9dCc6V2JIcIlP70MeFI9rj/ahaoZR7aycH+PXjtgE5kvdPdZ+XiccGIJzxk/uaYdTTJwKMieuBkra0j4tcPiwAZXlAKo9W/XfPuog8HXeODJziG9ZO0HzMf8rDV4jYe4COJoasTFwMPVKQxBqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aPcjl9D3Kku8V2IPrnCL+Vc1wVW96hbZKeqlZSmhgBg=; b=T7UEutWq4K+tdIWKrKwtPSB4dPNoAeywNm6vUKomAFCTHapHOeIxj5/6BqxNSTrMbVdIyhK3ZlguvF5j4ilGqIUGCMfNouDq+7D9AE+zyWbKEP6eBCsydWD1dTloxEc/ovBkbXHJEDygC38XwWYhAR9VQTGSvfuHhDP5pYRNEbQ= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2224.namprd11.prod.outlook.com (2603:10b6:301:52::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 09:36:05 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::50ce:c9a3:ab37:9fac]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::50ce:c9a3:ab37:9fac%9]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 09:36:05 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayloadPkg with IA32+X64 Thread-Topic: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayloadPkg with IA32+X64 Thread-Index: AQHXqTutLpwFG+l3I06yr91KZ7Fjl6ujKH5wgAGX4/CAABbxgA== Date: Wed, 15 Sep 2021 09:36:05 +0000 Message-ID: References: <20210914073907.1243-1-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ff5e895-bc2e-4c3b-f29b-08d9782c3d83 x-ms-traffictypediagnostic: MWHPR1101MB2224: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:128; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: akGbpcdx3eYrHz8HsUk3/VeXMfSR7FIsiqrPYWFafHSRk5hzQ0H0Y5zs7gFfAuUg5sqNxDjC9vHCk1RByAPDkqNkqGIiZPsDYiKEvPqMSE/DgygaHRd/0Efu/34vCDyQj0yFkBejpNtWsLoF/x+CWOoiGadVlMC2HFQACSGUb7me3Oq4nTTHcdzwhmta662rKteshGVl63R6PTCgNj9k8NHhu1+74p2I3SugqusOZxEtSkQGnb2oKI6Fn2SyQt+nu2I+bgjxElS/6MfJeLXNvXmT70X41eWq5qvakfk+aj6cFHQ6G5DQZC5Jmy0H73Wn5AtVB+bQ6FmI7e6TuSRi6MI84HeLuWQtlZbn2CXKWTKn35kf7Gp9mI59bXxapmUG7VqdUeo4TJFAnK0vTw1oH5n0UKCk+jUwbOZPZOBB55H7JKLl4CN+dvdly573W/2/R8GaOh1PYn07qELjZNJGVJtHLa0AcJXv7wrBO6imA9CGlocoqin1a1p4zU4yAWW3I792caDirIOPFivBoTrIVuSv6megCY3UtVkKGWCAEC/3XGUzzgapl1TP3yYoXEc8SkAU/HrtzRO2FNT/HJ0MgWr2UuMv+z9rjSCoI8Q9PuhTfXH+dJ1xCleLChx+kUzPNuFpt+/HOJgKf1uF+81ikgVYa+sba1TeJ50WYVrJuUWPkbu7l3MGWpdHfS+72Ae9ZCovXKe3m80G2d5hizmPMyoS84ik1h9s1maLaZ4FBxUigIFzraQbXFN52zzKLMqcauLgpRJBFwRTRBRx7Fe0Aps+yuAbM+Y5z+7jeIPgvQA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(54906003)(5660300002)(2906002)(38070700005)(53546011)(107886003)(6506007)(7696005)(83380400001)(66476007)(9686003)(33656002)(55016002)(122000001)(76116006)(110136005)(52536014)(66946007)(38100700002)(64756008)(8936002)(26005)(8676002)(186003)(66446008)(66556008)(316002)(508600001)(4326008)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eirTOOEYXWx0A+dIJuW0BIq3UyttvO2A85s2rrcOj1exDXa4AMjr1tQ4ZweD?= =?us-ascii?Q?OlsZW3BxJn+/pHeTwJ1JKx1/VhwrYOMVDuoSGxrT3aZflqmjukWJE0aeLTAo?= =?us-ascii?Q?HS+rl7Or1qB4IXmNCL/22rS/oJ+7ACvj11ACmRRjVLXwUoeb+SxkdP1PJFpW?= =?us-ascii?Q?FxhNEDhznGtfWCjOdV5dNe44vCkef9Cr2J3i8uUb96AKpxnnVyoeOXsHCmuG?= =?us-ascii?Q?bGc0vdfTqh5BlQ9wxndrfQpv+f9beAbn0LLdsrA7Vg/QQGd1r0Mm2b9uHc04?= =?us-ascii?Q?Y9kLuK3SdG5feD3235YqVOvPFXNhkScGKEAC+DSKRDX0D5t0pEckB7im7wkO?= =?us-ascii?Q?+KtCK8ayCZ3QBa+EdwfLVrmvFXxQW68lLq+l6WQ8zsSokPnEzYDCJP/wm6fN?= =?us-ascii?Q?cFCzvwaz/4vheqmoyybipyKJdO3jmLlqoo9ByNrcd03ip3v/5ubq2LyUDZ60?= =?us-ascii?Q?iO/XBIwIOgHvkjiDB4a+i0XSHuctorE1DlPWyNyaodu3sfv8QAQMZmhvrsLx?= =?us-ascii?Q?+1e43HgFWXqFZKJ0+AC4IxVzp8iV2ssYC6Jn6+kFayW3dE5RLLkBLtEOfJlt?= =?us-ascii?Q?jjz+p/lRBF5vUm+/elBs0dCFbqdrBThYhQvWvTzY+Hb0bwZndbHMMZkBmsrP?= =?us-ascii?Q?81wzmDDFEF4BYirWkzMHmT+plLOiinoOrFWRTMg3CLuLmY2ADkGk/ZgyFMRg?= =?us-ascii?Q?PYSqOW0SMXOEcPQJjZxTlNjS5T7DEgv0rbD8HDOv5fqqJ3iCgqi13HFZEo3T?= =?us-ascii?Q?7437/7CE1sFBXuFVgcP1PbtNdpPOl8JjYA+1VInyATaZpHOLPmqwtOsQcRBz?= =?us-ascii?Q?SpE97YwOouo0t95tqXspPB54fmRAN3ISd5Q55ZH+a1sfwS2pyz8CRG2pR8Rm?= =?us-ascii?Q?NqemjJGOEDZc9ls+JUP+DI6LHmh7eoioq/K4EoO3NJx62yATCpjVM40OkPvL?= =?us-ascii?Q?x7nuTpn3wVHZjoP2nVp8eujCqiLPcztkGTK4sVToeuQogC/+3Kl1gjhYr57c?= =?us-ascii?Q?7c/Qwy/aWt3u5kzkTN1TWYS3t5V1c32pWACWn47WIEX64WKopXSwWkmGgU7G?= =?us-ascii?Q?Wf9cVw8bcXn/PcXDjLolWMG5VMQoW3ztFVovi/TmagY8/7S2MWmvjF2tdGfS?= =?us-ascii?Q?f8dh4IvBPEO6zgWsyl2S03NF/HYdjdDzk8eRZdXsRx9XhohfTK4FVHobEGwM?= =?us-ascii?Q?wseFeCBDngD1w5gC8OrI+eld23/RtgP40SREuG5nO5JBOGy81Zqw8MLFe9/S?= =?us-ascii?Q?HfOr87f5ksTPPOkTzzhjxfvGk4kwAdf8g1CtRL7j6ulJMgEyXALVr/KcQekz?= =?us-ascii?Q?H+Kzt5eOOez45pL4ZbD9SI25?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ff5e895-bc2e-4c3b-f29b-08d9782c3d83 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 09:36:05.3884 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GgPjMSaUHPLUlNMpxU+IMVxqdesXuU90tPp4VrX3EXojTx6Eq4HvODQa5AT/0Cd3+DW9sL79GC5p0dQNjbUjXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2224 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Tan, Dun =20 Sent: Wednesday, September 15, 2021 4:55 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Dong, Guo ; Ma, Maurice ; You= , Benjamin Subject: RE: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayl= oadPkg with IA32+X64 Hi Ray, There are only "UniversalPayloadEntry.inf" and "UefiPayloadEntry.inf" under= [Components.IA32] in UefiPayloadPkg.dsc. The [Packages] sections in these = two .inf file only contain MdePkg, MdeModulePkg, UefiCpuPkg and UefiPayload= Pkg. So the PCDs in .dec files of these four pkgs used in UefiPayloadPkg.ds= c will not be treated as unspecified PCDs when building with IA32. In order= to avoid warnings when building under IA32, the PCDs in the dec files othe= r than these four pkgs needs to be placed in the PCD section with the 'X64'= suffix in UefiPayloadPkg.dsc. The ' gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport' is in 'MdeModulePkg.dec= '. So it won't be regarded as an unspecified PCD. Thanks, Dun -----Original Message----- From: Ni, Ray Sent: Tuesday, September 14, 2021 3:54 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Guo ; Ma, Maurice ; You= , Benjamin Subject: RE: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayl= oadPkg with IA32+X64 Dun, I am curious, why ' gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport' doesn't c= ause build warning? It is referenced by "MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf" under "[= Components.X64]". Thanks, Ray > -----Original Message----- > From: Tan, Dun > Sent: Tuesday, September 14, 2021 3:39 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma,=20 > Maurice ; You, Benjamin > Subject: [PATCH] UefiPayloadPkg: Fix the warning when building=20 > UefiPayloadPkg with IA32+X64 >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3603 >=20 > Move the unspecified PCDs from .common section. to .X64 section in .dsc f= ile. > The corresponding PCDs are not used in IA32. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You >=20 > Signed-off-by: Dun Tan > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 9912f2a20f..9d7f311343 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -327,6 +327,11 @@ > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 > !endif >=20 > +[PcdsPatchableInModule.X64] > + =20 > +gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTE > +R) > + =20 > +gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGIS > +TER) > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > + > [PcdsPatchableInModule.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa,=20 > 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0= x23, 0x31 } > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 > @@ -337,8 +342,6 @@ > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F > !endif > =20 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule|$(MAX_SIZE > _NON_POPULATE_CAPSULE) > - > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER > ) > - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGIST= ER) > # > # The following parameters are set by Library/PlatformHookLib > # > @@ -361,7 +364,6 @@ >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|$(MAX_LOGICA= L_PROCESSORS) > gUefiCpuPkgTokenSpaceGuid.PcdCpuNumberOfReservedVariableMtrrs|0 > - gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE >=20 > =20 > ###################################################################### > ########## > # > -- > 2.31.1.windows.1