From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.6172.1612337017972950702 for ; Tue, 02 Feb 2021 23:23:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kAS4TfFr; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) IronPort-SDR: 1xz9zUuk4njS841YsiOIfjzHGTbjc7FoouQntKCQTTkse1x2R04lIp9k0+e7nBOJYVd+JY0adj vu5rT+4WCdBw== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="180223485" X-IronPort-AV: E=Sophos;i="5.79,397,1602572400"; d="scan'208";a="180223485" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 23:23:34 -0800 IronPort-SDR: DumtenwqO65E3+8cRa+OH1H63mjBdqwZG+OF3kOVPhikjVaDUNPjw4aEB+RCxi/ux1HfSkEU/p 7J8IV/N7fEVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,397,1602572400"; d="scan'208";a="392304812" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 02 Feb 2021 23:23:34 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 2 Feb 2021 23:23:33 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 2 Feb 2021 23:23:33 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 2 Feb 2021 23:23:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CM4rVgSBIHdS4kNBXB4yVQWT22BztkQmg2RMbSp2yGJUeguiOKkVrxuz8PM7u/N14OUJ5M6E2XxfxAF4Xz3c7zaIasO5Ac70IRTzNg8ksYfOA7MUS+XxvdFw9KKGOZsplUGyDcCo2b+gDRerqobaXtVpUHCynr1WYWmttj9Vn74Dws4rg4iDwK0JvFYtVz0Tv7nLrmxNpsbnu9Son2n3dBKZ58jgLwC4bNYPaGGLnIB7Mf3SqnnoJLKzhK9M1qE/ZbWA00tiJ0uuaOW/S2qwmuNeQv0MyhQL5DKJxSF2WtGLKMV1B5pA3z9vuBcs6nbsiBOTfpLGGKlwvDk5NPp0NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7splg1tDnm5A6j9QHS5hdVWu8vsg7EIHb8Yf4+++yk=; b=WHSS6r8YF7CbNOE+BBofl+NjqLK8p3vY6kqBDfgSmtZ2ss5DaR+HzEF3PpkOPe89m9eagnjg+rKI31BOUhe1NTDbR5LqADBbS8RbA2CpmDWJH5DEk6o9pDkKh77c0cG7buBYE65MquwqEG/BKTCMnYPHNgWcXQGMC6Our4ilVSsx+X+WIdGiJ11PyvE85yImRZghd/OEE6Ai9zXuwwye4ykLjP6+unCZgd88BJBjNb5Smxp8AMrX/yNXRR1skVFSL0RfPPxlxUyQRL599uFzlJqOt6T6r6xQujDHzYqQKY/iNgGBMcPSFa/Sxlye1T/xXdAue2p4zcsebCp0v4nqIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7splg1tDnm5A6j9QHS5hdVWu8vsg7EIHb8Yf4+++yk=; b=kAS4TfFr+4AIM8yDwRarFrnuBW8XevZjihRcXaFPkrEUdkYnca2pRiXqpYWu4wSMUkj0xMf1whvUqJ/Oysirne8+cGWZNtIypnMXIi5k+WBU7QTuKEjKyuaJkoz/udrXu7nhBNGs/l4Om03Ohp3Rc9raqhv3W8IzCWHaGbBYt5c= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1328.namprd11.prod.outlook.com (2603:10b6:300:2b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Wed, 3 Feb 2021 07:23:32 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%6]) with mapi id 15.20.3805.028; Wed, 3 Feb 2021 07:23:32 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Add MpService dependency Thread-Topic: [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Add MpService dependency Thread-Index: AQHW+Pwtqz8ZJaKmm0SYNkUjJdAlCqpGCO8Q Date: Wed, 3 Feb 2021 07:23:31 +0000 Message-ID: References: <20210202004129.6055-1-yun.lou@intel.com> In-Reply-To: <20210202004129.6055-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fec06109-a0a9-4a56-9269-08d8c8149c57 x-ms-traffictypediagnostic: MWHPR11MB1328: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:626; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9tiacUu3gE6QvgNgKrSALE/mFdNqyT5l35TBJ3AVgAh1BjR34vBcBsVjTit/MKfWMifgdsuQHHsFQCGCfu2n/x5DCfhOJlHcoY3B402wn2ecVfQ1VzUHIULPWksTw8N0Jg006am1aYB8cD1hCaDvLzN59zD43dnNtZ1Y/Fd3OjZK9zDpxpsp6FEfAAjoF+bUNdR7T0N/39w8xmeW79arwLYklWn5Y63nCLPp74nNqcbcqyqa3js11W8lFZRvoVufVPoGh4d6hXKL77v/EOGyfnug3yugj3TBkTgB56vsDHk7iWIWTcxdyBoa+k67kBiR8/nAn/guQRrObQhS90nyrJR/iuNrYAbnPfxfCl30Gn6U+Z8rzp/gfSsFUOEPiyVnsNJ+3v1X8MHOEDbsP+i1tj8O781NAW6dSJH4locWHZW3cx+gPKZza4tOB2Pq7sxjtDpVkdG8RrO971+LAYxOLLj7e5hes3oFJgqVGPlULx/zA9O2YChDwooBdGEqDMBBeG3Hf4MUfaYunsDnIaYvdRGygpaXcWH8bt3wyo+bXWAF6a/jbgpQ4j7DKPDkroI+O/dMvZPSLxx9AjgYI52kIqQcDd6jtrOe3ZXTLnWEsFY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(39860400002)(396003)(136003)(376002)(346002)(64756008)(71200400001)(110136005)(316002)(66446008)(66476007)(86362001)(19627235002)(83380400001)(66556008)(76116006)(966005)(26005)(107886003)(5660300002)(478600001)(8676002)(33656002)(4326008)(7696005)(8936002)(9686003)(52536014)(54906003)(186003)(6506007)(66946007)(2906002)(53546011)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?li+cYMBri8QXi4qdAVUhxfVo96ee8iJuFIunktEZDjktSyhf3bhAdtZm1GYe?= =?us-ascii?Q?7OVy048JQBBgHb5mdQ88pri/H8/QY+FD/jYroXnIBrhchm4Y3LcrLMif88cR?= =?us-ascii?Q?uH9szHhTkWaFBjfBqIvsZlIy0gUY1RH6tEzwjx8ndwkgzZblAcYw30E2xZ3L?= =?us-ascii?Q?axHBhACzGnqTX2ldLXP4cPYi4/1s0VkH9xsf6qaeocmMF8VwZxVjp/16JREl?= =?us-ascii?Q?OEbTmMM1MpUJ3Oa2sSX6yWUjeQWiNi3BB8aSE8+rokYxXVxYquYHHO3F9DoA?= =?us-ascii?Q?0OjWBiddzKg0wDuj680l8YCcyw1SiPOO/1h7o2BUxIK5/ix6CDpTc+v7yTqO?= =?us-ascii?Q?pNYpbxc7P0fkmx7nbRjvy2tMeu3hMRQ/giwVAmUO3K2keQ8pe9BpTvwg3naz?= =?us-ascii?Q?5ZB1Dqkq/P74YdC+i5m3fnVA90HKuLmeN16KZt3+zrjy2rNT7Kp+z5pooLor?= =?us-ascii?Q?7LRx0fUQ3hmeUTP93ot31GW3Bk4tc045e3tvKOK+NfwYHDo+GwxKRTGWL83f?= =?us-ascii?Q?4UA/XYX3TpYRyYbGyJwVyDqEknVBTDmFd+A+Ut2DeDQBFX91i5+GuLB50VV0?= =?us-ascii?Q?h61LhEEgVo4+oHORJYmkeTuHURxockRDwzn645qdfKDRH1MDTp5RgvuWr6Dq?= =?us-ascii?Q?BfZIYYZ4YUXzUmDzyq+4i/tm9vpeDd6ie5XX4pl7rsODepKFvXXh5b+Nvhu7?= =?us-ascii?Q?MbDqIwQmv30xbpf6r+jRl+OWxW/JbFwSP7r4hKu9XYOsa0g7kdGBkxg5QrCy?= =?us-ascii?Q?9XJz1Lnif7SzzbXBQ0tG2XSFKJjz9df8dUrA3yTIkwHXTcJhpdgAWHySOHnK?= =?us-ascii?Q?iMtCjHZPYTDkqBURK6XzENjwrW3mnzYwBwVtuGuADvUdES3o6ZS6dXvhlFDo?= =?us-ascii?Q?NJufylAosCJstWzX6SGwhT5rD/zCVZW6FQ7ZWAQ9edCEFLuyZ/pSRUU4FmbX?= =?us-ascii?Q?K/ebq6SkiQ8uWrgJUc0OicnhNgyL4PtScTs5BF6womL7yEfjZGDtSoHQSyET?= =?us-ascii?Q?FWkmYdJxLaF8HfDOxybiWU6eqEAMjsE9LUa552s8WI9weg5E29neUhYDQuq2?= =?us-ascii?Q?Uu8tmV+A?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fec06109-a0a9-4a56-9269-08d8c8149c57 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 07:23:32.0044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y60KlCksfxig2NEvAKcsSquyBexpMPTzyb0zudlLuaCFxuxy3otYMNeOu311UD6etE6L7kZmDhtGc5feTVzyJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1328 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Lou, Yun > Sent: Tuesday, February 2, 2021 8:41 AM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric > ; Laszlo Ersek ; Kumar, Rahul1 > > Subject: [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Add MpService > dependency >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3190 >=20 > Add MpService dependency to enforce the executability of CpuCacheInfoLib. >=20 > Signed-off-by: Jason Lou > Cc: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 7 +------ > UefiCpuPkg/Include/Library/CpuCacheInfoLib.h | 2 -- > UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf | 2 +- > UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf | 2 +- > 4 files changed, 3 insertions(+), 10 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c > b/UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c > index d1f9830c91e7..d46fb0425851 100644 > --- a/UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c > +++ b/UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c > @@ -346,8 +346,6 @@ CpuCacheInfoCollectCpuCacheInfoData ( > @retval EFI_INVALID_PARAMETER CpuCacheInfo is NULL while > CpuCacheInfoCount contains the value >=20 > greater than zero. >=20 > @retval EFI_UNSUPPORTED Processor does not support > CPUID_CACHE_PARAMS Leaf. >=20 > - @retval EFI_NOT_FOUND EDKII_PEI_MP_SERVICES2_PPI or > EFI_MP_SERVICES_PROTOCOL interface >=20 > - is not found. >=20 > @retval EFI_OUT_OF_RESOURCES Required resources could not b= e > allocated. >=20 > @retval EFI_BUFFER_TOO_SMALL CpuCacheInfoCount is too small= to > hold the response CpuCacheInfo >=20 > array. CpuCacheInfoCount has b= een updated with the > length needed >=20 > @@ -384,10 +382,7 @@ GetCpuCacheInfo ( > // >=20 > // Initialize COLLECT_CPUID_CACHE_DATA_CONTEXT.MpServices. >=20 > // >=20 > - Status =3D CpuCacheInfoGetMpServices (&Context.MpServices); >=20 > - if (EFI_ERROR(Status)) { >=20 > - return Status; >=20 > - } >=20 > + CpuCacheInfoGetMpServices (&Context.MpServices); >=20 >=20 >=20 > NumberOfProcessors =3D CpuCacheInfoGetNumberOfProcessors > (Context.MpServices); >=20 >=20 >=20 > diff --git a/UefiCpuPkg/Include/Library/CpuCacheInfoLib.h > b/UefiCpuPkg/Include/Library/CpuCacheInfoLib.h > index a23b8b12b5ee..a7f29b188775 100644 > --- a/UefiCpuPkg/Include/Library/CpuCacheInfoLib.h > +++ b/UefiCpuPkg/Include/Library/CpuCacheInfoLib.h > @@ -59,8 +59,6 @@ typedef struct { > @retval EFI_INVALID_PARAMETER CpuCacheInfo is NULL while > CpuCacheInfoCount contains the value >=20 > greater than zero. >=20 > @retval EFI_UNSUPPORTED Processor does not support > CPUID_CACHE_PARAMS Leaf. >=20 > - @retval EFI_NOT_FOUND EDKII_PEI_MP_SERVICES2_PPI or > EFI_MP_SERVICES_PROTOCOL interface >=20 > - is not found. >=20 > @retval EFI_OUT_OF_RESOURCES Required resources could not b= e > allocated. >=20 > @retval EFI_BUFFER_TOO_SMALL CpuCacheInfoCount is too small= to > hold the response CpuCacheInfo >=20 > array. CpuCacheInfoCount has b= een updated with the > length needed >=20 > diff --git a/UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf > b/UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf > index 1fd45380b871..c481080e49d8 100644 > --- a/UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf > +++ b/UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCacheInfoLib.inf > @@ -40,4 +40,4 @@ [Protocols] > [Pcd] >=20 >=20 >=20 > [Depex] >=20 > - TRUE >=20 > + gEfiMpServiceProtocolGuid >=20 > diff --git a/UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf > b/UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf > index c8aa33c95a8f..0c73015cac8b 100644 > --- a/UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf > +++ b/UefiCpuPkg/Library/CpuCacheInfoLib/PeiCpuCacheInfoLib.inf > @@ -40,4 +40,4 @@ [Ppis] > [Pcd] >=20 >=20 >=20 > [Depex] >=20 > - TRUE >=20 > + gEdkiiPeiMpServices2PpiGuid >=20 > -- > 2.28.0.windows.1