From: "Ni, Ray" <ray.ni@intel.com>
To: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement
Date: Tue, 10 Aug 2021 01:47:11 +0000 [thread overview]
Message-ID: <CO1PR11MB4930350211E83048EEB9ABE68CF79@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW3PR11MB46021379FA5415DF9489CC18B6F69@MW3PR11MB4602.namprd11.prod.outlook.com>
Michael,
Allowing the gPeiSmmAccessPpiGuid PPI installation in normal boot will further allow gEfiPeiSmmCommunicationPpiGuid
installation in normal path, while without your change neither of the PPIs is installed in normal boot.
+ Jiewen for potential security concern.
Thanks,
Ray
> -----Original Message-----
> From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Sent: Tuesday, August 10, 2021 6:46 AM
> To: mikuback@linux.microsoft.com; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement
>
> Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
>
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Monday, August 09, 2021 6:40 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3539
>
> PeiInstallSmmAccessPpi() currently requires the boot mode be set to S3 to actually install gEfiPeiMmAccessPpiGuid.
>
> This change removes this requirement in the function implementation for two reasons:
>
> 1. Practical use cases exist to require this PPI in cases other than
> the boot mode being set to BOOT_ON_S3_RESUME.
>
> 2. It is poor API design to implicitly bury this requirement within
> a function whose responsibility is to install the PPI. The caller
> can easily place arbitrary constraints around whether to call
> based on conditions such as the boot mode being
> BOOT_ON_S3_RESUME.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c
> index d9bf4fba983e..4df0d695fdaf 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAcce
> +++ ssLib/PeiSmmAccessLib.c
> @@ -252,19 +252,7 @@ PeiInstallSmmAccessPpi (
> EFI_SMRAM_HOB_DESCRIPTOR_BLOCK *DescriptorBlock;
> SMM_ACCESS_PRIVATE_DATA *SmmAccessPrivate;
> VOID *HobList;
> - EFI_BOOT_MODE BootMode;
>
> - Status = PeiServicesGetBootMode (&BootMode);
> - if (EFI_ERROR (Status)) {
> - //
> - // If not in S3 boot path. do nothing
> - //
> - return EFI_SUCCESS;
> - }
> -
> - if (BootMode != BOOT_ON_S3_RESUME) {
> - return EFI_SUCCESS;
> - }
> //
> // Initialize private data
> //
> --
> 2.28.0.windows.1
next prev parent reply other threads:[~2021-08-10 1:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 13:39 [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Michael Kubacki
2021-08-09 22:46 ` Chaganty, Rangasai V
2021-08-10 1:47 ` Ni, Ray [this message]
2021-08-10 15:36 ` [edk2-devel] " Michael Kubacki
2021-08-12 5:20 ` Ni, Ray
2021-08-18 18:46 ` Michael Kubacki
2021-08-18 21:15 ` Chaganty, Rangasai V
2021-08-19 0:13 ` Michael Kubacki
2021-08-19 2:01 ` Yao, Jiewen
2021-08-19 10:01 ` Ni, Ray
2021-08-19 14:27 ` Yao, Jiewen
2021-08-19 19:45 ` Michael Kubacki
2021-08-20 8:11 ` Ni, Ray
2021-08-20 17:32 ` Michael Kubacki
2021-09-09 14:09 ` Michael Kubacki
2021-09-09 14:51 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930350211E83048EEB9ABE68CF79@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox