From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.2592.1628560034433577902 for ; Mon, 09 Aug 2021 18:47:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yQFV1g6t; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="300405386" X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="300405386" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 18:47:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="505964975" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 09 Aug 2021 18:47:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 9 Aug 2021 18:47:12 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 18:47:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 18:47:12 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 18:47:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N1asbAO4jvPHB6iKDlmBoeLz11eEwlwuz/a+3nwjze2ER4r8raXWCJ7/zx3jku7iWP4n6f+lvDY26HCvDM0Qxmi57rpTY+V+Mmu56h4WzOkStukQcgssRAH+/49b3yqR1Tj5lCmgd4JffQvijyV5/4d9Xchhtr9dHlIJ4N36fQBYtQ6PSwwMXVO6+7uny3n/9HVt13ZcIepqoRTlqisUibX65HZ0z0kXmzSkEL0OPRqURzZ64vxlb2t1IVAeWhtmHHgZHq2QQqQoTt52Wfxx9ycuJl7hheh1QYXcFqdwxmrASwWkU/BEMotvfpOPpqLjhdZlTPUDehlasW8LsvrnGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4GsJxsg2Ku/7zCzfwD8IYbTygXQMVE/SbjeT2hHP1g=; b=oH3Dfj5jDoQ6PvhTai+EAhj5eMrAGBiEDnamBPC3H8rwC3K+GZjDt7kzN9+Zg43mhfbAGaoso5NwIGwvjJtxIIi1bVrsKvSfgTusa6TAcCCtju8VhlwA9wcpCEP9nVva4ji00iP05IeBHsDV9P6wczAStjf7VHCgLRSyUdFQxmV+1qufFfknJ/IMPaov7EZSGCtvvAFC0CrvJqghsf5ebhaHTuPA/DbmYKifCvq+fHx9GZTuz7rz/ZyUCjeoVZMPhgZL3gvpjZoMKIKF7vcIkueje3iBHlkr4fQFoviA0DuQuY2F6nRB7/YCGc2j86xRQcf+oZTJY6UTEYoIk6PnRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4GsJxsg2Ku/7zCzfwD8IYbTygXQMVE/SbjeT2hHP1g=; b=yQFV1g6tOvivpAkrttrMFqVtWQHijMq+iouhKkZy9Ypd4DIpjdcKZEEMPjN1SJviZI64Gj8n+Ir1fjou/Xy7aVf96K2yNhCWEUhZW8Yv7Qzrhk4a5oon076kY2t1P7Ql7p4eJ/6FsG/PPtYOas03GZJ+dWSDKqzoUWTLPFbd0L4= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MW3PR11MB4634.namprd11.prod.outlook.com (2603:10b6:303:54::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.21; Tue, 10 Aug 2021 01:47:11 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865%5]) with mapi id 15.20.4394.023; Tue, 10 Aug 2021 01:47:11 +0000 From: "Ni, Ray" To: "Chaganty, Rangasai V" , "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Yao, Jiewen" Subject: Re: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Thread-Topic: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Thread-Index: AQHXjSQn8KjI+iTiQ06ihTX377ndNKtrxnaAgAAyitA= Date: Tue, 10 Aug 2021 01:47:11 +0000 Message-ID: References: <20210809133938.2430-1-mikuback@linux.microsoft.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.100.41 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3ba3f00-3edb-4839-dc2d-08d95ba0c581 x-ms-traffictypediagnostic: MW3PR11MB4634: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K6c/IhW12Oi37iYKJdCI2aQDhZfMMYZMD+1UF8w+qr/Cj/cV9IhOJ5ZrKvRt8zi2LuWM0EbWPTSt5UM/3G1w2XeSoun9pySZ3AsECZ9Pfupg9w2p4kLv4X6AGXbI47NtUiEb6Zlw9ZGq/6ff7GJdWB8CFZY8K35YT0JZuU6gJB+21pTujwrbhU+eJdYWQFq7g2Az+FqK1NCCvpCqzTtQ8pzDhC93yst6dT/JWYfsUjq9hXj8xg+60i7ib5CEgTshH3vPb5eq54YxS3063D2v+Xe9XASuFlhR8uv367uM0x5nY0tA/1HAikbeCSftl5UGmlCsMQIQQSYk2EV4KR7Yabv7zMfMS6qBxO08puMDpqMmSX7bidPGvPZ9Al7gJjJRHYIdrbocBEC0mnK8Q3djja+I5y3H6A9lSqanI6dOIopuAeuL6AwKF0+XJQvE8oXW7uwukEXZ5HbBvKi8keOjHybhWlXMU+elcfpkraeCsE0cc8619Mv1nP+PqdmLazz2pwI7F4T9NYrYq4x21hF+feHpP8EUXKqY3O3yyFpfZcbfpHdbea2rrWJ20aDVSCbYRQ/JKR//kbyccJrzgyw1+3nB1m/ft9JmnydhXY3htX8QkcZZVuTzNIR15AeqS7Xj3JVbh96s9XNcWfttWsPH93qt/mgHtqV9CKcmFSJoctCFJsUWS1NQjlfd2KrhyXkHGIdEW2YjHsjgkxB/FCzcpb27pzCO79mcodCC0zhZGUKgV9FehCWp24KzUz1+6H36VnblmQJg7KGNhgaVHUswQ8EeCvHpj0105WBWk06pcfk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(376002)(396003)(39860400002)(33656002)(316002)(52536014)(8936002)(110136005)(2906002)(5660300002)(186003)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(8676002)(86362001)(26005)(478600001)(4326008)(83380400001)(107886003)(71200400001)(9686003)(38070700005)(7696005)(55016002)(6506007)(53546011)(38100700002)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tE2tiFZbsLarmMy0oLeJdP2QSyI3IoAETOhvsCUaryX63C7YKzZCgkRCmeHD?= =?us-ascii?Q?HqozwJP6tZD5ZM5VzPGIe1eTmVatvIOL2RGfGqSddAXjlvKg9HTCE7phRuCl?= =?us-ascii?Q?YFhYQ1ySB6Mp6WgCvXSZ7mFli1IZ7kSyJg+iGfhWISWsMK6UDC5gzBSvPj3E?= =?us-ascii?Q?KhHKGwJXfalT7Qzsr2bZf8nCZK+PP7IngQ+gbNYuox7or71Sq8WxpSrrR46Q?= =?us-ascii?Q?sPXfjB6QYuPJdTlShHBeFM/vMtRWdsaJC/j0cbicaVEIBsSMiUTHmvp4Nb74?= =?us-ascii?Q?1zI6Bu0kPAByVlb4+y0aaupKnGWsFn2kR/U0qdcLSpVJ/1p9pwOEeKBU5SkM?= =?us-ascii?Q?VSoieCXN0tOsEQWA6Bsnkrvo9sztNSyMuTaJvGfRFOuZXpkYMwZxtLIfVJn1?= =?us-ascii?Q?9/wqn48gm6Wsih3HMk6dyYN7mxDC4aS9ze8Gq8UIl+Lr2/Wq15atokDNmL5M?= =?us-ascii?Q?pNclq2phKEyqr+mlMZRPltgKcp4ricWSz/a5+rgRTZtBgFAflRqCUtJkXlhQ?= =?us-ascii?Q?zQ5weVRwpqZaJc89XxsArwyz1MrlNhzVrey0otGWwiLx7lswK1DqmlYiGmpT?= =?us-ascii?Q?K0srBfAmpvE8UI8HsKVfl5hfZMT1TphC3SX2aqSuyvUmkKrlYiSVXuIyXYAb?= =?us-ascii?Q?B+VsM4beNjAZUQHhng89ARtH8nFz9FIhRt37WxRIPQP3/P5KLkcJvWUf9pH3?= =?us-ascii?Q?IMPHucAEvN37HW06wfItXoAjpAGqVFWPpN4yJsqZMmht1J/rcHkbDcwzB9ms?= =?us-ascii?Q?lZuXIk5oIj0DjHpQNPvt7dUWLX9q92jP/ZCnXA0tp7WGdjalFVakOUyJZZN2?= =?us-ascii?Q?0hXJVENaC59EMMYlxqjt8CtJ82uXSMHKDojW1rJcvtuMiFacIRApqF/n0AY7?= =?us-ascii?Q?5p34/eSRTIrGdcwJ+NurtM5mfJUV30rkvh9mb7QydcXmjQyQ3bwiICsw0LAo?= =?us-ascii?Q?9QRFOodl8m+Lh3LEUEAh1fOgl3SFS9szsmOttCz6Oy4tcrHbpSYYX2un+DTC?= =?us-ascii?Q?81l3N2wW7H7rCw4u/zVY87wDqdsQkZHyTNLMv3Ci8BoFUEQB+W3ekCNPB4gk?= =?us-ascii?Q?p+9/CFj98EiDgyqhIz08W9CIK8o/7pschXcEqZrMonCW/4MmyiM3kTharDrR?= =?us-ascii?Q?pI+3E2KPy/N74arq48WQ9Co6dwuZnKmQp7HG/3tvrdYsA7fNukrRsdTNrkZu?= =?us-ascii?Q?XFIuXIFtOyJnUY22sKrB+DhS6yJorSvqKiL/UP1lyE2YLQc7cdfgsi0OqffX?= =?us-ascii?Q?jGkJiXt8oza6GYU2BUslH20mNwPjN0txVm9X9M8tr3VzJH6cnKguVXbklNQr?= =?us-ascii?Q?PxuSIUbmOVxlvPbkCy9jiO87?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3ba3f00-3edb-4839-dc2d-08d95ba0c581 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 01:47:11.4978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6ABoa6Qcp6QdCJvSqixOthIa7d3DxyhCFj03TvYluvU6TJO95IrUStHEQjKRGKMP6Ex78k1oyNOC32FTFi5SXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4634 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Michael, Allowing the gPeiSmmAccessPpiGuid PPI installation in normal boot will furt= her allow gEfiPeiSmmCommunicationPpiGuid installation in normal path, while without your change neither of the PPIs = is installed in normal boot. + Jiewen for potential security concern. Thanks, Ray > -----Original Message----- > From: Chaganty, Rangasai V > Sent: Tuesday, August 10, 2021 6:46 AM > To: mikuback@linux.microsoft.com; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessL= ib: Remove S3 requirement >=20 > Reviewed-by: Sai Chaganty >=20 > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Monday, August 09, 2021 6:40 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: = Remove S3 requirement >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3539 >=20 > PeiInstallSmmAccessPpi() currently requires the boot mode be set to S3 to= actually install gEfiPeiMmAccessPpiGuid. >=20 > This change removes this requirement in the function implementation for t= wo reasons: >=20 > 1. Practical use cases exist to require this PPI in cases other than > the boot mode being set to BOOT_ON_S3_RESUME. >=20 > 2. It is poor API design to implicitly bury this requirement within > a function whose responsibility is to install the PPI. The caller > can easily place arbitrary constraints around whether to call > based on conditions such as the boot mode being > BOOT_ON_S3_RESUME. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/= PeiSmmAccessLib.c | 12 ------------ > 1 file changed, 12 deletions(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiS= mmAccessLib/PeiSmmAccessLib.c > b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib= /PeiSmmAccessLib.c > index d9bf4fba983e..4df0d695fdaf 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAcces= sLib/PeiSmmAccessLib.c > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAcce > +++ ssLib/PeiSmmAccessLib.c > @@ -252,19 +252,7 @@ PeiInstallSmmAccessPpi ( > EFI_SMRAM_HOB_DESCRIPTOR_BLOCK *DescriptorBlock; > SMM_ACCESS_PRIVATE_DATA *SmmAccessPrivate; > VOID *HobList; > - EFI_BOOT_MODE BootMode; >=20 > - Status =3D PeiServicesGetBootMode (&BootMode); > - if (EFI_ERROR (Status)) { > - // > - // If not in S3 boot path. do nothing > - // > - return EFI_SUCCESS; > - } > - > - if (BootMode !=3D BOOT_ON_S3_RESUME) { > - return EFI_SUCCESS; > - } > // > // Initialize private data > // > -- > 2.28.0.windows.1