From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.23199.1626662084828961540 for ; Sun, 18 Jul 2021 19:34:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=T9hwhD/2; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10049"; a="272096795" X-IronPort-AV: E=Sophos;i="5.84,250,1620716400"; d="scan'208";a="272096795" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2021 19:34:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,250,1620716400"; d="scan'208";a="461463331" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 18 Jul 2021 19:34:43 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 18 Jul 2021 19:34:42 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 18 Jul 2021 19:34:42 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 18 Jul 2021 19:34:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SGnblri2vE96YDIpjO08avvjTPDmwvjxEesYZVABR6FaeliGfU7eFTvH/2Go0kksXdtTEvSeOsb6Uo+rhE1CjSTgQOF/ipI/wtqgynV7kug9LAw6f2FzMzxlriS3RiiZ8eZCo0KIgtSQ7xa04+C9XLNORYcOQvh9tQTpaAewrX0PjT5t0XaduenUxVAAWjyAvQH400myFhnl+NItSx8Mf9tDuJXn5Oa20DJoEeGB9TmR1+voFR0H3+i2xZnLyreTi2s7ucuoT5cxtfRq6ZYQCNZSKT9/DpTG7ZRPwmxQaCROzupHGS2L6v0La8qom+5BoRg+j3LgrBToWPFCHhO77w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfJ+8oELAG+bOB6RKb61QMNGih2Vj3KrmE2LzMJ8ww8=; b=hyOUmup7XsGvvWieO266v+1REy7vAI4xpuB6GEmV0cYFg//rauAsizipVFY9tS2MtmjniJ04sLgOpdJYYv4JAiqDa2Cf4IyNA0mxEEkhRQvUvkrAXMfK1H24ybvvMJiXIH7e+ffRBmwlHIzB6KZPw+unrFu/TTYwBhXsyALr7va/iK5ys4H23i+lioUM/xZSctlYQtcbO/ujCy0dSjbFTmbp3HJCl65jWg6VRsaqpYKrBZtxlT2IKDLCDbvAZnoeNlj3COME0HFLkahZktX7TkW/H64JsI3+a5SWILQkGmec/pty/wjk9d2l5DGd8EFMnYnnqiJ6HotLDt4It5MOrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfJ+8oELAG+bOB6RKb61QMNGih2Vj3KrmE2LzMJ8ww8=; b=T9hwhD/2s2W4XCyxxFNw5Y+p7PNBpZddx4KBl5Zx6AFKJjSb2gd0Lwl45JWWKyFlbmjrhgHWn1RC11smx5V0vveD1BAVxMuDh6bToDxEsTuOjk7sFslscCuLsK0PjpJIu7Fy/ip3f0PZzEFbqtFgTe59XMWJUZ6o6s2Xk4QqlMo= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5154.namprd11.prod.outlook.com (2603:10b6:303:95::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Mon, 19 Jul 2021 02:34:41 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869%2]) with mapi id 15.20.4331.032; Mon, 19 Jul 2021 02:34:41 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "xiewenyi2@huawei.com" , "Wang, Jian J" , "Wu, Hao A" CC: "songdongkuang@huawei.com" , "wanghuiqiang@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value Thread-Topic: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default value Thread-Index: AQHXeXUgom32SvW8gEiuyRrzxI+GfKtJmSmw Date: Mon, 19 Jul 2021 02:34:41 +0000 Message-ID: References: <1626351895-21064-1-git-send-email-xiewenyi2@huawei.com> <1626351895-21064-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1626351895-21064-2-git-send-email-xiewenyi2@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 818668ac-2a8e-4ba0-5c97-08d94a5dc2f8 x-ms-traffictypediagnostic: CO1PR11MB5154: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6IWZuzA3oer0DRMd3Dm+QVFmacRWhhIltLUC9uPnTEhGRHIImQTle1G2V2VbI7+ojqOhWCTfbaJt4cyu44F1+HDf371bEKYxwD7Y8+WIO4VEuVY1Csi720HKtcUQ+rCzQjiJ2n4FvO0ebqy5cwrXeU/qHV8BL8Odc5B/PGGvekxOSTfmhae5EHsBfPC0VZn6zm4HaBcw3FUCTH0gwyuVZrM9nX/qfl/KAfXoCdPI37gvkT3SYwlWNkZCPoW0uR++ZkHQC0RLkmd9L766kswcQNaoxHhM9MgpAS4470cz0YdR5M7M9KxYCT0JaiYQhG5wpnMMxcJAF/Dhv6GI4hlXHb1zTLPQl6ZVXMwDaQtsWivsd5MAVLr4Ga4dw4/yWqSOhUhsk8h4x2sbB/fSuVfGUoxQhAxBGgJlYtd1GewqAx+DtFq7TbtVFNGDM0YvQ03N8OaUtpNzc+gtJdHvtJjdQOP2YiPWRrpW8oCgWN6F8Kt7BgF1xJ6jco9+betmsyyCdPQR7pJk7M5Sz53pvqawLDoVW0w500tqy51WY1XTc+BTjYoEoDTcemVz5wQnHRMWaWdIMPHG2kmNvwq1IzeRgWz360G/QCAkwr05p5Zqt05u952lCnPIMWi52NABPn7PXrLMAiteaSUK+0Vf0g3jvJYR8vNtS3dAmx3BH8m7X3FtRVifOti7eJ2tBUAsjRvRl1BJsy2xcqS/IKyq8PIu9AjcthpRqvOnWCSTiE2Y7a6BSngl3VkjAcxugoW/6EJ1Hj3mmeBRU67DO3SV8hwHCpVmOJHpQs3EszTU+lSKxdGOKwx9WUT4mLqm/WNB4AUH+Mq6EWRH4fezzJhYTJ41ZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7696005)(966005)(52536014)(55016002)(53546011)(508600001)(8936002)(66946007)(9686003)(83380400001)(76116006)(5660300002)(66476007)(66446008)(64756008)(66556008)(38100700002)(122000001)(4326008)(2906002)(110136005)(71200400001)(6636002)(6506007)(8676002)(33656002)(86362001)(54906003)(316002)(186003)(26005)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3VI4GrVf8CUmjGjd/xpDOierAcvPZ3wazCZj+qj0o6jAuF8Ly8jhghKgJ2wP?= =?us-ascii?Q?JxO9dcdlRNOpEzKrjeovpq8fHfkfnfjHvDjSSYrQvoV320dJsu04HM7sbOPR?= =?us-ascii?Q?mLtRnvwvfyAFsMbRWGx9xtcEWpYBs7j1nQbJBUrWp3oTmh2npQILIILB9pxb?= =?us-ascii?Q?8hoWATF7mvbu8MxlWYOdpaxk8vDZAkdzTeVMbjMmfjtJxqSEYmrn3gD65Zwf?= =?us-ascii?Q?95IvuBSrg8KiSJp4FirSXcBxCH1vp0Q4F/ze+vE/dXWcHytA9JXpQfKP/S7s?= =?us-ascii?Q?uQvxLcrWZ6TvVW5QIvQCrEyLetzAuI4R/XT1KqPdP76jyZxscQzGOJKAsR2e?= =?us-ascii?Q?hgRhf2FSZSsr4BO8PNnpq37yOTV3VgMSLxkwfpBqb3yNa0wx1yPMIkgcozE5?= =?us-ascii?Q?0rHVjtClMk2zoPNLyGs9PdvTUDbqGtXmTGMj8Wd/1JztUzdMiF4GxbkR9cjR?= =?us-ascii?Q?Klu9ZlbnILVuHnyIPTLKGmGgMalgS63fUwPZ8jt4q4NygM+3fr9W4V3l3IA8?= =?us-ascii?Q?rV5cpYoZIKibpYvqqrmOIYi2EQAZ55FW8+bS0GVhMgHCCxQxyd+lvkQUXMc9?= =?us-ascii?Q?GHjcKVtZnTIt5XCEaQF5iDErBOk0TuzbtecEcJKyUPvbsmQXkb9VfBBXmY+n?= =?us-ascii?Q?mEiT2oJJ7S0kz65K58IHRBxI7dxkcvAQ/3l9kyDudthYKBOa0E/+OXPJiLTk?= =?us-ascii?Q?y9SdFbkjvWgbpTBzszi/1ddPHnOozN2xiwVUm4ChTG26FoTW4YvgpwBmiUQ6?= =?us-ascii?Q?1E0Vng/oxohOm/MGv5efKpnWMRdvbkFQZq3jsGjFXoTodlMv+18V2DYElBqT?= =?us-ascii?Q?BxtCgCXyu3FMaKOIGqkavgtc6jZEDxuFsEZZpGeTQxZAw+EoJPPXbU1K03EI?= =?us-ascii?Q?dA1GZhrEwR5RAz7P7BGHon/auvrGPl3cxXOdu6xOiJKhLQFbR59Og7/AqF+G?= =?us-ascii?Q?tAqXaXjxOlgSemExiGdcNYEtP8HNMbcQsD+/jdvtFOAAJMVxfP9gM4Pz53g/?= =?us-ascii?Q?0CgPlZuqz8exRDlG5QmKml1Z4dEDH19Lo3SERIEAqcEUp7CqdUvU6FCZjRk6?= =?us-ascii?Q?WqWssKLlEF5ljX7jJVxUhmdQUuKh0MoClbgjSyLBirt/RZNN3zBKJvY8bV7u?= =?us-ascii?Q?fPm9ii94TojE5JZI5TUOdZ4F0wAHHkyeBrj7nceNJxztbR5t/iHh8rqK2RJb?= =?us-ascii?Q?4vzBQ4HUBxZjhjTDVfzymV5ftR2seej7aqVfgYSLpuEekz9oVQsgo8Ublx+d?= =?us-ascii?Q?35gk67LL3MkzJ/sTmNJszT9jRp2AyUGt+c2C9+ShjRnrDJxsGMWXcliiNvqa?= =?us-ascii?Q?iPNOeSe/nG3kJ6xtKIg0H721?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 818668ac-2a8e-4ba0-5c97-08d94a5dc2f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 02:34:41.2389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kHr+lE3sC90ZhztfIel/Q0GYTnxBTcnmqAmwmte1cKry73gHeL3o7JSKh9GRwZI9FoigY7jymc+wwimfpodOxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5154 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Wenyi, Can you explain a bit more about "if 52 bit physical address need to be su= pported, page size should also be set to 64KB alignment"? Can the platform DSC override this value instead of changing the default v= alue in MdeModulePkg.dec which impacts all platforms? Thanks, Ray -----Original Message----- From: devel@edk2.groups.io On Behalf Of wenyi,xie v= ia groups.io Sent: Thursday, July 15, 2021 8:25 PM To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A = Cc: songdongkuang@huawei.com; wanghuiqiang@huawei.com; xiewenyi2@huawei.co= m Subject: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg: Modify PCD default= value From: "wenyi.xie" The default value of PcdSrIovSystemPageSize is 0x1, it means the memory BA= R is 4KB alignment. When page size of OS is set to 64KB, as the resource pa= rtitions are different between OS and BIOS, it will cause pcie failture. An= d if 52 bit physical address need to be supported, page size should also be= set to 64KB alignment. So modify the default vaule of PcdSrIovSystemPageSize to 0x10 can meet the= requirement above. And even if the OS is 4KB alignment, new value of PCD i= s compatible for this situation. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Wenyi Xie --- MdeModulePkg/MdeModulePkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec= index ad84421cf3..426ea1b6cc 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1853,7 +1853,7 @@ # BIT0 set indicates 4KB alignment
# BIT1 set indicates 8KB alignment
# @Prompt SRIOV system page size. - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1|UINT32|0x1000= 0047 + + gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x10|UINT32|0x10 + 000047 =20 ## SMBIOS version. # @Prompt SMBIOS version. -- 2.20.1.windows.1