From: "Ni, Ray" <ray.ni@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change
Date: Tue, 13 Oct 2020 02:54:09 +0000 [thread overview]
Message-ID: <CO1PR11MB49304128A99A39CF5892E2BF8C040@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201012072230.46152-1-zhichao.gao@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Monday, October 12, 2020 3:23 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843
>
> Revert the patch to change the block size in child handler. It would
> block the CD (Eltorito) Hard disk media type's sub partition being
> observed.
> The blocksize patch used to fix the CD image's MBR table issue. The
> CD MBR table would always be ignored because it would be handled
> by the Eltorito partition handler first and never go into the MBR
> handler. So directly revert it.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
> index f10ce7c65b..473e091320 100644
> --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
> +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c
> @@ -1149,8 +1149,8 @@ PartitionInstallChildHandle (
>
> Private->Signature = PARTITION_PRIVATE_DATA_SIGNATURE;
>
> - Private->Start = MultU64x32 (Start, BlockSize);
> - Private->End = MultU64x32 (End + 1, BlockSize);
> + Private->Start = MultU64x32 (Start, ParentBlockIo->Media->BlockSize);
> + Private->End = MultU64x32 (End + 1, ParentBlockIo->Media->BlockSize);
>
> Private->BlockSize = BlockSize;
> Private->ParentBlockIo = ParentBlockIo;
> @@ -1187,7 +1187,13 @@ PartitionInstallChildHandle (
>
> Private->Media.IoAlign = 0;
> Private->Media.LogicalPartition = TRUE;
> - Private->Media.LastBlock = End - Start;
> + Private->Media.LastBlock = DivU64x32 (
> + MultU64x32 (
> + End - Start + 1,
> + ParentBlockIo->Media->BlockSize
> + ),
> + BlockSize
> + ) - 1;
>
> Private->Media.BlockSize = (UINT32) BlockSize;
>
> --
> 2.21.0.windows.1
next prev parent reply other threads:[~2020-10-13 2:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 7:22 [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Gao, Zhichao
2020-10-13 2:54 ` Ni, Ray [this message]
2020-10-14 5:58 ` [edk2-devel] " Zhiguang Liu
2020-10-15 10:17 ` Laszlo Ersek
2020-10-16 6:42 ` Gary Lin
2020-10-19 2:45 ` Gao, Zhichao
2020-10-19 5:56 ` Ni, Ray
2020-10-19 9:35 ` Gao, Zhichao
2020-10-19 13:12 ` Laszlo Ersek
2020-10-20 1:06 ` Gao, Zhichao
2020-10-20 9:52 ` Laszlo Ersek
2020-10-21 1:33 ` Gao, Zhichao
2020-10-21 12:26 ` Laszlo Ersek
2020-10-22 5:36 ` Gao, Zhichao
2020-10-19 12:46 ` Laszlo Ersek
2020-10-19 2:41 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49304128A99A39CF5892E2BF8C040@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox