From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.3245.1602557655276231649 for ; Mon, 12 Oct 2020 19:54:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=G4qZSIIc; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) IronPort-SDR: wbaFjJeIAzqnhOzbcKoqjI0MtgIvqEtC1mDiuO2tApdUZ4FqkxBpKXwrxw8GRW2ZiTgwrnCEHY J8SeMQ977Aaw== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="152766554" X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="152766554" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 19:54:14 -0700 IronPort-SDR: llPAmXsrg6utQd8yFOuoxM5qgDOsHjIb1+cKqMVsowlE53o6HWEMRP/rujHlRhIyMC2QFAEUTO 3hiGXVcz+A5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="530212007" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 12 Oct 2020 19:54:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 12 Oct 2020 19:54:13 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 12 Oct 2020 19:54:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 12 Oct 2020 19:54:13 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 12 Oct 2020 19:54:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFa0BH7v+t49BvvWMTicw6ExAjLjPOE4vadcCnKhrML2oTB0ZXijgS9Kw3e/IVJYHZj1UWklPu/RCnKkTbd6vMw7axFRWo/RSz+1QhO1vs41h4SwizWKehGsxtz1jjqUhGITMZMpAE/OREKlWnx9Q7o21uFGksxMs0QlJawJ0h4tSPtOZvmcrrMGxyMH84tWeMGVFTj3fHJ8ot5wpAa+u2ZfRWBl4JnZwg2NLy/MpmQ8o5rcVDgYDaLq5f5DWTEN602ICKhwFthPzOr1OPY/IH347xVSqtMsPBGvriEk0QAbkWdJZ87lADM5zrzOzEVkcwM0SuXK47UndbitWKPQxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWapvW2Xt5EyyVHBBW5YdXxyt+W4oQ05wc1WlYsVWps=; b=GlEqsOlb1Cl3hgzQoTKGMraiuOWlTlYLSuX4+oKCPfkGH9WECl5Hnj0z1OoEV8xVZdzHVKJQA7eQoPxKazuZJnp2VjfT7Dx0eoBHXwnrv8EgOZkZWU4Lhq+qDZyLA6bYm2+6b9nDwDpVLEDpzfQAGvbAeEp+cZAnnlFgGr4Mic/a1Co2EGEbO38cvKqOFjKOy/lOpynzgUM6sH1eZlckmsHyac+IbK40cV6FySFkdKZBInzzHnKc9TO1aBxcgL28Gh0xgz6mJbTwKIuVh+onxdVrXU54kvTo/7lW0T0GBw9H8kJIQVyERv1CenfAZm7/mcJ0wSIraxtA23KGM6CxTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWapvW2Xt5EyyVHBBW5YdXxyt+W4oQ05wc1WlYsVWps=; b=G4qZSIIcxPAGr1VLbMwV3K74FM8qWB2pS7bT2YNnz55qLQIgj0e/jNM/osxldCuTylJIASPuNTYOJl2kaUK/Eoz1Z7DOGABwxcPaijGc+G9EjGLZ9lZYpCBJbmOsxYwefNJvSSJtLlbbOMC2B/EQKEiTccewqCcSVpB7bEewDo8= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1615.namprd11.prod.outlook.com (2603:10b6:301:c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Tue, 13 Oct 2020 02:54:09 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::9804:f9c4:d0d7:9961]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::9804:f9c4:d0d7:9961%3]) with mapi id 15.20.3455.029; Tue, 13 Oct 2020 02:54:09 +0000 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wu, Hao A" Subject: Re: [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Thread-Topic: [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Thread-Index: AQHWoGiGCXf9EMfMvUaKOPLqN2LlJamU1zqQ Date: Tue, 13 Oct 2020 02:54:09 +0000 Message-ID: References: <20201012072230.46152-1-zhichao.gao@intel.com> In-Reply-To: <20201012072230.46152-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [222.67.55.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c53eb30-eed3-4d32-4098-08d86f234224 x-ms-traffictypediagnostic: MWHPR11MB1615: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Giw6IZ4s9DE0PFxOp9T3ZRt6Jtct821lg6COPKj2BypKBQmij7BCHK+y4wYY9YOfao4Mf2B2P3gaJY2oZ7RlflYMIrNOkdmBGHUlitY1OPlRCIv7Xr2vZ4kb19pReeu3geJfcKELEvx8Mp/jCk9IH9cHp4TnPww6r2X3TylTmTiEMUmYJs8X9LIyCB7ogXgbUZ45FDVY0nT9ut8X89e8m7O35P2Rqp6WFzssmUeC/ueDhN4zw9P0xfA4EcZNS9tuIMkFwOs9rc1uT2OaEpUcEwLvHz2AP4AO0YTZxiC4+wnmiC8Y+3bEnToI/r8tHy/+4EqiDKvtqQd0+fLXJuDS8VBuglv1Z072jnFWYC2DAHjU5330xLMDJdTSX66uZhBhTMYARtaMcuZJbatIq9S83g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(9686003)(8676002)(5660300002)(53546011)(8936002)(71200400001)(107886003)(316002)(110136005)(4326008)(86362001)(2906002)(186003)(26005)(7696005)(966005)(52536014)(33656002)(83380400001)(66946007)(66476007)(66446008)(76116006)(66556008)(64756008)(55016002)(83080400001)(478600001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: +SPpIFge1sKAKv4peJ0TUgl0/2WRln3UEcQq1vFUxkuiedyYSAOE7sBkSP9xeS6yoHs9JMK++mOz+1vGeOgrEgLJIwv/+LWa6jch3DFPfHBSrMHdALf+iKnH8ANwWu9Tu7WfQNOeygIdECd09xDOUgW6nTpIRuC+7yGCz+Xfb1qweRA3/M2U9yNJgSfe/tt61D6V5bIh0bvtf5FTZWVdrxpRb4kDGTEwMqAsMm2W2zgo40qOkFH1vn5SHAigTtcHDY7fFlTrvV7ZnsJ7hEqOc/7fXAky6Wr91T+oQRH5V3pbLEjxsDuRQniTGiv9sW4FNHmO20ldaeyIvbVrC9nn9dI4kYXBfZzVlI05ZVA4auf0NQqXP+wfa3YG908NnU6YgiGzEb9kZYXCw3xNQ7FyrRR0TfP3EjsTrnkyNjjET3DnyKEUHNgXdL/6EVSG5PnaJ18nsSKbVrqKHHQhI4eLrkT4Na2jHU1cjy+rZCmdGWev/a4+5lT1znJSiuAA4bud8wBu6OlQSqQD8gsEpdVOA1eVshAD6ftxDVMCcRKrr9YzP/+1ToYyQ7v76ECnAXk+MXp1+jASCiHBx66VLwFt2tcl766z5g1nFcRQAeTC8a8GCk4tLXehvdCIfr7v+Up/V1sJN0pL6yvpjdOuhRkwNA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c53eb30-eed3-4d32-4098-08d86f234224 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2020 02:54:09.6130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A/xO69YuU8VsjNIz7IF5Ap13rwRiCaygxWvV0S5X0gKSLtQ/oJhwhlKU4JFnMZT4rK8D3WgAXTwXzPdkbr1R4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1615 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, October 12, 2020 3:23 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wu, Hao A > Subject: [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler bloc= ksize change >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2843 >=20 > Revert the patch to change the block size in child handler. It would > block the CD (Eltorito) Hard disk media type's sub partition being > observed. > The blocksize patch used to fix the CD image's MBR table issue. The > CD MBR table would always be ignored because it would be handled > by the Eltorito partition handler first and never go into the MBR > handler. So directly revert it. >=20 > Cc: Ray Ni > Cc: Hao A Wu > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeMo= dulePkg/Universal/Disk/PartitionDxe/Partition.c > index f10ce7c65b..473e091320 100644 > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > @@ -1149,8 +1149,8 @@ PartitionInstallChildHandle ( >=20 > Private->Signature =3D PARTITION_PRIVATE_DATA_SIGNATURE; >=20 > - Private->Start =3D MultU64x32 (Start, BlockSize); > - Private->End =3D MultU64x32 (End + 1, BlockSize); > + Private->Start =3D MultU64x32 (Start, ParentBlockIo->Media-= >BlockSize); > + Private->End =3D MultU64x32 (End + 1, ParentBlockIo->Medi= a->BlockSize); >=20 > Private->BlockSize =3D BlockSize; > Private->ParentBlockIo =3D ParentBlockIo; > @@ -1187,7 +1187,13 @@ PartitionInstallChildHandle ( >=20 > Private->Media.IoAlign =3D 0; > Private->Media.LogicalPartition =3D TRUE; > - Private->Media.LastBlock =3D End - Start; > + Private->Media.LastBlock =3D DivU64x32 ( > + MultU64x32 ( > + End - Start + 1, > + ParentBlockIo->Media->BlockSize > + ), > + BlockSize > + ) - 1; >=20 > Private->Media.BlockSize =3D (UINT32) BlockSize; >=20 > -- > 2.21.0.windows.1