From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.4111.1606962192563919156 for ; Wed, 02 Dec 2020 18:23:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=WPaWgUQe; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) IronPort-SDR: kLgtuIR+CdezvyRLrdPFJ6CvMUsEk4gU+ZSL1RC3m33UpGRrHlrmXAh5U+UK0ETgYp9F8E2+Gr lBmAXM1Ln8kQ== X-IronPort-AV: E=McAfee;i="6000,8403,9823"; a="169616853" X-IronPort-AV: E=Sophos;i="5.78,388,1599548400"; d="scan'208";a="169616853" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 18:23:11 -0800 IronPort-SDR: hSqXyRaLTm0rh/W3/u52ybGh+tnANd6a/CNKcUysSDsBG3K+wyZBKVLASJ9mR4IFI2xe8td2Ms TOvG0V+5XIlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,388,1599548400"; d="scan'208";a="330678084" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 02 Dec 2020 18:23:11 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 2 Dec 2020 18:23:11 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 2 Dec 2020 18:23:10 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 2 Dec 2020 18:23:10 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 2 Dec 2020 18:23:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGvxGbVtXHjLFaI43z86BVlj71oldTz4q6DhSLDmJoDAG+3lUxQ/w4rzVl1CPhOiSC1LPBet+FkObKMqWCw5ekiApFyeykkUrr64om72KgNTEIcQZQEimUZjmJmjaHtnAXmfadlmt0kpek3sVw1dNIwwbIutlTHYPFPVUImrL4QyvwoIZU7w7WRRcjZ+ciiJsRamUZs+My0m9bijthOp0roH9BTVii9kKG7bIbAnmFgjiooYeje4IHc6Wngfw106kk4T+jShaabxcIw4ZdTUlV6Mw57yrY9youq8yx2gT/l70A13/IwSe+U3gl0Vc3YksQAztXgIwIdtzCkZi+bJLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N1hSYZc3eB3UUHzWxrtEXA6SiMtBCq+1ReH2WAoG8Mg=; b=Hj+ei4JHNRfyR3lnR1/KR6aQ07f6u2qwU/BHYa22W+FJDmxsn0M1b6DOubq1xH5YF+BrsPBzDAviaks10ThDJto3LVauF4z7AfiL/L7wKjZSunHw5VbUadxklARaXTO0xMa2wxgA6WpPY1p3gd3tS2nu9YJj0xs1grMYW5tfzwjgZp4z7e7GDvcqcyoU2s9QC7G93C9uoUcO0K3gDItGQohtWi0ANw/ZnHiDEsvaTpW15Mrlx9SDRB2SCyUPCZ8umB8/RfKnqkf0FbaYM7Kpv7XGbOlmKLlgaJU9qyJguV95fdtTOwtUsv66wbhpDo0pszeLvX6h12u5gfxyICB9ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N1hSYZc3eB3UUHzWxrtEXA6SiMtBCq+1ReH2WAoG8Mg=; b=WPaWgUQei+PDxq/wnMAs4wQry4yQdhO996/e3wZN4+0S5ktoQUyF5R1A9w5W9IPnefqFEkePAmjwSR4gpqfj0kNfUs7USBSfJaUGj4Epk9NQ1V89QvlNZdVgNNS7n0rxZl3d0d5CMgztK3X0x/4Uj2gJifvRRLjPNfvvxmY/Gug= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MW3PR11MB4745.namprd11.prod.outlook.com (2603:10b6:303:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Thu, 3 Dec 2020 02:23:09 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3611.031; Thu, 3 Dec 2020 02:23:09 +0000 From: "Ni, Ray" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Dong, Eric" , "lersek@redhat.com" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuDxe: Fix boot error Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/CpuDxe: Fix boot error Thread-Index: AQHWyPOBNOLkSmzgrEmEVUKxZl9OrankpBeg Date: Thu, 3 Dec 2020 02:23:09 +0000 Message-ID: References: <20201202213833.23316-1-guo.dong@intel.com> In-Reply-To: <20201202213833.23316-1-guo.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9eb9f99-4666-4443-d363-08d897326050 x-ms-traffictypediagnostic: MW3PR11MB4745: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FRKsJoimeZf0iNmFHxtmseY58hE4rOvhp/BayefutMv+L5SAU8ryOvEktsFKcGfucPwp4tCWt/FJtwkA5+l0yikviMkQovwdAxJ7dwmKxdJphay80IY40HBRoIwoJJOJlto4zXhbRsHwZTUkjEJ86Us7e0duAmZSuphhEVivMe4Ci7hTkTwl0gNzBpLqRIKn3lNKUZvV87CE/+Kh5ccYJ2fAgtO72JjnZXbeNV8xeyDg5XFyRJgFmkClLCXgiVKqAQW17Wr5g3xSGuSEcWdS0uM9hv2OSAbF+THGcMVpOuJedGX/ksdd9AS3fYgdwIgSbviLOcWzlM7FE2X4A+0o7NBg/wMR4EMS7SyxqnDaL4ZI88tso636aT9CF1ULKIhjTlc5HUzfV30d9BIzlY+C5Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(396003)(136003)(346002)(39860400002)(66476007)(53546011)(9686003)(66946007)(6506007)(7696005)(966005)(110136005)(316002)(26005)(83380400001)(54906003)(186003)(55016002)(64756008)(86362001)(19627235002)(71200400001)(478600001)(4326008)(2906002)(107886003)(8936002)(52536014)(8676002)(66556008)(76116006)(5660300002)(66446008)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rw7AtNOhvPZ4S9h2vWx4KjDKxHYLNs1eEBxAqsU6zDuVMgaawa/annKpIWP8?= =?us-ascii?Q?x5GxgXMM9/PaSxuyKmOj2q20XHrpr9MUbyNOZ5+vdI5McEvwuWWw0sHsinZn?= =?us-ascii?Q?+QLDjVEmS2kjuH/WEdabpZS0xMMnFHrpCC6/R5W18keaPIEDpHmuTQN8cNUz?= =?us-ascii?Q?4wzCQUbSkGNgyUKcqI8phCelmTxBA75sIdaGtzjMWsGK5UFOG5Qtj39/Z0DT?= =?us-ascii?Q?X1jCeX+EHpG6O4WhIDO4MLWPfvonNlwqR4bW5yCWtY86KWXmExat0waOF+HU?= =?us-ascii?Q?a/Y4dd6EyuT1FO/Gt4plWQwnc2uWG2WfDcHwo/XoJhJkQ38f3cceBDSZH7a+?= =?us-ascii?Q?h5nTJ7o/2CajX8eUfrKQ0DP6b+cVugMzLn+UNUr7DjMg2HXOvAiBXccKoqou?= =?us-ascii?Q?/5t1X2fZgmHT1OvkgcrV2uKFJPsopoerOq3plYEBqYn/uN/f/o79/h2hOckz?= =?us-ascii?Q?vOwhvnHlGP0kck/o8gUID9PpiJVp69XGIPcI+Nr5wUNJAemS/6jUV55pirOI?= =?us-ascii?Q?1mgK1Jl6nIZW21w3Nv5SML9dRxEc0/1YkNq9E5AtS+wbdUWwXJ/lgkg13NYj?= =?us-ascii?Q?OtAyRXz/Gz0N5SxJ2SzqTCYEIi/K1wOKTaS9A4rtsXkAvqzBxPk5QebUSZOl?= =?us-ascii?Q?Zuy/ZW4zpsJIhJqRcLXakzd6Fb3+N5QmjBwfaHehzeA3bpIN1nFhuOyTBMKW?= =?us-ascii?Q?IFT1Zj0gXJAQIxOdb6aGrVBxeVN+UwKAebR+3rKwVSXT+Cx2GKltpeL6L8ii?= =?us-ascii?Q?m/tZJTnqsnz59HF+Mh7g8+L0k7xuxcgDHO2DfM25+PdsEGqrdTBFaCYl1CQo?= =?us-ascii?Q?DEjK+K1OjUmnOQf5NLRiWlBQ1CCTtjVEyYqa8f86lbnA758slWlFKuZcUEug?= =?us-ascii?Q?+Bc91jslcXyEe5fAIZONpLJ2wkpjodqZKpuJkea4JfWY1Fp08reQ8EaUF2C3?= =?us-ascii?Q?T1jd6gpNTdlEnghLP9MBQJSOqFreC5Ud33tC7OHZrDf9RM5Ur/rAFrJlZASU?= =?us-ascii?Q?gZPb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9eb9f99-4666-4443-d363-08d897326050 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2020 02:23:09.1470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1dkAnLBpMTkCc6FHg7RUvW92PSyqCJ/CL3sBGDAChXitf/YViiaJb4dYWVMkeWRjPGxZ0IvfhqvtzKaOrOii4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4745 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Guo Dong > Sent: Thursday, December 3, 2020 5:39 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; > lersek@redhat.com; Kumar, Rahul1 > Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuDxe: Fix boot error >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3084 >=20 > When DXE drivers are dispatched above 4GB memory and > the system is already in 64bit mode, the address > setCodeSelectorLongJump in stack will be override > by parameter. so change to use 64bit address and > jump to qword address. >=20 > Signed-off-by: Guo Dong > --- > UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm > b/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm > index c3489bcc3e..6ad32b49f4 100644 > --- a/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm > +++ b/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm > @@ -23,8 +23,8 @@ ASM_PFX(SetCodeSelector): > sub rsp, 0x10 > lea rax, [setCodeSelectorLongJump] > mov [rsp], rax > - mov [rsp+4], cx > - jmp dword far [rsp] > + mov [rsp+8], cx > + jmp qword far [rsp] > setCodeSelectorLongJump: > add rsp, 0x10 > ret > -- > 2.16.2.windows.1