From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.5405.1617872055662063443 for ; Thu, 08 Apr 2021 01:54:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gWvBCivl; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) IronPort-SDR: Sh8+AXpL+cJf9cMCG7G8jD99Zk4Gml/Dx7hZvUOI2iX3+6Gqd68KLgi1EckQEiU9W49IGOoPpl wcr/nA9wyjpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="193034483" X-IronPort-AV: E=Sophos;i="5.82,205,1613462400"; d="scan'208";a="193034483" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 01:54:14 -0700 IronPort-SDR: Znjbaq/V9kt7trtLd1ZX/1KtmPEq5T4H8Wj2z6VcG4nDeJE3yEWV+T7Tz9SomGS2MBogB3iFz8 i2UvMQ/LZgfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,205,1613462400"; d="scan'208";a="380173875" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 08 Apr 2021 01:54:14 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 01:54:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 8 Apr 2021 01:54:13 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 8 Apr 2021 01:54:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFFyZcV2ItuMmOpH90gHSSJTI7NHdQp14u8j6YGocQPUPt8CURKpB5KBBgHvc7+jbFjal6h+N3r5XviYwXI4WtUR6jKEDJfm823C67ER0bntP0PRB+qYVLedQAj8xV3gw6/bMEX0vMd3+hMTMvLFLQuG15oGFRt6jOxT/44jbC/25JmIi00BbL/9+y8Fo/BxPpL8VsRC2BROToBdsKtAJWg0Nc0qLq5/w98jtli7ztq8f87sDwaX1u02SuN5GnKONCEMIhZdYRDMxH4Z2/1nRfh16PCDtWZ+/V4rpgW0HDskwgN0lmK9Tt9UL3nfIAVfoqH/8I4iPC2+c2oVXD1zBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2/0cpU8F6MqEmvEFEmpuq91llcbz0st2D36HmFwY2I=; b=cwFRqykLZ/QL81BkpxvA1uLKLj7wSchARvDgbpLmkq9IScPJXiFE78AnZmTuHUEh2Sjp8wz6NLsv20zMaXVRDoNzOY0ZmrUg4eQod93jZ5O6B0h+FwcMb/nVTDqiOVA4GVuO/Y/TFqos5s1YqRlL5hDb7BCJ2ODVbXpjDpbRo5GR0jK5FUnD/iiUsdR6Xr6Nxe/aKVU4HtSh4CocC2dPAlQV3azoLRpIP40hGR4pbxIvzfh2iv+hdk3CMbtbC7gKpZToF+KRPtFxYWSTTiJNlX7UFZy2oCrIzipOE25AtVbKXnT6l0mRcWZcEAfHtiSzPeAJyDp8tsI+rCkWfM/H5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2/0cpU8F6MqEmvEFEmpuq91llcbz0st2D36HmFwY2I=; b=gWvBCivlVVXI3GlNhFekSc6Tprccp9QRtSWKTK0FALv2dCLKafBS4FcODxySTHViPc+A69/asBd0drNoNw7OMMbwb1QdKXQgWHvQY1BeBlcGxhwJKbKogVv1Y2nlfaV8g31ryEOuI8gcp4we7PzDFEhSehWkUxdskMLcNa9VSgs= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1613.namprd11.prod.outlook.com (2603:10b6:301:e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Thu, 8 Apr 2021 08:54:12 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7%5]) with mapi id 15.20.4020.018; Thu, 8 Apr 2021 08:54:12 +0000 From: "Ni, Ray" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [PATCH] MinPlatformPkg: Add PcdFlashMicrocodeOffset Thread-Topic: [PATCH] MinPlatformPkg: Add PcdFlashMicrocodeOffset Thread-Index: AQHXLE44JpH1vP9y3EiwJTpMwwoSAKqqRXJAgAAClnA= Date: Thu, 8 Apr 2021 08:54:11 +0000 Message-ID: References: <20210408080711.1789-1-ray.ni@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eaf793dc-26c3-43f9-6626-08d8fa6be13f x-ms-traffictypediagnostic: MWHPR11MB1613: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j0AdDYGLI0tWThRvlsOVi/P7Ujnpoyafp/mAwgwTe6RJuCQ76oE0guQpnn1t5N7gysAhP+yOrjIwiKzWAoYLk7aRJkB5pML3g4eZXfj9R+Wd/YLXjHx6/JPkAaCXLEgp1E00YNxKbC+FL5OZ+qSjeCwtdTtI6MgZmFZCQfqXPMx5PkXhx5r6a+Dkz3RCwTlIkPpsICsfEqxKcLzHidJVMGBEgvqf5L+oKC69ZftHJZOpvuB09enOfPz/+UJrSJ4TpDaB1ep5FREFZYc03kmEzSCmTm609ON747d49psygnD0I3VexImAKjpObpWHIeyhiifnS8l+5MUHk7tLEl5D1H/ZiaVU3HZOMk3MAOlPIec6oQ6IHDjBPWYaSVcvyFgk3wZzWPg+QhZ10xqHTnHDCax2o9v4tMInkNHHosiZyeoZmScm65beukXsnWQcmQp8jN6puEfX7Iv8P6UyhicikXoNIP5szZymYCXyI6VcbtHOC4I9YpbHM2l54LeyhjT4OG/3SmvuiFuv3cIFGJGwbyJeNexuo1VHFWpC8lh9yDSXQbLkLnDdz0sjXAmi2/z4I3htXHntUUBLNYAIl2ijFqR9wgNXm6lQRc18vAUSW2vS/IBK6vvDhZwHCMQr+3EYxxI41cRDrd5hpruAhyDEQDnv/hqB/lH6fc1YHs51F3g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(366004)(376002)(396003)(346002)(186003)(66446008)(19627235002)(64756008)(83380400001)(66476007)(2906002)(9686003)(107886003)(6506007)(316002)(38100700001)(52536014)(76116006)(110136005)(5660300002)(55016002)(8676002)(66556008)(478600001)(71200400001)(86362001)(7696005)(4326008)(66946007)(26005)(33656002)(8936002)(54906003)(4744005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yfFM9JOzBVgHiWvlvPn/QkNINRfngVXCZdpKEPXdQNwBWcKVsXgvBe5L3C2t?= =?us-ascii?Q?w1QGiGvYjllQReStE1s9cuylPL6G2UWc3GQCSseWH3vaJR+wzWHxdODaYEe2?= =?us-ascii?Q?rAhMq+OqCy+MgrQDeiDFayyewyYH5Wsd0T3+VNlXI/pPLUCDS6zPkbMqGcVV?= =?us-ascii?Q?Pi/sASpPjNO0911XtreSMmjVgoKh7cfbe4kvYaG4sk8K6JGdSAnmGbHIx8ja?= =?us-ascii?Q?cgdYBO7eQFuWTYM7ZudOHrXtwGcI2L2aW0C9iu8vz6FzUOW224+V2CysZCcJ?= =?us-ascii?Q?W/u9EfSaML7JvmQX8usxe0DNU0iYDlWiQMODBqvLk42Gw72tvrhwg7ziNohx?= =?us-ascii?Q?K4ROUV9WMbfGENyHmJ8vzDUIgyr4NWRGbttAeh5rE3RW9cUv8gn0PPBvMMIV?= =?us-ascii?Q?lfCIiLpYWH6JcAuqg8ek/amVW+ddOEr3RxRv/isTWa+lC/N9+IdKJL3xcsQs?= =?us-ascii?Q?8fzkktTF2quUStYxKLrSh5N3GmE1I2iVyM4d2PRlRDXhwk0dELI59bXRJrDN?= =?us-ascii?Q?sxYrjOuM6OaTuKP+aKbT2ZLyCIxQvoj2BhFDJRQlstVYF0nzoUvHErx0+sJG?= =?us-ascii?Q?V+qa78nGRU85h/SNkT2mPP/l7Hf6nFzJNMsJMSybbLKIrSPmFa+Kt2mHefmQ?= =?us-ascii?Q?fqDaA4w4GsM0Yo/kYefW/HLM+2gH3ffVWdy5M9TyANOGcdfokx479lP7RgjK?= =?us-ascii?Q?rqh7SaEuR1BxvVrgkcAf/uDGVUECgLP+dArD/FdC9G3zCDQnrZBD7aFAasLR?= =?us-ascii?Q?Ece/rQuIlZ0UJQIkZ53iqboe6YxkyG1i+faKXI7WVWnDKWeDk7o08FbzPB8M?= =?us-ascii?Q?45e9Z28F7JggIDM8kPznAAvGhzhzjIjtGti0cxNj2DUyhBwGJEcfEqNkAS0z?= =?us-ascii?Q?l6KQcA99mQBLMCJg+m8Ik5GT1VcGjQEFkslMH1mqBXMqXH4jhTeq5NArDUt9?= =?us-ascii?Q?tuEH7dKoujy7hct4+//mALAqdv7bZhuMa0E11G9FOhXFBN09CDdsgUeDcJmh?= =?us-ascii?Q?tfaGOlO5kDAX9AIbS5GZzcJrYnE8TSarePadganDt3MPpsRwKWKWH4D3HUWo?= =?us-ascii?Q?hl4rOkJvfn5UoqrfFsNMMvMMP7706TJg1QLo6eoOlT3XP6kEt3f81cFRmNJQ?= =?us-ascii?Q?I2WNnwyF18VvwEZrsgA5YwJ3yf0Y0ID4ezGTvYz5Jwtg7DlUzFL5QkgZz1CI?= =?us-ascii?Q?9WUI1CNQoCncU+ybWw7LGe7ckxUoj0qn3bIlTCj+maxSrO0hObdKrHWe7xl1?= =?us-ascii?Q?CTBCYEodnYc1CBHFVVF/MH+Q1B64cJPYvyzyU9pILIQzuJDqS/60pyINgmnc?= =?us-ascii?Q?I0kNR3K45PKgNvANhW2bFMV2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaf793dc-26c3-43f9-6626-08d8fa6be13f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 08:54:11.8725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xO4ko088hD2VCpHlJ21fOZjFr+w+67AHTSBHlyaI90xALKRh1j+jPe3QzUGrahkCsgZv/w1Lox5nLeG5URqYeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1613 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > 1. Maybe we can align with IntelFsp2WrapperPkg which have this PCD > default value as 0x90 for typical cases? Sure. I will update to 0x90. > 2. Since we already have MicrocodeOffset PCD there, to prevent from > confusing, how about renaming it to something like > PcdFlashMicrocodeBypassBytes? BypassBytes might not be a clear name for indicating the PCD meaning. How about "PcdMicrcocodeOffsetInFv"? > 3. Please add comments to describe this particular PCD meaning, because i= t is > different from others (flash map definition PCD) I will. >=20 > > > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryBase|0x00000000| > UIN > > T32|0x20000004 > > > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize|0x00000000| > UIN > > T32|0x20000005-- > > 2.27.0.windows.1