From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.2862.1607495166472973873 for ; Tue, 08 Dec 2020 22:26:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=og4BsWjF; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) IronPort-SDR: +ahBMSeptZguz/RGMHk2nfu1gv6Xh7N98xJ1wTRZ7kqosZ3P3I9j4d4RlKMBYGD53rnfxkHgru clwJDzjTZ5MA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="258734838" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="258734838" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 22:26:05 -0800 IronPort-SDR: 9pKVPG90T79Dyd4bSSPVhMR43VJP89RySZUEk4xpTZxCSEtTZeQwwscFB6JDDKMhpJ15D+RcwB zPIxuGJn6mWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="364009273" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 08 Dec 2020 22:26:05 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Dec 2020 22:26:05 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Dec 2020 22:26:04 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Dec 2020 22:26:04 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Dec 2020 22:25:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8AIR1tI91iOFBgrT4DUudqaDpNpuMrOhuDv4QzOt6AgAeb0EfLqoYFgkYd/IUpws6fe4ecJLrQcILDMMlbW5u65Z9VORjDt+rbScfydzRr4w5dYpKlN03u+9yiaJlE17gM4fy4CD483HTK5oO1RD73z0f9GOEAmSi/OLI9Tp6mLGfmvWt/XbhuSodYnIeQGpe0Sa3bixKgwg3lTPrXP/VO8wcSikzm0mM9SqUhK4HOXAAlPLPp3eBJWUnJpc57qpTL/ecKtTAIEjdd2b0iRL64cBrv5fawiFSODI/9pFHzK0ijc5657kn5Y21lC49YjIBf42paKbZaPO3H+DHVQ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxGv2yNd8JUPKO2c8BbVB68ZJa1A2CVIyROTtW/sCgE=; b=ftfHUPVB6Mlem7f5eaNr7wqwEjk0dY8K9zN6myuBb3weG2Eya0X1VtEpFRZvgiRAr7IbZ7fl0ViCfyimF91f+9mxsv+HR+LKN4p/ZFh2YUBXHOeZoJd1/387qFMr1zm3HhtFaA5g81uXGP28+sbFZA7DP9hFMgso3yRnxwuqrqt2De+qR184JmVPPtTQD6d41pb+Ut8GhwPAcjYq6QlW/b5adseJ+qa1OAwcj3GjNUxizpDI1jGno6RAxhNeUWwtOAOZbOjpf6rdAHoTWYXQwa7LV/Se0e2qRNEDMfWp0CGDpM+LitbCmKyoiL9Zqeo4js7Y/ISaltcE1dY2ay5a8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxGv2yNd8JUPKO2c8BbVB68ZJa1A2CVIyROTtW/sCgE=; b=og4BsWjFMih3di4Td//+j8zZDGawrllTt6IhttqWx5nl6fjdU5DdUCKT1NgiMdelXFX+49Rf15VNmxOnFVXpQr8TpFy/zYsbe4qkIvheuamywTCbmtSbhL9z0rT6i6EWmINttfSFqPtOZjaEYJDof0lUapCJ7ED5qc/nRil+O8A= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1694.namprd11.prod.outlook.com (2603:10b6:300:21::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Wed, 9 Dec 2020 06:25:42 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 06:25:42 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" , "Li, Aaron" CC: "Chaganty, Rangasai V" , "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Thread-Topic: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Thread-Index: AQHWzSpEpdItp2GGcECvHu+kpB6GgKnuS43QgAABkeA= Date: Wed, 9 Dec 2020 06:25:42 +0000 Message-ID: References: <20201208061924.6082-1-aaron.li@intel.com> <164EF7F6368FEA75.12383@groups.io> In-Reply-To: <164EF7F6368FEA75.12383@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39184f86-3397-4fa2-7147-08d89c0b412d x-ms-traffictypediagnostic: MWHPR11MB1694: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DOqPjVfyvn5OQ9pkloEEvYW2A+NaYiQE13C+six1Hicg9anXeyOx/Ll3Oq4IOE9LXPnKl4hLu4yl/qFgYaQEEtvixeTMk4lSrWusZIIY1G94St7VNjBkpT4e+5/QlM0ksP/QvzYA86RiScyymhU4eyCT1W01rSRUHlgHeZdx6Gd0kbqDP83nqqdjLH3jBdw0OAWNtFUoYQMGZIMFt59Jx6YlfpwyWB3rBXjyIzeDM0g8LkUCkImhm0wzjjer9kfDzeIMNgklVfaLjLKWStf6krg+IguujNLcgIabpMt02GTBr9gX1eLk0Ki52ZGD70FZOcJTPGKG87iq9MbrM4OoYhVM+Ar3ajO7lF9UwGDHdNtdAI8yJv82ReNsCViA/9z8RLZ3+FU/VFtc1GpdruT+2Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(346002)(83380400001)(7696005)(186003)(107886003)(2906002)(66446008)(5660300002)(4326008)(76116006)(55016002)(110136005)(8936002)(54906003)(66476007)(508600001)(64756008)(6636002)(33656002)(71200400001)(53546011)(9686003)(66946007)(6506007)(26005)(86362001)(52536014)(966005)(66556008)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CwzJ7zMYaP8mV9lK1OwR8/py6alhaFEK/I9kRtExeUI76WFMxdfz3FsSxtuO?= =?us-ascii?Q?B0ivfL1rz0SX8ioYhSM/iAONAxXE5A78rVZKxklNw2Zl45LBmiK8rUfJUcu+?= =?us-ascii?Q?CmNurD8RCVwmpoqLli/p+v4VLFTUi/DHw2rAlfjFQP09xzS5GtYxqGhRZK+7?= =?us-ascii?Q?2fJu+WkMnQUAlUbt8EY5AY/9H1+EJVfMuC8uFIrdAg7erx4TbFaauf3gwUKV?= =?us-ascii?Q?7ptj/Poz2KQmag4+luDYOkhcEq4DoxD+R+tKvXMCK9NYCxVINuw8m07RFZWt?= =?us-ascii?Q?W5QELxZaExWOeAal/JWlulUqLlCdOBehfUFnppa0K/O0qDe/I6EVhcHvFFbF?= =?us-ascii?Q?YSGl+DPmG6Ec5Vswv4aoZFVrb1jKQ/0QXxQoo7VMsHn74oPuyhdboNXnHJTp?= =?us-ascii?Q?lbbnIfOxApfHpDcPkkhFKyxK42vLDUlQTSPWjm4DecIx2ndZaLKMVBe1Q3XA?= =?us-ascii?Q?kcBUV4ag7ApLHa6G6SnRX+TqLiZ9tGtLoWOH1t+t9A2ah+9Us40STUYh4myR?= =?us-ascii?Q?hB7swiBwfhe5u4VU1hr+xYN2pgTfNJbjbdXjcFuh/WQDqaaOujuhgWPsoY9U?= =?us-ascii?Q?nsHft0Iq1oMWA7OiW1hbcZ5qfdQskAFwAiEu1ZEBjmNftjyfPKZHf6+OX+dx?= =?us-ascii?Q?ApnxoLV/G8fuKFaOMaYhfG9lpq2LKYR8lvyNfW+gmauHDsMh0Pl/48qMvZ8I?= =?us-ascii?Q?vOBAkrt6OUXD/DyYYJjTXo+hfVd1V2E0B7KqmRSqwu/ZKHK5+zsVU62oXdNg?= =?us-ascii?Q?pRVITdUVDItPlHa9xXBE3ZPVHGtOI1/NARmt80z416vjckF1eDk2zgAYNdCa?= =?us-ascii?Q?VXUJl7OGQqU9l4gIq0Y53E9+9suub149trui06WSEuufnrcDcbdd2hlmVdf8?= =?us-ascii?Q?ODF2y5l/xzXtpkI6AIYhG5XJPoC6KoIH3iL7udAmO4eP5BGDIPR2QV/mawh+?= =?us-ascii?Q?Fv4WClFVxje0UbL1UHbzLilKXW1BFCN77TJJU48Hy6uzJIdjego7C5ZbZdGA?= =?us-ascii?Q?4TKj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39184f86-3397-4fa2-7147-08d89c0b412d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 06:25:42.3950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nupwY1WlruU+CrO6ik1aEG4FN3qb5iiSpwacZYF3GPSIkp3fdyGGVoOztJ9b33k/3wsA4oivYz/IrGlZgLY8lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1694 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I saw the code that calls FreePool(). So no memory leak issue. (though FreePool is a nop in PEI) Can you improve the change a bit by merging the two FreePool (PatchInfoBuf= fer) together? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, December 9, 2020 2:19 PM > To: devel@edk2.groups.io; Li, Aaron > Cc: Chaganty, Rangasai V ; Fu, Siyuan > > Subject: Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocode= Pei: > Fix return value in ShadowMicrocode. >=20 > It seems PatchInfoBuffer is not freed when Not Found is returned. >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Aaron L= i > > Sent: Tuesday, December 8, 2020 2:19 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Chaganty, Rangasai V > > ; Fu, Siyuan > > Subject: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePe= i: > Fix > > return value in ShadowMicrocode. > > > > ShadowMicrocode should return EFI_NOT_FOUND when no valid Microcode > > found > > in FIT table. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3110 > > > > Signed-off-by: Aaron Li > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Cc: Siyuan Fu > > --- > > > > > Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei= .c > > | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodeP= ei > > .c > > > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodeP= ei > > .c > > index 5c7ee6910c8e..5539a121cbb6 100644 > > --- > > > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodeP= ei > > .c > > +++ > > > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodeP= ei > > .c > > @@ -377,6 +377,9 @@ IsValidFitTable ( > > with microcode patches data in it. > > > > > > > > @retval EFI_SUCCESS The microcode has been shadowed to > memory. > > > > + @retval EFI_INVALID_PARAMETER BufferSize or Buffer is NULL. > > > > + @retval EFI_INVALID_PARAMETER CpuIdCount not equal to 0 and > > MicrocodeCpuId is NULL. > > > > + @retval EFI_NOT_FOUND No valid microcode found. > > > > @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of > > resources. > > > > > > > > **/ > > > > @@ -460,6 +463,9 @@ ShadowMicrocode ( > > )); > > > > > > > > ShadowMicrocodePatchWorker (PatchInfoBuffer, PatchCount, > TotalLoadSize, > > BufferSize, Buffer); > > > > + } else { > > > > + FreePool (PatchInfoBuffer); > > > > + return EFI_NOT_FOUND; > > > > } > > > > > > > > FreePool (PatchInfoBuffer); > > > > -- > > 2.29.2.windows.2 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#68443): https://edk2.groups.io/g/devel/message/684= 43 > > Mute This Topic: https://groups.io/mt/78798288/1712937 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > >=20 >=20 >=20 >=20 >=20