From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.2820.1607494753682952785 for ; Tue, 08 Dec 2020 22:19:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dp/gEffP; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) IronPort-SDR: oyNObpsRos4FxZrfoII2bXICwKvM88TLeS25UkNx70q3dPGIoWip+d21a5IL/BX6speOufcp8q qcEbXBpX5emA== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="258734212" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="258734212" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 22:19:12 -0800 IronPort-SDR: 30OgzfMKtolTS8rUU2M89VwWNC0E+zjdWo34fTbBSLkRHXFz9VmnaBvt/DbN6xO4FKEpjmMjiY lCQNEfL49iAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="542279599" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 08 Dec 2020 22:19:12 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Dec 2020 22:19:12 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Dec 2020 22:19:11 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Dec 2020 22:19:11 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Dec 2020 22:19:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMGl7Bf5WxBdC5HhmN6zpFtxxpmd8iZaDOyPOCy+gvbD7mBJkv3U0FF1Vi5oor8ZzwOVgDLManC/EWaWwHGdT1SMjP1qXvFsZaW+xG+mteQR7LdFl3T8PIMD3uyZKUZnj41GQ6jqRr++3a+Muy72Q0t8BEHeKO+RFW8ou2/kZx8mGQmduKv6/duN7TGznopk+tO7gpHJD2XDlDdDP/jspVKecltSSvdxzY8ameipYzJcYaZ2GNyRv8mfX3F5ApupmBmkce5b5PUUunNg7+XD7uhbOeKnwnDeu72292keApA0CtnXjUFyaeB6Xlc/4ep7R/kiVIz0tzmlRZRCcfLzJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g5kjoOZOk2KCwirbyCeuWoKnWyNUeeUbobg0ro/Qww4=; b=UCojOvSyQcZLRNIowgh0vsUp2R0aylJC9B8ySYouwQzr1aFyVaz83KUJnDdvdocs6SjZ/eS0HfX+MGSFIfnXcomrZFDDhXGxL2Ec7H1e+Rm2HdvOnOJJwaXw/NYY/ehdJFhfpTs+/v3fX9SX9WU20/kfNs5fuARZpxycS7ZHfOBj4rfbO4MzJvpy4sssy1Se3P1cR9+3NMZJu8vCOTpp9Lk89bz/SRku/zk6XM6A5L7fGqGYTPxfbe75idxVGTi6eFKySo0vR9j76tI9vy12/r1ZwX6SggMpWreIR9FCecK9/BHg5FZVi/8s8amhuGFzum7RO3Pi3dJr+DFK998svw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g5kjoOZOk2KCwirbyCeuWoKnWyNUeeUbobg0ro/Qww4=; b=dp/gEffPDCvglKHSrE7YlwHamgnZ3zwk88nGcLLo6JlWMbxWMWNpQyxY4kYJEjZ5rO3pI24I4MFwK3puU/PNYI5qZ5GAFiyc0bQvg8rZtCU3Z6YjDlrBgt94qfpDAdzDB5TeAWuaLMktlZoew9No9i/zYDJixBAMJsNAYrLhnA4= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB4851.namprd11.prod.outlook.com (2603:10b6:303:9b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Wed, 9 Dec 2020 06:19:06 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 06:19:06 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Li, Aaron" CC: "Chaganty, Rangasai V" , "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Thread-Topic: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Thread-Index: AQHWzSpEpdItp2GGcECvHu+kpB6GgKnuS43Q Date: Wed, 9 Dec 2020 06:19:06 +0000 Message-ID: References: <20201208061924.6082-1-aaron.li@intel.com> In-Reply-To: <20201208061924.6082-1-aaron.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8114296f-c4e3-4dc2-d117-08d89c0a54fd x-ms-traffictypediagnostic: CO1PR11MB4851: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:639; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /cR52SdePCtvXi2MvOtC1tKbtf5euPhL2ROOTYUT5Khx3rTT46pCGSVTm0ex7Hi7rGJiU8zhBtPqQKJe2NTRHMAFjaXKHoO5nBCHUxIcvcXE0w+C6aYG/eCi+zpWKePzd3uC6NV7PNEJKgaqQzgWQW7zbb43WTu/Fda1GyRrPWVxHVTc+6wqapILe7kGPCcjG34e0xK4JrofPNxKNJVZy18ehCGou1lbqPxR6cYnfXdYEq8kjRQa9A01kITKDvOU3N86CzTuQXGJxpW9rmrzrB/do14ADCoTX4xfaFhGSUlPZF11+Nbg3KRtHtu5xxHY65yDUT2VDaBxRlguu7QKiL6aw9qRXgQqMHxx0LSEXJ6AaJXMvvtmyC52f/Ni5BuFkr64oM6gElhunK+8WjTSqg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(376002)(186003)(26005)(64756008)(2906002)(6636002)(5660300002)(55016002)(4326008)(66556008)(66946007)(52536014)(66476007)(66446008)(76116006)(54906003)(7696005)(83380400001)(8936002)(9686003)(71200400001)(8676002)(53546011)(508600001)(107886003)(110136005)(966005)(6506007)(86362001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?GrZhIa20FJq34CP/tCNaAGs0/aCz5uuKqqPbDcTuQJfqJEMX0EsDv0W8cggS?= =?us-ascii?Q?LVDiWzFIxnSZnu2gZHVBmTQxPFTK7j/uFlHM66rYo6uohN7lv2QdevoJJOlY?= =?us-ascii?Q?s5FOmE2/395AlnuKalykFQOBFvC15SVeIoq/ecUaKZ57dbTVzEUWUmdDqmT0?= =?us-ascii?Q?CbAdInzwSFYHWFxfiQvEwfNdPvKxII6teDHN9H9ufvHO1oDZ2YbhPJ+4vqaR?= =?us-ascii?Q?MqDRgvVDOF4OIXgWUjO0e6FFWwYyi7K6xtfNOveNShPkqOhvjEf4AL+/ZH8I?= =?us-ascii?Q?mM0TKmev26gMKmynPFJ2VgCZTiC+9RLTSSMWAPxRgUzY5WvUQkquIYUZGfte?= =?us-ascii?Q?uE9dlYoVfBbSq2RR+jSFOjfq7JpFdA3TDhUXRUnW3YlCcBbwFkOziBNlSVsc?= =?us-ascii?Q?yS8NlIN/QVBGi7MhWDfClkM7zGhqTHqVHthrLoeuBFPFjJU2qKXd1xtF30gF?= =?us-ascii?Q?SNjjYstFZycbeYLKfASsobyDmGYxMv/q9ye8QgKpTv3IB4tc8y6WVMh/APWx?= =?us-ascii?Q?A77+fB9s2e7XgA4IQKwQNOrwIVMhjCp0HAYm0NxvplVWIGY6Q92RBZliLwcT?= =?us-ascii?Q?7RgyUJ7gdzjL5dmYkJ1DKbFUOtSwI0DuFJg6Bu4LCzalanfP8mZQnt2upe8i?= =?us-ascii?Q?ALeln9BOYw4B4GM/q/ab6rP44HUvcYRDMC2meiAcJrONlL5P7KbgVeQxWzrN?= =?us-ascii?Q?wbTTysvl5PVcURT3gHOmk85cDKYiw5+R0iFTWR+dB8ANfAFao1GChkV4pX5v?= =?us-ascii?Q?N37UN1iOgASMqqDuNFkF8DyXMKiu7a1L2SinynusN4pqKu0JR2PmV2q/Vv4y?= =?us-ascii?Q?SZTn/++2c9F2mXqL2xnFG/jpGcjzn/1ecUmDnxPZNIqSvv7eA+KChVSUONRu?= =?us-ascii?Q?/iWA8vuv9AkI0yvl7MNgqvyEuPrF2YqC3L7B2i9gdqXsx4e568nKkRA45vOv?= =?us-ascii?Q?IfHCYYCbmlq/WzPZ7nbzXvGKCV/AYhEj6HQ/XngrxoC133LjqNWSJMPbePUQ?= =?us-ascii?Q?WeN4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8114296f-c4e3-4dc2-d117-08d89c0a54fd X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 06:19:06.1983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: glWd1wFnZPv2j/85ZYo9WV44niXZJNBPHnHhWt0Yx4+hRy4OgPSHI+zCAHOXWJregVF3fhGxVUbFzPZJJaFE8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4851 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It seems PatchInfoBuffer is not freed when Not Found is returned. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Aaron Li > Sent: Tuesday, December 8, 2020 2:19 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Fu, Siyuan > Subject: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: = Fix > return value in ShadowMicrocode. >=20 > ShadowMicrocode should return EFI_NOT_FOUND when no valid Microcode > found > in FIT table. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3110 >=20 > Signed-off-by: Aaron Li > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Siyuan Fu > --- >=20 > Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.= c > | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > index 5c7ee6910c8e..5539a121cbb6 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > +++ > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > @@ -377,6 +377,9 @@ IsValidFitTable ( > with microcode patches data in it. >=20 >=20 >=20 > @retval EFI_SUCCESS The microcode has been shadowed to me= mory. >=20 > + @retval EFI_INVALID_PARAMETER BufferSize or Buffer is NULL. >=20 > + @retval EFI_INVALID_PARAMETER CpuIdCount not equal to 0 and > MicrocodeCpuId is NULL. >=20 > + @retval EFI_NOT_FOUND No valid microcode found. >=20 > @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of > resources. >=20 >=20 >=20 > **/ >=20 > @@ -460,6 +463,9 @@ ShadowMicrocode ( > )); >=20 >=20 >=20 > ShadowMicrocodePatchWorker (PatchInfoBuffer, PatchCount, TotalLoadSi= ze, > BufferSize, Buffer); >=20 > + } else { >=20 > + FreePool (PatchInfoBuffer); >=20 > + return EFI_NOT_FOUND; >=20 > } >=20 >=20 >=20 > FreePool (PatchInfoBuffer); >=20 > -- > 2.29.2.windows.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#68443): https://edk2.groups.io/g/devel/message/68443 > Mute This Topic: https://groups.io/mt/78798288/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20