From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.2442.1622768507266228719 for ; Thu, 03 Jun 2021 18:01:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=sTD76hC4; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) IronPort-SDR: 3ZNWx5N8ufQ4PJbUM0DrlRThChbgPTMPZJipfAfuG/yqWwQ/H3mix2fUPNibKpPF+axIFwt+bZ WUsfjHWiahMg== X-IronPort-AV: E=McAfee;i="6200,9189,10004"; a="204222791" X-IronPort-AV: E=Sophos;i="5.83,246,1616482800"; d="scan'208";a="204222791" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 18:01:19 -0700 IronPort-SDR: 0QxTArVMBHprIMvPSLw5aXRyGCdRFrKrRzrws1Xk6GgAwFuoVzqu8u7i4gxtaWIFWg1wW4RcB3 x3FEVsE2yGmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,246,1616482800"; d="scan'208";a="400774404" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 03 Jun 2021 18:01:18 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 3 Jun 2021 18:01:17 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 3 Jun 2021 18:01:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 3 Jun 2021 18:01:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6NOg5KEE8/hf8QYF4c/lfg+nNaU7VpikH3AHxcscpRlrCG+SSQPZEUqk/VRQVYjehWzzbvi69xiex/0sqlOatK5CDFwJ8IZ1F3S5seot6f5B5TqVz9X0atM+dF1RpKaHrdUCH7UGMceaLJEoGEn8QLR8Z3tvY4iTFJtCOgsJW029NzFG4g0GDKnd/Uyc9IQ/cDh4Ey/NmHuLtyV8OoNlKl26yKAVhRiTL1gQWhk4COdcmqA6e+ymu4OAb1s7t+ULGPLdNsG3wlyMBEtIH4eqbYBIDhAu3p/PxBP+ztf3y2RN+5wzB2ybpyL8a4LRswIEd9nMIX1LWnh3PY9CHIY2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NySqtsxkyFQKLVeqPg5sqPB/y409C3daHj/zabxyPq8=; b=mCrLtKg/3jKCSOb/dTjYYZcW56ZaHAEXjeW6UULiAMkmIkx7EVjK4SMVzb7VYbgPUW1Aj05dH+zbKRT7hoD+YiEJXqGwKXQCiY7YzLC6Rj4hHZOMscSPpMtMmpvCZOFcSy6dho+sQMSVvdSaBO5Jvk1kBX3FhP7qaPAOnvPr34UZTGVwbtv3UPqe16yqhbeBH8o0Vgo43Wxr+Ieefw7uzOBNhrHmkHwAm28NoxTsYlX5RPsbqV1w0LOVp9QdJEaJ7/Xew0jTpgy+D7rFkCr5tHnNQqN4l/YiirKNjhePuhjFcNWcKntcr7/2I0I0sE+4PSiudWW7wrdFBEwcsvYQDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NySqtsxkyFQKLVeqPg5sqPB/y409C3daHj/zabxyPq8=; b=sTD76hC4Y9BZteDA+72JItC2lDfRXqDprfRYQTA9Yml5fJrBODWnbB3UNuQ0xFhS3QCGFDsDYKQf+AbeuRRVzt9rriNU7mEsmX8vJvoZDry+oVc7l4a50t1AsZmFbWb6bu+d+I9t0orWmxHvMpShFvFk5bLpjJ0iPkZsWFqmYL0= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1277.namprd11.prod.outlook.com (2603:10b6:300:29::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20; Fri, 4 Jun 2021 01:01:15 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::a439:f8ae:4699:718f]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::a439:f8ae:4699:718f%6]) with mapi id 15.20.4195.024; Fri, 4 Jun 2021 01:01:15 +0000 From: "Ni, Ray" To: "Wu, Hao A" , "devel@edk2.groups.io" , "Liu, Zhiguang" CC: "Kinney, Michael D" , Liming Gao , "Ma, Maurice" , "Dong, Guo" Subject: Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload Thread-Topic: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload Thread-Index: AQHXWELplE84MZoRiUezlGfsjLW+rasDCHpg Date: Fri, 4 Jun 2021 01:01:15 +0000 Message-ID: References: <20210603062259.1390-1-ray.ni@intel.com> <20210603062259.1390-2-ray.ni@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a46e387-682a-482f-62b0-08d926f440fc x-ms-traffictypediagnostic: MWHPR11MB1277: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nRmu4jYy5hAg+5YfDBjEKX9dyVPu/db2FGWxPODKMPEpRggycPY0rJP3KNZ3RoZmtAzapq/PGpJfhIKM7fFMokjt5IOn16DBSHVwOM0EEz34vX73eR/j00BXsKgM1BmbhfPs9kkuZXzhu3zSSvVRGpSajYSO+Rqdn+NWWT4TMCBzpOiTUZCe9UwmBf+BzyYZ8krcKoq4HZL7OddAMnuNQJFtgoysVOF92b99qkoS+Qeued4PITakuATRvQGka9XtTSYeO6ph3q9bQ1gOwRXutn/vLfxknoQCbMe+TJKeCvc2DZRCTmvtQFLsjIyYxYZC7D93kIpBpc0anTlQbIEuF+IKF8onJTLryhbS9P90N62u+0tHsuZCwRoI9QhC9uOX0rFV915x7XJaMpl5b0sPVQ9YpFd4DxQwdQwgNt7c+BZ/wrqrMmjNPoty9Q94Ksr0uLiUlWLVa5RyS8+S0GdpkSNCtZvSK5oVfziQfU2/Hiu5vl0ff7aZoDRw4DeMeecg+f0u1YHrn8Aj7ZIsywnpASJxuWm5pgq8l8EyUUHBLM8bqkOJEG5zy5D+qetPZcWBGx+eBEns1LDaqjwdR+B7ZHcc4rzJwirc25C0iTlt4KQtUQJ8aSfAOzUnyIxxWQudXszvlQBC0POY2TTMGOYWjqSCmjoiiL3ZTxdsWo1/vvAR+jv/8zHEu8sUxWAjA2M2t4k5epPYTHii2z+7X8dQyettSua8PlCqbFukw5GMbeJ4ryL/Ke5Qzq+THtR1mq8AuvU86UAkK3wcQzBQuOBayw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(136003)(376002)(366004)(396003)(38100700002)(122000001)(52536014)(66946007)(64756008)(66556008)(9686003)(66476007)(66446008)(7696005)(86362001)(83380400001)(55016002)(5660300002)(8676002)(107886003)(4326008)(54906003)(316002)(110136005)(8936002)(26005)(186003)(53546011)(33656002)(6506007)(71200400001)(2906002)(76116006)(6636002)(478600001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?VSKh7lhWKP0r28mZQqJ3xm1Yq6qk+M7PF8jIcLb+JotIEOCUM4Y3A4hFyICR?= =?us-ascii?Q?G0+OLZ4XYvS/xdMhUjVqeJU1TUACQ5Z+V8bMeMHgbYxCvU9X7lMRZPg4aNha?= =?us-ascii?Q?0mDI6mgJ6tXCAKT0ABjQPK1Bj1B+XM63KBQ4j8XP7SyHPwDZ34+4D9LBpmnc?= =?us-ascii?Q?aU3itXUNSsvQSstgWD3P3KU7N64hDrURt5uiX2MLYM/np4Vj6tglOriDpf8P?= =?us-ascii?Q?6WtX44njwQURMlplbqkp6Pxhhi1sSSh517shKgQIyeWay4pukeAPm4GZRhA0?= =?us-ascii?Q?2rx1UWrS49j3preCPmP5cLe5rtIU9AryoI1eu9rpWRYSbZRjELAdk7RLDX7T?= =?us-ascii?Q?WFokpSz9zeEQdd2cXRF3Enq+zD5aot+mB0MPpj0xyFCoimculd2rbU2oyKgS?= =?us-ascii?Q?g2MeGxFNLJnzxkm/mHlUY/1VepDxyto8NkPmUO7g/JumAG4DEN5FYALBz39T?= =?us-ascii?Q?0o3G3koWFqulvSgzxzknsC+RiWsUGs6t0riAXp0nNVOhyguxL+du5cqpoJI0?= =?us-ascii?Q?haChRKBy3dFfBIIgg5xsYa3eB93Ix95AeicEs/fSw0mgIVP6+RWQCQRTe8yZ?= =?us-ascii?Q?VpWsTVGpulodUJPUHrkVDQagomZZtYr+wo+JEN70ngrjeNP0hSM1HWKbtBVo?= =?us-ascii?Q?Von4Z8YNnxNWurjf/GAYVoAk2sLtQ/DGpB4OuO7+4TqISQPKWanc+/UAgtcD?= =?us-ascii?Q?0LEaBrpLM8o/xahK6wDUdFn0bI2qxUCLQIGkQRLr5PfvUXtVi2Xj3C6la/dP?= =?us-ascii?Q?kahTe+OamVLmhRsME41EPd/DVvN9CVdcmEOx5XUbYPrFaIuXBrr2otCS5EB+?= =?us-ascii?Q?bGr2Stk02M0ew8iIHp9AeKY1mpBQ8+3aVfbnVDrGkaQMuxDiN3g1uaLirDjV?= =?us-ascii?Q?+e2TZ22qDcB9Mn9SlGh0HCBQGY7hcL+/5No2MOBwAbneAw27lDbcyCtSsIS2?= =?us-ascii?Q?8UKHbv70mQuffG+uOScGLnLqyEyfFUKS75TjaR3VwVGCIUieB16L3WH/62eJ?= =?us-ascii?Q?JFri3yFVSYPDcHOFbbLGRYE0PxdL5k4Hp6uHjsQc1SrVwVJ2VpCqgd73SZ3K?= =?us-ascii?Q?SzMh58IzXCyWlnT+kmI/9MRKf52ndkD3TW/TMHVHIMQqh9NJIaykOSAEXR5I?= =?us-ascii?Q?9kvWv3GYHmiMmDheVFLMUwRs7ZMzciKPUwhahoQMqeeKh2bgG5EyLxWH2uB7?= =?us-ascii?Q?fwg7ttfU8MTatfWnIcI3x3MfiO+9jyo6AAInFzQrOFLCsVSXKTqE1bwaL2q0?= =?us-ascii?Q?PRSqZ9SoKS0gt83Ers39lL+mslZmeTaC3n4SB75Oi9PSeMR7masL03is2WVS?= =?us-ascii?Q?sHA+z1FV3PsMcqTDYZWS3KX6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a46e387-682a-482f-62b0-08d926f440fc X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2021 01:01:15.2419 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jad7IVJhMVtAcovChDNl8WLhV+iwq+v8JDnWJF3TDcHGOqnz025Ho1vydmwgWxXlRIaUwcZsYerTEMNV97A8ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1277 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hao, Sure. I will send patch to change Maintainers.txt putting Zhiguang and me o= n the reviewer list for Include/UniversalPayload after this is merged. For the specific changes in AcpiTableDxe and SmbiosDxe, I will discuss with= Zhiguang and send changes to append him on reviewer list of ACPI Modules a= nd SMBIOS Modules. Ok to you? Thanks, Ray > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, June 3, 2021 2:37 PM > To: devel@edk2.groups.io; Ni, Ray ; Liu, Zhiguang > > Cc: Kinney, Michael D ; Liming Gao > ; Ma, Maurice ; Dong, > Guo > Subject: RE: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: A= dd > definition for extra info in payload >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, Ray > > Sent: Thursday, June 3, 2021 2:23 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Liming Gao > > ; Liu, Zhiguang ; Ma, > > Maurice ; Dong, Guo > > Subject: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add > > definition for extra info in payload > > > > The payload is in ELF format per the universal payload spec. > > PLD_INFO_HEADER is stored in the ELF payload as a separate section name= d > > ".upld_info". > > > > Extra data needed by payload is stored in sections whose name starts wi= th > > ".upld.". >=20 >=20 > Hello Ray and Zhiguang, >=20 > There are a couple of on-going patch series on UniversalPayload. > Since the specifications for UniversalPayload does not classified as indu= stry > standard at this moment, some definitions will be placed under MdeModuleP= kg. >=20 > I have a request to update the MdeModulePkg part of the Maintainers.txt f= ile > to list the reviewers for these UniversalPayload header files as well as = those > UniversalPayload related implementation source files. >=20 > For the timing of this Maintainers.txt file change, I am fine with either= : > a) Made in one of the UniversalPayload related patch series > b) Made after all the implementations are completed >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Signed-off-by: Ray Ni > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Maurice Ma > > Cc: Guo Dong > > --- > > .../Include/UniversalPayload/ExtraData.h | 28 ++++++++++++++ > > .../UniversalPayload/UniversalPayload.h | 38 +++++++++++++++++++ > > MdeModulePkg/MdeModulePkg.dec | 3 ++ > > 3 files changed, 69 insertions(+) > > create mode 100644 MdeModulePkg/Include/UniversalPayload/ExtraData.h > > create mode 100644 > > MdeModulePkg/Include/UniversalPayload/UniversalPayload.h > > > > diff --git a/MdeModulePkg/Include/UniversalPayload/ExtraData.h > > b/MdeModulePkg/Include/UniversalPayload/ExtraData.h > > new file mode 100644 > > index 0000000000..07b7426683 > > --- /dev/null > > +++ b/MdeModulePkg/Include/UniversalPayload/ExtraData.h > > @@ -0,0 +1,28 @@ > > +/** @file++ Copyright (c) 2021, Intel Corporation. All rights reserve= d.
+ > > SPDX-License-Identifier: BSD-2-Clause-Patent++**/+#ifndef > > __EXTRA_DATA_H__+#define __EXTRA_DATA_H__++extern GUID > > gPldExtraDataGuid;++#pragma pack(1)++typedef struct {+ CHAR8 > > Identifier[16];+ EFI_PHYSICAL_ADDRESS Base;+ UINT64 = Size;+} > > PLD_EXTRA_DATA_ENTRY;++typedef struct {+ PLD_GENERIC_HEADER > > PldHeader;+ UINT32 Count;+ PLD_EXTRA_DATA_ENTRY Ent= ry[0];+} > > PLD_EXTRA_DATA;++#pragma pack()++#endifdiff --git > > a/MdeModulePkg/Include/UniversalPayload/UniversalPayload.h > > b/MdeModulePkg/Include/UniversalPayload/UniversalPayload.h > > new file mode 100644 > > index 0000000000..b8e9fe11a1 > > --- /dev/null > > +++ b/MdeModulePkg/Include/UniversalPayload/UniversalPayload.h > > @@ -0,0 +1,38 @@ > > +/** @file++ Copyright (c) 2021, Intel Corporation. All rights reserve= d.
+ > > SPDX-License-Identifier: BSD-2-Clause-Patent++**/+#ifndef > > __UNIVERSAL_PAYLOAD_H__+#define > > __UNIVERSAL_PAYLOAD_H__++typedef VOID (EFIAPI > > *UNIVERSAL_PAYLOAD_ENTRY) (VOID *HobList);++#define PLD_IDENTIFIER > > SIGNATURE_32('U', 'P', 'L', 'D')+#define PLD_INFO_SEC_NAME > > ".upld_info"+#define PLD_EXTRA_SEC_NAME_PREFIX ".upld."+#define > > PLD_EXTRA_SEC_NAME_PREFIX_LENGTH (sizeof > > (PLD_EXTRA_SEC_NAME_PREFIX) - 1)++#pragma pack(1)++typedef struct {+ > > UINT32 Identifier;+ UINT32 = HeaderLength;+ > > UINT16 SpecRevision;+ UINT8 = Reserved[2];+ > > UINT32 Revision;+ UINT32 = Attribute;+ UINT32 > > Capability;+ CHAR8 ProducerId[16];+ CHAR8 > > ImageId[16];+} PLD_INFO_HEADER;++typedef struct {+ UINT8 Revision;+ > > UINT8 Reserved[3];+} PLD_GENERIC_HEADER;++#pragma pack()++#endifdiff > > --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec > > index 8d38383915..d823ad0ba7 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -404,6 +404,9 @@ [Guids] > > ## Include/Guid/MigratedFvInfo.h gEdkiiMigratedFvInfoGuid =3D > > { 0xc1ab12f7, 0x74aa, 0x408d, { 0xa2, 0xf4, 0xc6, 0xce, 0xfd, 0x17, 0x9= 8, > > 0x71 } } + ## Include/UniversalPayload/ExtraData.h+ gPldExtraDataGuid= =3D > > {0x15a5baf6, 0x1c91, 0x467d, {0x9d, 0xfb, 0x31, 0x9d, 0x17, 0x8d, 0x4b, > > 0xb4}}+ [Ppis] ## Include/Ppi/AtaController.h gPeiAtaControllerPpiG= uid > > =3D { 0xa45e60d1, 0xc719, 0x44aa, { 0xb0, 0x7a, 0xaa, 0x77, 0x7f, 0x85,= 0x90, > > 0x6d }}-- > > 2.31.1.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#76009): https://edk2.groups.io/g/devel/message/7600= 9 > > Mute This Topic: https://groups.io/mt/83277975/1768737 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] = - > > =3D-=3D-=3D-=3D-=3D-=3D > >