From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.4458.1607996682753620720 for ; Mon, 14 Dec 2020 17:44:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZRhgMaxJ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) IronPort-SDR: gZuczh870gA7TTwLU4Z05zYGthS3zut0Tj6Bt2Xd5qQyN+zoWOKzGiiTsCsueLxcaPnQIr6/RY BUJlzUTVFXrg== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="162558814" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="162558814" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 17:44:41 -0800 IronPort-SDR: ErwCbW9JwLDdBTgrIrixte6N4aI9amlGAJ/7EtvqWUP/k45LergMddUp+V/yxlvVTYBcBvRSpD wWkwvgJHZK1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="383002521" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 14 Dec 2020 17:44:41 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Dec 2020 17:44:41 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Dec 2020 17:44:40 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 14 Dec 2020 17:44:40 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 14 Dec 2020 17:44:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G+MxTLKOAWQEagXXFZJ0xHFaWMCZCaA+tjwaIGkoq4aCWSbfUKip7S9EnaHw/+neaMJzMp3Ot8GM1hhWkptiz8L1+QzC39Xv5wHnuyBYIb0RmrxfQh2SN7CskhlblT/g3FnIpaj13euYJ3WXJtJWw11IPsie18GLonrAaBvoZUGri9u1W9Ah69nXC9+d/n4jEQOWOuNjSgdIXV6oal5pRFmtM2bd4zd14tJgolsUTBsdzGBtCMeiVlHgOb6mq8yv/o8NXxopVgOlSbpMT4KqbPN/aAIYjtt3RzpOL6zMhYPJCTRTYLkGlqVeOVlNQwyFIv4o0uWgU5riRxmuJ/pv5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZpJQVcouGldsaaTTby3t1skqLxgcrwM9jOvcd7Ioxs=; b=J4KHsnLhK3ynKNp+CwOORV7b59GtAJOWWSet1PsBjuIKcwbfPrWc3F3fgYQhQQbnqkjg4lt35v4XJYiJubRudjW4wpNTyc3OqFYpXvdrEA2PUvWSCV1RRbeCAsNj7epGI5TilPSLAeIQ5hubq+hCGtYj1VoIOsRjfxsemOZDT2EOq+iA79E5eUORubVcdQU84mwWGxyUuU553J5el6BnlavntYDwuqCHfNyuhAGFrJL9mmXIBTeKWbNpKuwoDNKy/2zHX995WsUy32/zolsPruJodWtkDsUyDKzpOMap//I6vXxk0M0zl3fPE6VCLS3mWQCUeAaM/KeBhYlQMQXARA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZpJQVcouGldsaaTTby3t1skqLxgcrwM9jOvcd7Ioxs=; b=ZRhgMaxJIVC+f5tL/BBQJIE1kHD0Cvc3f9dpGLx9nlruPT2rZmeZigAoczr6bnDHaVK0HIQHE/SwCjPOWwWgOK0AO+QVbuwZDO1vV8kbNfsHeJt2INMdx1KIm4+lzcVd2rKwc2SlVUWfBIfzMIQNn6EP4L/yPgTUbBo/RcXv++Q= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1613.namprd11.prod.outlook.com (2603:10b6:301:e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Tue, 15 Dec 2020 01:44:37 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 01:44:37 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "cheptsov@ispras.ru" CC: "Wang, Jian J" , "Wu, Hao A" , "Albecki, Mateusz" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Thread-Topic: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Thread-Index: AQHWz5+tNtmBpFBF+kOaxHpzLSrt96n3aBOw Date: Tue, 15 Dec 2020 01:44:36 +0000 Message-ID: References: <20201211092502.21763-1-cheptsov@ispras.ru> In-Reply-To: <20201211092502.21763-1-cheptsov@ispras.ru> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [222.64.228.139] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f4fb50b-0879-4391-8026-08d8a09afb14 x-ms-traffictypediagnostic: MWHPR11MB1613: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c3eTKPWnAJBlV3F14NwX3oH+2grJc/IuM4o7Cz/CDTpLm43Cysj0epqBASQNh+VtI+sV06RvhkNFsxxNizQ3+uz4kDjPS8o9BGRC9S+ljVSbWp4h3LcUEIraTH+9Qs1PFu75qAGcyrOKoUIwakXry6i9gX20hSyJPvL121Iz/aHvWyA3ttzbAZCvadGxMmt+NsZHJKCcg4gcZcjeYVEQoTlQO7EAPVzJ1YNNj5wa0k9GCLLbPjZCIKj/3okvYciu0Zjb16XOuEwd4vyM5ziRrgOGXG5hfskl97Eun4Vj1ykt9pim7FbbHV6oFVLp8J1t99+KDLJPd/6C6NzDKkmJNIgiuH8uBXl2cSXNoKL2qOIhSP7qLghm86p3xVIvtRB3Um4r3tu7BeLXuwiNv3Ub5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(346002)(966005)(66446008)(4326008)(76116006)(33656002)(8936002)(71200400001)(7696005)(6506007)(54906003)(66946007)(86362001)(110136005)(52536014)(66556008)(64756008)(66476007)(83380400001)(508600001)(2906002)(8676002)(5660300002)(186003)(9686003)(53546011)(55016002)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XTZrKFKyO5qvSdbqv1tWYTztGrk8M5i3anb2K5+oUOtVuSy6uT7JUmLJoACm?= =?us-ascii?Q?ETSHVkPB8KPMovTr0jWZGk0mJfY2yTgvxf7Dzttqeq6hST16PkFJ9kCRtxPi?= =?us-ascii?Q?VSXruWF2e84NGPUmg+iJPy82GCU+5Ztqn+yuYM4bE6CuwKfWhpkuHZhBtnUH?= =?us-ascii?Q?GZPLWNeevwi6npYvS/LCF8mRywB3+ZxWoKBEq1gEPtwbE/LlQ7UQHfO7BC4L?= =?us-ascii?Q?EelPSoX1J3OUEV7In1Cp2WE952tNWN0TmlvK4R6EAKDU8ECoGwzOvxRmIPaP?= =?us-ascii?Q?vkTa3DVafS6CfIUNNGwQwQ8jr9ly8AM2Kqhyx8Saq6TsLB37lWKEgsh5JEw7?= =?us-ascii?Q?df1rlElKhWwTedUTwtrQi0zFivGXhfbLFQfJJ2dzc7VQU0IES1JdRsQuLb6F?= =?us-ascii?Q?/YPGX01mrW1Yd1+NMZRg5ldLGBC6j2N9FQjaCl2r7xVzPi1nNhz1xkVpwPL3?= =?us-ascii?Q?7/ZI5eL2vKEV8tweQ7O2yRQ32dJxtcJ1fyu/yXOyRHcCV0fd7v3Kj4O9rQAw?= =?us-ascii?Q?36VtCBaxVhtWhNsnpGYtqty93oeaY3q+KVuZvpzMPWbXW+izjmTyv3gO+0GG?= =?us-ascii?Q?MtyqLfKT7vDcPbyBTZKpKC9vdmcqvCbIqXVtvkhjulFqC1QLlLMjNWgLZAab?= =?us-ascii?Q?8hEI9+bhTfjR+t2atNlqnAPksnixJgQP+ZYxfTsBeFPn0o/UwaP115bVE3bl?= =?us-ascii?Q?sFuC83QHyzuSjU7uxkVAr6/9qsv6Qk5RF+fgSCwher1e+urEAnVE3IITG7ug?= =?us-ascii?Q?O9dHaq/9lvS9g7xL9J1UDITnjPpY5h8R0SzRIHbBqXY/Y/YVkvC5bnMjl1jg?= =?us-ascii?Q?GMsUPdV6ArXMza1UdK93wXjHmlkZCXTlDlTebx7Jgb2D6Gsw96wHVouo+i4y?= =?us-ascii?Q?e85VWofUHJFfGYis/eRwJBYlTy+8bheEPMGwcHLzbn+quZpWW0Hl8z2wbrd3?= =?us-ascii?Q?LAda2rctVZYpQRR+wTfOBfSyld/be6lCBbrPr4/ElcY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4fb50b-0879-4391-8026-08d8a09afb14 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 01:44:37.0190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wlYSVZvGOCvrAz5Zht2FmmMaqtvDPvoHTpfjUrD+9Jnfl1luLjCSF+/PmZcllo9TENvnp4gzv01W7GsZryFgMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1613 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable DuetPkg was removed from edk2. If the change is specially for DUET use case, I am afraid we cannot accept = this change. Hao, Can this change benefit a general use case? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Vitaly Che= ptsov > Sent: Friday, December 11, 2020 5:25 PM > To: devel@edk2.groups.io > Cc: Vitaly Cheptsov ; Wang, Jian J ; Wu, Hao A ; > Albecki, Mateusz ; Laszlo Ersek > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add sup= port for drives in RAID mode >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3118 >=20 > This resolves the problem of using drivers connected to Intel G33 > builtin SATA controller when run from DuetPkg when it can only > be configured in RAID mode through the firmware settings. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Mateusz Albecki > Cc: Laszlo Ersek > Signed-off-by: Vitaly Cheptsov > --- > MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > index ab06e2833c..301335c967 100644 > --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > @@ -324,7 +324,7 @@ SataControllerSupported ( > return EFI_UNSUPPORTED; > } >=20 > - if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) { > + if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) || IS_PCI_RAID = (&PciData)) { > return EFI_SUCCESS; > } >=20 > @@ -465,7 +465,7 @@ SataControllerStart ( > if (IS_PCI_IDE (&PciData)) { > Private->IdeInit.ChannelCount =3D IDE_MAX_CHANNEL; > Private->DeviceCount =3D IDE_MAX_DEVICES; > - } else if (IS_PCI_SATADPA (&PciData)) { > + } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) { > // > // Read Ports Implemented(PI) to calculate max port number (0 based)= . > // > -- > 2.24.3 (Apple Git-128) >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#68707): https://edk2.groups.io/g/devel/message/68707 > Mute This Topic: https://groups.io/mt/78875596/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20