From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.6687.1620696432297755111 for ; Mon, 10 May 2021 18:27:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=U2wr5RiP; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) IronPort-SDR: U9qFCg1dOdGVKIwYp7yhnRX5C29XpSkKyeHPiqhPuwKjYjZq25JvapgSZDIRYSg0ybPUfVWxZ5 cBeouQtrEiUQ== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="199395477" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="199395477" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 18:27:10 -0700 IronPort-SDR: AhX6xVurFB/DrofZb/nTLHo4mwNwjf/eelQKbjrldDVGLe9Xov4SMsctMXdAibRT3saMHGT33t UYDt1abQkCuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="468567595" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 10 May 2021 18:27:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 18:27:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 18:27:09 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 10 May 2021 18:27:09 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 10 May 2021 18:27:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GB9HtnkaYexR5xx/aUIcdNHQv8xkIF680M11VPeW3gKgL4rzPLO4rGHB6z/rUkDRXY3bitxIvcG9tFEZMi5FntdC2MCdhIvU8qujBpEfqPDLesfByduI07Qr3rX9OGoIeHNQnTjgCyKT5EVJrdv6NKYe5Dt/X6l3LDDsEc/YpHYjo6ZrFQMbycpy1w0avM6zgiCqnX5YAoI6Ib30nJnaLeLcoK890m1RuU/YQcx9P/JRER6QF9bppMCPiiBhfXoQtVtaXLk3hNIO7L8ginZEvBi2qxaTzINdmYBvCdfSjR6jog4l58VZB4hdwEo4tPb8SgLQvbqzN+fqlxne8KLVzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/4EnJVcofoyFtcCgJR9BIMaE8mfQHrnNffcx0BPof70=; b=F5glbGY5bvsQ0Yx82BPduN4AKpsPqdCK7P7WvE11qiDubpBM6/ZKERXVAss9af9IUMrR6aN1vQU1JL1BKlo9Diwevh9uWLlI1gOZISTawzVnoNxLl57WtiIBestxqPROFERcqr3YnoP5KeopVTDmqK95x+KaC/zZZiDpQIB/RbfGrzW/Ab3DZdzCIJeBfaE92p90ZYaabPuAbce/XdZ4R6g6EWHoxM7ijBV/U7yqEZmQp9p68ViIVpfiJjPJHAnAKLOVatalbLVsmEtOOwik1oP34V0XgV0ru73PjwA2wExosksAw/TusC1PklpTtfOEjduOtJhkMBAS3xGefhduMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/4EnJVcofoyFtcCgJR9BIMaE8mfQHrnNffcx0BPof70=; b=U2wr5RiPXblzDSY8BOW7GS6sB21jjKDBBtO8SkGQcZgx66HewUr5KNXTUCAf203QmaP1PjMc9zoREqBBKt3HKLI25+NGkkXaILrtWqh5ZTiLez7YZPnOZQAMawuhvSYNqU/3Nip6bAtWyGYs86XGY59PS3+oRpNrNnQ8bizb0BA= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2270.namprd11.prod.outlook.com (2603:10b6:301:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Tue, 11 May 2021 01:27:07 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7%5]) with mapi id 15.20.4108.031; Tue, 11 May 2021 01:27:07 +0000 From: "Ni, Ray" To: "Wu, Hao A" , "Liu, Zhiguang" , "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu from any fv Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu from any fv Thread-Index: AQHXRXTCxuuPTNxliUCePo9ybgheparcZd0AgAAEzACAARHWAIAAAb6w Date: Tue, 11 May 2021 01:27:07 +0000 Message-ID: References: <20210510081532.1073-1-zhiguang.liu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82490176-bf4d-4b3c-2233-08d9141be440 x-ms-traffictypediagnostic: MWHPR1101MB2270: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +mJsvLJ+7gj/RHSi4WNLbXe718lFkfSIXdgYNo0OC/PB0AD6vLVYsHDUPfun8ZMKHNrrNwZksEqx92eU3M/DnPnP30IXBObagRlJpPzHHFzNHLShMgKczglmejprVTMKE53Vc7j8ouSYm9P09JBomgZtI38MNDhwuaCyn6u/lceiDg+ZQo5X6C0U0KPgHn/bBLDYiUuRg5ob57YH1zAJpWi3OqB4lfPjkAuPzzMsmIooE2Qn40cWbpHlmN5hZ5VhZxkHR+evUnMhi7senAK8kDrf3lEfqeRDpuGk9jEPmNEE4hNGT1fvSFa325RRE+xn08cwxgym0LdNNqTpU0kNv/rpGokQJ+Dyq45VxvnB+qDdOlEll3iEJcVQlQwlGS/W57dZxXU8W4snvgFnm+Ma/++N3D3rLclqzyUvnciArmPUWv4ScaVEWf64KSCCN6BK1PyvgxLO0Q+jvYqNZsAsgRhCqDqz4t3tXLWdW1GaEGIrFjZg+Xcc4jqqLgP6COc2oWJOZ3b9woOnDNnL8FM9Ebf+L3sGoe8IDsoWF+hpHTwlvS/neoaHxHv+LqbXC51MZNebhlhF54JPgQwavHCwe4kRqkPdMbPfhLTeSs4a+RybPhwUpnj1PCghYJj9Udj8YNnFEWLjL3dFhxc/Nk+OMsPjHKHVi51O93YR4Z+R3sF92rpfINljgz/OM+Ab+UoPgDCEGGVPOdHlR2CLgtm0LSBancWvK2TsRQRBpPo56is= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(396003)(136003)(346002)(39860400002)(2906002)(316002)(86362001)(66946007)(71200400001)(33656002)(7696005)(64756008)(66446008)(66476007)(5660300002)(66556008)(4326008)(76116006)(107886003)(8936002)(6506007)(83380400001)(26005)(38100700002)(8676002)(966005)(52536014)(53546011)(55016002)(186003)(9686003)(478600001)(110136005)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?TBIU3xaIZY+QupG7XEXa2IAxtkvaDly6WspYtP1pdYZdNGhzPglDTcxP95Kd?= =?us-ascii?Q?sukDhfFITzRGM6IJFASHwkImtY5K9i/DUWQGrV9NJJ5enxu+UOIitST/JByZ?= =?us-ascii?Q?5RFV2gk4TRxOIijqn86d2SlqjcTlr/b1LBsG3Xs0PJvmVJan1ktZcMNGRHmF?= =?us-ascii?Q?DCZgPrV585Z8vV1KpN0EJBB32mF9g9VLwkxfyGmtYyRaZAxedwY0zKrVl086?= =?us-ascii?Q?aAUOUSVuevauLDjtLmj+dMf+4U1k/YDbolCAOYI8BZjvoYbyDvhQ39DFecMC?= =?us-ascii?Q?SzRFVf7+FUbGZ5zYCo9mQZ+2KamUlt3JEh6IR3YOMA4wlXdCLks08LADqcif?= =?us-ascii?Q?EJAyTAByqJqJ+0GBSjI5PpfmHLnT2xxDfhlImkfscQVmfDF4ZLWHx6gmwEF3?= =?us-ascii?Q?YR9sAUkotZxBIaE/vPzCKyOY7kCb5KM1zaqssn1hHfvT2UYx9ApRpKkrfLqi?= =?us-ascii?Q?HUz/cDfYvtrEBUVlPqF7VYcZJ9rQaq/cCJAhAxOl7Hqip/fxMhVQLHY+v+Pj?= =?us-ascii?Q?4e4eqBd5BlSPLp3h+87WXqWaPSUP+Tq6DBULE0yi0lPVCsfJGufii8UuKw2u?= =?us-ascii?Q?bmtfpNrm77cVcxF387+KDI7Y5WSMZGw0G+hfj17qLoC9vELN67cILsy6Em3H?= =?us-ascii?Q?ELHuAJwPti5ag+uvy1gvoe/tkGC0I2EU2flKD7GZf0lq3HvdEpPDN+lL5FwG?= =?us-ascii?Q?Js1feWhk+/zFgk2C64SDlMd5fWtxTo8lhGD2B/9DEVzrrOL6CFqZa5mdr0ou?= =?us-ascii?Q?Y3qqgbd61GH0cjf9OWOOh3A8RRbw7kEKYs1CwQoW3bh1AxO6AbA+coC8H3Pr?= =?us-ascii?Q?Uq5M+e5otMPnyE+aNY7E9PziPn8UQlrbH0fGIRtq5nZUvPpW4Vslyi9XfEeU?= =?us-ascii?Q?mqAXnlv/NW6mJaA3MDfOiiM+f6QfsjdnryKbuvSZivhOpXqTLh+VfH6GEuR+?= =?us-ascii?Q?nHtGZmouDhURSERXGTzva16SrV2u3X+gmmQSmjY6EtBLtDj733afFsuWMfJP?= =?us-ascii?Q?vCLAqkhrv2zm7cYEkBxPsvbWbnbpRTA5aH+qyBAwuxkN00ghELV1718bMcfz?= =?us-ascii?Q?3iugJAz4mzOpZt2JUD2ZJ98ofilqbFU2DeYJrwiKJvmggi2DWjKsLmHefOvR?= =?us-ascii?Q?pYC0bvjuBf9scaIw0YbG+i1kGRoYK0Xx0BqZoQCK5bjY6B8oNNk4Us3LV/Ik?= =?us-ascii?Q?BmLfXsS4ZvXf5AOPOZnXpac0YFbSVkbDDd3AE46VQkZ5sgL5wPqePQz/v+xg?= =?us-ascii?Q?Opzxzs/ph5hUaP++gyBjO9iirys3qBF+9oImxi9DTMrg/acTbZ1XTt62zwpm?= =?us-ascii?Q?rayPOVvPNqsw7aXCk+xVYUpc?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82490176-bf4d-4b3c-2233-08d9141be440 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 01:27:07.4233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZveCqxTNE4UF5S82lhWXn8ynxeRGvtmul6+AdJtxCNSbv4A3phhUFhBjoi9XjPYjkWil0gCKDsVSCQkTaXlG+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2270 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hao, I agree with you on the performance evaluation and function header upd= ate. Besides that, I don't have other comments. > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, May 11, 2021 9:20 AM > To: Liu, Zhiguang ; Gao, Zhichao > ; Ni, Ray ; > devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > menu from any fv >=20 > > -----Original Message----- > > From: Liu, Zhiguang > > Sent: Monday, May 10, 2021 5:00 PM > > To: Wu, Hao A ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Gao, Zhichao > > ; Ni, Ray > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > menu > > from any fv > > > > Hi Hao, > > > > I don't have the data about the boot performance. > > However, I think it has little impact for the originally working platfo= rms. > > In function GetSectionFromAnyFv, It will first search section in curren= t FV. > > If it finds the section, it will return succuss. > > Only if it can't find the section, it will take extra time to search in= other FV. > This > > case won't happen in originally working platforms >=20 >=20 > Thanks Zhiguang. > The implementation of GetSectionFromAnyFv() will try searching the caller= 's > FFS first, so there should be no impact to currently working platforms. >=20 > Could you help to update the function comments for > BmRegisterBootManagerMenu() to reflect this change (first searching the > same FV, if fails then all FVs). > With this handled: > Reviewed-by: Hao A Wu >=20 > Hello Zhichao and Ray, do you have comments for this patch? Thanks in > advance. >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Thanks > > Zhiguang > > > > > -----Original Message----- > > > From: Wu, Hao A > > > Sent: Monday, May 10, 2021 4:42 PM > > > To: devel@edk2.groups.io; Liu, Zhiguang > > > Cc: Wang, Jian J ; Gao, Zhichao > > > ; Ni, Ray > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot > manager > > > menu from any fv > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > Zhiguang Liu > > > > Sent: Monday, May 10, 2021 4:16 PM > > > > To: devel@edk2.groups.io > > > > Cc: Wang, Jian J ; Wu, Hao A > > > > ; Gao, Zhichao ; Ni, > Ray > > > > > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > > > menu > > > > from any fv > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3384 > > > > > > > > Currently, UefiBootManagerLib has the below assumption: > > > > Assume the BootManagerMenuFile is in the same FV as the module > > > > links to this library. > > > > It has some limitation now, so remove the assumption. > > > > > > > > > Hello Zhiguang, > > > > > > Sorry for a question. Do you know what is the boot performance impact > > > if 'GetSectionFromAnyFv()' is being used? > > > Any data on the impact for originally working platforms? > > > > > > Best Regards, > > > Hao Wu > > > > > > > > > > > > > > Cc: Jian J Wang > > > > Cc: Hao A Wu > > > > Cc: Zhichao Gao > > > > Cc: Ray Ni > > > > Signed-off-by: Zhiguang Liu > > > > --- > > > > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 7 +++---- > > > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > > index 6cc34d29c0..b8df4d590f 100644 > > > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > > > @@ -2,7 +2,7 @@ > > > > Library functions which relates with booting. Copyright (c) > > > > 2019, NVIDIA CORPORATION. All rights reserved.-Copyright (c) 2011 - > > > > 2020, Intel Corporation. All rights reserved.
+Copyright (c) 201= 1 > > > > - 2021, Intel Corporation. All rights reserved.
(C) Copyright > > > > 2015-2021 Hewlett Packard Enterprise Development LP
SPDX- > License- > > Identifier: > > > > BSD-2- Clause-Patent @@ -2385,7 +2385,6 @@ > > > > EfiBootManagerRefreshAllBootOption ( > > > > This function is called to get or create the boot option for the > > > > Boot > > > Manager > > > > Menu. The Boot Manager Menu is shown after successfully booting = a > > > boot > > > > option.- Assume the BootManagerMenuFile is in the same FV as the > > > module > > > > links to this library. @param BootOption Return the boot opt= ion of > the > > > > Boot Manager Menu @@ -2437,7 +2436,7 @@ > > > BmRegisterBootManagerMenu ( > > > > if (DevicePath =3D=3D NULL) { Data =3D NULL;- Status =3D > GetSectionFromFv (+ > > > > Status =3D GetSectionFromAnyFv ( PcdGetPtr > > > > (PcdBootManagerMenuFile), EFI_SECTION_PE32, = 0,@@ > - > > > > 2455,7 +2454,7 @@ BmRegisterBootManagerMenu ( > > > > // // Get BootManagerMenu application's description from E= FI > User > > > > Interface Section. //- Status =3D GetSectionFromFv (+ Sta= tus =3D > > > > GetSectionFromAnyFv ( PcdGetPtr (PcdBootManagerMenuF= ile), > > > > EFI_SECTION_USER_INTERFACE, 0,-- > > > > 2.30.0.windows.2 > > > > > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#74859): > > > > https://edk2.groups.io/g/devel/message/74859 > > > > Mute This Topic: https://groups.io/mt/82714887/1768737 > > > > Group Owner: devel+owner@edk2.groups.io > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > > [hao.a.wu@intel.com] > > > > - =3D-=3D-=3D-=3D-=3D-=3D > > > >