From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.31064.1612169033070892569 for ; Mon, 01 Feb 2021 00:43:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=PTa1e99A; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) IronPort-SDR: 8BE7tjrvBu/ZJKJ9bzifG+64q/OnyT7dZ+OcmCHvpxAPBrxiKsQxK2YL04sAcNxZ3ShsaQRLOt /y+vz5pjbf0g== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="244735601" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="244735601" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 00:43:52 -0800 IronPort-SDR: QmIr/UbkXnmb97ICEe3NkgRYoHoBr0cIK9aJIYW8JnnuVLaBWcN+tH6Cp33Wbu0GUxNeBEVN+F 78i4Afs7xDGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="478785616" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2021 00:43:52 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 00:43:51 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Feb 2021 00:43:51 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 1 Feb 2021 00:43:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFftTxmiQLrAkLmbBDNP8dLXoiV2HJMimp4VDBaKxeIby9DjQFB1YDJVmDJFsRUMRXnXiyT97SbnuQ+g1LeAp+v7xam6EFxZWdFlG/CSLuijJ861+wI6GWYsPLosG2RQVF1YXcx0yt5cArfPJpScBfovg84Bb+HrESooEPgrS5r94Ku3h288dM+WyL8AgqpwPxmFzDj8Kg/7Qs3bnGrEQgDoQTFNkwN0awQbRdrtgj0bPVBafAioNFOJW/pe7lphB2crS+iXcTWTyg7HD8Q5sQWrTnG6HLq9CijGesyDnQJnqPzmJD8AIlpEvBUAmjKQmevJqBEgCU7mxqAgPlQSWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCIJX/gZTQluqk7Os7YlznMD6llLMYjM/IPUZrfe4Sg=; b=Idt7PYHqFWUWUB/5DCBDgYAaVe/pBG/yjhliMl9WCQAnJ7NAhCEN5owHxZvvVlVkDbKAym0KyqDDGj09QrLnM6hX2m4OQL+klJZeVHRJ0Bg9elJEBPz/oZS4qUu6IhDEtFqz7OnNKinPWio1cXtTLafY3wS9k2qqdpFNVWdMd2o3U1r6sCx4F1VDky74SMd+luuETHgmBde5wBQ8iaZx3Y3LA++ydMOTLWin6IYPEdkKMJ6FtM3BFOhFiJv96PK9P9pSEfVgBvCqVQtouQqX6fqOUGbo9tZ33vBkWNxnuiLEP5/zU+QwL9Gu1T6S3X2vHdsVs5X20iyNEa3Fx3+xlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCIJX/gZTQluqk7Os7YlznMD6llLMYjM/IPUZrfe4Sg=; b=PTa1e99AbMgdRqYA3LAm8DISzfvQ4qe3ZVSEURj+EtobzCUbMUD+FBnIDEq+ht2FSUMo508zgzXDrgDZtzK32pgRQ8tzkerQ6kjToguNDhXFtqTCUU+fQ0w8PmkgC5K83tbmPXXmE5r2ZQLJAiJn9+ojPUIFBMbV0Y3ymxXUusE= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB4962.namprd11.prod.outlook.com (2603:10b6:303:99::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Mon, 1 Feb 2021 08:43:50 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%6]) with mapi id 15.20.3805.025; Mon, 1 Feb 2021 08:43:50 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v1 1/1] UefiCpuPkg/CpuCacheInfoLib: Add more dependency of CpuCacheInfoLib Thread-Topic: [PATCH v1 1/1] UefiCpuPkg/CpuCacheInfoLib: Add more dependency of CpuCacheInfoLib Thread-Index: AQHW+FwhwcafjWwCPEiNOGZEwJT7XKpC+9bw Date: Mon, 1 Feb 2021 08:43:50 +0000 Message-ID: References: <20210201053551.5232-1-yun.lou@intel.com> In-Reply-To: <20210201053551.5232-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6482b3a2-0c0a-4367-6ca1-08d8c68d7f86 x-ms-traffictypediagnostic: CO1PR11MB4962: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yrDccdRPYcJSO4IVChV/GkA6zml2pzASgOsWaE0cyUXFDFe9cwTjcesFz04mQ8553RP9n4K9rzWJWFqpF754VD3UXHeU/uJ59V0txQvzDn9Dv/hsRzNqiQvMX/UkzIoKKrdrq7brpk6ciur8VqId2lE+4n802VvCijHcftM0asPD/dxRL8ZlyrSmUcEr5Kw1wasJTdVzWnnNOzZIFTHgAC7E6fpVGXIqi9H3vqWbknmmr9Qz5dDO8SBfY4+mGC4TqHs4keY1pg3lHMzSpCe0jPR4fgO7EYo4hmA67zwhzSJyCG1/ZQcFtHvrr6GbGPcg2hQAkCm7fmba1cC4QgPqpzQihn6PRvw689kzMjGNj/J9RBkZt1gyF1brS2JfAvC2VhB1eeb9TgCc0LyMGwrcsBuoN/Rg+30V19zq9p5hdWifeCTl9+Do/Ff7Ku/Ivga6L6K0gJS7AshI28lRDcdr6Kqd4s1gNdvMOhieouqnk+wRNA8tmeEMlFb96+qx9i2Dbk9yOwnIM0cyHM/DvFSZrg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(66446008)(66556008)(66476007)(64756008)(5660300002)(52536014)(558084003)(478600001)(86362001)(71200400001)(76116006)(66946007)(8676002)(8936002)(107886003)(2906002)(6506007)(9686003)(33656002)(186003)(7696005)(110136005)(316002)(26005)(55016002)(54906003)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QnMn+aW6Y8vorbMlKLuYqrx2Ny56IQc4Oezx8AE74UWmsmDBx4MSud7d51VI?= =?us-ascii?Q?8b+cw+EjHNNd7WYRZR1IehYsf5QDdsSFl1Wo473Uls9wJ4L2FPZeXTdme6Qo?= =?us-ascii?Q?4PrBPmcIwrva+ri/PZmd+s7iLiGzxPw0n9ZFX/k01lbP9mTC0Evy6rfmYH/X?= =?us-ascii?Q?uScJLmXRNZ2jlEbc9lkuQ8b7KIc47fbDck7Air3VftTUtObESKki3/Ez8Hji?= =?us-ascii?Q?nhHjpFpFv+V3nXe+uzbbqbOS72Xuf2Qe0tD1O30wEBGOuwgSNb6mACLIalEA?= =?us-ascii?Q?L2SdjvDoUu9zknVhIsH1UnJ2V4gAgqCeSVYrvXqAgq/BpRdIVlCYF993jzgv?= =?us-ascii?Q?dDeeUNKkl/xFJ9wbLhY6y1GkpRy8jTcGxK/zY4metR6BimV+cvIg77kIxGH5?= =?us-ascii?Q?9ohp39qVl33aSGPZodPIrn4QrdXH/Hd+0K5c+dQCUKcBFEyJlTsRW2v28w9g?= =?us-ascii?Q?7lIAra/sOqMeNZ6X/uiqvbLiQM5sC4BsCbSzX0errg2/XP+6rZEuNAZUTi3k?= =?us-ascii?Q?3cbSWRr1pNp943DM+a3i2MVshQGZXqON5y9IwJxIDG2GY9INcZzx1ggtf2cH?= =?us-ascii?Q?DHD8YL1LOu2W6u1rw/p6aO03dBSzppj64/KmL91/O4qgu0InEpcipZGMoU2b?= =?us-ascii?Q?QPjdQaklEss21CTEzApz855S7E3APw3myvELC64ZN0BKbAcThvCQG11QNQtO?= =?us-ascii?Q?ndT9ak7atKhlQLCVbAtYdRfqLk0s0TMe+vBY1jSIetGvZJugzJSLhdouVb/y?= =?us-ascii?Q?z4ZH7GDuWwQJocbBF4jBvCY0AcFz1EFHwZWILraPQJz6y8iYeOnaXxS457rT?= =?us-ascii?Q?I+cuMkTz1c8n2y8SW/GSAox8ho/JrrO9O3WO3If8kBQff92L5sh1NwbIUzvM?= =?us-ascii?Q?ZvDqRT+2qg1GrvCnCYW6hK7hRmSMjVz2ZCUzpzrQS2yC/Yes9/TQTRKfKFYN?= =?us-ascii?Q?POTTNdvTHGN16Bj+qvxbvocqwVKlJss+cm4L1V4nwchKMzjFA4fu4DuJCEh1?= =?us-ascii?Q?7W/HzV0/DdLInuH8IaYsySXQ6lRSd9g80CqT1s5OoK7pWXJncAD38FDtFDur?= =?us-ascii?Q?0/upBQFM?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6482b3a2-0c0a-4367-6ca1-08d8c68d7f86 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2021 08:43:50.3068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BQXMU+khPO4uaM8SqTzcovrPVtnF79Wr1WIsZ9TVoJusDtkPrOrziXoiESZTwSqLZu7oUS9CG92rUweCvaD0Ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4962 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > - Status =3D CpuCacheInfoGetMpServices (&Context.MpServices); >=20 > - if (EFI_ERROR(Status)) { >=20 > - return Status; >=20 > - } >=20 > + CpuCacheInfoGetMpServices (&Context.MpServices); Why not replace the if-check with an assertion as below? + ASSERT_EFI_ERROR (Status);