public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-platforms] [patch V2 03/35] Drivers/OptionRomPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Thu, 25 Mar 2021 23:31:39 +0000	[thread overview]
Message-ID: <CO1PR11MB49305DD2DF5088100AF234918C629@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210322082040.14104-4-dandan.bi@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2450 bytes --]

Reviewed-by: ray.ni@intel.com<mailto:ray.ni@intel.com>

thanks,
ray
________________________________
From: Bi, Dandan <dandan.bi@intel.com>
Sent: Monday, March 22, 2021 4:20:08 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>
Subject: [edk2-platforms] [patch V2 03/35] Drivers/OptionRomPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Drivers/OptionRomPkg/OptionRomPkg.dsc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Drivers/OptionRomPkg/OptionRomPkg.dsc b/Drivers/OptionRomPkg/OptionRomPkg.dsc
index 8a13cc54e6..d6bd88b58e 100644
--- a/Drivers/OptionRomPkg/OptionRomPkg.dsc
+++ b/Drivers/OptionRomPkg/OptionRomPkg.dsc
@@ -4,11 +4,11 @@
 # This package is designed to interoperate with the EDK II open source project
 # at http://www.tianocore.org, and this package is required to build PCI compliant
 # Option ROM image for all CPU architectures, including EBC target.
 # A single driver can support mixes of EFI 1.1, UEFI 2.0 and UEFI 2.1.
 #
-# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
 # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
 # Copyright (c) 2020, ARM Limited. All rights reserved.
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -37,10 +37,12 @@ [Defines]
 ################################################################################
 [SkuIds]
   0|DEFAULT              # The entry: 0|DEFAULT is reserved and always required.

 [LibraryClasses]
+  !include MdePkg/MdeLibs.dsc.inc
+
   DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
   DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
   BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
   BltLib|OptionRomPkg/Library/GopBltLib/GopBltLib.inf
--
2.18.0.windows.1


[-- Attachment #2: Type: text/html, Size: 3951 bytes --]

  reply	other threads:[~2021-03-25 23:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  8:20 [edk2-platforms] [patch V2 00/35] Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 01/35] Drivers/ASIX: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 02/35] Drivers/DisplayLink: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 03/35] Drivers/OptionRomPkg: " Dandan Bi
2021-03-25 23:31   ` Ni, Ray [this message]
2021-03-22  8:20 ` [edk2-platforms] [patch V2 04/35] Features/Debugging: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 05/35] Features/Network: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 06/35] Features/OutOfBandManagement: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 07/35] Features/PowerManagement: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 08/35] Features/SystemInformation: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 09/35] Features/UserInterface: " Dandan Bi
     [not found] ` <20210322082040.14104-21-dandan.bi@intel.com>
2021-03-23  2:18   ` [edk2-platforms] [patch V2 20/35] Platform/RISC-V: " Abner Chang
     [not found] ` <20210322082040.14104-22-dandan.bi@intel.com>
2021-03-23  2:18   ` [edk2-platforms] [patch V2 21/35] Platform/SiFive: " Abner Chang
     [not found] ` <20210322082040.14104-34-dandan.bi@intel.com>
2021-03-23  2:18   ` [edk2-platforms] [patch V2 33/35] Silicon/RISC_V: " Abner Chang
     [not found] ` <20210322082040.14104-27-dandan.bi@intel.com>
2021-03-25 23:31   ` [edk2-platforms] [patch V2 26/35] Silicon/IntelSiliconPkg: " Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB49305DD2DF5088100AF234918C629@CO1PR11MB4930.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox