From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.22898.1626662594337269357 for ; Sun, 18 Jul 2021 19:43:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=efAzM65n; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10049"; a="190572698" X-IronPort-AV: E=Sophos;i="5.84,251,1620716400"; d="scan'208";a="190572698" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2021 19:43:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,251,1620716400"; d="scan'208";a="414706196" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga003.jf.intel.com with ESMTP; 18 Jul 2021 19:43:12 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 18 Jul 2021 19:43:12 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 18 Jul 2021 19:43:12 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 18 Jul 2021 19:43:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 18 Jul 2021 19:43:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b516yI88Yv+UARx3JUfptVtuDXxdQ9mxNEt/7OtbMcXNTbyIxBD3hfFetUe2ET5SVwrdqu7iTWiWbkIi/crsU9VTfvOfX0HD7ky6P6DJzqhnbtOvk/Zmq+EpGPk0Osp1ZjLmh2TO3AuflXgFIpLO/8K81tXJM6eIlvMp1r49qIqj4UjXv8rWkW4UFfCvQKE4HpsyBgE97sEqKJkq1jc/fp46o9GFdsFED3p8nQ4KQ3vmaTOBjNl5tW8aIMTUDGTgzyh2knnXT9vHikA1/snpFgMcVGoxoJ26bxwduV3v4tH6yQ43GpBcaxLwSu5jtxkiCB6TdCTZs2pfdaLL74b1+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CMr2U1sxqjl3BpdkmUFxzUTO+ZIBrT1aWi+Q93B6BA=; b=mU1I0xqa3VNUhWrzgTpfq11SpNfGcrzMgOSviEAS2mV+ji9rhPAKJkM3oNleIq5pfjZw7WOzv9yJAZoAkY1Rg1bCEmnMRTxVwnvjNYBPCAEIKA1gZeRTgHVwn3lnPbo+qIXvxYfeNYMfojmkxQ3sI2vSoJRHlA07KE54qMOqe3jVlo3GIjO+pSunR+DY3Nl1OFLHBjL3LijB1982kijZ+lvGBkM3TGLgYwcaezMOL5aJ56CsN9MxVSHcFJmVNBvl4S0P3kx6wwROPbTeIA44LI6woVcTFY0sao9/i5eQRZ5uknHpvldzoW9/6i6w8VRW4RyY9QoUeg1HcCgO7uc/Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CMr2U1sxqjl3BpdkmUFxzUTO+ZIBrT1aWi+Q93B6BA=; b=efAzM65nMz2bWjt3CJGZZywxEO/JA0IobD5cBfz34E/y+pF/JC7+bYueaiMBLL5RH+0kjLLHork4bdawQBKPmtNWqxyOSGwDUdZaLMMkGfud3itNGuzmhACUmsYIK0dNIN4xlwaRukOS4wJW9U5V22EEaw7eRJPDfkR+7Fg18cg= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB1550.namprd11.prod.outlook.com (2603:10b6:301:b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22; Mon, 19 Jul 2021 02:43:08 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869%2]) with mapi id 15.20.4331.032; Mon, 19 Jul 2021 02:43:08 +0000 From: "Ni, Ray" To: "S, Ashraf Ali" , "devel@edk2.groups.io" CC: "Kumar, Rahul1" , "De, Debkumar" , "Han, Harry" , "West, Catharine" , "Solanki, Digant H" , "V, Sangeetha" Subject: Re: [PATCH] UefiCpuPkg: SecCoreNative without ResetVector Thread-Topic: [PATCH] UefiCpuPkg: SecCoreNative without ResetVector Thread-Index: AQHXeJV0XNpZkwPlUE68kpmk6QNSMqtJniQA Date: Mon, 19 Jul 2021 02:43:08 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6202b3a-66f0-499a-ca83-08d94a5ef14a x-ms-traffictypediagnostic: MWHPR11MB1550: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bded9od5xo/LWkIHN7II0mRny68C1pwRyG5c/uxypFBahFkwCFSb2lHuhrHimB+GKhuqLIlvEPIWCwods+DcJnKlpkrUEGYkhhjFSY+EO3kgxvPLdsxGyiEaTCLziGqCB8UuBOLlkPJ/siUxYrB5U9sL3rabjPz5XTz67lz9tN6+Mv7AmlnhXlcyq85g6xHqLHUY/+iiPmC9/0RycT5wt48zEvU4LoPhdLtJZ6UBB7iDgvKdBREK3Wjoa1QUSUXP1BsTWfNqiSl9N5M4PNcjGpIbHbElp1rxhKTnAdWdYZvycvJzjOTcYZpcPKCA6qEsf3M7s06/XzablzC6qpKlre+VfvuAZeTNbNTYck7BbsYe41bVAzC8Qc49QSr0po4L8CU17XxI7xBfcJwOFBJwCTq85eliEqWpO5YwbB1eGSwT5qEM0O03bRYrEFYmE2WM5Mlyk9cvIRKJs54fvfNwmannm1uoeTS2nPqdHIYhdi3KevTMZckIyYzLSZ/z1uLoI+8t8RkGNqibp8gdxbJlEazxJxYbBk/UnxI7mZ92pAh5J9203wRFNvhzmCT37T42p+yRbk8IqCJEURj+J/Wwn38aZhTCL1Z5zNvCPmZM3DDC88Q9ImqeiquNPoPpW1YlrOgh9DMIhKBlhKNishUAZtQAOgGaZclSbrXLTr52Gnqshu6K/EsWuKhTL6MuflevyS5CID5qDA0KudciuLtGUTHimAo+JHep5/eYZwbRZnsfTjFUSAHWIRAKhUynLUm4SnI9HuXS/ue9MwbCBLSZvIzuMYbPTBByXq+Z4Ru3WHs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(346002)(366004)(136003)(64756008)(2906002)(52536014)(66446008)(55016002)(54906003)(110136005)(33656002)(5660300002)(316002)(9686003)(186003)(26005)(66476007)(53546011)(66556008)(6506007)(38100700002)(19627235002)(71200400001)(7696005)(8936002)(86362001)(107886003)(8676002)(83380400001)(76116006)(66946007)(478600001)(4326008)(122000001)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RWk38oT42AQj3vaWxR0jFTQedmBNzMI0F6CKqSMwWN5Pk++E6UaD8/DCczH9?= =?us-ascii?Q?lXoh3RL3+mzn1IoIC/pW3YjxCy8EYlUbpY2TAqpMh3dBSiQoStefhT8M/sPj?= =?us-ascii?Q?rQeZGCBXlkWnlmNvwR/MWRmd57uGN08PRB3CkO0on+9WGF/YyMOO7wUWsEn3?= =?us-ascii?Q?pR/TO6DiIfjogmabQiomDiqdT+jNgdCaZkNnDy+OOBfTx7jGPDMZvmjbmxai?= =?us-ascii?Q?24RJ+gkQIeYh99p9/H7aQSKONPnBuaXU1IQDlYBW0cwJpiG3Hgo9YFPfPkmq?= =?us-ascii?Q?m8yp5g/utqmm2KXM9/Zvh+dV/4jCzyczCK5n8PpvK6eHlfr0JCDojIINpidK?= =?us-ascii?Q?pMnuKgq69ufSwGVTE7Dzv92IwBv21CmTKN5ngIL2b4pBxrP2J8w3pBtPoTwt?= =?us-ascii?Q?vpLPD2EQ2UyoOdGjrEvf7ml5shH1iITb9DYMjTheYJgPlfUmsTBP/AUbCbCF?= =?us-ascii?Q?a73dWFVVKfEidrUXrdWaZbdjBDB3oTxatDB7n+y2Q9oknyCCw3VdmaSH0L7o?= =?us-ascii?Q?R4cwIJzejpsbE9jGopWx/Up1TJ7+1Dt1KEJEJ9IypE/+m6SBdPSyD6uAM/XV?= =?us-ascii?Q?zP3QdFjEAwTJWahFXhw1ckNx8edM2DXw0YEkYkiNCmeQMbJqf0FcyJAqUL2c?= =?us-ascii?Q?2t8cp/ZIbXKjwPW5g71ze5uf3PCwfXf5Yj+xAf6lZZw0huvcxdF73Z+lztgn?= =?us-ascii?Q?qLXubrdZ+NnnZGt+r+a/P/0S4IbVKzquN9Jx9tuXwF0TnOOCXcduqlKb46do?= =?us-ascii?Q?MzsVqdlQENI8rTXZqf7l2UEf5rf4rmcmhenJkWTtuQqi9iTJCnsOfu/ccnsw?= =?us-ascii?Q?LHqAYRkpJWEfPrPmMQw450RdcXFJvsq0lLStitkj+1KwtDKHCaJRgvLn3E23?= =?us-ascii?Q?HSEDoZ4+ddk8u9ULlIch5mS3oRLbGc92RMgcOK57nKrClNcsSFF9hYWSKC+s?= =?us-ascii?Q?7VsKWRFs7Wp1KpyUlU+2T5ttX3Pgm8tU0n9Y1YJBTquQgk9dHY4bmUWIRiow?= =?us-ascii?Q?RVNqfDFoNr23kXUVO/rY3TvLPVXwqHvKw/LQCA7fT8lnlPjQuCDHJq8lx3OW?= =?us-ascii?Q?LRHnhjcSe6BUN3Ow6tPABjHaDjIHInfk43CF4YS/8NlO5qum9LluTn97zrqr?= =?us-ascii?Q?7C7sJaHv1/BvjkSP1NXp1vqN9MP4FSxkyUtRG3JEKZU/dyYa0k7zrsBeFxYi?= =?us-ascii?Q?nGmQna0sN3zb/hAF2tQnq8HKXV85tsGe45vFJ0h4Veo20d+H7GR3eXXJQ904?= =?us-ascii?Q?cBQKZ+/307IVWKT0vHT9rblsY1TLjnaezCoxFk0cJAqZ4njY+AafgFj9wj8R?= =?us-ascii?Q?fengbjLOBj/rmSsSLR3uBQWF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6202b3a-66f0-499a-ca83-08d94a5ef14a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2021 02:43:08.3903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LYjYTtVOVixf5Yc5BqLv+bnPkeGZAaXfPOsZCt4cJwDGPGNRPGubcXNRJlLfG6Se/ScmQNpM9rSnIxGb1bswdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1550 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ashraf, What unit tests have you performed with this native SecCore? Thanks, Ray -----Original Message----- From: S, Ashraf Ali =20 Sent: Wednesday, July 14, 2021 5:48 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Ni, Ray ; Kum= ar, Rahul1 ; De, Debkumar ; = Han, Harry ; West, Catharine ; Solanki, Digant H ; V, Sangeetha Subject: [PATCH] UefiCpuPkg: SecCoreNative without ResetVector REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3492 Currently SecCore.inf having the resetvector code under IA32. if the user w= ants to use both SecCore and UefiCpuPkg ResetVector it's not possible, sinc= e SecCore and ResetVector(VTF0.INF/ResetVector.inf) are sharing the same GUID which is BFV. to overcome this issue we can creat= e the Duplicate version of the SecCore.inf as SecCoreNative.inf which conta= ins pure SecCore Native functionality without resetvector. SecCoreNative.inf should have the Unique GUID so that it can be used along = with UefiCpuPkg ResetVector in there implementation. Signed-off-by: Ashraf Ali S Cc: Ray Ni Cc: Rahul Kumar Cc: Debkumar De Cc: Harry Han Cc: Catharine West Cc: Digant H Solanki Cc: Sangeetha V --- UefiCpuPkg/SecCore/SecCoreNative.inf | 80 ++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 UefiCpuPkg/SecCore/SecCoreNative.inf diff --git a/UefiCpuPkg/SecCore/SecCoreNative.inf b/UefiCpuPkg/SecCore/SecC= oreNative.inf new file mode 100644 index 0000000000..f89a0e5f38 --- /dev/null +++ b/UefiCpuPkg/SecCore/SecCoreNative.inf @@ -0,0 +1,80 @@ +## @file +# SecCoreNative module that implements the SEC phase. +# +# This is the first module taking control after the reset vector. +# The entry point function is _ModuleEntryPoint in PlatformSecLib. +# The entry point function will start with protected mode, since the # =20 +the transistion to flat mode it done by the resetvector, enable # =20 +temporary memory and call into SecStartup(). +# +# Copyright (c) 2021, Intel Corporation. All rights reserved.
# =20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D SecCore + MODULE_UNI_FILE =3D SecCore.uni + FILE_GUID =3D 43CA74CA-7D29-49A0-B3B9-20F84015B27D + MODULE_TYPE =3D SEC + VERSION_STRING =3D 1.0 + + +# +# The following information is for reference only and not required by the = build tools. +# +# VALID_ARCHITECTURES =3D IA32 X64 EBC +# + +[Sources] + SecMain.c + SecMain.h + FindPeiCore.c + SecBist.c + +[Packages] + MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec + UefiCpuPkg/UefiCpuPkg.dec + +[LibraryClasses] + BaseMemoryLib + DebugLib + PlatformSecLib + PcdLib + DebugAgentLib + UefiCpuLib + PeCoffGetEntryPointLib + PeCoffExtraActionLib + CpuExceptionHandlerLib + ReportStatusCodeLib + PeiServicesLib + PeiServicesTablePointerLib + HobLib + +[Ppis] + ## SOMETIMES_CONSUMES + ## PRODUCES + gEfiSecPlatformInformationPpiGuid + ## SOMETIMES_CONSUMES + ## SOMETIMES_PRODUCES + gEfiSecPlatformInformation2PpiGuid + gEfiTemporaryRamDonePpiGuid ## PRODUCES + ## NOTIFY + ## SOMETIMES_CONSUMES + gPeiSecPerformancePpiGuid + gEfiPeiCoreFvLocationPpiGuid + ## CONSUMES + gRepublishSecPpiPpiGuid + +[Guids] + ## SOMETIMES_PRODUCES ## HOB + gEfiFirmwarePerformanceGuid + +[Pcd] + gUefiCpuPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize ## CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdMigrateTemporaryRamFirmwareVolumes =20 +## CONSUMES + +[UserExtensions.TianoCore."ExtraFiles"] + SecCoreExtra.uni -- 2.30.2.windows.1