From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.7051.1611910856893118834 for ; Fri, 29 Jan 2021 01:00:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=FiYnBzhq; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) IronPort-SDR: vWLzYGBHQXREtHes2SHiZp4buVdq1FIW6K6y0k/o1CzG2qE/++sKZ9M7nxhP1grhmnFOGCG+3U sEsMB18/cUXw== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="168059352" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="168059352" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 01:00:52 -0800 IronPort-SDR: 2BuIEF+4qnhAi+75nf+AJFvu0kjGOQntrCWhbrQKxrCVwz696AM4LTrMh8SIz5qPQXjEuhUEqe W8Qn6jMQH0jg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="505646759" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 29 Jan 2021 01:00:52 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 29 Jan 2021 01:00:50 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 29 Jan 2021 01:00:49 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 29 Jan 2021 01:00:49 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 29 Jan 2021 01:00:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D9GUfaY9LYqQQtGtfqWRXlkcQWcVbWQfnhLuHnTY3c9t0Bny+OKvvDGdRLZ2RiZSUchvCgm+Bem5gFNrOJiFmcK1jQEdUooM+p+bVoIRsnHmtdbzr+klC4Izu0RCXNT7aEZ2dU8c2nIdRr9pH1vFeJcw4BCpeYFZCNav+H8+z83XhkJ9muiIk4CuaTxlQwsavWVuWy9IUWh1RNOuP2VKCe8mgWltmPbabVf7k/c7JcZMLBUzpffTwqc1iOr3F69FfYLHdYIbbGXdoscWmmFsQOznd5D6EoNADjARKHZKs7AhXGYf24e6fVS4S7kBcz3IW48pvlNYK+WGi0RDlqWyig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GG0MLXnxT1Afv8gRHcemKmq/5zprexOIyC7RGU6E0Ks=; b=URpVOXQRKcruJ74kCEu4SlwuweES9Zvn2BwtMe3FlRxzMHgi589azCi89EjOk0yWSamEc3OS1TbGZqiArIDY0OX6F8C6a1sCNJtBkHbYTln/xHFcRr5tjzBmj+hS4FSE2x/K/ypykFoQCd4OsWLmD3eC9kyZ0eX5RsHPZyc3Rt2FSJF0dOBUxrBVYHdIOnR6u8VZ2KrmjVCbQWkEgWTiun/ojOrgaEigOl0zJjmbeq5tvoFi/TFfjxgoTF76vdoHAi2F31oJjXUSLKLs6LVo+LckIyTgpGTHLKFzCqQjDRRO8MPiM2yrOn+kDDEqeYox0VWTzy9+tlGgcdiC24hJ2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GG0MLXnxT1Afv8gRHcemKmq/5zprexOIyC7RGU6E0Ks=; b=FiYnBzhqDhi+nGO19mn/GznAdxiOQ0zP2KhdN2OmNJDswPNW0zxQlhHDoZPGLIbZx+oTTbekESGhdFBf2j77/aHfohc2jLTTC+FkToTLxOs9gR6k7/0KPT91xyF4jHV14D38XIMPl769i9GnCz1p0eYuXiTySiq38X5r6EN5kU8= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB4946.namprd11.prod.outlook.com (2603:10b6:303:9e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Fri, 29 Jan 2021 09:00:47 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%6]) with mapi id 15.20.3805.021; Fri, 29 Jan 2021 09:00:47 +0000 From: "Ni, Ray" To: "Park, Aiden" , "Wu, Hao A" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Dong, Guo" Subject: Re: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Thread-Topic: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Thread-Index: AQHW6d6A3b2IsRFKuUufTWu6DlYyG6o979cAgAAgO1A= Date: Fri, 29 Jan 2021 09:00:47 +0000 Message-ID: References: <20210113190114.19888-1-aiden.park@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77010cbd-deed-4638-d699-08d8c4345e87 x-ms-traffictypediagnostic: CO1PR11MB4946: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NbwS0VoRwFdXIfSkPJs+zpugkstAGQae4zTQ2SPT0NyItUXkz6JtuOUg12Mt/rROJHZbeyHUD/zPoBrfjYwExYBWDfolXloSPW6UScmqJquYcL7jZYEu6i4NxhS1INIX7/YctX+f/ins3I/VLsYRaM9jAQZaOZnmiVPAtdYtVGYVAxUwP9Oguce9wbo5T4wfLQzW7QtddaeIWcgrLVP2cOOWL3B4k8FyvtytJgzBqkCYjyRLB3H0OuT9X0tRN9IWKX6d/m/04Mp39HRGJFUeINlsu238JLzfvXfoFxKgudN9z9bhVi4jKBo+BEBNBvlk26SlalzsqRAJl+JpU7ur4mNOJTHThJOiiFa4ymTuk6u6HBy/vFRHwYBiOYGOhCQFw5ZZSDIa7ieZfE7cVbJ67y+kIA96ilIbxq/r24sUsem1M/S6fJHd4XQ2XV/r2KNE2bF3YU7+zCK/5MBW0yexjunJWWRYjJ3gJXXCM3uA5JVzGVV0KtOxhmvNgFfMjd9nfPsA6FxD/7gXjT8dA7zfvg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(71200400001)(52536014)(107886003)(33656002)(9686003)(55016002)(8676002)(5660300002)(4326008)(64756008)(316002)(66946007)(66556008)(54906003)(110136005)(66446008)(66476007)(76116006)(53546011)(6506007)(7696005)(2906002)(83380400001)(8936002)(86362001)(26005)(186003)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?G99VwVtU/7pnoAEHcjw+/F2BCpf6H13VbyvAcbIFAa2LHWZjMsWBwnUA8BOJ?= =?us-ascii?Q?RNADF+9Y4UJwp1rN0+ZOtv0eMKKo0w36kS67ZM9kzciG77VXsE+V8SSCBq1e?= =?us-ascii?Q?cdty5ImzRVgLcFRPq93Rt7anloaoQ0F9YVEMCFfmc4hlsfp0xi+pkqrrsNiT?= =?us-ascii?Q?dCMVHMQlcoXF9Ck94T1FiogkqJx8cVHVLeMaFH1yJFWxZ0ou73qGBCVutB94?= =?us-ascii?Q?kpMsjilzWCSy5xNtgp3GfqqtKTSvWj1nXmS5TRIDeP7/4BGCLaCgW14bnEtD?= =?us-ascii?Q?Fh2y8A7bhvnuG/v0i4OP1JAdhbvK3bUtyKNXTkzzgBG3zcZODhgqbxPGsvBk?= =?us-ascii?Q?mpHoW1GY/HTOEcZDgXl1vvvTE+8q8+09EXGtnZlDi0nS40EnA2yj1/hnT8xp?= =?us-ascii?Q?g8tuuF4eNhpXlEX3EIS9f7h6ckw0TfH3h525mZm+gtF0iqJ1sxR8A3GmRp4g?= =?us-ascii?Q?/ttGkknzyDvaHnsxDH+CZ+rgg0SLjIkmiRd083INbJ5oHpNQ/KLGALJK9B2Q?= =?us-ascii?Q?xKxd6cg00Yv+iBF43bpJGlxF4+GYxfTv86AsMRNp+ch6tRZRqpKZRqSN5NnF?= =?us-ascii?Q?rfDwB/JUa8WaOX9e8h/CttQF0c1Vh7Zvi5FACGb1iOGX6ryAAikVQgOdkMb1?= =?us-ascii?Q?mtUjP5pP1/R2whpq2EgjilyWa56m8ZyZ1rxrcGzdDbQTj4E3IJX+GnYGwnEi?= =?us-ascii?Q?dtpkWq+S06SZgO976oDnutO1GNblzNeW2qs6H0yNNtKTYveJUU3rJf5K0k2G?= =?us-ascii?Q?VkL8UCUP4iu4/j8pwjUAvv+CQnu636XV2g6XtPQ5wGSi1jJYvZLhNxDBwgib?= =?us-ascii?Q?PEVQNq0IBHVh9IYWKcgfIUmxN01mmo+r5E3Nn3yL6RBV3sGLYaIXJdxgeJzv?= =?us-ascii?Q?I9UvHMMC473hlhZm2Nap0jBAcdyFiVekICtT3aQ5YQA6sP/WhtUuzDOCVoQx?= =?us-ascii?Q?eNeK/rAS4g0Bn6b+FUJWhDeJU7Y4N6WKcBUHiVbX434YyDkcGnM+imQzFzhD?= =?us-ascii?Q?eOaLFpZIs2kX1UHMOYeDS4m+ABuUYfQdzXaxToTLR813TFFfV4GcVswg1Vro?= =?us-ascii?Q?RhUSMl1j?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77010cbd-deed-4638-d699-08d8c4345e87 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2021 09:00:47.5323 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /ar4vXrKwn/Tw7mjXJzliMG1+neTCStOKRWKZPSGWcUBYthdRP9NKblIPWNUbvWiRSWtRpmdEuc1n1MKE2UpIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4946 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Park, Aiden > Sent: Friday, January 29, 2021 9:55 AM > To: Wu, Hao A ; Ni, Ray ; devel@edk= 2.groups.io > Cc: Ma, Maurice ; Dong, Guo > Subject: RE: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRo= mLight >=20 > Hello, >=20 > Can you please review this? >=20 > > -----Original Message----- > > From: Park, Aiden > > Sent: Wednesday, January 13, 2021 11:01 AM > > To: Wu, Hao A ; Ni, Ray ; > > devel@edk2.groups.io > > Cc: Park, Aiden ; Ma, Maurice > > ; Dong, Guo > > Subject: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > > ProcessOptionRomLight > > > > From: Aiden Park > > > > The ProcessOptionRomLight() assumes that OpRom has already been process= ed > > in the previous full enumeration and updates AllOpRomProcessed flag to = TRUE > > by default. However, this may not be applicable with other pre-stage bo= ot > > firmwares. > > > > This will update AllOpRomProcessed flag properly by checking > > PciRomGetImageMapping(). > > > > Signed-off-by: Aiden Park > > --- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > index 1b64924b7b..e8337e865e 100644 > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > @@ -1168,12 +1168,7 @@ ProcessOptionRomLight ( > > ProcessOptionRomLight (Temp); > > } > > > > - PciRomGetImageMapping (Temp); > > - > > - // > > - // The OpRom has already been processed in the first round > > - // > > - Temp->AllOpRomProcessed =3D TRUE; > > + Temp->AllOpRomProcessed =3D PciRomGetImageMapping (Temp); > > > > CurrentLink =3D CurrentLink->ForwardLink; > > } > > -- > > 2.20.1 >=20 > Best Regards, > Aiden